jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/945938 )
Change subject: [todo] remove unnecessary or unclear todo hints ......................................................................
[todo] remove unnecessary or unclear todo hints
Change-Id: I3fd3b23611ee364ea149068962e1fd1feffd813c --- M pywikibot/diff.py M pywikibot/bot.py 2 files changed, 23 insertions(+), 17 deletions(-)
Approvals: Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/bot.py b/pywikibot/bot.py index d40f640..2d788ba 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -2363,7 +2363,6 @@ :return: pywikibot.ItemPage or None """ if not summary: - # FIXME: i18n summary = 'Bot: New item with sitelink from {}'.format( page.title(as_link=True, insite=self.repo))
diff --git a/pywikibot/diff.py b/pywikibot/diff.py index 09caf2a..b80a1e3 100644 --- a/pywikibot/diff.py +++ b/pywikibot/diff.py @@ -396,22 +396,20 @@ return pending return None
- # TODO: Missing commands (compared to git --patch): edit and search - help_msg = {'y': 'accept this hunk', - 'n': 'do not accept this hunk', - 'q': 'do not accept this hunk and quit reviewing', - 'a': 'accept this hunk and all other pending', - 'd': 'do not apply this hunk or any of the later hunks in ' - 'the file', - 'g': 'select a hunk to go to', - 'j': 'leave this hunk undecided, see next undecided hunk', - 'J': 'leave this hunk undecided, see next hunk', - 'k': 'leave this hunk undecided, see previous undecided ' - 'hunk', - 'K': 'leave this hunk undecided, see previous hunk', - 's': 'split this hunk into smaller ones', - '?': 'help', - } + help_msg = { + 'y': 'accept this hunk', + 'n': 'do not accept this hunk', + 'q': 'do not accept this hunk and quit reviewing', + 'a': 'accept this hunk and all other pending', + 'd': 'do not apply this or any of the later hunks in the file', + 'g': 'select a hunk to go to', + 'j': 'leave this hunk undecided, see next undecided hunk', + 'J': 'leave this hunk undecided, see next hunk', + 'k': 'leave this hunk undecided, see previous undecided hunk', + 'K': 'leave this hunk undecided, see previous hunk', + 's': 'split this hunk into smaller ones', + '?': 'help', + }
super_hunks = self._generate_super_hunks( h for h in self.hunks if h.reviewed == Hunk.PENDING)