jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/555722 )
Change subject: [tests] Make T240060 deviation a separate test ......................................................................
[tests] Make T240060 deviation a separate test
Bug: T240060 Change-Id: I62c3b5ce8f80c8c81ec89ad0765edf6de6ea867c --- M tests/tools_ip_tests.py 1 file changed, 15 insertions(+), 7 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/tools_ip_tests.py b/tests/tools_ip_tests.py index 2585091..88cd474 100644 --- a/tests/tools_ip_tests.py +++ b/tests/tools_ip_tests.py @@ -9,7 +9,7 @@
from distutils.version import StrictVersion
-from pywikibot.tools import ip, PY2 +from pywikibot.tools import ip, PY2, PYTHON_VERSION
from tests import unittest_print from tests.aspects import unittest, TestCase, DeprecationTestCase @@ -214,12 +214,6 @@ self.ipv6test(False, '1.2.3.4::')
# Testing IPv4 addresses represented as dotted-quads - # Leading zero's in IPv4 addresses not allowed: some systems treat the - # leading "0" in ".086" as the start of an octal number - # Update: The BNF in RFC-3986 explicitly defines the dec-octet - # (for IPv4 addresses) not to have a leading zero - self.ipv6test(False, 'fe80:0000:0000:0000:0204:61ff:254.157.241.086') - # but this is OK, since there's a single digit self.ipv6test(True, '::ffff:192.0.2.128') self.ipv6test(False, 'XXXX:XXXX:XXXX:XXXX:XXXX:XXXX:1.2.3.4') self.ipv6test(False, '1111:2222:3333:4444:5555:6666:256.256.256.256') @@ -654,6 +648,16 @@ # extra 0 not allowed! self.ipv6test(False, '2001:0000:1234:0000:00001:C1C0:ABCD:0876')
+ def _test_T240060_failures(self): + """Test known deviated behaviour in Python 3.8.""" + # Testing IPv4 addresses represented as dotted-quads + # Leading zero's in IPv4 addresses not allowed: some systems treat the + # leading "0" in ".086" as the start of an octal number + # Update: The BNF in RFC-3986 explicitly defines the dec-octet + # (for IPv4 addresses) not to have a leading zero + self.ipv6test(PYTHON_VERSION >= (3, 8), + 'fe80:0000:0000:0000:0204:61ff:254.157.241.086') +
class IPRegexTestCase(TestIPBase, DeprecationTestCase):
@@ -702,6 +706,10 @@ """Test known bugs in the ipaddr module.""" self._test_T105443_failures()
+ def test_T240060_failures(self): + """Test known bugs in the ipaddr module.""" + self._test_T240060_failures() +
if __name__ == '__main__': # pragma: no cover try: