jenkins-bot has submitted this change and it was merged.
Change subject: [IMPROV] site_tests: Use assertLessEqual ......................................................................
[IMPROV] site_tests: Use assertLessEqual
Instead of using assertTrue, which will only say that the result was False when it doesn't apply, it's using now assertLessEqual which hopefully shows the values compared. If both values are a set the two operations are the same:
a <= b and a.issubset(b)
Change-Id: I64a1a311a3a2a1c617279444442230b966bd5b31 --- M tests/site_tests.py 1 file changed, 6 insertions(+), 5 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py index 70e2b15..ae56705 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -397,11 +397,12 @@ filterRedirects=False)) self.assertEqual(filtered & redirs, set([])) self.assertEqual(indirect & redirs, set([])) - self.assertTrue(filtered.issubset(indirect)) - self.assertTrue(filtered.issubset(backlinks)) - self.assertTrue(redirs.issubset(backlinks)) - self.assertTrue(backlinks.issubset( - set(mysite.pagebacklinks(mainpage, namespaces=[0, 2])))) + self.assertLessEqual(filtered, indirect) + self.assertLessEqual(filtered, backlinks) + self.assertLessEqual(redirs, backlinks) + self.assertLessEqual( + backlinks, + set(self.site.pagebacklinks(mainpage, namespaces=[0, 2])))
# pagereferences includes both backlinks and embeddedin embedded = set(mysite.page_embeddedin(mainpage, namespaces=[0]))