jenkins-bot has submitted this change and it was merged.
Change subject: [IMPROV] Optimize/remove unneeded calls to Page.isEmpty() ......................................................................
[IMPROV] Optimize/remove unneeded calls to Page.isEmpty()
A check for Page.isEmpty() is unnecessary as it will never be checked when it would yield True. A sequence of conditions was also optimized (quicker condition check first) when replacing links.
Change-Id: Ib68446a77f52f59440d9f50fef416b9bfdb39827 --- M scripts/interwiki.py 1 file changed, 1 insertion(+), 9 deletions(-)
Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified
diff --git a/scripts/interwiki.py b/scripts/interwiki.py index 9854bc6..f1b314a 100755 --- a/scripts/interwiki.py +++ b/scripts/interwiki.py @@ -1446,14 +1446,6 @@ pywikibot.output(u'File autonomous_problems.dat open or corrupted! Try again with -restore.') sys.exit() iw = () - elif not page.isCategory() and page.isEmpty(): - globalvar.remove.append(unicode(page)) - if not globalvar.quiet: - pywikibot.output(u"NOTE: %s is empty; ignoring it and its interwiki links" - % page) - # Ignore the interwiki links - self.done.remove(page) - iw = ()
for link in iw: linkedPage = pywikibot.Page(link) @@ -1834,7 +1826,7 @@ except pywikibot.NoPage: pywikibot.output(u"Not editing %s: page does not exist" % page) raise SaveError(u'Page doesn't exist') - if page.isEmpty() and not page.isCategory(): + if not page.isCategory() and page.isEmpty(): pywikibot.output(u"Not editing %s: page is empty" % page) raise SaveError(u'Page is empty.')