[Pywikibot-commits] [Gerrit] Wikibase now uses uppercase ids. - change (pywikibot/core)

Ladsgroup has submitted this change and it was merged.

Change subject: Wikibase now uses uppercase ids. ......................................................................

Wikibase now uses uppercase ids.

We now force IDs to be uppercase rather than lowercase.

Change-Id: I19a33f60ea72e447f8a971279f149947d4e46bfd Announcement: http://lists.wikimedia.org/pipermail/wikidata-tech/2013-September/000296.htm... --- M pywikibot/page.py 1 file changed, 3 insertions(+), 3 deletions(-)

Approvals: Ladsgroup: Verified; Looks good to me, approved

diff --git a/pywikibot/page.py b/pywikibot/page.py index a20d7ce..3b250c0 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -2506,7 +2506,7 @@ @param title: id number of item, "Q###" """ super(ItemPage, self).__init__(site, title, ns=0) - self.id = title.lower() + self.id = title.upper() # This might cause issues if not ns0?

@classmethod def fromPage(cls, page): @@ -2672,7 +2672,7 @@ @param title: page name of property, like "Property:P##" """ WikibasePage.__init__(self, source, title, ns=120) - self.id = self.title(withNamespace=False).lower() + self.id = self.title(withNamespace=False).upper() if not self.id.startswith(u'p'): raise ValueError(u"'%s' is not a property page!" % self.title())

@@ -2697,7 +2697,7 @@ """ def __init__(self, site, title): WikibasePage.__init__(self, site, title, ns=122) - self.id = self.title(withNamespace=False).lower() + self.id = self.title(withNamespace=False).upper() if not self.id.startswith(u'u'): raise ValueError(u"'%s' is not a query page!" % self.title())