jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/565727 )
Change subject: [bugfix] Do not use a hyphen within family name ......................................................................
[bugfix] Do not use a hyphen within family name
Bug: T243120 Change-Id: I07c692756daa1fa67a974c8ee90e0c18470a6721 --- M tests/generate_family_files_tests.py 1 file changed, 5 insertions(+), 3 deletions(-)
Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/generate_family_files_tests.py b/tests/generate_family_files_tests.py index 54deeaa..236e697 100644 --- a/tests/generate_family_files_tests.py +++ b/tests/generate_family_files_tests.py @@ -1,7 +1,7 @@ # -*- coding: utf-8 -*- """Test generate_family_files script.""" # -# (C) Pywikibot team, 2018-2019 +# (C) Pywikibot team, 2018-2020 # # Distributed under the terms of the MIT license. # @@ -38,17 +38,19 @@
"""Test generate_family_file functionality."""
+ familyname = 'testgff' + def setUp(self): """Set up tests class.""" super(TestGenerateFamilyFiles, self).setUp() self.generator_instance = FamilyTestGenerator( - url=self.site.base_url(''), name='gff-test', dointerwiki='y') + url=self.site.base_url(''), name=self.familyname, dointerwiki='y')
def test_initial_attributes(self): """Test initial FamilyFileGenerator attributes.""" self.assertEqual(self.generator_instance.base_url, self.site.base_url('')) - self.assertEqual(self.generator_instance.name, 'gff-test') + self.assertEqual(self.generator_instance.name, self.familyname) self.assertEqual(self.generator_instance.dointerwiki, 'y') self.assertIsInstance(self.generator_instance.wikis, dict) self.assertIsInstance(self.generator_instance.langs, list)