John Vandenberg has posted comments on this change.
Change subject: Replacing references from Bugzilla to Phabricator ......................................................................
Patch Set 1:
(8 comments)
https://gerrit.wikimedia.org/r/#/c/234734/1/pywikibot/data/api.py File pywikibot/data/api.py:
Line 1785: # bug 66619 (T68619), after gerrit 124323 breaking change we have a
Why do you keep “bug 66619”? Also “gerrit 124323” is not a good identifier.
Done
Line 2082: # maybe removed when T48535 is solved
remove this second line; T48535 is mentioned on the line above, T48535 is s
Done
https://gerrit.wikimedia.org/r/#/c/234734/1/pywikibot/exceptions.py File pywikibot/exceptions.py:
Line 293: This is considered invalid in Pywikibot. See Bug T75184.
lowercase bug?
Done
https://gerrit.wikimedia.org/r/#/c/234734/1/pywikibot/login.py File pywikibot/login.py:
Line 286: # TODO: investigate other unhandled API codes (bug 75539)
need to add 'T'
Done
https://gerrit.wikimedia.org/r/#/c/234734/1/pywikibot/textlib.py File pywikibot/textlib.py:
Line 303: # can't handle lookahead or lookbehind (see bug #1731008)(bug not found):
this is a SF.net bug number; see https://www.mediawiki.org/wiki/Manual:Pywi
Created T123185 for this
https://gerrit.wikimedia.org/r/#/c/234734/1/tests/script_tests.py File tests/script_tests.py:
Line 129: 'editarticle': 'Nothing changed', # This masks related bug T70645 but that
T70645 is fixed; need to determine if this comment is still useful.
No longer needed IMO; removed.
Line 142: 'transferbot': 'Target site not different from source site', # Bug T70662
T70662 is fixed; need to determine if this comment is still useful.
No longer needed IMO; removed.
https://gerrit.wikimedia.org/r/#/c/234734/1/tests/site_tests.py File tests/site_tests.py:
Line 608: # Bug # T17985 - reverse and start combined; fixed in v 1.14
I guess the second # was used as “number” which does seem odd (and afaik an
Done