Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/944950 )
Change subject: [tests] Modify fixme patterns ......................................................................
[tests] Modify fixme patterns
Change-Id: Ib36cabd42f196e7027b553b4ae8f2a0065107b99 --- M pywikibot/page/_collections.py M .codeclimate.yml M pywikibot/page/_wikibase.py M scripts/archivebot.py 4 files changed, 15 insertions(+), 6 deletions(-)
Approvals: Xqt: Verified; Looks good to me, approved
diff --git a/.codeclimate.yml b/.codeclimate.yml index c302eb9..a257ef8 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -40,9 +40,9 @@ - fixme - hack - TODO - - todo + - todo: - XXX - - xxx + - xxx:
exclude_patterns: - "docs/" diff --git a/pywikibot/page/_collections.py b/pywikibot/page/_collections.py index 6f40b30..a88ccf7 100644 --- a/pywikibot/page/_collections.py +++ b/pywikibot/page/_collections.py @@ -573,7 +573,7 @@
:return: the altered dict from parameter data. """ - raise NotImplementedError # todo + raise NotImplementedError # TODO
def toJSON(self, diffto: Optional[dict] = None) -> dict: """ @@ -584,4 +584,4 @@
:param diffto: JSON containing entity data """ - raise NotImplementedError # todo + raise NotImplementedError # TODO diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py index 7b341cb..a5cf089 100644 --- a/pywikibot/page/_wikibase.py +++ b/pywikibot/page/_wikibase.py @@ -2050,7 +2050,7 @@
def get_data_for_new_entity(self): """Return data required for creation of a new lexeme.""" - raise NotImplementedError # todo + raise NotImplementedError # TODO
def toJSON(self, diffto: Optional[dict] = None) -> dict: """ diff --git a/scripts/archivebot.py b/scripts/archivebot.py index 76acb3a..886494a 100755 --- a/scripts/archivebot.py +++ b/scripts/archivebot.py @@ -428,7 +428,7 @@ if (unit == 'B' and self_size >= size or unit == 'T' and len(self.threads) >= size or self_size > self.archiver.maxsize): - self.full = True # xxx: this is one-way flag + self.full = True # note: this is one-way flag return self.full
def feed_thread(self, thread: DiscussionThread,