jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/516595 )
Change subject: [PEP8] Be consistent in return statement ......................................................................
[PEP8] Be consistent in return statement
returning False from generate_user_files.main() is never used as I can see and it is not consistent with returning None implicitly at the end of this function.
- just return - change the message to plural support and comma separated delimiters
Change-Id: I6724d3f0c955b52044306de8c533d88809d7937e --- M generate_user_files.py 1 file changed, 5 insertions(+), 3 deletions(-)
Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified
diff --git a/generate_user_files.py b/generate_user_files.py index 36decb8..84d1e31 100755 --- a/generate_user_files.py +++ b/generate_user_files.py @@ -2,7 +2,7 @@ # -*- coding: utf-8 -*- """Script to create user-config.py.""" # -# (C) Pywikibot team, 2010-2018 +# (C) Pywikibot team, 2010-2019 # # Distributed under the terms of the MIT license. # @@ -440,8 +440,10 @@
local_args = pywikibot.handle_args(args) if local_args: - pywikibot.output('Unknown arguments: %s' % ' '.join(local_args)) - return False + pywikibot.output('Unknown argument{}: {}' + .format('s' if len(local_args) > 1 else '', + ', '.join(local_args))) + return
pywikibot.output('You can abort at any time by pressing ctrl-c') if config.mylang is not None: