jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/399202 )
Change subject: Replace assertRaises with assertRaisesRegex in login_tests.py ......................................................................
Replace assertRaises with assertRaisesRegex in login_tests.py
assertRaisesRegex allows for the exception message to be checked against a given string, providing more precision in checking errors.
Bug: T154281 Change-Id: I079e52b67f17f85fa5137218a0342d985e4876b8 --- M tests/login_tests.py 1 file changed, 3 insertions(+), 2 deletions(-)
Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/login_tests.py b/tests/login_tests.py index d1fcc81..0354e08 100644 --- a/tests/login_tests.py +++ b/tests/login_tests.py @@ -74,8 +74,9 @@
del FakeConfig.usernames['*'] FakeConfig.usernames['*']['en'] = FakeUsername - self.assertRaises(NoUsername, LoginManager) - + error_undefined_username = 'ERROR: Username for.*is undefined.\nIf' + self.assertRaisesRegex(NoUsername, error_undefined_username, + LoginManager) FakeConfig.usernames['*']['*'] = FakeUsername lm = LoginManager() self.assertEqual(lm.username, FakeUsername)