[Pywikibot-commits] [Gerrit] Do not require login for pure logging purposes - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged.

Change subject: Do not require login for pure logging purposes ......................................................................

Do not require login for pure logging purposes

If the user is not logged in, then don't display their talk page status, as this would require a log-in. This is annoying if one just needs read-only access, or needs to read a wiki that has a broken login (e.g. toolserver)

Change-Id: Ia46d1938221ef70aaf2a752f1b9a4cc5493d34dc --- M pywikibot/bot.py 1 file changed, 8 insertions(+), 1 deletion(-)

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified

diff --git a/pywikibot/bot.py b/pywikibot/bot.py index 13aaf41..2d478c5 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -272,7 +272,14 @@ log(u' %s' % ver)

# messages on bot discussion page? - log(u'MESSAGES: %s' % ('unanswered' if site.messages() else 'none')) + if site.logged_in(): + if site.messages(): + messagestate = 'unanswered' + else: + messagestate = 'none' + else: + messagestate = 'unknown (not logged in)' + log(u'MESSAGES: %s' % messagestate)

log(u'=== ' * 14)