jenkins-bot has submitted this change and it was merged.
Change subject: intersect: Dont use %r to log Page generator ......................................................................
intersect: Dont use %r to log Page generator
If one of the generators is a collection, %r will list all of the pages, which could be very large, and also very ugly if the Page titles are not ascii as %r should force the titles to be ascii, causing some form of encoding fallback like backslashes.
Change-Id: Ifb8f654861fb7d96994bd4611c3613ad036ce81f --- M pywikibot/tools/__init__.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: XZise: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py index b7de462..7a4bd59 100644 --- a/pywikibot/tools/__init__.py +++ b/pywikibot/tools/__init__.py @@ -500,7 +500,8 @@ time.sleep(2) super(ThreadList, self).append(thd) thd.start() - debug("thread started: %r" % thd, self._logger) + debug("thread %d ('%s') started" % (len(self), type(thd)), + self._logger)
def stop_all(self): """Stop all threads the pool."""