jenkins-bot has submitted this change and it was merged.
Change subject: There is no need for gen in clean_sandbox.py ......................................................................
There is no need for gen in clean_sandbox.py
It was a mistake added in 9dc69a9c. When a gen is not defined SandboxBot handles the matter itself and defines sandbox of the site as gen to run.
Change-Id: I116e46be739126fbb8b481e265271a267ab67f5b --- M scripts/clean_sandbox.py 1 file changed, 3 insertions(+), 8 deletions(-)
Approvals: XZise: Looks good to me, approved jenkins-bot: Verified
diff --git a/scripts/clean_sandbox.py b/scripts/clean_sandbox.py index 9df6529..590db4b 100755 --- a/scripts/clean_sandbox.py +++ b/scripts/clean_sandbox.py @@ -170,8 +170,7 @@ raise RuntimeError if not self.generator: if self.site.code not in sandboxTitle: - pywikibot.error(u'No generator is given for this site' - u'(%s), exiting.' % self.site) + pywikibot.bot.suggest_help(missing_generator=True) raise RuntimeError local_sandbox_title = sandboxTitle[self.site.code] if not isinstance(local_sandbox_title, list): @@ -288,13 +287,9 @@
generator = gen_factory.getCombinedGenerator()
- if generator: - bot = SandboxBot(generator=generator, **opts) - bot.run() - return True + bot = SandboxBot(generator=generator, **opts) + bot.run()
- pywikibot.bot.suggest_help(missing_generator=True) - return False
if __name__ == "__main__": main()