Xqt has submitted this change and it was merged.
Change subject: several code clean-up: ......................................................................
several code clean-up:
- remove unused userlib import - remove unused item variable - pep8 changes
Change-Id: I73f9f2ffb81e638eed5bc920b1cb62639dca627d --- M revertbot.py 1 file changed, 13 insertions(+), 10 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/revertbot.py b/revertbot.py index 672295b..7f54cf5 100644 --- a/revertbot.py +++ b/revertbot.py @@ -4,7 +4,7 @@ """ # # (C) Bryan Tong Minh, 2008 -# (C) Pywikipedia bot team, 2008-2012 +# (C) Pywikipedia bot team, 2008-2013 # # Distributed under the terms of the MIT license. # @@ -13,19 +13,20 @@
import re import wikipedia as pywikibot -import query, userlib +import query
class BaseRevertBot(object): """ Base revert bot
Subclass this bot and override callback to get it to do something useful. + """ - def __init__(self, site, comment = None): + def __init__(self, site, comment=None): self.site = site self.comment = comment
- def get_contributions(self, max = -1, ns = None): + def get_contributions(self, max=-1, ns=None): predata = { 'action': 'query', 'list': 'usercontribs', @@ -33,7 +34,8 @@ 'ucuser': self.site.username(), } if ns: predata['ucnamespace'] = ns - if max < 500 and max != -1: predata['uclimit'] = str(max) + if max < 500 and max != -1: + predata['uclimit'] = str(max)
count = 0 iterator = iter(xrange(0)) @@ -55,7 +57,7 @@ count += 1 yield item
- def revert_contribs(self, callback = None): + def revert_contribs(self, callback=None): self.site.forceLogin()
if callback is None: @@ -93,9 +95,11 @@ raise RuntimeError(data['error'])
pages = data['query'].get('pages', ()) - if not pages: return False + if not pages: + return False page = pages.itervalues().next() - if len(page.get('revisions', ())) != 2: return False + if len(page.get('revisions', ())) != 2: + return False rev = page['revisions'][1]
comment = u'Reverted to revision %s by %s on %s' % (rev['revid'], @@ -128,10 +132,9 @@
def main(): - item = None for arg in pywikibot.handleArgs(): continue - bot = myRevertBot(site = pywikibot.getSite()) + bot = myRevertBot(site=pywikibot.getSite()) bot.revert_contribs()
if __name__ == "__main__":