jenkins-bot has submitted this change and it was merged.
Change subject: Use Q7 for test_item_missing ......................................................................
Use Q7 for test_item_missing
Q404 was restored, causing test_item_missing to fail. Use Q7 instead.
Bug: T110819 Change-Id: I96909daec59160e03d2217c5e7ba97aa1d69ee4a --- M tests/wikibase_tests.py 1 file changed, 16 insertions(+), 14 deletions(-)
Approvals: Multichill: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index 28be15f..1214560 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -321,26 +321,28 @@
def test_item_missing(self): wikidata = self.get_repo() - # this item is deleted - item = pywikibot.ItemPage(wikidata, 'Q404') - self.assertEqual(item._link._title, 'Q404') - self.assertEqual(item.title(), 'Q404') + # this item has never existed + item = pywikibot.ItemPage(wikidata, 'Q7') + self.assertEqual(item._link._title, 'Q7') + self.assertEqual(item.title(), 'Q7') self.assertFalse(hasattr(item, '_content')) - self.assertEqual(item.id, 'Q404') - self.assertEqual(item.getID(), 'Q404') - self.assertEqual(item.getID(numeric=True), 404) + self.assertEqual(item.id, 'Q7') + self.assertEqual(item.getID(), 'Q7') + numeric_id = item.getID(numeric=True) + self.assertIsInstance(numeric_id, int) + self.assertEqual(numeric_id, 7) self.assertFalse(hasattr(item, '_content')) self.assertRaises(pywikibot.NoPage, item.get) self.assertTrue(hasattr(item, '_content')) - self.assertEqual(item.id, 'Q404') - self.assertEqual(item.getID(), 'Q404') - self.assertEqual(item._link._title, 'Q404') - self.assertEqual(item.title(), 'Q404') + self.assertEqual(item.id, 'Q7') + self.assertEqual(item.getID(), 'Q7') + self.assertEqual(item._link._title, 'Q7') + self.assertEqual(item.title(), 'Q7') self.assertRaises(pywikibot.NoPage, item.get) self.assertTrue(hasattr(item, '_content')) - self.assertEqual(item._link._title, 'Q404') - self.assertEqual(item.getID(), 'Q404') - self.assertEqual(item.title(), 'Q404') + self.assertEqual(item._link._title, 'Q7') + self.assertEqual(item.getID(), 'Q7') + self.assertEqual(item.title(), 'Q7')
def test_item_never_existed(self): wikidata = self.get_repo()