Pywikibot-commits

pywikibot-commits@lists.wikimedia.org

1 participants
13499 discussions

[Gerrit] ...core[master]: [coverage] Ignore error codes while uploading to coverage
by Xqt (Code Review) 17 Apr '23

17 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909298 ) Change subject: [coverage] Ignore error codes while uploading to coverage ...................................................................... [coverage] Ignore error codes while uploading to coverage https://community.codecov.com/t/bash-uploader-returns-error-code-on-appveyo… Bug: T334674 Change-Id: Iaae6fddf31cf69d162144be31de222367fd01d78 --- M .appveyor.yml 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.appveyor.yml b/.appveyor.yml index d45fc52..1bf60ff 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -90,7 +90,5 @@ - ps: | $env:PATH = 'C:\msys64\usr\bin;' + $env:PATH Invoke-WebRequest -Uri 'https://codecov.io/bash' -OutFile codecov.sh - bash codecov.sh + bash codecov.sh -U "-s" -A "-s" -artifacts: - - path: dist\* .coverage coverage.xml -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909298 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Iaae6fddf31cf69d162144be31de222367fd01d78 Gerrit-Change-Number: 909298 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [coverage] Try to find coverage.xml from artifacts
by Xqt (Code Review) 17 Apr '23

17 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909254 ) Change subject: [coverage] Try to find coverage.xml from artifacts ...................................................................... [coverage] Try to find coverage.xml from artifacts Bug: T334674 Change-Id: I41d27ffcf4af0800390ab1d3d07c1c295b8a35ce --- M .appveyor.yml 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.appveyor.yml b/.appveyor.yml index 3daa226..d45fc52 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -86,11 +86,11 @@ - "%CMD_IN_ENV% coverage run -m unittest discover -vv -p \"*_tests.py\"" -after_test: +on_finish: - ps: | $env:PATH = 'C:\msys64\usr\bin;' + $env:PATH Invoke-WebRequest -Uri 'https://codecov.io/bash' -OutFile codecov.sh - bash codecov.sh -f "coverage.xml" + bash codecov.sh artifacts: - path: dist\* .coverage coverage.xml -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909254 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I41d27ffcf4af0800390ab1d3d07c1c295b8a35ce Gerrit-Change-Number: 909254 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [FIX] update wowwiki Family file
by jenkins-bot (Code Review) 17 Apr '23

17 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909238 ) Change subject: [FIX] update wowwiki Family file ...................................................................... [FIX] update wowwiki Family file Bug: T334834 Change-Id: Ib7f5e196ff9ec1b4b1e18bca125727c63bcfbb5d --- M pywikibot/families/wowwiki_family.py M tests/site_tests.py 2 files changed, 20 insertions(+), 16 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/families/wowwiki_family.py b/pywikibot/families/wowwiki_family.py index 51fa7c0..36190e2 100644 --- a/pywikibot/families/wowwiki_family.py +++ b/pywikibot/families/wowwiki_family.py @@ -1,6 +1,6 @@ """Family module for WOW wiki.""" # -# (C) Pywikibot team, 2009-2022 +# (C) Pywikibot team, 2009-2023 # # Distributed under the terms of the MIT license. # @@ -17,11 +17,11 @@ codes = ( 'ar', 'cs', 'da', 'de', 'el', 'en', 'es', 'et', 'fa', 'fi', 'fr', 'he', - 'hu', 'is', 'it', 'ja', 'ko', 'lt', 'lv', 'nl', 'no', 'pl', 'pt', - 'pt-br', 'ru', 'sk', 'sv', 'tr', 'uk', 'zh', 'zh-tw' + 'hu', 'it', 'ja', 'ko', 'nl', 'no', 'pl', 'pt', 'pt-br', 'ru', 'uk', + 'zh', 'zh-tw' ) - removed_wikis = ['hr', 'ro', 'sr'] + removed_wikis = ['is', 'hr', 'lt', 'lv', 'ro', 'sk', 'sr', 'sv', 'tr'] code_aliases = {'nn': 'no'} @@ -30,9 +30,8 @@ """Property listing family languages.""" cls.langs = super().langs # override deviations - for i, lang in enumerate(['es', 'et', 'sv'], start=1): + for i, lang in enumerate(['en', 'es', 'et', 'uk'], start=1): cls.langs[lang] = cls.domains[i] - cls.langs['uk'] = cls.domains[-1] return cls.langs @classproperty @@ -61,12 +60,7 @@ def domains(cls): """List of domains used by family wowwiki.""" return [cls.domain, - 'wow-es.gamepedia.com', # es + 'wowwiki-archive.fandom.com', # en + 'wow.gamepedia.com', # es 'worldofwarcraft.fandom.com', # et - 'warcraft.fandom.com'] # sv, uk - - def scriptpath(self, code): - """Return the script path for this family.""" - if code == 'es': - return '' - return super().scriptpath(code) + 'warcraft.fandom.com'] # uk diff --git a/tests/site_tests.py b/tests/site_tests.py index 5b37a79..d3f4847 100755 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """Tests for the site module.""" # -# (C) Pywikibot team, 2008-2022 +# (C) Pywikibot team, 2008-2023 # # Distributed under the terms of the MIT license. # @@ -1109,7 +1109,7 @@ def test_wow(self): """Test wowwiki.fandom.com.""" - url = 'wowwiki.fandom.com' + url = 'wowwiki-archive.fandom.com' site = self.site self.assertEqual(site.hostname(), url) self.assertEqual(site.code, 'en') -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909238 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ib7f5e196ff9ec1b4b1e18bca125727c63bcfbb5d Gerrit-Change-Number: 909238 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...i18n[master]: Localisation updates from https://translatewiki.net.
by Xqt (Code Review) 17 Apr '23

17 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/909222 ) Change subject: Localisation updates from https://translatewiki.net. ...................................................................... Localisation updates from https://translatewiki.net. Change-Id: I2d4e118dbfc84cdb930683b24493de9da387ea56 --- M category_redirect/lt.json M checkimages/lt.json M noreferences/lt.json A transferbot/lt.json M category/lt.json M blockpageschecker/lt.json A unusedfiles/lt.json M protect/lt.json A delinker/lt.json M unprotect/lt.json 10 files changed, 75 insertions(+), 9 deletions(-) Approvals: L10n-bot: Looks good to me, approved Xqt: Verified; Looks good to me, approved diff --git a/blockpageschecker/lt.json b/blockpageschecker/lt.json index 94af29c..461595c 100644 --- a/blockpageschecker/lt.json +++ b/blockpageschecker/lt.json @@ -1,8 +1,11 @@ { "@metadata": { "authors": [ - "Aswanas" + "Aswanas", + "Nokeoo" ] }, + "blockpageschecker-adding": "Robotas: Pridedamas puslapio užrakinimo šablonas", + "blockpageschecker-modifying": "Robotas: Pakeistas pasenęs šablonas", "blockpageschecker-deleting": "Bot: trina pasenusį šabloną" } diff --git a/category/lt.json b/category/lt.json index 1729cc8..5a35108 100644 --- a/category/lt.json +++ b/category/lt.json @@ -12,6 +12,7 @@ }, "category-adding": "Robotas: Pridedama kategorija [[:Category:%(newcat)s|%(newcat)s]]", "category-also-in": "(taip pat ir %(alsocat)s)", + "category-clean": "Robotas: Pašalinta kategorija %(category)s, nes ji jau yra po %(child)s", "category-listifying": "Robotas: Numeruoja nuo %(fromcat)s ({{PLURAL:%(num)d|1 įrašas|%(num)d įrašų}})", "category-removing": "robotas: šalinama iš %(oldcat)s", "category-renamed": "robotas: Perkelta iš %(oldcat)s. Autoriai: %(authors)s", diff --git a/category_redirect/lt.json b/category_redirect/lt.json index b6b022a..c6fa09f 100644 --- a/category_redirect/lt.json +++ b/category_redirect/lt.json @@ -1,7 +1,8 @@ { "@metadata": { "authors": [ - "Aswanas" + "Aswanas", + "Nokeoo" ] }, "category_redirect-add-template": "Robotas: Prideda kategoriją nukreipti šabloną pataisymui", @@ -9,5 +10,19 @@ "category_redirect-comment": "Kategorija nukreipia priežiūros robotą", "category_redirect-edit-request": "Aptikta, kad sekantys apsaugoti puslapiai turi būti atnaujinti pagal kategorijos nuorodas: %(itemlist)s", "category_redirect-edit-request-item": "* %(title)s yra %(oldcat)s, kuris yra nukreipimas į %(newcat)s", - "category_redirect-fix-double": "robotas: Taisomas dvigubas peradresavimas" + "category_redirect-fix-double": "robotas: Taisomas dvigubas peradresavimas", + "category_redirect-log-added": "* Prie %(oldcat)s pridėta [[%(ns)s%(template)s]]", + "category_redirect-log-add-failed": "* Nepavyko pridėti [[%(ns)s%(template)s]] prie %(oldcat)s", + "category_redirect-log-double": "* Ištaisytas dvigubas peradresavimas: %(oldcat)s -> %(newcat)s -> %(targetcat)s", + "category_redirect-log-failed": "** Nepavyko: %(error)s", + "category_redirect-log-false-positive": "* Netikėtas neperadresavimas: %(oldcat)s", + "category_redirect-log-ignoring": "* Nepaisoma %(oldcat)s", + "category_redirect-log-loop": "* Peradresavimo kilpa iš %(oldcat)s", + "category_redirect-log-moved": "* %(oldcat)s: %(found)d rastas, %(moved)d perkeltas", + "category_redirect-log-move-error": "* %(oldcat)s: klaida move_contents", + "category_redirect-log-new": "Nauji peradresavimai nuo paskutinės ataskaitos:", + "category_redirect-log-not-loaded": "* Nepavyko įkelti %(oldcat)s; ignoruojama", + "category_redirect-log-skipping": "* Praleidžiama %(oldcat)s; atvėsimo laikotarpyje", + "category_redirect-older-logs": "'''[%(oldlogs)s Senesni žurnalai]'''", + "category_redirect-problem-redirects": "# %(oldcat)s nukreipia į %(redpage)s" } diff --git a/checkimages/lt.json b/checkimages/lt.json index 2b184de..c8988c2 100644 --- a/checkimages/lt.json +++ b/checkimages/lt.json @@ -1,10 +1,18 @@ { "@metadata": { "authors": [ + "Nokeoo", "Tomasdd", "Zygimantus" ] }, + "checkimages-deletion-comment": "Robotas: Pridedama %(adding)s", + "checkimages-doubles-file-comment": "Robotas: Failas jau yra Vikitekoje, gali būti ištrintas", + "checkimages-doubles-head": "Pasikartojantis failas", + "checkimages-doubles-talk-comment": "Robotas: Pranešta, kad failas jau yra Vikitekoje", + "checkimages-log-comment": "Robotas: Atnaujintas žurnalas", + "checkimages-no-license-head": "Vaizdas be licencijos", "checkimages-source-notice-comment": "Robotas: Prašoma šaltinio informacija.", - "checkimages-unknown-extension-head": "Nežinomas plėtinys!" + "checkimages-unknown-extension-head": "Nežinomas plėtinys!", + "checkimages-unknown-extension-msg": "Atrodo, kad failas %(file)s turi netinkamą plėtinį, prašome patikrinti." } diff --git a/delinker/lt.json b/delinker/lt.json new file mode 100644 index 0000000..1886063 --- /dev/null +++ b/delinker/lt.json @@ -0,0 +1,8 @@ +{ + "@metadata": { + "authors": [ + "Nokeoo" + ] + }, + "delinker-delink": "Robotas: failas [[%(title)s]] buvo pašalintas, nes jį ištrynė [[:User:%(user)s]]: ''%(comment)s''" +} diff --git a/noreferences/lt.json b/noreferences/lt.json index 49f21f8..1f0f6ff 100644 --- a/noreferences/lt.json +++ b/noreferences/lt.json @@ -1,6 +1,9 @@ { "@metadata": { - "authors": [] + "authors": [ + "Nokeoo" + ] }, - "noreferences-add-tag": "robotas: Pridedama trūkstama <references /> žymė" + "noreferences-add-tag": "robotas: Pridedama trūkstama <references /> žymė", + "noreferences-fix-tag": "Robotas: Ištaisyta netinkama žymos <references /> sintaksė" } diff --git a/protect/lt.json b/protect/lt.json index 6983760..fae15b7 100644 --- a/protect/lt.json +++ b/protect/lt.json @@ -1,12 +1,13 @@ { "@metadata": { "authors": [ - "Aswanas" + "Aswanas", + "Nokeoo" ] }, "protect-category": "Robotas: Išsaugomi visi puslapiai iš kategorijos %(cat)s", "protect-images": "Robotas: Išsaugomos visos nuotraukos puslapyje %(page)s", "protect-links": "Robotas: Išsaugomi visi puslapiai, į kuriuos yra nuoroda iš %(page)s", - "protect-ref": "Robotas: Išsaugomi visi puslapiai, į kuriuos yra nuoroda iš %(page)s", + "protect-ref": "Robotas: Apsaugomi visi puslapiai, su nuoroda į %(page)s", "protect-simple": "Robotas: Išsaugomas failų sąrašas." } diff --git a/transferbot/lt.json b/transferbot/lt.json new file mode 100644 index 0000000..5b6a635 --- /dev/null +++ b/transferbot/lt.json @@ -0,0 +1,9 @@ +{ + "@metadata": { + "authors": [ + "Nokeoo" + ] + }, + "transferbot-summary": "Puslapis perkeltas iš %(source)s", + "transferbot-target": "Šis puslapis buvo perkeltas iš %(source)s. Jo redagavimo istoriją galima peržiūrėti adresu %(history)s" +} diff --git a/unprotect/lt.json b/unprotect/lt.json index 8b60a54..c759027 100644 --- a/unprotect/lt.json +++ b/unprotect/lt.json @@ -2,12 +2,13 @@ "@metadata": { "authors": [ "Aswanas", + "Nokeoo", "Zygimantus" ] }, "unprotect-category": "Robotas: Nesaugomi visi puslapiai iš kategorijos %(cat)s", "unprotect-images": "Robotas: Neaugomos visos nuotraukos puslapyje %(page)s", "unprotect-links": "Robotas: Nesaugomi visi puslapiai, į kuriuos yra nuoroda iš %(page)s", - "unprotect-ref": "Robotas: Nesaugomi visi puslapiai, į kuriuos yra nuoroda iš %(page)s", + "unprotect-ref": "Robotas: Nebesaugomi visi puslapiai, nurodantys į %(page)s", "unprotect-simple": "Robotas: Nesaugomas failų sąrašas" } diff --git a/unusedfiles/lt.json b/unusedfiles/lt.json new file mode 100644 index 0000000..58aa070 --- /dev/null +++ b/unusedfiles/lt.json @@ -0,0 +1,8 @@ +{ + "@metadata": { + "authors": [ + "Nokeoo" + ] + }, + "unusedfiles-comment": "Robotas: failas pažymimas kaip našlaitis" +} -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/909222 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/i18n Gerrit-Branch: master Gerrit-Change-Id: I2d4e118dbfc84cdb930683b24493de9da387ea56 Gerrit-Change-Number: 909222 Gerrit-PatchSet: 1 Gerrit-Owner: L10n-bot <l10n-bot(a)translatewiki.net> Gerrit-Reviewer: L10n-bot <l10n-bot(a)translatewiki.net> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [coverage] Invoke codecov.sh for Appveyor
by Xqt (Code Review) 17 Apr '23

17 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909206 ) Change subject: [coverage] Invoke codecov.sh for Appveyor ...................................................................... [coverage] Invoke codecov.sh for Appveyor https://codingdefined.github.io/hive-blog/how-i-added-appveyor-codecov-to-n… Bug: T334674 Change-Id: I52e334e092fff9b8dd5e8e3128a03ee920b1cfe2 --- M .appveyor.yml 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.appveyor.yml b/.appveyor.yml index a82cd16..3daa226 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -86,11 +86,11 @@ - "%CMD_IN_ENV% coverage run -m unittest discover -vv -p \"*_tests.py\"" -on_finish: +after_test: - ps: | - $env:PATH = 'C:\msys64\usr\bin;' + $env:PATH - Invoke-WebRequest -Uri 'https://codecov.io/bash' -OutFile codecov.sh - bash codecov.sh -f "coverage.xml" + $env:PATH = 'C:\msys64\usr\bin;' + $env:PATH + Invoke-WebRequest -Uri 'https://codecov.io/bash' -OutFile codecov.sh + bash codecov.sh -f "coverage.xml" artifacts: - path: dist\* .coverage coverage.xml -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909206 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I52e334e092fff9b8dd5e8e3128a03ee920b1cfe2 Gerrit-Change-Number: 909206 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Update coverage for generate_family_file.py
by Xqt (Code Review) 17 Apr '23

17 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909197 ) Change subject: [tests] Update coverage for generate_family_file.py ...................................................................... [tests] Update coverage for generate_family_file.py Change-Id: I359b16a69ed1414f5d2400a3372578632ee594d1 --- M pywikibot/scripts/generate_family_file.py 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/scripts/generate_family_file.py b/pywikibot/scripts/generate_family_file.py index 8b0607c..874631b 100755 --- a/pywikibot/scripts/generate_family_file.py +++ b/pywikibot/scripts/generate_family_file.py @@ -133,7 +133,7 @@ break else: return w, verify - return None, None + return None, None # pragma: no cover def run(self) -> None: """Main method, generate family file.""" @@ -182,7 +182,7 @@ code_len = len(self.langs) if code_len > 1: if self.dointerwiki is None: - while True: + while True: # pragma: no cover makeiw = input( '\n' f'There are {code_len} sites available.' @@ -210,7 +210,7 @@ self.langs = [wiki for wiki in self.langs if domain in wiki['url']] - elif makeiw == 'e': + elif makeiw == 'e': # pragma: no cover for wiki in self.langs: print(wiki['prefix'], wiki['url']) do_langs = re.split(' *,| +', -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909197 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I359b16a69ed1414f5d2400a3372578632ee594d1 Gerrit-Change-Number: 909197 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [coverage] Invoke codecov.sh for Appveyor
by Xqt (Code Review) 17 Apr '23

17 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909194 ) Change subject: [coverage] Invoke codecov.sh for Appveyor ...................................................................... [coverage] Invoke codecov.sh for Appveyor https://www.appveyor.com/blog/2017/03/17/codecov/ Bug: T334674 Change-Id: I87329fe0305a7e31b81ab5203839e973e2fc2cd0 --- M .appveyor.yml 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/.appveyor.yml b/.appveyor.yml index 8130c22..a82cd16 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -87,7 +87,10 @@ - "%CMD_IN_ENV% coverage run -m unittest discover -vv -p \"*_tests.py\"" on_finish: - # - codecov + - ps: | + $env:PATH = 'C:\msys64\usr\bin;' + $env:PATH + Invoke-WebRequest -Uri 'https://codecov.io/bash' -OutFile codecov.sh + bash codecov.sh -f "coverage.xml" artifacts: - path: dist\* .coverage coverage.xml -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909194 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I87329fe0305a7e31b81ab5203839e973e2fc2cd0 Gerrit-Change-Number: 909194 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [IMPR] None as default value can be omitted with dict.get()
by jenkins-bot (Code Review) 17 Apr '23

17 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908944 ) Change subject: [IMPR] None as default value can be omitted with dict.get() ...................................................................... [IMPR] None as default value can be omitted with dict.get() Change-Id: I18650a58b1bd205f251d1eda397b3b1778dd9f5d --- M pywikibot/page/_wikibase.py M pywikibot/echo.py M pywikibot/site/_basesite.py 3 files changed, 13 insertions(+), 4 deletions(-) Approvals: Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/echo.py b/pywikibot/echo.py index 18112da..9d271ee 100644 --- a/pywikibot/echo.py +++ b/pywikibot/echo.py @@ -59,8 +59,8 @@ except KeyError: notif.read = False - notif.content = data.get('*', None) - notif.revid = data.get('revid', None) + notif.content = data.get('*') + notif.revid = data.get('revid') return notif def mark_as_read(self) -> bool: diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py index 0e278c8..d7e9f5c 100644 --- a/pywikibot/page/_wikibase.py +++ b/pywikibot/page/_wikibase.py @@ -1579,7 +1579,7 @@ """ claim_repo = site.get_repo_for_entity_type('property') claim = cls(claim_repo, data['mainsnak']['property'], - datatype=data['mainsnak'].get('datatype', None)) + datatype=data['mainsnak'].get('datatype')) if 'id' in data: claim.snak = data['id'] elif 'hash' in data: diff --git a/pywikibot/site/_basesite.py b/pywikibot/site/_basesite.py index c0311d3..a5f92df 100644 --- a/pywikibot/site/_basesite.py +++ b/pywikibot/site/_basesite.py @@ -414,7 +414,7 @@ def interwiki_putfirst(self): """Return list of language codes for ordering of interwiki links.""" - return self.family.interwiki_putfirst.get(self.code, None) + return self.family.interwiki_putfirst.get(self.code) def getSite(self, code): # noqa: N802 """Return Site object for language 'code' in this Family.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908944 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I18650a58b1bd205f251d1eda397b3b1778dd9f5d Gerrit-Change-Number: 908944 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [IMPR] replace some format strings with f-strings
by jenkins-bot (Code Review) 16 Apr '23

16 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908982 ) Change subject: [IMPR] replace some format strings with f-strings ...................................................................... [IMPR] replace some format strings with f-strings Change-Id: I708c0ca1eda2c9a37d1f291e63b7075a74b7e842 --- M pywikibot/site_detect.py 1 file changed, 21 insertions(+), 12 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site_detect.py b/pywikibot/site_detect.py index c79983f..3d61a3f 100644 --- a/pywikibot/site_detect.py +++ b/pywikibot/site_detect.py @@ -93,12 +93,11 @@ 'Unable to determine articlepath because the wiki is ' 'private. Use the Main Page URL instead of the API.') else: - raise RuntimeError('Unable to determine articlepath: ' - '{}'.format(self.fromurl)) + raise RuntimeError( + f'Unable to determine articlepath: {self.fromurl}') def __repr__(self) -> str: - return '{}("{}")'.format( - self.__class__.__name__, self.fromurl) + return f'{type(self).__name__}("{self.fromurl}")' @property def langs(self): @@ -108,9 +107,11 @@ + '?action=query&meta=siteinfo&siprop=interwikimap' '&sifilteriw=local&format=json') iw = response.json() - if 'error' in iw: - raise RuntimeError('{} - {}'.format(iw['error']['code'], - iw['error']['info'])) + + error = iw.get('error') + if error: + raise RuntimeError(f"{error['code']} - {error['info']}") + return [wiki for wiki in iw['query']['interwikimap'] if 'language' in wiki] @@ -151,9 +152,8 @@ 'Private wiki detected. Login is required.\n' 'Please enter your username?') # Setup a dummy family so that we can create a site object - fam = pywikibot.family.AutoFamily( - 'temporary_family', - self.api[:-8]) + fam = pywikibot.family.AutoFamily('temporary_family', + self.server + self.scriptpath) site = pywikibot.Site(fam.code, fam, username) site.version = lambda: str(self.version) # Now the site object is able to login @@ -259,8 +259,8 @@ self._parsed_url, new_parsed_url) self._parsed_url = new_parsed_url - self.server = '{}://{}'.format( - self._parsed_url.scheme, self._parsed_url.netloc) + self.server = '{url.scheme}://{url.netloc}'.format( + url=self._parsed_url) self.scriptpath = self._parsed_url.path def handle_starttag(self, tag, attrs) -> None: -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908982 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I708c0ca1eda2c9a37d1f291e63b7075a74b7e842 Gerrit-Change-Number: 908982 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] use Q15169668 item for wikibase_tests.py
by jenkins-bot (Code Review) 16 Apr '23

16 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908983 ) Change subject: [tests] use Q15169668 item for wikibase_tests.py ...................................................................... [tests] use Q15169668 item for wikibase_tests.py wikibase_tests.TestLoadRevisionsCaching needs up to 3 minutes to be finished with Q60 (New York City). Replace it with Q15169668 (Pywikibot) thich needs less than a tenth of this time. Bug: T334809 Change-Id: Ib9a2dcc83e60696a616df8bf81653453d566176f --- M tests/wikibase_tests.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index 435ce88..ea322ed 100755 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -64,7 +64,7 @@ def setUp(self): """Setup test.""" - self._page = ItemPage(self.get_repo(), 'Q60') + self._page = ItemPage(self.get_repo(), 'Q15169668') super().setUp() def test_page_text(self): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908983 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ib9a2dcc83e60696a616df8bf81653453d566176f Gerrit-Change-Number: 908983 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits