Pywikibot-commits

pywikibot-commits@lists.wikimedia.org

1 participants
13497 discussions

[Gerrit] ...core[master]: [tests] Add write_tests action
by Xqt (Code Review) 30 Apr '23

30 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913653 ) Change subject: [tests] Add write_tests action ...................................................................... [tests] Add write_tests action Change-Id: I6b6abaaa20787002f095eaa3f52ecfbfc3eef960 --- A .github/workflows/write_tests-ci.yml 1 file changed, 94 insertions(+), 0 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/write_tests-ci.yml b/.github/workflows/write_tests-ci.yml new file mode 100644 index 0000000..9aa1d4e --- /dev/null +++ b/.github/workflows/write_tests-ci.yml @@ -0,0 +1,85 @@ +name: Pywikibot CI +# Run Pywikibot tests with a variety of Python versions + +on: + push: + branches: [ master, stable ] + pull_request: + branches: [ master ] + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +env: + PYWIKIBOT_TEST_RUNNING: 1 + PYWIKIBOT_USERNAME: Pywikibot-test + +jobs: + build: + runs-on: 'ubuntu-latest' + continue-on-error: ${{ matrix.experimental || false }} + timeout-minutes: 120 + + strategy: + fail-fast: false + max-parallel: 16 + + matrix: + python-version: ["3.7"] + site: ['wikipedia:test'] + experimental: [true] + + steps: + - name: Checkout Repository + uses: actions/checkout@v3 + with: + submodules: true + + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v4 + with: + python-version: ${{ matrix.python-version }} + + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip --version + pip install -U setuptools + if [ -f dev-requirements.txt ]; then pip install -r dev-requirements.txt; fi + if [ -f requirements.txt ]; then pip install -r requirements.txt; fi + python -c "import setuptools; print('setuptools:', setuptools.__version__)" + + - name: Generate user files + run: | + python -Werror::UserWarning -m pwb generate_user_files -site:${{matrix.site}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; + echo "usernames['wikipedia']['en'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py + echo "usernames['wikisource']['zh'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py + echo "usernames['wikipedia']['test'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py + echo "usernames['wikidata']['test'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py + echo "usernames['commons']['commons'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py + echo "usernames['meta']['meta'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py + echo "max_retries = 3" >> user-config.py + echo "noisysleep = float('inf')" >> user-config.py + echo "maximum_GET_length = 5000" >> user-config.py + echo "console_encoding = 'utf8'" >> user-config.py + echo "import os" >> user-config.py + echo "password_file = os.path.expanduser('passwordfile')" >> user-config.py + echo "('${{ env.PYWIKIBOT_USERNAME }}', '${{ secrets.PYWIKIBOT_USERPWD }}')" > passwordfile + + - name: Test with unittest or pytest + id: ci_test + continue-on-error: true + timeout-minutes: 90 + env: + PYWIKIBOT_TEST_WRITE: ${{ matrix.site == 'wikipedia:test' && 1 || 0}} + run: | + python pwb.py version + pytest --cov=.; -a 'write' + + - name: Upload coverage to Codecov + uses: codecov/codecov-action@v3 + + - name: Check on failure + if: steps.ci_test.outcome == 'failure' + run: exit 1 -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913653 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I6b6abaaa20787002f095eaa3f52ecfbfc3eef960 Gerrit-Change-Number: 913653 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Update coverage for tests
by jenkins-bot (Code Review) 30 Apr '23

30 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913605 ) Change subject: [tests] Update coverage for tests ...................................................................... [tests] Update coverage for tests Change-Id: Ifaaf309ddd14d30f8ec1d8353c8f47d7a720afc1 --- M tests/site_login_logout_tests.py M tests/proofreadpage_tests.py M tests/time_tests.py M tests/site_generators_tests.py M tests/page_tests.py M tests/paraminfo_tests.py M tests/logentries_tests.py M tests/eventstreams_tests.py M tests/api_tests.py 9 files changed, 44 insertions(+), 37 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/api_tests.py b/tests/api_tests.py index 56580d4..783e1b5 100755 --- a/tests/api_tests.py +++ b/tests/api_tests.py @@ -982,7 +982,7 @@ req.submit() except SystemExit: pass # expected exception from DummyThrottle instance - except APIError as e: + except APIError as e: # pragma: no cover pywikibot.warning( 'Wrong api lagpattern regex, cannot retrieve lag value') raise e diff --git a/tests/eventstreams_tests.py b/tests/eventstreams_tests.py index 65dc347..a5762ec 100755 --- a/tests/eventstreams_tests.py +++ b/tests/eventstreams_tests.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """Tests for the eventstreams module.""" # -# (C) Pywikibot team, 2017-2022 +# (C) Pywikibot team, 2017-2023 # # Distributed under the terms of the MIT license. # @@ -280,7 +280,7 @@ n += 1 try: element = json.loads(event.data) - except ValueError as e: + except ValueError as e: # pragma: no cover self.source.resp.close() # close SSLSocket del self.source raise ValueError( diff --git a/tests/logentries_tests.py b/tests/logentries_tests.py index 6d21d45..1270738 100755 --- a/tests/logentries_tests.py +++ b/tests/logentries_tests.py @@ -88,12 +88,12 @@ self.assertIsInstance(logentry.comment(), str) self.assertIsInstance(logentry.user(), str) self.assertEqual(logentry.user(), logentry['user']) - except HiddenKeyError as e: + except HiddenKeyError as e: # pragma: no cover self.assertRegex( str(e), r"Log entry $[^)]+$ has a hidden '\w+' key and you " r"don't have permission to view it") - except KeyError as e: + except KeyError as e: # pragma: no cover self.assertRegex(str(e), "Log entry ([^)]+) has no 'comment' key") else: self.assertEqual(logentry.comment(), logentry['comment']) @@ -120,7 +120,7 @@ self.assertIsInstance(logentry.page(), pywikibot.FilePage) else: self.assertIsInstance(logentry.page(), pywikibot.Page) - else: + else: # pragma: no cover with self.assertRaises(KeyError): logentry.page() @@ -179,13 +179,13 @@ - set(LogEntryFactory._logtypes)): if not simple_type: # paraminfo also reports an empty string as a type - continue + continue # pragma: no cover try: self._test_logevent(simple_type) - except StopIteration: + except StopIteration: # pragma: no cover unittest_print( - 'Unable to test "{}" on "{}" because there are no log ' - 'entries with that type.'.format(simple_type, key)) + f'Unable to test "{simple_type}" on "{key}" because there' + ' are no log entries with that type.') class TestLogentryParams(TestLogentriesBase): diff --git a/tests/page_tests.py b/tests/page_tests.py index 795f437..6e92e99 100755 --- a/tests/page_tests.py +++ b/tests/page_tests.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """Tests for the page module.""" # -# (C) Pywikibot team, 2008-2022 +# (C) Pywikibot team, 2008-2023 # # Distributed under the terms of the MIT license. # @@ -198,7 +198,7 @@ p1 = pywikibot.Page(site, 'Help:Test page#Testing') ns_name = 'Help' if site.namespaces[12][0] != ns_name: - ns_name = site.namespaces[12][0] + ns_name = site.namespaces[12][0] # pragma: no cover self.assertEqual(p1.title(), ns_name + ':Test page#Testing') self.assertEqual(p1.title(underscore=True), ns_name + ':Test_page#Testing') @@ -232,7 +232,7 @@ p2 = pywikibot.Page(site, 'File:Jean-Léon Gérôme 003.jpg') ns_name = 'File' if site.namespaces[6][0] != ns_name: - ns_name = site.namespaces[6][0] + ns_name = site.namespaces[6][0] # pragma: no cover self.assertEqual(p2.title(), 'File:Jean-Léon Gérôme 003.jpg') self.assertEqual(p2.title(underscore=True), 'File:Jean-Léon_Gérôme_003.jpg') diff --git a/tests/paraminfo_tests.py b/tests/paraminfo_tests.py index 78a329d..13d67afd 100755 --- a/tests/paraminfo_tests.py +++ b/tests/paraminfo_tests.py @@ -49,7 +49,7 @@ values = self._get_param_values(site, module, parameter) exp = set(expected) val = set(values) - if not exp.issuperset(val): + if not exp.issuperset(val): # pragma: no cover diff = val - exp self.fail('Unexpected param{} {} in values' .format('s' if len(diff) > 1 else '', diff)) diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py index f05fc54..40a1728 100755 --- a/tests/proofreadpage_tests.py +++ b/tests/proofreadpage_tests.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """Tests for the proofreadpage module.""" # -# (C) Pywikibot team, 2015-2022 +# (C) Pywikibot team, 2015-2023 # # Distributed under the terms of the MIT license. # @@ -392,11 +392,10 @@ total=1, **rvargs) rvgen.set_maximum_items(-1) # suppress use of rvlimit parameter - try: + loaded_text = '' + with suppress(LookupError, StopIteration, TypeError, ValueError): pagedict = next(rvgen) loaded_text = pagedict.get('revisions')[0].get('*') - except (StopIteration, TypeError, KeyError, ValueError, IndexError): - loaded_text = '' page_text = page._page_to_json() self.assertEqual(json.loads(page_text), json.loads(loaded_text)) diff --git a/tests/site_generators_tests.py b/tests/site_generators_tests.py index 388d7e5..fe2572a 100755 --- a/tests/site_generators_tests.py +++ b/tests/site_generators_tests.py @@ -312,11 +312,10 @@ for page in mysite.allpages(maxsize=200, total=5): self.assertIsInstance(page, pywikibot.Page) self.assertTrue(page.exists()) - if (len(page.text.encode(mysite.encoding())) > 200 - and mysite.data_repository() == mysite): + if len(page.text.encode(mysite.encoding())) > 200 \ + and mysite.data_repository() == mysite: # pragma: no cover unittest_print( - '{}.text is > 200 bytes while raw JSON is <= 200' - .format(page)) + f'{page}.text is > 200 bytes while raw JSON is <= 200') continue self.assertLessEqual(len(page.text.encode(mysite.encoding())), 200) @@ -724,7 +723,8 @@ self.assertIn('editcount', user) self.assertIn('registration', user) - def _test_allusers_with_group(self): + @unittest.expectedFailure + def test_allusers_with_group(self): """Test the site.allusers(group=..) method.""" mysite = self.get_site() for user in mysite.allusers(prefix='D', group='bot', total=5): @@ -800,10 +800,10 @@ imagepage = self.imagepage for using in mysite.imageusage(imagepage, filterredir=False, total=5): self.assertIsInstance(using, pywikibot.Page) - if using.isRedirectPage(): + if using.isRedirectPage(): # pragma: no cover unittest_print( - '{} is a redirect, although just non-redirects were ' - 'searched. See also T75120'.format(using)) + f'{using} is a redirect, although just non-redirects were' + ' searched. See also T75120') self.assertFalse(using.isRedirectPage()) @@ -827,8 +827,8 @@ entry = next(gen) except StopIteration: break - except HiddenKeyError as e: # T216876 - self.skipTest(e) + except HiddenKeyError as e: # pragma: no cover + self.skipTest(e) # T216876 else: self.assertEqual(entry.type(), logtype) @@ -1094,13 +1094,12 @@ for hit in mysite.search('wiki', namespaces=0, total=10): self.assertIsInstance(hit, pywikibot.Page) self.assertEqual(hit.namespace(), 0) - except APIError as e: + except APIError as e: # pragma: no cover if e.code == 'gsrsearch-error' and 'timed out' in e.info: - self.skipTest('gsrsearch returned timeout on site{}:\n{!r}' - .format(mysite, e)) + self.skipTest( + f'gsrsearch returned timeout on site {mysite}:\n{e!r}') if e.code == 'gsrsearch-text-disabled': - self.skipTest('gsrsearch is diabled on site {}:\n{!r}' - .format(mysite, e)) + self.skipTest(f'gsrsearch is diabled on site {mysite}:\n{e!r}') raise def test_search_where_title(self): diff --git a/tests/site_login_logout_tests.py b/tests/site_login_logout_tests.py index 5ea1cfd..5fbdc6e 100755 --- a/tests/site_login_logout_tests.py +++ b/tests/site_login_logout_tests.py @@ -6,7 +6,7 @@ to fail. """ # -# (C) Pywikibot team, 2022 +# (C) Pywikibot team, 2022-2023 # # Distributed under the terms of the MIT license. # @@ -74,7 +74,7 @@ raised = False try: site.login() - except Exception as e: + except Exception as e: # pragma: no cover raised = e self.assertFalse(raised) diff --git a/tests/time_tests.py b/tests/time_tests.py index efa04d3..6e85f8e 100755 --- a/tests/time_tests.py +++ b/tests/time_tests.py @@ -130,7 +130,7 @@ sep = 'T' t1 = Timestamp.utcnow() if not t1.microsecond: # T199179: ensure microsecond is not 0 - t1 = t1.replace(microsecond=1) + t1 = t1.replace(microsecond=1) # pragma: no cover ts1 = t1.isoformat() t2 = Timestamp.fromISOformat(ts1) ts2 = t2.isoformat() @@ -170,7 +170,7 @@ """Test conversion from and to Timestamp format.""" t1 = Timestamp.utcnow() if not t1.microsecond: # T191827: ensure microsecond is not 0 - t1 = t1.replace(microsecond=1000) + t1 = t1.replace(microsecond=1000) # pragma: no cover ts1 = t1.totimestampformat() t2 = Timestamp.fromtimestampformat(ts1) ts2 = t2.totimestampformat() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913605 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ifaaf309ddd14d30f8ec1d8353c8f47d7a720afc1 Gerrit-Change-Number: 913605 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] remove write-test from pywikibot-ci.yml
by Xqt (Code Review) 30 Apr '23

30 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913652 ) Change subject: [tests] remove write-test from pywikibot-ci.yml ...................................................................... [tests] remove write-test from pywikibot-ci.yml write test will be runned in its own action because there are too many failures Change-Id: If6760c4cf05a40d6e11f49fb2339a24a13d7e839 --- M .github/workflows/pywikibot-ci.yml 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index 7c8a8f0..215613d 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -33,7 +33,6 @@ # ubuntu-20.04 required for Python 3.6 - python-version: 3.7 site: wikipedia:test - write-test: true experimental: true - python-version: 3.6 site: False @@ -128,7 +127,6 @@ PYWIKIBOT_TEST_NO_RC: ${{ (matrix.site == 'wikisource:zh' || matrix.test_no_rc) && 1 || 0 }} PYWIKIBOT_TEST_PROD_ONLY: ${{ matrix.test_prod_only && 1 || 0 }} - PYWIKIBOT_TEST_WRITE: ${{ (matrix.site == 'wikipedia:test' && matrix.write-test ) && 1 || 0}} run: | python pwb.py version if [ ${{matrix.site || 0}} != 'wikipedia:test' ]; then -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913652 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If6760c4cf05a40d6e11f49fb2339a24a13d7e839 Gerrit-Change-Number: 913652 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Remove experimental attribute for wowwiki tests
by Xqt (Code Review) 29 Apr '23

29 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913611 ) Change subject: [tests] Remove experimental attribute for wowwiki tests ...................................................................... [tests] Remove experimental attribute for wowwiki tests Test can run without experimental attribute after failures were fixed Change-Id: I47bfb46476905279cc3ea6b42048c5a9210f4b89 --- M .github/workflows/pywikibot-ci.yml 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index d165f33..7c8a8f0 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -57,7 +57,6 @@ os: ubuntu-20.04 - python-version: 3.8 site: wowwiki:uk - experimental: true - python-version: 3 site: wikipedia:de os: macOS-latest -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913611 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I47bfb46476905279cc3ea6b42048c5a9210f4b89 Gerrit-Change-Number: 913611 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] skip TestUserContribsWithoutUser.test_user_prefix on wowwiki
by jenkins-bot (Code Review) 29 Apr '23

29 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913568 ) Change subject: [tests] skip TestUserContribsWithoutUser.test_user_prefix on wowwiki ...................................................................... [tests] skip TestUserContribsWithoutUser.test_user_prefix on wowwiki Change-Id: Ic11b3835fc14fec6c6720d0f779c12c357aee74e --- M tests/site_generators_tests.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_generators_tests.py b/tests/site_generators_tests.py index 2f5888a..388d7e5 100755 --- a/tests/site_generators_tests.py +++ b/tests/site_generators_tests.py @@ -1173,6 +1173,9 @@ def test_user_prefix(self): """Test the site.usercontribs() method with userprefix.""" mysite = self.get_site() + if mysite.family.name == 'wowwiki': + self.skipTest(f'Too many timeouts on {mysite}') + for contrib in mysite.usercontribs(userprefix='John', total=5): self.assertIsInstance(contrib, dict) for key in ('user', 'title', 'ns', 'pageid', 'revid'): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913568 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ic11b3835fc14fec6c6720d0f779c12c357aee74e Gerrit-Change-Number: 913568 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Skip HttpbinTestCase tests when a ServerError occurs
by jenkins-bot (Code Review) 29 Apr '23

29 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913564 ) Change subject: [tests] Skip HttpbinTestCase tests when a ServerError occurs ...................................................................... [tests] Skip HttpbinTestCase tests when a ServerError occurs add a new method fetch() to aspects.HttpbinTestCase which delegates request to http.fetch() but skips the test on ServerErrors. Bug: T335622 Change-Id: Id8199c483c955098053ffe0d04d8d342fa97a489 --- M tests/aspects.py M tests/http_tests.py 2 files changed, 28 insertions(+), 9 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/aspects.py b/tests/aspects.py index d3ebde0..4515cb2 100644 --- a/tests/aspects.py +++ b/tests/aspects.py @@ -49,6 +49,7 @@ DrySite, WarningSourceSkipContextManager, execute_pwb, + skipping, ) @@ -1569,3 +1570,8 @@ def get_httpbin_hostname(self): """Return httpbin hostname.""" return 'httpbin.org' + + def fetch(self, *args, **kwargs): + """Delegate http request to http.fetch but skip on ServerError.""" + with skipping(ServerError): + return http.fetch(*args, **kwargs) diff --git a/tests/http_tests.py b/tests/http_tests.py index a21b7bc..b84eaa5 100755 --- a/tests/http_tests.py +++ b/tests/http_tests.py @@ -258,21 +258,21 @@ def test_existing_headers(self): """Test fake_user_agent with existing headers.""" - r = http.fetch(self.get_httpbin_url('/status/200'), + r = self.fetch(self.get_httpbin_url('/status/200'), headers={'user-agent': 'EXISTING'}) self.assertEqual(r.request.headers['user-agent'], 'EXISTING') def test_argument_values_changes(self): """Test fake_user_agent with argument value changes.""" - r = http.fetch(self.get_httpbin_url('/status/200'), + r = self.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent=True) self.assertNotEqual(r.request.headers['user-agent'], http.user_agent()) - r = http.fetch(self.get_httpbin_url('/status/200'), + r = self.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent=False) self.assertEqual(r.request.headers['user-agent'], http.user_agent()) - r = http.fetch(self.get_httpbin_url('/status/200'), + r = self.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent='ARBITRARY') self.assertEqual(r.request.headers['user-agent'], 'ARBITRARY') @@ -280,21 +280,21 @@ """Test fake_user_agent with empty value.""" with self.assertRaisesRegex(ValueError, 'Invalid parameter: use_fake_user_agent'): - http.fetch(self.get_httpbin_url('/status/200'), + self.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent='') def test_parameter_set_to_none(self): """Test fake_user_agent with parameter wrongly set to None.""" with self.assertRaisesRegex(ValueError, 'Invalid parameter: use_fake_user_agent'): - http.fetch(self.get_httpbin_url('/status/200'), + self.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent=None) def test_overridden_domains(self): """Test fake_user_agent with manually overridden domains.""" config.fake_user_agent_exceptions = { self.get_httpbin_hostname(): 'OVERRIDDEN'} - r = http.fetch(self.get_httpbin_url('/status/200'), + r = self.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent=False) self.assertEqual(r.request.headers['user-agent'], 'OVERRIDDEN') @@ -564,10 +564,10 @@ 'X-Amzn-Trace-Id', 'X-B3-Parentspanid', 'X-B3-Spanid', 'X-B3-Traceid', 'X-Forwarded-Client-Cert', ) - r_data_request = http.fetch(self.get_httpbin_url('/post'), + r_data_request = self.fetch(self.get_httpbin_url('/post'), method='POST', data={'fish&chips': 'delicious'}) - r_body_request = http.fetch(self.get_httpbin_url('/post'), + r_body_request = self.fetch(self.get_httpbin_url('/post'), method='POST', data={'fish&chips': 'delicious'}) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913564 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Id8199c483c955098053ffe0d04d8d342fa97a489 Gerrit-Change-Number: 913564 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Split LiveFakeUserAgentTestCase
by jenkins-bot (Code Review) 29 Apr '23

29 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913511 ) Change subject: [tests] Split LiveFakeUserAgentTestCase ...................................................................... [tests] Split LiveFakeUserAgentTestCase Change-Id: I3c38d5792d11c976b47a6fe9fb437f4e9338c343 --- M tests/http_tests.py 1 file changed, 32 insertions(+), 26 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/http_tests.py b/tests/http_tests.py index 6d39fca..a21b7bc 100755 --- a/tests/http_tests.py +++ b/tests/http_tests.py @@ -239,6 +239,7 @@ self.assertIn('Python/' + str(PYTHON_VERSION[0]), http.user_agent()) +@require_modules('fake_useragent') class LiveFakeUserAgentTestCase(HttpbinTestCase): """Test the usage of fake user agent.""" @@ -255,52 +256,48 @@ self.orig_fake_user_agent_exceptions) super().tearDown() - def _test_fetch_use_fake_user_agent(self): - """Test `use_fake_user_agent` argument of http.fetch.""" - # Existing headers - r = http.fetch( - self.get_httpbin_url('/status/200'), - headers={'user-agent': 'EXISTING'}) + def test_existing_headers(self): + """Test fake_user_agent with existing headers.""" + r = http.fetch(self.get_httpbin_url('/status/200'), + headers={'user-agent': 'EXISTING'}) self.assertEqual(r.request.headers['user-agent'], 'EXISTING') - # Argument value changes + def test_argument_values_changes(self): + """Test fake_user_agent with argument value changes.""" r = http.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent=True) self.assertNotEqual(r.request.headers['user-agent'], http.user_agent()) + r = http.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent=False) self.assertEqual(r.request.headers['user-agent'], http.user_agent()) - r = http.fetch( - self.get_httpbin_url('/status/200'), - use_fake_user_agent='ARBITRARY') + + r = http.fetch(self.get_httpbin_url('/status/200'), + use_fake_user_agent='ARBITRARY') self.assertEqual(r.request.headers['user-agent'], 'ARBITRARY') - # Empty value - with self.assertRaisesRegex( - ValueError, - 'Invalid parameter: use_fake_user_agent'): + def test_empty_valu(self): + """Test fake_user_agent with empty value.""" + with self.assertRaisesRegex(ValueError, + 'Invalid parameter: use_fake_user_agent'): http.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent='') - # Parameter wrongly set to None - with self.assertRaisesRegex( - ValueError, - 'Invalid parameter: use_fake_user_agent'): + def test_parameter_set_to_none(self): + """Test fake_user_agent with parameter wrongly set to None.""" + with self.assertRaisesRegex(ValueError, + 'Invalid parameter: use_fake_user_agent'): http.fetch(self.get_httpbin_url('/status/200'), use_fake_user_agent=None) - # Manually overridden domains + def test_overridden_domains(self): + """Test fake_user_agent with manually overridden domains.""" config.fake_user_agent_exceptions = { self.get_httpbin_hostname(): 'OVERRIDDEN'} - r = http.fetch( - self.get_httpbin_url('/status/200'), use_fake_user_agent=False) + r = http.fetch(self.get_httpbin_url('/status/200'), + use_fake_user_agent=False) self.assertEqual(r.request.headers['user-agent'], 'OVERRIDDEN') - @require_modules('fake_useragent') - def test_fetch_with_fake_useragent(self): - """Test method with fake_useragent module.""" - self._test_fetch_use_fake_user_agent() - class CharsetTestCase(TestCase): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913511 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I3c38d5792d11c976b47a6fe9fb437f4e9338c343 Gerrit-Change-Number: 913511 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Ignore disabled_tests from coverage
by Xqt (Code Review) 29 Apr '23

29 Apr '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913505 ) Change subject: [tests] Ignore disabled_tests from coverage ...................................................................... [tests] Ignore disabled_tests from coverage Change-Id: I059dd0eec1a0906ca310ed0b9c19be50eafd67c0 --- M tests/__init__.py 1 file changed, 12 insertions(+), 4 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/tests/__init__.py b/tests/__init__.py index 1de6877..8f10bc7 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -217,10 +217,9 @@ 'Extra test modules (run after library, before scripts):\n {}' .format(', '.join(extra_test_modules))) - if disabled_tests: - unittest_print( - 'Skipping tests (to run: python -m unittest ...):\n {!r}' - .format(disabled_tests)) + if disabled_tests: # pragma: no cover + unittest_print(f'Skipping tests (to run: python -m unittest ...):\n' + f' {disabled_tests!r}') modules = (module for module in chain(library_test_modules, -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913505 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I059dd0eec1a0906ca310ed0b9c19be50eafd67c0 Gerrit-Change-Number: 913505 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] Fix spelling mistake
by jenkins-bot (Code Review) 29 Apr '23

29 Apr '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913504 ) Change subject: [doc] Fix spelling mistake ...................................................................... [doc] Fix spelling mistake Change-Id: I65ef12f670229adeeb12e5a3b715141274ff4a54 --- M tests/djvu_tests.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/djvu_tests.py b/tests/djvu_tests.py index 6cdcf95..db008fa 100755 --- a/tests/djvu_tests.py +++ b/tests/djvu_tests.py @@ -2,7 +2,7 @@ """Unit tests for djvu.py.""" # -# (C) Pywikibot team, 2015-2022 +# (C) Pywikibot team, 2015-2023 # # Distributed under the terms of the MIT license. # @@ -116,7 +116,7 @@ def setUpModule(): - """Sekip if djvulibre library not installed.""" + """Skip if djvulibre library not installed.""" with skipping(OSError, msg='djvulibre library not installed.'): dp = subprocess.Popen(['djvudump'], stdout=subprocess.PIPE, -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913504 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I65ef12f670229adeeb12e5a3b715141274ff4a54 Gerrit-Change-Number: 913504 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] Update documentation
by Meno25 (Code Review) 29 Apr '23

29 Apr '23

Meno25 has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913219 ) Change subject: [doc] Update documentation ...................................................................... [doc] Update documentation Fix broken link Change-Id: I1d04a0f964d97e3f025e02f3633cdd001a7a6022 --- M scripts/README.rst 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Meno25: Verified; Looks good to me, approved diff --git a/scripts/README.rst b/scripts/README.rst index e7fbffe..0ed2066 100644 --- a/scripts/README.rst +++ b/scripts/README.rst @@ -195,4 +195,4 @@ ** Outdated and deleted scripts can be recovered.** Refer `Outdated core scripts` and `Outdated compat scripts` in our documentation: -https://doc.wikimedia.org/pywikibot/master/scripts/index.html#scripts-descriptions +https://doc.wikimedia.org/pywikibot/master/scripts/index.html#script-descriptions -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/913219 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I1d04a0f964d97e3f025e02f3633cdd001a7a6022 Gerrit-Change-Number: 913219 Gerrit-PatchSet: 2 Gerrit-Owner: Meno25 <meno25mail(a)gmail.com> Gerrit-Reviewer: Meno25 <meno25mail(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits