Pywikibot-commits

pywikibot-commits@lists.wikimedia.org

13500 discussions

[Gerrit] ...core[master]: [doc] Fix WikibasePage documentation
by jenkins-bot (Code Review) 25 Sep '22

25 Sep '22

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834690 ) Change subject: [doc] Fix WikibasePage documentation ...................................................................... [doc] Fix WikibasePage documentation Change-Id: I6fac2af91f1a3798b34eafbf9b21b4a12ab41c5b --- M ROADMAP.rst M pywikibot/page/_wikibase.py 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/ROADMAP.rst b/ROADMAP.rst index fc3acfc..3b40eed 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,8 +1,7 @@ Current release 7.7.0 ^^^^^^^^^^^^^^^^^^^^^ -* TypeError is raised if *aliases* parameter of :meth:`WikibaseEntity.editEntity - <page.WikibaseEntity.editEntity>` or :meth:`WikibasePage.editEntity +* TypeError is raised if *aliases* parameter of :meth:`WikibasePage.editAliases <page.WikibasePage.editEntity>` method is not a list (:phab:`T318034`) * Raise TypeError in :meth:`AliasesDict.normalizeData <pywikibot.page._collections.AliasesDict.normalizeData>` if *data* value is not a list (:phab:`T318034`) diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py index 332f97a..2418cd8 100644 --- a/pywikibot/page/_wikibase.py +++ b/pywikibot/page/_wikibase.py @@ -286,9 +286,9 @@ """Edit an entity using Wikibase ``wbeditentity`` API. This function is wrapped around by: - - :meth:`editLabels` - - :meth:`editDescriptions` - - :meth:`editAliases` + - :meth:`WikibasePage.editLabels` + - :meth:`WikibasePage.editDescriptions` + - :meth:`WikibasePage.editAliases` - :meth:`ItemPage.setSitelinks` .. seealso:: :meth:`WikibasePage.editEntity` @@ -1066,7 +1066,8 @@ A *sitelink* can be a Page object, a BaseLink object or a ``{'site': dbname, 'title': title}`` dictionary. - Refer :meth:`editEntity` for *asynchronous* and *callback* usage. + Refer :meth:`WikibasePage.editEntity` for *asynchronous* and + *callback* usage. """ self.setSitelinks([sitelink], **kwargs) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834690 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I6fac2af91f1a3798b34eafbf9b21b4a12ab41c5b Gerrit-Change-Number: 834690 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [flake8] Solve B026 bugbear issue
by jenkins-bot (Code Review) 25 Sep '22

25 Sep '22

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834642 ) Change subject: [flake8] Solve B026 bugbear issue ...................................................................... [flake8] Solve B026 bugbear issue Do not unpack positional arguments after keyword arguments Bug: T318472 Change-Id: I58c75370f5d69a63fcfb08b5659c870e7db8d504 --- M pywikibot/page/_wikibase.py M tox.ini 2 files changed, 5 insertions(+), 9 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py index 4193764..8a721d7 100644 --- a/pywikibot/page/_wikibase.py +++ b/pywikibot/page/_wikibase.py @@ -1264,15 +1264,11 @@ data['datatype'] = self._type return data - def newClaim(self, *args, **kwargs): - """ - Helper function to create a new claim object for this property. - - :rtype: pywikibot.page.Claim - """ + def newClaim(self, *args, **kwargs) -> 'Claim': + """Helper function to create a new claim object for this property.""" # todo: raise when self.id is -1 - return Claim(self.site, self.getID(), datatype=self.type, - *args, **kwargs) + return Claim(self.site, self.getID(), *args, datatype=self.type, + **kwargs) def getID(self, numeric: bool = False): """ diff --git a/tox.ini b/tox.ini index be649f4..6a83292 100644 --- a/tox.ini +++ b/tox.ini @@ -110,7 +110,7 @@ # DARXXX: Darglint docstring issues to be solved -ignore = B007,B026,C103,D105,D211,D401,D413,D412,DAR003,DAR101,DAR102,DAR201,DAR202,DAR301,DAR401,DAR402,DAR501,H101,H238,H301,H306,H404,H405,H903,P101,P102,P103,P205,W503 +ignore = B007,C103,D105,D211,D401,D413,D412,DAR003,DAR101,DAR102,DAR201,DAR202,DAR301,DAR401,DAR402,DAR501,H101,H238,H301,H306,H404,H405,H903,P101,P102,P103,P205,W503 enable-extensions = H203,H204,H205,N818 color = always -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834642 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I58c75370f5d69a63fcfb08b5659c870e7db8d504 Gerrit-Change-Number: 834642 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Legoktm <legoktm(a)debian.org> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Only run login_tests-ci.yml if previous job was successfull
by Xqt (Code Review) 25 Sep '22

25 Sep '22

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834664 ) Change subject: [tests] Only run login_tests-ci.yml if previous job was successfull ...................................................................... [tests] Only run login_tests-ci.yml if previous job was successfull Change-Id: Idf3289b6759dba34b595a2b860103357b04111f0 --- M .github/workflows/login_tests-ci.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/login_tests-ci.yml b/.github/workflows/login_tests-ci.yml index 55d5246..977c5da 100644 --- a/.github/workflows/login_tests-ci.yml +++ b/.github/workflows/login_tests-ci.yml @@ -19,6 +19,7 @@ jobs: build: runs-on: ${{ matrix.os || 'ubuntu-latest' }} + if: ${{ github.event.workflow_run.conclusion == 'success' }} continue-on-error: ${{ matrix.experimental || false }} timeout-minutes: 2 -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834664 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Idf3289b6759dba34b595a2b860103357b04111f0 Gerrit-Change-Number: 834664 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [L10N] Update languages_by_size
by jenkins-bot (Code Review) 25 Sep '22

25 Sep '22

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834663 ) Change subject: [L10N] Update languages_by_size ...................................................................... [L10N] Update languages_by_size Change-Id: Icf6718dd480e45adb4da23885177216cf185e6fe --- M pywikibot/families/wikipedia_family.py M pywikibot/families/wiktionary_family.py 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/families/wikipedia_family.py b/pywikibot/families/wikipedia_family.py index c70a7ce..619f5ab 100644 --- a/pywikibot/families/wikipedia_family.py +++ b/pywikibot/families/wikipedia_family.py @@ -40,20 +40,20 @@ 'mn', 'nv', 'crh', 'xmf', 'ha', 'si', 'bat-smg', 'os', 'frr', 'or', 'ps', 'gd', 'ban', 'cdo', 'yi', 'bug', 'ilo', 'sd', 'am', 'nap', 'sah', 'hsb', 'fo', 'li', 'map-bms', 'mai', 'mzn', 'gor', 'eml', 'ace', 'bcl', - 'shn', 'sa', 'zh-classical', 'wa', 'ie', 'lij', 'as', 'zu', 'ig', + 'shn', 'sa', 'zh-classical', 'wa', 'ie', 'lij', 'as', 'ig', 'zu', 'mhr', 'mrj', 'hyw', 'hif', 'mni', 'km', 'hak', 'roa-tara', 'pam', - 'sn', 'so', 'nso', 'rue', 'bh', 'se', 'myv', 'vls', 'nds-nl', 'sat', - 'mi', 'sc', 'nah', 'vep', 'tum', 'gan', 'kab', 'glk', 'tk', 'fiu-vro', + 'sn', 'so', 'nso', 'rue', 'bh', 'se', 'myv', 'vls', 'nds-nl', 'mi', + 'sat', 'sc', 'nah', 'vep', 'tum', 'gan', 'kab', 'glk', 'tk', 'fiu-vro', 'co', 'bo', 'ab', 'ary', 'gv', 'frp', 'kw', 'kv', 'pcd', 'csb', 'ug', 'udm', 'skr', 'zea', 'ay', 'gn', 'mt', 'nrm', 'bjn', 'smn', 'lez', - 'lfn', 'stq', 'lo', 'olo', 'mwl', 'fur', 'rm', 'ang', 'lad', 'gom', - 'rw', 'koi', 'ext', 'tyv', 'dsb', 'dty', 'ln', 'av', 'cbk-zam', 'dv', + 'lfn', 'stq', 'lo', 'olo', 'mwl', 'fur', 'rm', 'ang', 'rw', 'lad', + 'gom', 'koi', 'ext', 'tyv', 'dsb', 'dty', 'ln', 'av', 'cbk-zam', 'dv', 'ksh', 'gag', 'pap', 'bxr', 'pfl', 'pag', 'pi', 'haw', 'awa', 'tay', 'ks', 'tw', 'inh', 'dag', 'krc', 'szy', 'xal', 'mdf', 'kaa', 'za', 'pdc', 'atj', 'to', 'arc', 'tcy', 'kbp', 'jam', 'na', 'wo', 'kbd', 'nia', 'nov', 'tet', 'ki', 'mnw', 'lg', 'bi', 'tpi', 'nqo', 'jbo', 'roa-rup', 'fj', 'lbe', 'kg', 'xh', 'ty', 'cu', 'shi', 'srn', 'trv', - 'om', 'guw', 'sm', 'gcr', 'alt', 'chr', 'ltg', 'blk', 'ny', 'pih', + 'om', 'guw', 'sm', 'gcr', 'alt', 'blk', 'chr', 'ltg', 'ny', 'pih', 'got', 'mad', 'st', 'ami', 'tn', 'bm', 've', 'rmy', 'ts', 'chy', 'rn', 'iu', 'ak', 'ss', 'ff', 'ch', 'kcg', 'pnt', 'ady', 'ik', 'ee', 'pcm', 'sg', 'din', 'pwn', 'kl', 'ti', 'dz', 'cr', diff --git a/pywikibot/families/wiktionary_family.py b/pywikibot/families/wiktionary_family.py index 69dd825..158263e 100644 --- a/pywikibot/families/wiktionary_family.py +++ b/pywikibot/families/wiktionary_family.py @@ -32,7 +32,7 @@ 'pt', 'kn', 'vi', 'sr', 'th', 'hi', 'ro', 'no', 'id', 'et', 'cs', 'ml', 'my', 'uz', 'li', 'or', 'eo', 'te', 'fa', 'skr', 'gl', 'ar', 'oc', 'jv', 'az', 'eu', 'uk', 'br', 'ast', 'is', 'da', 'lo', 'simple', 'bn', - 'la', 'sg', 'hr', 'fj', 'tg', 'sk', 'ky', 'bg', 'wa', 'shn', 'mnw', + 'la', 'sg', 'hr', 'fj', 'tg', 'sk', 'ky', 'bg', 'wa', 'mnw', 'shn', 'ur', 'ps', 'cy', 'vo', 'om', 'he', 'sl', 'af', 'zh-min-nan', 'scn', 'lmo', 'tl', 'pa', 'sw', 'fy', 'ms', 'nn', 'ka', 'lv', 'min', 'sq', 'nds', 'lb', 'co', 'mn', 'pnb', 'bs', 'nah', 'yue', 'sa', 'kk', 'km', -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834663 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Icf6718dd480e45adb4da23885177216cf185e6fe Gerrit-Change-Number: 834663 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] Update ROADMAP.rst and CHANGELOG.rst
by jenkins-bot (Code Review) 25 Sep '22

25 Sep '22

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834661 ) Change subject: [doc] Update ROADMAP.rst and CHANGELOG.rst ...................................................................... [doc] Update ROADMAP.rst and CHANGELOG.rst Also some other fixes. Change-Id: I09feadfb8d1cb8300f5cdb723c32c90b4984259f --- M ROADMAP.rst M docs/scripts/index.rst M pywikibot/page/_collections.py M pywikibot/tools/threading.py M scripts/CHANGELOG.rst 5 files changed, 15 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/ROADMAP.rst b/ROADMAP.rst index d94a213..fc3acfc 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,7 +1,15 @@ Current release 7.7.0 ^^^^^^^^^^^^^^^^^^^^^ +* TypeError is raised if *aliases* parameter of :meth:`WikibaseEntity.editEntity + <page.WikibaseEntity.editEntity>` or :meth:`WikibasePage.editEntity + <page.WikibasePage.editEntity>` method is not a list (:phab:`T318034`) +* Raise TypeError in :meth:`AliasesDict.normalizeData + <pywikibot.page._collections.AliasesDict.normalizeData>` if *data* value is not a list (:phab:`T318034`) * tools' threading classes were moved to :mod:`tools.threading` submodule +* No longer raise NotimplementedError in :meth:`APISite.page_from_repository + <pywikibot.site._apisite.APISite.page_from_repository>` (:phab:`T318033`) +* Ability to set ``PYWIKIBOT_TEST_...`` environment variables with pwb wrapper (:phab:`T139847`) * OmegaWiki family was removed * Provide global ``-config`` option to specify the user config file name * Run :mod:`pywikibot.scripts.login` script in parallel tasks if ``-async`` option is given (:phab:`T57899`) diff --git a/docs/scripts/index.rst b/docs/scripts/index.rst index c20b9a5..95d07b9 100644 --- a/docs/scripts/index.rst +++ b/docs/scripts/index.rst @@ -3,6 +3,7 @@ .. automodule:: scripts :no-members: + :noindex: .. include:: ../../scripts/README.rst :start-after: included. diff --git a/pywikibot/page/_collections.py b/pywikibot/page/_collections.py index cd8af8e..14cc42d 100644 --- a/pywikibot/page/_collections.py +++ b/pywikibot/page/_collections.py @@ -150,7 +150,7 @@ """Helper function to expand data into the Wikibase API structure. .. versionchanged:: 7.7 - raises TypeError *data* value is not a list. + raises TypeError if *data* value is not a list. :param data: Data to normalize :return: The dict with normalized data diff --git a/pywikibot/tools/threading.py b/pywikibot/tools/threading.py index c4d997c..6d13cbe 100644 --- a/pywikibot/tools/threading.py +++ b/pywikibot/tools/threading.py @@ -1,4 +1,4 @@ -"""Miscellaneous helper functions (not wiki-dependent).""" +"""Classes which can be used for threading.""" # # (C) Pywikibot team, 2008-2022 # diff --git a/scripts/CHANGELOG.rst b/scripts/CHANGELOG.rst index 8066403..9a1008c 100644 --- a/scripts/CHANGELOG.rst +++ b/scripts/CHANGELOG.rst @@ -11,6 +11,10 @@ * Add -sort option to sort archives by (latest) timestamp * Archive unsigned threads using timestamp of the next thread (:phab:`T69663`, :phab:`T182685`) +category_redirect +~~~~~~~~~~~~~~~~~ +* Use localized template prefix (:phab:`T318049`) + create_isbn_edition ~~~~~~~~~~~~~~~~~~~ -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834661 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I09feadfb8d1cb8300f5cdb723c32c90b4984259f Gerrit-Change-Number: 834661 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [CI] Revert: cancel old github action for login_tests
by Xqt (Code Review) 25 Sep '22

25 Sep '22

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834658 ) Change subject: [CI] Revert: cancel old github action for login_tests ...................................................................... [CI] Revert: cancel old github action for login_tests Change-Id: Ia4a6ac99d83ddcb7f57445239507211d40cc330f --- M .github/workflows/login_tests-ci.yml 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/login_tests-ci.yml b/.github/workflows/login_tests-ci.yml index 1e2605b..55d5246 100644 --- a/.github/workflows/login_tests-ci.yml +++ b/.github/workflows/login_tests-ci.yml @@ -11,10 +11,6 @@ types: - completed -concurrency: - group: ${{ github.ref }} - cancel-in-progress: true - env: PYWIKIBOT_TEST_RUNNING: 1 PYWIKIBOT_LOGIN_LOGOUT: 1 -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834658 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ia4a6ac99d83ddcb7f57445239507211d40cc330f Gerrit-Change-Number: 834658 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [IMPR] use preload parameter of getCombinedGenerato to preload pages
by jenkins-bot (Code Review) 25 Sep '22

25 Sep '22

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834356 ) Change subject: [IMPR] use preload parameter of getCombinedGenerato to preload pages ...................................................................... [IMPR] use preload parameter of getCombinedGenerato to preload pages Change-Id: I92c2459fc8ca46e2d1d3ded68d4d5aebcedd747c --- M scripts/category.py 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/category.py b/scripts/category.py index 3b25670..5f339a8 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -1553,14 +1553,11 @@ cat_db = CategoryDatabase(rebuild=rebuild) if action == 'add': - gen = gen_factory.getCombinedGenerator() + gen = gen_factory.getCombinedGenerator(preload=True) if not gen: # default for backwards compatibility gen_factory.handle_arg('-links') - gen = gen_factory.getCombinedGenerator() - # The preloading generator is responsible for downloading multiple - # pages from the wiki simultaneously. - gen = pagegenerators.PreloadingGenerator(gen) + gen = gen_factory.getCombinedGenerator(preload=True) bot = CategoryAddBot(gen, newcat=options.get('to'), sort_by_last_name=sort_by_last_name, -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834356 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I92c2459fc8ca46e2d1d3ded68d4d5aebcedd747c Gerrit-Change-Number: 834356 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [IMPR] decrease nested flow in CategoryPreprocess.determine_type_target
by jenkins-bot (Code Review) 25 Sep '22

25 Sep '22

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/833998 ) Change subject: [IMPR] decrease nested flow in CategoryPreprocess.determine_type_target ...................................................................... [IMPR] decrease nested flow in CategoryPreprocess.determine_type_target Change-Id: If1f62727b6a40aea83d820a9efcf6e3d38e3239c --- M scripts/category.py 1 file changed, 27 insertions(+), 25 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/category.py b/scripts/category.py index cb04077..7c8cfc7 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -199,46 +199,48 @@ self.edit_redirects = edit_redirects self.create = create - def determine_type_target(self, page) -> Optional[pywikibot.Page]: + def determine_type_target( + self, + page: pywikibot.Page + ) -> Optional[pywikibot.Page]: """ Return page to be categorized by type. :param page: Existing, missing or redirect page to be processed. - :type page: pywikibot.Page :return: Page to be categorized. """ if page.exists(): - if page.isRedirectPage(): - # if it is a redirect, use the redirect target instead - redir_target = page.getRedirectTarget() - if self.follow_redirects: - if redir_target.exists(): - return redir_target + if not page.isRedirectPage(): + return page - if self.create: - redir_target.text = '' - pywikibot.output('Redirect target {} does not exist ' - 'yet; creating.'.format( - redir_target.title(as_link=True))) - return redir_target + # if it is a redirect, use the redirect target instead + redir_target = page.getRedirectTarget() + if self.follow_redirects: + if redir_target.exists(): + return redir_target - if self.edit_redirects: - return page - - pywikibot.warning( - 'Redirect target {} cannot be modified; skipping.' - .format(redir_target)) - return None + if self.create: + redir_target.text = '' + pywikibot.output('Redirect target {} does not exist yet; ' + 'creating.'.format( + redir_target.title(as_link=True))) + return redir_target if self.edit_redirects: return page - pywikibot.warning('Page {} is a redirect to {}; skipping.' - .format(page.title(as_link=True), - redir_target.title(as_link=True))) + pywikibot.warning( + 'Redirect target {} cannot be modified; skipping.' + .format(redir_target)) return None - return page + if self.edit_redirects: + return page + + pywikibot.warning('Page {} is a redirect to {}; skipping.' + .format(page.title(as_link=True), + redir_target.title(as_link=True))) + return None if self.create: page.text = '' -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/833998 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If1f62727b6a40aea83d820a9efcf6e3d38e3239c Gerrit-Change-Number: 833998 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [cleanup] Remove always attribute in CategoryAddBot
by jenkins-bot (Code Review) 25 Sep '22

25 Sep '22

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/833793 ) Change subject: [cleanup] Remove always attribute in CategoryAddBot ...................................................................... [cleanup] Remove always attribute in CategoryAddBot CategoryAddBot derives from CategoryPreprocess which is BaseBot. BaseBot has 'always': False as available_options and opt.always is used within userPut method and may be set there whereas always attribute is no longer used since CategoryAddBot inherits from BaseBot after aa255ee change. Change-Id: I5b1ed4db971a17d28ea664dd45fd3c0ef2243e99 --- M scripts/category.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/category.py b/scripts/category.py index cb04077..3a645f1 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -439,7 +439,6 @@ self.sort = sort_by_last_name self.create = create self.follow_redirects = follow_redirects - self.always = False self.comment = comment @staticmethod -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/833793 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I5b1ed4db971a17d28ea664dd45fd3c0ef2243e99 Gerrit-Change-Number: 833793 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [CI] cancel old github action if a new commit is made
by Xqt (Code Review) 25 Sep '22

25 Sep '22

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834657 ) Change subject: [CI] cancel old github action if a new commit is made ...................................................................... [CI] cancel old github action if a new commit is made Change-Id: I1e38e8067dfa0d705e4e41b148c2a57c230da62d --- M .github/workflows/login_tests-ci.yml M .github/workflows/pywikibot-ci.yml 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/login_tests-ci.yml b/.github/workflows/login_tests-ci.yml index 55d5246..1e2605b 100644 --- a/.github/workflows/login_tests-ci.yml +++ b/.github/workflows/login_tests-ci.yml @@ -11,6 +11,10 @@ types: - completed +concurrency: + group: ${{ github.ref }} + cancel-in-progress: true + env: PYWIKIBOT_TEST_RUNNING: 1 PYWIKIBOT_LOGIN_LOGOUT: 1 diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index ae29edc..55969f5 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -10,6 +10,10 @@ pull_request: branches: [ master ] +concurrency: + group: ${{ github.ref }} + cancel-in-progress: true + env: PYWIKIBOT_TEST_RUNNING: 1 PYWIKIBOT_USERNAME: Pywikibot-test -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/834657 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I1e38e8067dfa0d705e4e41b148c2a57c230da62d Gerrit-Change-Number: 834657 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits