Merlijn van Deen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/76343
Change subject: Expand all Text for Checking Hidden Categories
......................................................................
Expand all Text for Checking Hidden Categories
An example of this issue is [1] which has a template that actually adds the
_HIDDEN_ keyword. The other change proposed here is not to use regular
expressions for that match, it is pointless.
[1] http://commons.wikimedia.org/wiki/Category:Cultural_heritage_monuments_in_P…
Change-Id: I4d1acce3c3c311724a577435829630c8e2548581
---
M pywikibot/page.py
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/43/76343/1
diff --git a/pywikibot/page.py b/pywikibot/page.py
index d34a5c6..215b643 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -1844,9 +1844,12 @@
def isHiddenCategory(self):
"""Return True if the category is hidden."""
- text = self.get()
- hidden = re.search('__HIDDENCAT__', text)
- return bool(hidden)
+ # FIXME
+ # This should use action=query&list=allcategories
+ # setting acfrom and acto to the category title and adding
+ # acprop=hidden but currently fails in some cases
+ # (see bug 48824)
+ return '__HIDDENCAT__' in self.expand_text()
def copyTo(self, cat, message):
"""
--
To view, visit https://gerrit.wikimedia.org/r/76343
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d1acce3c3c311724a577435829630c8e2548581
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Merlijn van Deen <valhallasw(a)gmail.com>
Gerrit-Reviewer: DMaggot <david.narvaez(a)computer.org>
Hello PywikibotCommitWatcher,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/76318
to review the following change.
Change subject: improvement; add '.gitattributes' file in order to re-enable some $Id$ support
......................................................................
improvement; add '.gitattributes' file in order to re-enable some $Id$ support
Change-Id: I048cecae3ffa2f16c1500d0b7a95bd30ea551dec
---
A .gitattributes
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/18/76318/1
diff --git a/.gitattributes b/.gitattributes
new file mode 100644
index 0000000..274c91d
--- /dev/null
+++ b/.gitattributes
@@ -0,0 +1 @@
+*.py ident
--
To view, visit https://gerrit.wikimedia.org/r/76318
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I048cecae3ffa2f16c1500d0b7a95bd30ea551dec
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: DrTrigon <dr.trigon(a)surfeu.ch>
Gerrit-Reviewer: PywikibotCommitWatcher <pywikibot-commits(a)lists.wikimedia.org>
Hello PywikibotCommitWatcher,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/76288
to review the following change.
Change subject: improvement; adopted LICENSE in order to reflect changes in externals management
......................................................................
improvement; adopted LICENSE in order to reflect changes in externals management
Change-Id: Ia926612cf98d68794aedfa4385dbda219fa65bf9
---
M LICENSE
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/88/76288/1
diff --git a/LICENSE b/LICENSE
index 95c57cb..95545e7 100644
--- a/LICENSE
+++ b/LICENSE
@@ -35,6 +35,10 @@
about the suitability of this array for any purpose. It is provided
"as is" without express or implied warranty.
-The 'BeautifulSoup.py' module is Copyright (c) 2004-2007 Leonard Richardson,
-and is licensed under the terms of the Python Software Foundation license,
-which is available at http://www.python.org/download/releases/2.5/license/.
+Everything in the 'externals' directory is general released under seperate
+licenses. Some parts may come from Pywikipedia bot team and share the same
+permissions, but in general they have to be checked for any external package
+seperately.
+For example the 'BeautifulSoup.py' module is Copyright (c) 2004-2007 Leonard
+Richardson, and licensed under the terms of the Python Software Foundation
+license, available at http://www.python.org/download/releases/2.5/license/.
--
To view, visit https://gerrit.wikimedia.org/r/76288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia926612cf98d68794aedfa4385dbda219fa65bf9
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: DrTrigon <dr.trigon(a)surfeu.ch>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)gmail.com>
Gerrit-Reviewer: Multichill <maarten(a)mdammers.nl>
Gerrit-Reviewer: PywikibotCommitWatcher <pywikibot-commits(a)lists.wikimedia.org>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
DrTrigon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/76318
Change subject: improvement; add '.gitattributes' file in order to re-enable some $Id$ support
......................................................................
improvement; add '.gitattributes' file in order to re-enable some $Id$ support
Change-Id: I048cecae3ffa2f16c1500d0b7a95bd30ea551dec
---
A .gitattributes
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/18/76318/1
diff --git a/.gitattributes b/.gitattributes
new file mode 100644
index 0000000..274c91d
--- /dev/null
+++ b/.gitattributes
@@ -0,0 +1 @@
+*.py ident
--
To view, visit https://gerrit.wikimedia.org/r/76318
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I048cecae3ffa2f16c1500d0b7a95bd30ea551dec
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: DrTrigon <dr.trigon(a)surfeu.ch>
DrTrigon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/76317
Change subject: bug fix; solve bug introduced by r11524 and reported by totoazero and xqt
......................................................................
bug fix; solve bug introduced by r11524 and reported by totoazero and xqt
Change-Id: I30c0efab5cb2c3dfc0cb574792e7a17a5a00e2a3
---
M externals/__init__.py
1 file changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/17/76317/1
diff --git a/externals/__init__.py b/externals/__init__.py
index dfd4f20..7b18c26 100644
--- a/externals/__init__.py
+++ b/externals/__init__.py
@@ -279,14 +279,21 @@
return False
else:
files = dependency_dictionary[distro]
- if files and show_question(files):
- callable_ = globals()[distro.replace('-', '_') + '_install']
+ func = distro.replace('-', '_') + '_install'
+ if files and (func in globals()) and show_question(files):
+ callable_ = globals()[func]
return callable_(files)
else:
return False
+def sunos_install(dependency_dictionary):
+ lowlevel_warning(u'Not implemented yet, download mode will be used.')
+ return False # skip this in order to trigger 'download_install' next
+
+
def windows_install(dependency_dictionary):
+ lowlevel_warning(u'Not available in windows OS, download mode will be used.')
return False # skip this in order to trigger 'download_install' next
### END of VisTrails inspired and copied code ### ### ### ### ### ### ### ###
@@ -373,11 +380,15 @@
return
# install the missing module
- dist = guess_system().split(u'-')
- if globals()[dist[0] + '_install'](modules_needed[m][0]):
+ dist = guess_system()
+ func = dist.split(u'-')[0] + '_install'
+ lowlevel_warning(u'Trying to install by use of "%s" package management system:' % dist)
+ if (func in globals()) and globals()[func](modules_needed[m][0]):
return
+ lowlevel_warning(u'Trying to install by download from source URL:')
if download_install(modules_needed[m][1], m, path):
return
+ lowlevel_warning(u'Trying to install by use of mercurial:')
if (len(modules_needed[m]) > 2) and\
mercurial_repo_install(modules_needed[m][2], m, path):
return
--
To view, visit https://gerrit.wikimedia.org/r/76317
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30c0efab5cb2c3dfc0cb574792e7a17a5a00e2a3
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: DrTrigon <dr.trigon(a)surfeu.ch>