Pywikibot-commits July 2024

pywikibot-commits@lists.wikimedia.org

1 participants
82 discussions

[Gerrit] ...core[master]: [flow] add __all__ to flow module
by jenkins-bot (Code Review) 28 Jul '24

28 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057395?usp=email ) Change subject: [flow] add __all__ to flow module ...................................................................... [flow] add __all__ to flow module Change-Id: I3753903cca9f5f664a0c32d874a5162702c354a4 --- M pywikibot/flow.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/flow.py b/pywikibot/flow.py index 15e7f12..bb51164 100644 --- a/pywikibot/flow.py +++ b/pywikibot/flow.py @@ -3,7 +3,6 @@ Structured Discussions was formerly known as Flow. Flow was renamed in 2017 as the focus was scoped to user-to-user discussions. -.. versionadded:: 3.0.20170403 .. caution:: Structured Discussions support previously known as Flow is no longer tested because the test environment was disabled. Please use this module with care. @@ -39,6 +38,14 @@ from pywikibot.tools import cached, deprecated_args +__all__ = ( + 'Board', + 'FlowPage', + 'Post', + 'Topic', +) + + class FlowPage(BasePage, abc.ABC): """The base page meta class for the Flow extension. -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I3753903cca9f5f664a0c32d874a5162702c354a4 Gerrit-Change-Number: 1057395 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [flow] remove flow_edit_tests.py and flow_thanks_tests.py
by jenkins-bot (Code Review) 28 Jul '24

28 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057383?usp=email ) Change subject: [flow] remove flow_edit_tests.py and flow_thanks_tests.py ...................................................................... [flow] remove flow_edit_tests.py and flow_thanks_tests.py Flow is disabled on test-wiki, therefore most tests cannot run there. Remove flow_edit_tests.py and flow_thanks_tests.py and move TestFlowEditFailure to flow_tests.py file. Also update flow module documentation. Bug: T371180 Change-Id: I70cf82ccbf9b600a7455903070e69261b57acc04 --- M docs/api_ref/flow.rst M pywikibot/flow.py M tests/__init__.py D tests/flow_edit_tests.py M tests/flow_tests.py D tests/flow_thanks_tests.py 6 files changed, 49 insertions(+), 375 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/docs/api_ref/flow.rst b/docs/api_ref/flow.rst index adfb422..be9b2a7 100644 --- a/docs/api_ref/flow.rst +++ b/docs/api_ref/flow.rst @@ -1,6 +1,6 @@ -***************************** -:mod:`flow` --- Flow Entities -***************************** +*********************************************** +:mod:`flow` --- Structured Discussions Entities +*********************************************** .. automodule:: flow - :synopsis: Objects representing Flow entities, like boards, topics, and posts + :synopsis: Objects representing Structured Discussions entities, like boards, topics, and posts diff --git a/pywikibot/flow.py b/pywikibot/flow.py index 2d58130..15e7f12 100644 --- a/pywikibot/flow.py +++ b/pywikibot/flow.py @@ -1,4 +1,20 @@ -"""Objects representing Flow entities, like boards, topics, and posts.""" +"""Objects representing Structured Discussions entities. + +Structured Discussions was formerly known as Flow. Flow was renamed in +2017 as the focus was scoped to user-to-user discussions. + +.. versionadded:: 3.0.20170403 +.. caution:: Structured Discussions support previously known as Flow is + no longer tested because the test environment was disabled. Please + use this module with care. +.. deprecated:: 9.4 + Structured Discussions extension is not maintained and will be + removed. Users are encouraged to stop using it. (:phab:`T371180`) +.. seealso:: + - https://www.mediawiki.org/wiki/Structured_Discussions + - https://www.mediawiki.org/wiki/Structured_Discussions/Wikis + - https://www.mediawiki.org/wiki/Extension:StructuredDiscussions +""" # # (C) Pywikibot team, 2015-2024 # @@ -339,14 +355,12 @@ self._reload() -# Flow non-page-like objects class Post: - """A post to a Flow discussion topic.""" + """A post to a Flow discussion topic. This is a non-page-like object.""" def __init__(self, page: Topic, uuid: str) -> None: - """ - Initializer. + """Initializer. :param page: Flow topic :param uuid: UUID of a Flow post diff --git a/tests/__init__.py b/tests/__init__.py index 34944b3..cf3b51c 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -85,8 +85,6 @@ 'file', 'fixes', 'flow', - 'flow_edit', - 'flow_thanks', 'gui', 'http', 'i18n', diff --git a/tests/flow_edit_tests.py b/tests/flow_edit_tests.py deleted file mode 100755 index b84ca6c..0000000 --- a/tests/flow_edit_tests.py +++ /dev/null @@ -1,298 +0,0 @@ -#!/usr/bin/env python3 -"""Edit tests for the flow module.""" -# -# (C) Pywikibot team, 2015-2024 -# -# Distributed under the terms of the MIT license. -# -from __future__ import annotations - -import unittest -from contextlib import contextmanager, suppress - -from pywikibot.exceptions import LockedPageError, TimeoutError -from pywikibot.flow import Board, Post, Topic -from tests.aspects import TestCase -from tests.utils import skipping - -MODERATION_REASON = 'Pywikibot test' - - -(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') -class TestFlowCreateTopic(TestCase): - - """Test the creation of Flow topics.""" - - family = 'wikipedia' - code = 'test' - write = True - - def test_create_topic(self): - """Test creation of topic.""" - content = 'If you can read this, the Flow code in Pywikibot works!' - board = Board(self.site, 'Talk:Pywikibot test') - topic = board.new_topic(MODERATION_REASON, content, 'wikitext') - first_post = topic.replies()[0] - wikitext = first_post.get(content_format='wikitext') - self.assertIn('wikitext', first_post._content) - self.assertNotIn('html', first_post._content) - self.assertIsInstance(wikitext, str) - self.assertEqual(wikitext, content) - - def test_summarize_topic(self): - """Test summarize topic we just created.""" - board = Board(self.site, 'Talk:Pywikibot test') - topic = next(board.topics(total=1)) - self.assertIsNone(topic.summary()) - - content = 'That was (and is still) a test' - topic.summarize(content) - self.assertIsInstance(topic.summary(), str) - self.assertEqual(topic.summary(), content) - - content = 'That works' - topic.summarize(content) - self.assertIsInstance(topic.summary(), str) - self.assertEqual(topic.summary(), content) - - -(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') -class TestFlowReply(TestCase): - - """Test replying to existing posts.""" - - family = 'wikipedia' - code = 'test' - write = True - - @classmethod - def setUpClass(cls): - """Set up class.""" - super().setUpClass() - cls._topic_title = 'Topic:Stf56oxx0sd4dkj1' - - def test_reply_to_topic(self): - """Test replying to "topic" (really the topic's root post).""" - # Setup - content = 'I am a reply to the topic. Replying works!' - topic = Topic(self.site, self._topic_title) - with skipping(TimeoutError): - old_replies = topic.replies(force=True)[:] - # Reply - reply_post = topic.reply(content, 'wikitext') - # Test content - wikitext = reply_post.get(content_format='wikitext') - self.assertIn('wikitext', reply_post._content) - self.assertNotIn('html', reply_post._content) - self.assertIsInstance(wikitext, str) - self.assertEqual(wikitext, content) - # Test reply list in topic - new_replies = topic.replies(force=True) - self.assertLength(new_replies, len(old_replies) + 1) - - def test_reply_to_topic_root(self): - """Test replying to the topic's root post directly.""" - # Setup - content = ("I am a reply to the topic's root post. " - 'Replying still works!') - topic = Topic(self.site, self._topic_title) - with skipping(TimeoutError): - topic_root = topic.root - old_replies = topic_root.replies(force=True)[:] - # Reply - reply_post = topic_root.reply(content, 'wikitext') - # Test content - wikitext = reply_post.get(content_format='wikitext') - self.assertIn('wikitext', reply_post._content) - self.assertNotIn('html', reply_post._content) - self.assertIsInstance(wikitext, str) - self.assertEqual(wikitext, content) - # Test reply list in topic - new_replies = topic_root.replies(force=True) - self.assertLength(new_replies, len(old_replies) + 1) - - def test_reply_to_post(self): - """Test replying to an ordinary post.""" - # Setup - content = 'I am a nested reply to a regular post. Still going strong!' - topic = Topic(self.site, self._topic_title) - root_post = Post(topic, 'stf5bamzx32rj1gt') - with skipping(TimeoutError): - old_replies = root_post.replies(force=True)[:] - # Reply - reply_post = root_post.reply(content, 'wikitext') - # Test content - wikitext = reply_post.get(content_format='wikitext') - self.assertIn('wikitext', reply_post._content) - self.assertNotIn('html', reply_post._content) - self.assertIsInstance(wikitext, str) - self.assertEqual(wikitext, content) - # Test reply list in topic - new_replies = root_post.replies(force=True) - self.assertLength(new_replies, len(old_replies) + 1) - - def test_nested_reply(self): - """Test replying to a previous reply to a topic.""" - # Setup - first_content = 'I am a reply to the topic with my own replies. Great!' - second_content = ('I am a nested reply. This conversation is ' - 'getting pretty good!') - topic = Topic(self.site, self._topic_title) - with skipping(TimeoutError): - topic_root = topic.root - # First reply - old_root_replies = topic_root.replies(force=True)[:] - first_reply_post = topic_root.reply(first_content, 'wikitext') - # Test first reply's content - first_wikitext = first_reply_post.get(content_format='wikitext') - self.assertIn('wikitext', first_reply_post._content) - self.assertNotIn('html', first_reply_post._content) - self.assertIsInstance(first_wikitext, str) - self.assertEqual(first_wikitext, first_content) - # Test reply list in topic - new_root_replies = topic_root.replies(force=True) - self.assertLength(new_root_replies, len(old_root_replies) + 1) - - # Nested reply - old_nested_replies = first_reply_post.replies(force=True)[:] - self.assertEqual(old_nested_replies, []) - second_reply_post = first_reply_post.reply(second_content, - 'wikitext') - # Test nested reply's content - second_wikitext = second_reply_post.get(content_format='wikitext') - self.assertIn('wikitext', second_reply_post._content) - self.assertNotIn('html', second_reply_post._content) - self.assertIsInstance(second_wikitext, str) - self.assertEqual(second_wikitext, second_content) - - # Test reply list in first reply - # Broken due to current Flow reply structure (T105438) - # new_nested_replies = first_reply_post.replies(force=True) - # self.assertLength(new_nested_replies, len(old_nested_replies) + 1) - - # Current test for nested reply list - self.assertEqual(old_nested_replies, []) - more_root_replies = topic_root.replies(force=True) - self.assertLength(more_root_replies, len(new_root_replies) + 1) - - -(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') -class TestFlowLockTopic(TestCase): - - """Locking and unlocking topics.""" - - family = 'wikipedia' - code = 'test' - write = True - - def test_lock_unlock_topic(self): - """Lock and unlock a test topic.""" - # Setup - topic = Topic(self.site, 'Topic:Sn12rdih4iducjsd') - if topic.is_locked: - topic.unlock(MODERATION_REASON) - self.assertFalse(topic.is_locked) - # Lock topic - topic.lock(MODERATION_REASON) - self.assertTrue(topic.is_locked) - # Unlock topic - topic.unlock(MODERATION_REASON) - self.assertFalse(topic.is_locked) - - -class TestFlowEditFailure(TestCase): - - """Flow-related edit failure tests.""" - - family = 'wikipedia' - code = 'test' - write = True - - def test_reply_to_locked_topic(self): - """Test replying to locked topic (should raise exception).""" - # Setup - content = 'I am a reply to a locked topic. This is not good!' - topic = Topic(self.site, 'Topic:Smxnipjfs8umm1wt') - # Reply (should raise a LockedPageError exception) - with self.assertRaises(LockedPageError): - topic.reply(content, 'wikitext') - topic_root = topic.root - with self.assertRaises(LockedPageError): - topic_root.reply(content, 'wikitext') - topic_reply = topic.root.replies(force=True)[0] - with self.assertRaises(LockedPageError): - topic_reply.reply(content, 'wikitext') - - -class FlowTests(TestCase): - - """Flow tests base class.""" - - family = 'wikipedia' - code = 'test' - write = True - - def setUp(self): - """Setup tests.""" - super().setUp() - self.topic = Topic(self.site, 'Topic:Sl4svodmrhzmpjjh') - self.post = Post(self.topic, 'sq1qvoig1az8w7cd') - - @contextmanager - def restored(self, flow): - """Setup and restore test.""" - # Setup - if flow.is_moderated: - flow.restore(MODERATION_REASON) - self.assertFalse(flow.is_moderated) - try: - yield flow - finally: - # Restore - flow.restore(MODERATION_REASON) - self.assertFalse(flow.is_moderated) - - -(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') -class TestFlowHide(FlowTests): - - """Hiding topics and posts.""" - - def test_hide(self): - """Hide and restore a test topic and post.""" - for flow in (self.topic, self.post): - with self.subTest(flow=flow.__class__.__name__), \ - self.restored(flow): - # Hide - flow.hide(MODERATION_REASON) - self.assertTrue(flow.is_moderated) - - -class TestFlowSysop(FlowTests): - - """Deleting and Suppressing topics and posts.""" - - rights = 'flow-delete,flow-suppress' - - def test_delete(self): - """Delete and restore a test topic and post.""" - for flow in (self.topic, self.post): - with self.subTest(flow=flow.__class__.__name__), \ - self.restored(flow): - # Delete - flow.delete_mod(MODERATION_REASON) - self.assertTrue(flow.is_moderated) - - def test_suppress(self): - """Suppress and restore a test topic and post.""" - for flow in (self.topic, self.post): - with self.subTest(flow=flow.__class__.__name__), \ - self.restored(flow): - # Suppress - flow.suppress(MODERATION_REASON) - self.assertTrue(flow.is_moderated) - - -if __name__ == '__main__': - with suppress(SystemExit): - unittest.main() diff --git a/tests/flow_tests.py b/tests/flow_tests.py index 0d21e3e..56da2aa 100755 --- a/tests/flow_tests.py +++ b/tests/flow_tests.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """Tests for the flow module.""" # -# (C) Pywikibot team, 2015-2023 +# (C) Pywikibot team, 2015-2024 # # Distributed under the terms of the MIT license. # @@ -11,7 +11,7 @@ from contextlib import suppress from pywikibot import config -from pywikibot.exceptions import NoPageError +from pywikibot.exceptions import LockedPageError, NoPageError from pywikibot.flow import Board, Post, Topic from tests.aspects import TestCase from tests.basepage import ( @@ -263,6 +263,30 @@ self.assertTrue(topic_hidden.is_moderated) +class TestFlowEditFailure(TestCase): + + """Flow-related edit failure tests.""" + + family = 'wikipedia' + code = 'test' + write = True + + def test_reply_to_locked_topic(self): + """Test replying to locked topic (should raise exception).""" + # Setup + content = 'I am a reply to a locked topic. This is not good!' + topic = Topic(self.site, 'Topic:Smxnipjfs8umm1wt') + # Reply (should raise a LockedPageError exception) + with self.assertRaises(LockedPageError): + topic.reply(content, 'wikitext') + topic_root = topic.root + with self.assertRaises(LockedPageError): + topic_root.reply(content, 'wikitext') + topic_reply = topic.root.replies(force=True)[0] + with self.assertRaises(LockedPageError): + topic_reply.reply(content, 'wikitext') + + if __name__ == '__main__': with suppress(SystemExit): unittest.main() diff --git a/tests/flow_thanks_tests.py b/tests/flow_thanks_tests.py deleted file mode 100755 index 5f1cced..0000000 --- a/tests/flow_thanks_tests.py +++ /dev/null @@ -1,64 +0,0 @@ -#!/usr/bin/env python3 -"""Tests for thanks-related code.""" -# -# (C) Pywikibot team, 2016-2024 -# -# Distributed under the terms of the MIT license. -# -from __future__ import annotations - -import unittest -from contextlib import suppress - -from pywikibot.flow import Topic -from tests.aspects import TestCase - -NO_THANKABLE_POSTS = 'There is no recent post which can be test thanked.' - - -(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') -class TestThankFlowPost(TestCase): - - """Test thanks for Flow posts.""" - - family = 'wikipedia' - code = 'test' - - write = True - - @classmethod - def setUpClass(cls): - """Set up class.""" - super().setUpClass() - cls._topic_title = 'Topic:Tvkityksg1ukyrrw' - - @unittest.expectedFailure # T367308 - def test_thank_post(self): - """Test thanks for Flow posts.""" - site = self.get_site() - topic = Topic(site, self._topic_title) - for post in reversed(topic.replies()): - user = post.creator - if site.user() == user.username: - continue - if user.is_thankable: - break - else: - self.skipTest(NO_THANKABLE_POSTS) - before_time = site.getcurrenttimestamp() - post.thank() - log_entries = site.logevents(logtype='thanks', total=5, page=user, - start=before_time, reverse=True) - self.assertTrue(bool(next(log_entries, None))) - - def test_self_thank(self): - """Test that thanking one's own Flow post causes an error.""" - site = self.get_site() - topic = Topic(site, self._topic_title) - my_reply = topic.reply('My attempt to thank myself.') - self.assertAPIError('invalidrecipient', None, my_reply.thank) - - -if __name__ == '__main__': - with suppress(SystemExit): - unittest.main() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I70cf82ccbf9b600a7455903070e69261b57acc04 Gerrit-Change-Number: 1057383 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [9.4] Prepare next release
by jenkins-bot (Code Review) 28 Jul '24

28 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057378?usp=email ) Change subject: [9.4] Prepare next release ...................................................................... [9.4] Prepare next release Change-Id: Idca98e6b8945cd3fd2f60bacfc89ddad179720be --- M HISTORY.rst M ROADMAP.rst M pywikibot/__metadata__.py M scripts/__init__.py 4 files changed, 25 insertions(+), 19 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/HISTORY.rst b/HISTORY.rst index 74b5323..91ed982 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -1,6 +1,28 @@ Release History =============== +9.3.0 +----- +*28 July 2024* + +* Only add lang links from API response to a given page if present in family file (:phab:`T371107`) +* Add support for ``cswikivoyage`` to Pywikibot (:phab:`T370915`) +* :class:`pywikibot.FilePage` has a parameter *ignore_extension* to ignore file extension check :phab:`T352237`) +* Provide :attr:`cosmetic_changes.main_sortkey` to localize sort key in + :meth:`CosmeticChangesToolkit.standardizePageFooter<cosmetic_changes.CosmeticChangesToolkit.standardizePageFooter>` +* Add *ignore_section parameter* to :meth:`site.APISite.getredirtarget` and :meth:`page.BasePage.getRedirectTarget` to + ignore :exc:`exceptions.SectionError` (:phab:`T370295`) +* Avoid backslash in repr string of :class:`page.WikibaseEntity` +* *botflag* parameter of :meth:`page.BasePage.save`, :meth:`page.BasePage.put`, :meth:`page.BasePage.touch`, + :meth:`pywikibot.Page.set_redirect_target` and :meth:`pywikibot.ItemPage.set_redirect_target` was renamed to *bot* to + be in sync with :meth:`APISite.editpage<pywikibot.site._apisite.APISite.editpage>` and :api:`edit`. +* use :meth:`page.BasePage.templates` in :meth:`Page.templatesWithParams<page.Page.templatesWithParams>` to cache + templates +* Re-implement :meth:`Page.main_authors()<page._toolforge.WikiBlameMixin.main_authors>` as + :meth:`Page.authorship()<page._toolforge.WikiBlameMixin.authorship>` using ``xtools`` (:phab:`T366100`); + ``wikitextparser`` packages is required for it. + + 9.2.1 ----- *13 July 2024* diff --git a/ROADMAP.rst b/ROADMAP.rst index 63d76f2..c2fb21e 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,23 +1,7 @@ Current Release Changes ======================= -* Only add lang links from API response to a given page if present in family file (:phab:`T371107`) -* Add support for ``cswikivoyage`` to Pywikibot (:phab:`T370915`) -* :class:`pywikibot.FilePage` has a parameter *ignore_extension* to ignore file extension check :phab:`T352237`) -* Provide :attr:`cosmetic_changes.main_sortkey` to localize sort key in - :meth:`CosmeticChangesToolkit.standardizePageFooter<cosmetic_changes.CosmeticChangesToolkit.standardizePageFooter>` -* Add *ignore_section parameter* to :meth:`site.APISite.getredirtarget` and :meth:`page.BasePage.getRedirectTarget` to - ignore :exc:`exceptions.SectionError` (:phab:`T370295`) -* Avoid backslash in repr string of :class:`page.WikibaseEntity` -* *botflag* parameter of :meth:`page.BasePage.save`, :meth:`page.BasePage.put`, :meth:`page.BasePage.touch`, - :meth:`pywikibot.Page.set_redirect_target` and :meth:`pywikibot.ItemPage.set_redirect_target` was renamed to *bot* to - be in sync with :meth:`APISite.editpage<pywikibot.site._apisite.APISite.editpage>` and :api:`edit`. -* use :meth:`page.BasePage.templates` in :meth:`Page.templatesWithParams<page.Page.templatesWithParams>` to cache - templates -* Re-implement :meth:`Page.main_authors()<page._toolforge.WikiBlameMixin.main_authors>` as - :meth:`Page.authorship()<page._toolforge.WikiBlameMixin.authorship>` using ``xtools`` (:phab:`T366100`); - ``wikitextparser`` packages is required for it. - +* (no changes yet) Current Deprecations ==================== diff --git a/pywikibot/__metadata__.py b/pywikibot/__metadata__.py index ff248c6..aeaccf7 100644 --- a/pywikibot/__metadata__.py +++ b/pywikibot/__metadata__.py @@ -12,6 +12,6 @@ from time import strftime -__version__ = '9.3.0' +__version__ = '9.4.0.dev1' __url__ = 'https://www.mediawiki.org/wiki/Manual:Pywikibot' __copyright__ = f'2003-{strftime("%Y")}, Pywikibot team' diff --git a/scripts/__init__.py b/scripts/__init__.py index dac5584..02c277d 100644 --- a/scripts/__init__.py +++ b/scripts/__init__.py @@ -32,4 +32,4 @@ # # Distributed under the terms of the MIT license. # -__version__ = '9.3.0' +__version__ = '9.4.0' -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Idca98e6b8945cd3fd2f60bacfc89ddad179720be Gerrit-Change-Number: 1057378 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <dalangi-ctr(a)wikimedia.org> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[stable]: Merge branch 'master' into stable
by jenkins-bot (Code Review) 28 Jul '24

28 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057375?usp=email ) Change subject: Merge branch 'master' into stable ...................................................................... Merge branch 'master' into stable Change-Id: I15774e6cd593d123d565babf40abab19dbcb72ab --- M HISTORY.rst M ROADMAP.rst M pywikibot/__metadata__.py 4 files changed, 119 insertions(+), 41 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/HISTORY.rst b/HISTORY.rst index 20a7673..74b5323 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -1,17 +1,6 @@ Release History =============== -<<<<<<< HEAD (e7da58 Update git submodules) -||||||| BASE -9.1.3 ------ -*28.05.2024* - -* Add support for dtpwiki (:phab:`T365232`) -* i18n updates - -9.1.2 -======= 9.2.1 ----- *13 July 2024* @@ -20,7 +9,6 @@ * i18n updates ->>>>>>> BRANCH (27ca7e [9.3] Publish Pywikibot 9.3) 9.2.0 ----- *22 June 2024* diff --git a/ROADMAP.rst b/ROADMAP.rst index ae8eabd..63d76f2 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,28 +1,6 @@ Current Release Changes ======================= -<<<<<<< HEAD (e7da58 Update git submodules) -* Add support for ``aewikimedia`` to Pywikibot (:phab:`T362529`) -* i18n updates -||||||| BASE -* Add support for ``btmwiki`` to Pywikibot (:phab:`T368069`) -* Include image repository extensions in :attr:`site.APISite.file_extensions - <pywikibot.site._apisite.APISite.file_extensions>` -* Ignore :exc:`ValueError` durig upcast of :class:`FilePage<pywikibot.page.FilePage>` due to invalid file extension - (:phab:`T367777`) -* Add :func:`pagegenerators.SupersetPageGenerator` pagegenerator (:phab:`T367684`) -* No longer wait in :meth:`data.api.Request._http_request` for ``ImportError`` and ``NameError`` -* Replace ``requests.utils.urlparse`` with ``urllib.parse.urlparse`` in - :func:`comms.http.get_authentication` (:phab:`T367649`) -* Show an appropiate message if ``requests_oauthlib`` package is required but missing (:phab:`T353387`) -* Retry ``DBUnexpectedError`` in :meth:`data.api.Request._internal_api_error` (:phab:`T367383`) -* Duplicated entries found in :mod:`pywikibot` were removed -* Pass ``None`` instead of an empty string as *expiry* argument in - :meth:`site.APISite.protect()<pywikibot.site._apisite.APISite.protect>` (:phab:`T367176`) -* Fix keyword argument in :meth:`Page.undelete()<page.BasePage.undelete>` when - calling :meth:`site.APISite.undelete()<pywikibot.site._apisite.APISite.undelete>` (:phab:`T367037`) -* Check whether :attr:`BaseBot.generator<bot.BaseBot.generator>` is None in :meth:`run()<bot.BaseBot.run>` method -======= * Only add lang links from API response to a given page if present in family file (:phab:`T371107`) * Add support for ``cswikivoyage`` to Pywikibot (:phab:`T370915`) * :class:`pywikibot.FilePage` has a parameter *ignore_extension* to ignore file extension check :phab:`T352237`) @@ -40,7 +18,6 @@ :meth:`Page.authorship()<page._toolforge.WikiBlameMixin.authorship>` using ``xtools`` (:phab:`T366100`); ``wikitextparser`` packages is required for it. ->>>>>>> BRANCH (27ca7e [9.3] Publish Pywikibot 9.3) Current Deprecations ==================== diff --git a/pywikibot/__metadata__.py b/pywikibot/__metadata__.py index fcc5815..ff248c6 100644 --- a/pywikibot/__metadata__.py +++ b/pywikibot/__metadata__.py @@ -12,12 +12,6 @@ from time import strftime -<<<<<<< HEAD (e7da58 Update git submodules) -__version__ = '9.2.1' -||||||| BASE -__version__ = '9.2.0' -======= __version__ = '9.3.0' ->>>>>>> BRANCH (27ca7e [9.3] Publish Pywikibot 9.3) __url__ = 'https://www.mediawiki.org/wiki/Manual:Pywikibot' __copyright__ = f'2003-{strftime("%Y")}, Pywikibot team' -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: stable Gerrit-Change-Id: I15774e6cd593d123d565babf40abab19dbcb72ab Gerrit-Change-Number: 1057375 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [9.3] Publish Pywikibot 9.3
by jenkins-bot (Code Review) 28 Jul '24

28 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057349?usp=email ) Change subject: [9.3] Publish Pywikibot 9.3 ...................................................................... [9.3] Publish Pywikibot 9.3 Change-Id: I35e3acd180b1f7de1341f393faaf5c8692c60a2c --- M pywikibot/__metadata__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/__metadata__.py b/pywikibot/__metadata__.py index 63aa9c9..ff248c6 100644 --- a/pywikibot/__metadata__.py +++ b/pywikibot/__metadata__.py @@ -12,6 +12,6 @@ from time import strftime -__version__ = '9.3.0.dev1' +__version__ = '9.3.0' __url__ = 'https://www.mediawiki.org/wiki/Manual:Pywikibot' __copyright__ = f'2003-{strftime("%Y")}, Pywikibot team' -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I35e3acd180b1f7de1341f393faaf5c8692c60a2c Gerrit-Change-Number: 1057349 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [doc] update ROADMAP.rst and CHANGELOG.rst
by jenkins-bot (Code Review) 27 Jul '24

27 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057348?usp=email ) Change subject: [doc] update ROADMAP.rst and CHANGELOG.rst ...................................................................... [doc] update ROADMAP.rst and CHANGELOG.rst Change-Id: I5057cb43d8a4bf28e6f1a91c06c14b9914350ff9 --- M ROADMAP.rst M scripts/CHANGELOG.rst 2 files changed, 34 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/ROADMAP.rst b/ROADMAP.rst index ce8bc73..63d76f2 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,6 +1,14 @@ Current Release Changes ======================= +* Only add lang links from API response to a given page if present in family file (:phab:`T371107`) +* Add support for ``cswikivoyage`` to Pywikibot (:phab:`T370915`) +* :class:`pywikibot.FilePage` has a parameter *ignore_extension* to ignore file extension check :phab:`T352237`) +* Provide :attr:`cosmetic_changes.main_sortkey` to localize sort key in + :meth:`CosmeticChangesToolkit.standardizePageFooter<cosmetic_changes.CosmeticChangesToolkit.standardizePageFooter>` +* Add *ignore_section parameter* to :meth:`site.APISite.getredirtarget` and :meth:`page.BasePage.getRedirectTarget` to + ignore :exc:`exceptions.SectionError` (:phab:`T370295`) +* Avoid backslash in repr string of :class:`page.WikibaseEntity` * *botflag* parameter of :meth:`page.BasePage.save`, :meth:`page.BasePage.put`, :meth:`page.BasePage.touch`, :meth:`pywikibot.Page.set_redirect_target` and :meth:`pywikibot.ItemPage.set_redirect_target` was renamed to *bot* to be in sync with :meth:`APISite.editpage<pywikibot.site._apisite.APISite.editpage>` and :api:`edit`. @@ -14,6 +22,8 @@ Current Deprecations ==================== +* 9.3.0: :meth:`page.BasePage.userName` and :meth:`page.BasePage.isIpEdit` are deprecated in favour of + ``user`` or ``anon`` attributes of :attr:`page.BasePage.latest_revision` property * 9.2.0: Imports of :mod:`logging` functions from :mod:`bot` module is deprecated and will be desupported * 9.2.0: *total* argument in ``-logevents`` pagegenerators option is deprecated; use ``-limit`` instead (:phab:`T128981`) diff --git a/scripts/CHANGELOG.rst b/scripts/CHANGELOG.rst index 31ae292..b207ef7 100644 --- a/scripts/CHANGELOG.rst +++ b/scripts/CHANGELOG.rst @@ -1,6 +1,30 @@ Scripts Changelog ================= +9.3.0 +----- + +delinker +^^^^^^^^ + +* Ignore file extension check :phab:`T352237`) + +fixing_redirects +^^^^^^^^^^^^^^^^ + +* Ignore :exc:`SectionError` in fixing_redirects.py script (:phab:`T370295`) + +interwiki +^^^^^^^^^ + +* ``-wiktionary`` option was removed + +redirect +^^^^^^^^ + +* Show the current redirect target with redirect summary (:phab:`T254839`) + + 9.2.0 ----- -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I5057cb43d8a4bf28e6f1a91c06c14b9914350ff9 Gerrit-Change-Number: 1057348 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <dalangi-ctr(a)wikimedia.org> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [tests] Disable flow_edit_tests.py and flow_thanks_tests.py
by jenkins-bot (Code Review) 27 Jul '24

27 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057347?usp=email ) Change subject: [tests] Disable flow_edit_tests.py and flow_thanks_tests.py ...................................................................... [tests] Disable flow_edit_tests.py and flow_thanks_tests.py Bug: T371112 Change-Id: I0c6b0f4acc4ecad7402a98d9a5da00a6e18a583b --- M tests/flow_edit_tests.py M tests/flow_thanks_tests.py 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/flow_edit_tests.py b/tests/flow_edit_tests.py index f78f16b..b84ca6c 100755 --- a/tests/flow_edit_tests.py +++ b/tests/flow_edit_tests.py @@ -18,6 +18,7 @@ MODERATION_REASON = 'Pywikibot test' +(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') class TestFlowCreateTopic(TestCase): """Test the creation of Flow topics.""" @@ -55,6 +56,7 @@ self.assertEqual(topic.summary(), content) +(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') class TestFlowReply(TestCase): """Test replying to existing posts.""" @@ -174,6 +176,7 @@ self.assertLength(more_root_replies, len(new_root_replies) + 1) +(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') class TestFlowLockTopic(TestCase): """Locking and unlocking topics.""" @@ -182,7 +185,6 @@ code = 'test' write = True - @unittest.expectedFailure # T367301 def test_lock_unlock_topic(self): """Lock and unlock a test topic.""" # Setup @@ -251,11 +253,11 @@ self.assertFalse(flow.is_moderated) +(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') class TestFlowHide(FlowTests): """Hiding topics and posts.""" - @unittest.expectedFailure # T367303 def test_hide(self): """Hide and restore a test topic and post.""" for flow in (self.topic, self.post): diff --git a/tests/flow_thanks_tests.py b/tests/flow_thanks_tests.py index 2f875af..5f1cced 100755 --- a/tests/flow_thanks_tests.py +++ b/tests/flow_thanks_tests.py @@ -16,6 +16,7 @@ NO_THANKABLE_POSTS = 'There is no recent post which can be test thanked.' +(a)unittest.skip('T371112: Structured Discussion was disabled on test-wiki') class TestThankFlowPost(TestCase): """Test thanks for Flow posts.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I0c6b0f4acc4ecad7402a98d9a5da00a6e18a583b Gerrit-Change-Number: 1057347 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [tests] activate windows action for CI
by Xqt (Code Review) 27 Jul '24

27 Jul '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057343?usp=email ) Change subject: [tests] activate windows action for CI ...................................................................... [tests] activate windows action for CI remove experimental flag Change-Id: I3d5aebedf2fc82f01c48f23ee5e72c8a84719ef8 --- M .github/workflows/windows_tests.yml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/windows_tests.yml b/.github/workflows/windows_tests.yml index 9d54d4c..82591e6 100644 --- a/.github/workflows/windows_tests.yml +++ b/.github/workflows/windows_tests.yml @@ -26,7 +26,6 @@ python-version: [ "3.7.1", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0" ] python-arch: [ x64, x86 ] site: [ "wikipedia:en" ] - experimental: [ true ] steps: - name: Checkout Repository -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057343?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I3d5aebedf2fc82f01c48f23ee5e72c8a84719ef8 Gerrit-Change-Number: 1057343 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] ...core[master]: [fix] Only add lang links to page._langlinks if present in family file
by jenkins-bot (Code Review) 27 Jul '24

27 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057340?usp=email ) Change subject: [fix] Only add lang links to page._langlinks if present in family file ...................................................................... [fix] Only add lang links to page._langlinks if present in family file Language links retrieved via API may have links which aren't present in the family file. Bug: T371107 Change-Id: I9e850f2f02eac3208bc1361eb6ff76d4589f2575 --- M pywikibot/data/api/_generators.py 1 file changed, 20 insertions(+), 5 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api/_generators.py b/pywikibot/data/api/_generators.py index de6f011..69ca560 100644 --- a/pywikibot/data/api/_generators.py +++ b/pywikibot/data/api/_generators.py @@ -20,7 +20,12 @@ import pywikibot from pywikibot import config from pywikibot.backports import Callable, Iterable -from pywikibot.exceptions import Error, InvalidTitleError, UnsupportedPageError +from pywikibot.exceptions import ( + Error, + InvalidTitleError, + UnknownSiteError, + UnsupportedPageError, +) from pywikibot.site import Namespace from pywikibot.tools import deprecated from pywikibot.tools.collections import GeneratorWrapper @@ -936,10 +941,20 @@ def _update_langlinks(page, langlinks) -> None: - """Update page langlinks.""" - links = {pywikibot.Link.langlinkUnsafe(link['lang'], link['*'], - source=page.site) - for link in langlinks} + """Update page langlinks. + + .. versionadded:: 9.3 + only add a language link if it is found in the family file. + + :meta public: + """ + links = set() + for langlink in langlinks: + with suppress(UnknownSiteError): + link = pywikibot.Link.langlinkUnsafe(langlink['lang'], + langlink['*'], + source=page.site) + links.add(link) if hasattr(page, '_langlinks'): page._langlinks |= links -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I9e850f2f02eac3208bc1361eb6ff76d4589f2575 Gerrit-Change-Number: 1057340 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [tests] test TestInterwikidataBot.test_main for unconnected sites
by jenkins-bot (Code Review) 26 Jul '24

26 Jul '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057237?usp=email ) Change subject: [tests] test TestInterwikidataBot.test_main for unconnected sites ...................................................................... [tests] test TestInterwikidataBot.test_main for unconnected sites Bug: T371108 Change-Id: I4ee09a18b2b06d7901668f84d3682c413b7a2ca4 --- M tests/interwikidata_tests.py 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/interwikidata_tests.py b/tests/interwikidata_tests.py index e1bfb08..45ae584 100755 --- a/tests/interwikidata_tests.py +++ b/tests/interwikidata_tests.py @@ -55,9 +55,17 @@ def test_main(self): """Test main function interwikidata.py.""" - # The main function return None. - with empty_sites(): - self.assertIsNone(interwikidata.main()) + # The default site is used here + if pywikibot.Site().has_data_repository: + with empty_sites(): + # The main function return None. + self.assertIsNone(interwikidata.main()) + else: + with empty_sites(), self.assertRaisesRegex( + ValueError, + r'[a-z}+:[a-z_-]+ does not have a data repository, use ' + r'interwiki\.py instead\.'): + interwikidata.main() def test_iw_bot(self): """Test IWBot class.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1057237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I4ee09a18b2b06d7901668f84d3682c413b7a2ca4 Gerrit-Change-Number: 1057237 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits July 2024