jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/946516 )
Change subject: [i18n] update i18n for duplication reports
......................................................................
[i18n] update i18n for duplication reports
Change-Id: I9afb8fc8211d6fe053af8dc802a08dfa1e64f9c0
---
M checkimages/en.json
M checkimages/it.json
M checkimages/de.json
3 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/checkimages/de.json b/checkimages/de.json
index ec3a422..f3e3d64 100644
--- a/checkimages/de.json
+++ b/checkimages/de.json
@@ -10,7 +10,7 @@
"checkimages-doubles-file-comment": "Bot: Datei liegt bereits auf Commons, kann gelöscht werden",
"checkimages-doubles-head": "Datei-Duplikat",
"checkimages-doubles-talk-comment": "Bot: Benachrichtigung, dass die Datei bereits auf Commons vorhanden ist",
- "checkimages-doubles-talk-text": "Vielen Dank für das Hochladen von %(upload)s. Diese Datei ist jedoch eine Kopie von %(image)s. Der Bot hat die Datei, die am wenigsten verwendet wurde oder aktuell war, als Duplikat markiert. Wenn Sie es für angebrachter halten, die Datei als sofort zu löschend markiert zu belassen, können Sie die doppelten Dateien löschen und die Löschvorlage von der zu belassenden Datei entfernen. Dies ist eine automatisierte Nachricht von %(bot)s.",
+ "checkimages-doubles-talk-text": "Vielen Dank für das Hochladen von %(upload)s. Diese Datei ist jedoch eine Kopie von:%(image)sDer Bot hat die Datei, die am wenigsten verwendet wurde oder aktuell war, als Duplikat markiert. Wenn Sie es für angebrachter halten, die Datei als sofort zu löschend markiert zu belassen, können Sie die doppelten Dateien löschen und die Löschvorlage von der zu belassenden Datei entfernen. Dies ist eine automatisierte Nachricht von %(bot)s.",
"checkimages-log-comment": "Bot: Aktualisiere das Log",
"checkimages-no-license-head": "Bild ohne Lizenz",
"checkimages-source-tag-comment": "Bot: Markiere zur Dateiüberprüfung, da keine Lizenzvorlage gefunden.",
diff --git a/checkimages/en.json b/checkimages/en.json
index f73023e..6e082f7 100644
--- a/checkimages/en.json
+++ b/checkimages/en.json
@@ -11,7 +11,7 @@
"checkimages-doubles-file-comment": "Bot: File already on Commons, may be deleted",
"checkimages-doubles-head": "Duplicate file",
"checkimages-doubles-talk-comment": "Bot: Notify that the file already exists on Commons",
- "checkimages-doubles-talk-text": "Thank you for uploading %(upload)s. However, this file is a copy of %(image)s. The Bot has marked as a duplicate the file that was found to be least used or most recent. If you deem it more appropriate to leave the file marked as to be deleted immediately, feel free to delete the duplicate files and remove the deletion template from the one to be left. This is an automated message from %(bot)s.",
+ "checkimages-doubles-talk-text": "Thank you for uploading %(upload)s. However, this file is a copy of:%(image)sThe Bot has marked as a duplicate the file that was found to be least used or most recent. If you deem it more appropriate to leave the file marked as to be deleted immediately, feel free to delete the duplicate files and remove the deletion template from the one to be left. This is an automated message from %(bot)s.",
"checkimages-forced-mode": "('''forced mode''')",
"checkimages-has-duplicates": "has the following duplicates%(force)s:",
"checkimages-log-comment": "Bot: Updating the log",
diff --git a/checkimages/it.json b/checkimages/it.json
index 1a57e01..4a608e1 100644
--- a/checkimages/it.json
+++ b/checkimages/it.json
@@ -11,7 +11,7 @@
"checkimages-doubles-file-comment": "Bot: file già su Commons, può essere cancellato",
"checkimages-doubles-head": "File doppio",
"checkimages-doubles-talk-comment": "Bot: notifico il file doppio trovato",
- "checkimages-doubles-talk-text": "Grazie per aver caricato %s(upload)s. Tuttavia, questo file risulta una copia di %s(image)s. Il Bot ha segnato come doppione il file che è risultato essere meno utilizzato o più recente. Nel caso ritenessi più appropriato lasciare il file segnalato come da cancellare immediatamente, sentiti libero di mettere in cancellazione i file doppi e togliere il template di cancellazione da quello da lasciare. Questo è un messaggio automatico di %(bot)s.",
+ "checkimages-doubles-talk-text": "Grazie per aver caricato %s(upload)s. Tuttavia, questo file risulta una copia di:%s(image)sIl Bot ha segnato come doppione il file che è risultato essere meno utilizzato o più recente. Nel caso ritenessi più appropriato lasciare il file segnalato come da cancellare immediatamente, sentiti libero di mettere in cancellazione i file doppi e togliere il template di cancellazione da quello da lasciare. Questo è un messaggio automatico di %(bot)s.",
"checkimages-log-comment": "Bot: aggiorno il log",
"checkimages-no-license-head": "File senza licenza",
"checkimages-source-tag-comment": "Bot: Aggiungo unverified",
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/946516
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/i18n
Gerrit-Branch: master
Gerrit-Change-Id: I9afb8fc8211d6fe053af8dc802a08dfa1e64f9c0
Gerrit-Change-Number: 946516
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/945946 )
Change subject: [i18n] Add i18n for duplication reports
......................................................................
[i18n] Add i18n for duplication reports
Text was taken from https://it.wikipedia.org/wiki/Progetto:Coordinamento/Immagini/Bot/Messaggi/…
Change-Id: I9296d187c88520e3070b0603230e95f2e89879dd
---
M checkimages/en.json
M checkimages/it.json
M checkimages/de.json
M checkimages/qqq.json
4 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/checkimages/de.json b/checkimages/de.json
index 07f0541..ec3a422 100644
--- a/checkimages/de.json
+++ b/checkimages/de.json
@@ -10,6 +10,7 @@
"checkimages-doubles-file-comment": "Bot: Datei liegt bereits auf Commons, kann gelöscht werden",
"checkimages-doubles-head": "Datei-Duplikat",
"checkimages-doubles-talk-comment": "Bot: Benachrichtigung, dass die Datei bereits auf Commons vorhanden ist",
+ "checkimages-doubles-talk-text": "Vielen Dank für das Hochladen von %(upload)s. Diese Datei ist jedoch eine Kopie von %(image)s. Der Bot hat die Datei, die am wenigsten verwendet wurde oder aktuell war, als Duplikat markiert. Wenn Sie es für angebrachter halten, die Datei als sofort zu löschend markiert zu belassen, können Sie die doppelten Dateien löschen und die Löschvorlage von der zu belassenden Datei entfernen. Dies ist eine automatisierte Nachricht von %(bot)s.",
"checkimages-log-comment": "Bot: Aktualisiere das Log",
"checkimages-no-license-head": "Bild ohne Lizenz",
"checkimages-source-tag-comment": "Bot: Markiere zur Dateiüberprüfung, da keine Lizenzvorlage gefunden.",
diff --git a/checkimages/en.json b/checkimages/en.json
index 3431526..f73023e 100644
--- a/checkimages/en.json
+++ b/checkimages/en.json
@@ -11,6 +11,7 @@
"checkimages-doubles-file-comment": "Bot: File already on Commons, may be deleted",
"checkimages-doubles-head": "Duplicate file",
"checkimages-doubles-talk-comment": "Bot: Notify that the file already exists on Commons",
+ "checkimages-doubles-talk-text": "Thank you for uploading %(upload)s. However, this file is a copy of %(image)s. The Bot has marked as a duplicate the file that was found to be least used or most recent. If you deem it more appropriate to leave the file marked as to be deleted immediately, feel free to delete the duplicate files and remove the deletion template from the one to be left. This is an automated message from %(bot)s.",
"checkimages-forced-mode": "('''forced mode''')",
"checkimages-has-duplicates": "has the following duplicates%(force)s:",
"checkimages-log-comment": "Bot: Updating the log",
diff --git a/checkimages/it.json b/checkimages/it.json
index a14743b..1a57e01 100644
--- a/checkimages/it.json
+++ b/checkimages/it.json
@@ -11,6 +11,7 @@
"checkimages-doubles-file-comment": "Bot: file già su Commons, può essere cancellato",
"checkimages-doubles-head": "File doppio",
"checkimages-doubles-talk-comment": "Bot: notifico il file doppio trovato",
+ "checkimages-doubles-talk-text": "Grazie per aver caricato %s(upload)s. Tuttavia, questo file risulta una copia di %s(image)s. Il Bot ha segnato come doppione il file che è risultato essere meno utilizzato o più recente. Nel caso ritenessi più appropriato lasciare il file segnalato come da cancellare immediatamente, sentiti libero di mettere in cancellazione i file doppi e togliere il template di cancellazione da quello da lasciare. Questo è un messaggio automatico di %(bot)s.",
"checkimages-log-comment": "Bot: aggiorno il log",
"checkimages-no-license-head": "File senza licenza",
"checkimages-source-tag-comment": "Bot: Aggiungo unverified",
diff --git a/checkimages/qqq.json b/checkimages/qqq.json
index d324fca..96983fa 100644
--- a/checkimages/qqq.json
+++ b/checkimages/qqq.json
@@ -10,6 +10,7 @@
"checkimages-doubles-file-comment": "Edit summary used by the bot while it reports a problem in the file page",
"checkimages-doubles-head": "Head of the report given to the uploader",
"checkimages-doubles-talk-comment": "Edit summary used by the bot while it reports the problem in the uploader's talk page",
+ "checkimages-doubles-talk-text": "Uploader notification if the uploaded file has duplicates on image repository",
"checkimages-forced-mode": "Report is generated in force mode",
"checkimages-has-duplicates": "Report that an image has several duplicates",
"checkimages-log-comment": "Edit summary for the checkimages' report",
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/945946
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/i18n
Gerrit-Branch: master
Gerrit-Change-Id: I9296d187c88520e3070b0603230e95f2e89879dd
Gerrit-Change-Number: 945946
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/945900 )
Change subject: [doc] remove sphinx.ext.todo and use codeclimate instead
......................................................................
[doc] remove sphinx.ext.todo and use codeclimate instead
Change-Id: I80f8d5b8922bb2b21163f15b24fa6f99c39ba478
---
M .codeclimate.yml
M docs/conf.py
M scripts/checkimages.py
M scripts/coordinate_import.py
M pywikibot/page/_basepage.py
M pywikibot/page/_wikibase.py
M scripts/create_isbn_edition.py
M scripts/archivebot.py
8 files changed, 16 insertions(+), 41 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.codeclimate.yml b/.codeclimate.yml
index 141af70..1f2412a 100644
--- a/.codeclimate.yml
+++ b/.codeclimate.yml
@@ -46,6 +46,7 @@
exclude_patterns:
- "docs/"
- "!docs/conf.py"
+- "tox.ini"
- "*.json"
- "*.png"
- "*.rst"
diff --git a/docs/conf.py b/docs/conf.py
index e310fe8..f8edf4d 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -53,9 +53,7 @@
'sphinx.ext.autosectionlabel',
'sphinx.ext.autosummary',
'sphinx.ext.extlinks',
- # 'sphinx.ext.intersphinx',
'sphinx.ext.napoleon',
- 'sphinx.ext.todo',
'sphinx.ext.viewcode',
'sphinxext.opengraph',
]
@@ -142,7 +140,7 @@
# keep_warnings = False
# If true, `todo` and `todoList` produce output, else they produce nothing.
-todo_include_todos = True
+# todo_include_todos = False
# -- Options for HTML output ----------------------------------------------
diff --git a/pywikibot/page/_basepage.py b/pywikibot/page/_basepage.py
index 7c62214..796eac5 100644
--- a/pywikibot/page/_basepage.py
+++ b/pywikibot/page/_basepage.py
@@ -1539,7 +1539,7 @@
"""
if hasattr(self, '_langlinks'):
return iter(self.langlinks(include_obsolete=include_obsolete))
- # XXX We might want to fill _langlinks when the Site
+ # FIXME: We might want to fill _langlinks when the Site
# method is called. If we do this, we'll have to think
# about what will happen if the generator is not completely
# iterated upon.
diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py
index a5cf089..959c0b1 100644
--- a/pywikibot/page/_wikibase.py
+++ b/pywikibot/page/_wikibase.py
@@ -217,7 +217,7 @@
:raise NoWikibaseEntityError: if the entity doesn't exist
"""
if not hasattr(self, '_revid'):
- # fixme: unlike BasePage.latest_revision_id, this raises
+ # FIXME: unlike BasePage.latest_revision_id, this raises
# exception when entity is redirect, cannot use get_redirect
self.get()
return self._revid
@@ -275,7 +275,7 @@
value = cls.fromJSON(self._content.get(key, {}), self.repo)
setattr(self, key, value)
data[key] = value
- # xxx: need better handling for this
+ # fixme: need better handling for this
if key in ['claims', 'statements']:
value.set_on_item(self)
diff --git a/scripts/archivebot.py b/scripts/archivebot.py
index 886494a..466707c 100755
--- a/scripts/archivebot.py
+++ b/scripts/archivebot.py
@@ -691,7 +691,7 @@
raise MalformedConfigError(e)
threads_per_archive[key].append((i, thread))
- whys.add(why) # xxx: we don't know if we ever archive anything
+ whys.add(why) # FIXME: we don't know if we ever archive anything
params = self.get_params(self.now, counter)
aux_params = self.get_params(self.now, counter + 1)
diff --git a/scripts/checkimages.py b/scripts/checkimages.py
index a5fb81a..5470cef 100755
--- a/scripts/checkimages.py
+++ b/scripts/checkimages.py
@@ -67,12 +67,6 @@
* Text= This is the template that the bot will use when it will report the
image's problem.
-.. todo::
- * Clean the code, some passages are pretty difficult to understand.
- * Add the "catch the language" function for commons.
- * Fix and reorganise the new documentation
- * Add a report for the image tagged.
-
.. versionchanged:: 8.4
Welcome messages are imported from :mod:`scripts.welcome` script.
"""
diff --git a/scripts/coordinate_import.py b/scripts/coordinate_import.py
index 21956a6..56df43c 100755
--- a/scripts/coordinate_import.py
+++ b/scripts/coordinate_import.py
@@ -174,7 +174,7 @@
if arg == '-create':
create_new = True
- # xxx: this preloading preloads neither coordinates nor Wikibase items
+ # FIXME: this preloading preloads neither coordinates nor Wikibase items
# but preloads wikitext which we don't need
generator = generator_factory.getCombinedGenerator(preload=True)
diff --git a/scripts/create_isbn_edition.py b/scripts/create_isbn_edition.py
index 291c0f0..82b924b 100755
--- a/scripts/create_isbn_edition.py
+++ b/scripts/create_isbn_edition.py
@@ -169,33 +169,6 @@
Possible important replication delay; wait 5 minutes before retry
-- otherwise risk for creating duplicates.
-**Known problems:**
- * Unknown ISBN, e.g. 9789400012820
- * No ISBN data available for an edition either causes no output
- (goob = Google Books), or an error message (wiki, openl)
- The script is taking care of both
- * Only 6 ISBN attributes are listed by the webservice(s)
- missing are e.g.: place of publication, number of pages
- * Not all ISBN atttributes have data (authos, publisher, date of
- publication, language)
- * The script uses multiple webservice calls (script might take time,
- but it is automated)
- * Need to amend ISBN items that have no author, publisher, or other
- required data (which additional services to use?)
- * How to add still more digital libraries?
- * Does the KBR has a public ISBN service (Koninklijke
- Bibliotheek van België)?
- * Filter for work properties -- need to amend Q47461344 (written
- work) instance and P629 (edition of) + P747 (has edition)
- statements https://www.wikidata.org/wiki/Q63413107
- ['9781282557246', '9786612557248', '9781847196057', '9781847196040']
- P8383: Goodreads-identificatiecode voor work 13957943 (should
- have P2969)
- P5331: OCLC-identificatiecode voor work 793965595 (should have P243)
-
-.. todo::
- * Add source reference (digital library instance)
-
**Algorithm:**
# Get parameters
# Validate parameters
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/945900
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I80f8d5b8922bb2b21163f15b24fa6f99c39ba478
Gerrit-Change-Number: 945900
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <dalangi-ctr(a)wikimedia.org>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/945551 )
Change subject: [doc] Explain the links counter
......................................................................
[doc] Explain the links counter
Change-Id: Ibed34ff04e4d0739c07b14b4c56b75e717971af9
---
M scripts/solve_disambiguation.py
1 file changed, 18 insertions(+), 6 deletions(-)
Approvals:
D3r1ck01: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/solve_disambiguation.py b/scripts/solve_disambiguation.py
index 8694a1b..ee9544f 100755
--- a/scripts/solve_disambiguation.py
+++ b/scripts/solve_disambiguation.py
@@ -873,7 +873,7 @@
if include:
# save the original text so we can show the changes later
original_text = text
- n = 0
+ n_links = 0 # number of links
curpos = 0
dn = False
edited = False
@@ -881,11 +881,13 @@
while True:
m = self.linkR.search(text, pos=curpos)
if not m:
- if n == 0:
- # No changes necessary for this disambiguation title.
+ # No additinal link found
+ if n_links == 0:
+ # No remaining links to change for this disambiguation
+ # title.
return 'nochange'
- # stop loop and save page
+ # There are links to change; stop loop and save page
break
# Ensure that next time around we will not find this same hit.
@@ -911,7 +913,7 @@
.format(m['title'], ref_page.title()))
continue
- n += 1
+ n_links += 1 # new link found: increase link counter
# how many bytes should be displayed around the current link
context = 60
@@ -964,7 +966,8 @@
break
if answer == 's':
- n -= 1 # TODO what's this for?
+ # skip this link and decrease link counter
+ n_links -= 1
continue
if answer == 'e':
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/945551
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ibed34ff04e4d0739c07b14b4c56b75e717971af9
Gerrit-Change-Number: 945551
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <dalangi-ctr(a)wikimedia.org>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged