Pywikibot-commits March 2023

pywikibot-commits@lists.wikimedia.org

1 participants
50 discussions

[Gerrit] ...core[master]: [IMPR] Ignore talk pages with Site.watched_pages
by jenkins-bot (Code Review) 05 Mar '23

05 Mar '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894215 ) Change subject: [IMPR] Ignore talk pages with Site.watched_pages ...................................................................... [IMPR] Ignore talk pages with Site.watched_pages - add new 'with_talkpage' parameter to Site.watched_pages - ignore talk pages and special pages is with_talkpage is False Bug: T330806 Change-Id: Ifb3c90091e5d469950c45e593882b96885b8fc17 --- M pywikibot/site/_generators.py 1 file changed, 29 insertions(+), 1 deletion(-) Approvals: Bináris: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site/_generators.py b/pywikibot/site/_generators.py index cdb796a..4752b45 100644 --- a/pywikibot/site/_generators.py +++ b/pywikibot/site/_generators.py @@ -2113,21 +2113,36 @@ def watched_pages( self, force: bool = False, - total: Optional[int] = None + total: Optional[int] = None, *, + with_talkpage: bool = True ) -> Generator['pywikibot.Page', Any, None]: """Return watchlist. .. note:: ``watched_pages`` is a restartable generator. See :class:`tools.collections.GeneratorWrapper` for its usage. .. seealso:: :api:`Watchlistraw` + .. versionadded:: 8.1 + the *with_talkpage* parameter. :param force: Reload watchlist :param total: if not None, limit the generator to yielding this many items in total + :param with_talkpage: if false, ignore talk pages and special + pages :return: generator of pages in watchlist """ + def ignore_talkpages(page): + """Ignore talk pages and special pages.""" + ns = page.namespace() + return ns >= 0 and not page.namespace() % 2 + expiry = None if force else pywikibot.config.API_config_expiry gen = api.PageGenerator(site=self, generator='watchlistraw', expiry=expiry) gen.set_maximum_items(total) + + if not with_talkpage: + gen._namespaces = True + gen._check_result_namespace = ignore_talkpages + return gen -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894215 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ifb3c90091e5d469950c45e593882b96885b8fc17 Gerrit-Change-Number: 894215 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Bináris <wikiposta(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [bugfix] load page info when creating a page if not updated previously
by jenkins-bot (Code Review) 05 Mar '23

05 Mar '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894208 ) Change subject: [bugfix] load page info when creating a page if not updated previously ...................................................................... [bugfix] load page info when creating a page if not updated previously If pageid was retrieved and the page was created after that, the new pageid is not updated and remains 0. Therefore call site.loadpageinfo in such case. Bug: T330980 Change-Id: I6a867da59dda24e0387db556edda85a92d570cca --- M pywikibot/page/_basepage.py 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Bináris: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page/_basepage.py b/pywikibot/page/_basepage.py index 2dc891a..8a7374e 100644 --- a/pywikibot/page/_basepage.py +++ b/pywikibot/page/_basepage.py @@ -1291,6 +1291,10 @@ if not quiet: pywikibot.warning(f'Page {link} not saved') raise PageSaveRelatedError(self) + + if not self.pageid: + self.site.loadpageinfo(self) + if not quiet: pywikibot.info(f'Page {link} saved') -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894208 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I6a867da59dda24e0387db556edda85a92d570cca Gerrit-Change-Number: 894208 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Bináris <wikiposta(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] Fix documentation for Site.watched_pages
by jenkins-bot (Code Review) 05 Mar '23

05 Mar '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894210 ) Change subject: [doc] Fix documentation for Site.watched_pages ...................................................................... [doc] Fix documentation for Site.watched_pages Bug: T330799 Change-Id: I941de05e2e6298bbbb41d0ca8e6fe0a109206549 --- M pywikibot/site/_generators.py 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Bináris: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site/_generators.py b/pywikibot/site/_generators.py index 99a75e7..cdb796a 100644 --- a/pywikibot/site/_generators.py +++ b/pywikibot/site/_generators.py @@ -2110,18 +2110,21 @@ return self._generator(api.PageGenerator, type_arg='pageswithprop', gpwppropname=propname, total=total) - def watched_pages(self, force: bool = False, total=None): - """ - Return watchlist. + def watched_pages( + self, + force: bool = False, + total: Optional[int] = None + ) -> Generator['pywikibot.Page', Any, None]: + """Return watchlist. + .. note:: ``watched_pages`` is a restartable generator. See + :class:`tools.collections.GeneratorWrapper` for its usage. .. seealso:: :api:`Watchlistraw` :param force: Reload watchlist :param total: if not None, limit the generator to yielding this many items in total - :type total: int - :return: list of pages in watchlist - :rtype: list of pywikibot.Page objects + :return: generator of pages in watchlist """ expiry = None if force else pywikibot.config.API_config_expiry gen = api.PageGenerator(site=self, generator='watchlistraw', -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894210 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I941de05e2e6298bbbb41d0ca8e6fe0a109206549 Gerrit-Change-Number: 894210 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Bináris <wikiposta(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Skip test on proofwiki on github action
by jenkins-bot (Code Review) 05 Mar '23

05 Mar '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894206 ) Change subject: [tests] Skip test on proofwiki on github action ...................................................................... [tests] Skip test on proofwiki on github action Access to proofwiki is forbidden (status 403) if called from github action. Skip this test then instead of expect the failure. Bug: T331223 Change-Id: Ice47cf3ae7883bfa4012e7b8fea4b7a2008d9dd7 --- M tests/site_detect_tests.py 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_detect_tests.py b/tests/site_detect_tests.py index 918d76f..6173ff7 100755 --- a/tests/site_detect_tests.py +++ b/tests/site_detect_tests.py @@ -18,7 +18,7 @@ from pywikibot.site_detect import MWSite from tests.aspects import PatchingTestCase, TestCase -from tests.utils import DrySite, expected_failure_if, skipping +from tests.utils import DrySite, skipping class SiteDetectionTestCase(TestCase): @@ -58,7 +58,6 @@ """Test detection of MediaWiki sites.""" standard_version_sites = ( - # 'http://www.proofwiki.org/wiki/$1', 'http://www.ck-wissen.de/ckwiki/index.php?title=$1', 'http://en.citizendium.org/wiki/$1', # Server that hosts www.wikichristian.org is unreliable - it @@ -113,10 +112,10 @@ with self.subTest(url=urlparse(url).netloc): self.assertSite(url) - @expected_failure_if(os.getenv('GITHUB_ACTIONS')) # T331223 def test_proofreadwiki(self): """Test detection of proofwiki.org site.""" - # test is failing on github, see T331223 + if os.getenv('GITHUB_ACTIONS'): + self.skipTest('Skip test on github due to T331223') self.assertSite('http://www.proofwiki.org/wiki/$1') def test_non_standard_version_sites(self): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894206 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ice47cf3ae7883bfa4012e7b8fea4b7a2008d9dd7 Gerrit-Change-Number: 894206 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] exclude proofwiki test on github
by jenkins-bot (Code Review) 05 Mar '23

05 Mar '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894182 ) Change subject: [tests] exclude proofwiki test on github ...................................................................... [tests] exclude proofwiki test on github Change-Id: Ia5b39a646158a4047f2ba0ca54e07d237ce63e63 --- M tests/site_detect_tests.py 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_detect_tests.py b/tests/site_detect_tests.py index 2298f92..918d76f 100755 --- a/tests/site_detect_tests.py +++ b/tests/site_detect_tests.py @@ -1,10 +1,11 @@ #!/usr/bin/env python3 """Test for site detection.""" # -# (C) Pywikibot team, 2014-2022 +# (C) Pywikibot team, 2014-2023 # # Distributed under the terms of the MIT license. # +import os import unittest from contextlib import suppress from http import HTTPStatus @@ -15,8 +16,9 @@ import pywikibot from pywikibot.exceptions import ServerError from pywikibot.site_detect import MWSite + from tests.aspects import PatchingTestCase, TestCase -from tests.utils import DrySite, skipping +from tests.utils import DrySite, expected_failure_if, skipping class SiteDetectionTestCase(TestCase): @@ -56,7 +58,7 @@ """Test detection of MediaWiki sites.""" standard_version_sites = ( - 'http://www.proofwiki.org/wiki/$1', + # 'http://www.proofwiki.org/wiki/$1', 'http://www.ck-wissen.de/ckwiki/index.php?title=$1', 'http://en.citizendium.org/wiki/$1', # Server that hosts www.wikichristian.org is unreliable - it @@ -111,6 +113,12 @@ with self.subTest(url=urlparse(url).netloc): self.assertSite(url) + @expected_failure_if(os.getenv('GITHUB_ACTIONS')) # T331223 + def test_proofreadwiki(self): + """Test detection of proofwiki.org site.""" + # test is failing on github, see T331223 + self.assertSite('http://www.proofwiki.org/wiki/$1') + def test_non_standard_version_sites(self): """Test detection of non standard MediaWiki sites.""" for url in self.non_standard_version_sites: -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894182 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ia5b39a646158a4047f2ba0ca54e07d237ce63e63 Gerrit-Change-Number: 894182 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] Update documentation
by Xqt (Code Review) 05 Mar '23

05 Mar '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894167 ) Change subject: [doc] Update documentation ...................................................................... [doc] Update documentation Change-Id: I2336b205395c0c6867f70b1f68d5ff8de28434ff --- M pywikibot/__init__.py M ROADMAP.rst M scripts/CHANGELOG.rst M pywikibot/page/_wikibase.py M pywikibot/comms/http.py M HISTORY.rst 6 files changed, 34 insertions(+), 8 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/HISTORY.rst b/HISTORY.rst index 829a961..fd9d1b2 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -1,6 +1,17 @@ Release history =============== +8.0.1 +----- +*04 March 2023* + +* Add support for azwikimedia, gucwiki, gurwiki (:phab:`T317121`, :phab:`T326238`, :phab:`T327844`) +* Avoid error when replacement includes backslash (:phab:`T330021`) +* Copy snak IDs/hashes when using :meth:`page.WikibaseEntity.editEntity` (:phab:`T327607`) +* Add ``timezone_aware`` to :meth:`pywikibot.WbTime.toTimestamp` (:phab:`T325868`) +* L10N and i18n updates + + 8.0.0 ----- *21 January 2023* diff --git a/ROADMAP.rst b/ROADMAP.rst index dca8d35..afc57ca 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,11 +1,7 @@ Current release --------------- -* Add support for azwikimedia, gucwiki, gurwiki (:phab:`T317121`, :phab:`T326238`, :phab:`T327844`) -* Avoid error when replacement includes backslash (:phab:`T330021`) -* Copy snak IDs/hashes when using :meth:`page.WikibaseEntity.editEntity` (:phab:`T327607`) -* Add ``timezone_aware`` to :meth:`pywikibot.WbTime.toTimestamp` (:phab:`T325868`) -* L10N and i18n updates +* Improve flush exception logging Deprecations diff --git a/pywikibot/__init__.py b/pywikibot/__init__.py index afc4441..2b376c3 100644 --- a/pywikibot/__init__.py +++ b/pywikibot/__init__.py @@ -709,6 +709,9 @@ """ Convert the data to a pywikibot.Timestamp. + .. versionchanged:: 8.0.1 + *timezone_aware* parameter was added. + :param timezone_aware: Whether the timezone should be passed to the Timestamp object. :raises ValueError: instance value cannot be represented using diff --git a/pywikibot/comms/http.py b/pywikibot/comms/http.py index 2f345ce..77128be 100644 --- a/pywikibot/comms/http.py +++ b/pywikibot/comms/http.py @@ -109,9 +109,13 @@ session.cookies = cookie_jar -# Prepare flush on quit def flush() -> None: # pragma: no cover - """Close the session object. This is called when the module terminates.""" + """Close the session object. This is called when the module terminates. + + .. versionchanged:: 8.1 + log the traceback and show the exception value in the critical + message + """ log('Closing network session.') session.close() diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py index f9911cb..0eb10f9 100644 --- a/pywikibot/page/_wikibase.py +++ b/pywikibot/page/_wikibase.py @@ -297,6 +297,9 @@ .. seealso:: :meth:`WikibasePage.editEntity` + .. versionchanged:: 8.0.1 + Copy snak IDs/hashes (:phab:`T327607`) + :param data: Data to be saved """ update_self = False diff --git a/scripts/CHANGELOG.rst b/scripts/CHANGELOG.rst index 8f86a68..20e73bf 100644 --- a/scripts/CHANGELOG.rst +++ b/scripts/CHANGELOG.rst @@ -1,7 +1,7 @@ Scripts Changelog ================= -8.1.0 +8.0.1 ----- clean_sandbox -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894167 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I2336b205395c0c6867f70b1f68d5ff8de28434ff Gerrit-Change-Number: 894167 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[stable]: Merge branch master into stable
by jenkins-bot (Code Review) 04 Mar '23

04 Mar '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894141 ) Change subject: Merge branch master into stable ...................................................................... Merge branch master into stable Change-Id: Ibe7460f6e6898e7ce7fbeb624dd5bb4f5853b996 --- M .appveyor.yml M pywikibot/__metadata__.py M scripts/__init__.py 4 files changed, 74 insertions(+), 3 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/.appveyor.yml b/.appveyor.yml index 5437d37..0be0fb9 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -1,7 +1,7 @@ image: Visual Studio 2022 clone_depth: 50 skip_tags: true -version: 8.1.{build} +version: 8.0.{build} environment: PYWIKIBOT_DIR: "%appdata%\\Pywikibot" diff --git a/pywikibot/__metadata__.py b/pywikibot/__metadata__.py index 4c139f8..b199a77 100644 --- a/pywikibot/__metadata__.py +++ b/pywikibot/__metadata__.py @@ -11,7 +11,7 @@ __name__ = 'pywikibot' -__version__ = '8.1.0.dev0' +__version__ = '8.0.1' __description__ = 'Python MediaWiki Bot Framework' __maintainer__ = 'The Pywikibot team' __maintainer_email__ = 'pywikibot(a)lists.wikimedia.org' diff --git a/scripts/__init__.py b/scripts/__init__.py index 4be7d80..ebf7f57 100644 --- a/scripts/__init__.py +++ b/scripts/__init__.py @@ -29,4 +29,4 @@ # # Distributed under the terms of the MIT license. # -__version__ = '8.1.0' +__version__ = '8.0.1' -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894141 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: stable Gerrit-Change-Id: Ibe7460f6e6898e7ce7fbeb624dd5bb4f5853b996 Gerrit-Change-Number: 894141 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] Fix sphinx links
by Xqt (Code Review) 04 Mar '23

04 Mar '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894144 ) Change subject: [doc] Fix sphinx links ...................................................................... [doc] Fix sphinx links Change-Id: I184cd95542f118f62bcbdc3b0c9244f1c0540c55 --- M ROADMAP.rst 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/ROADMAP.rst b/ROADMAP.rst index 5a115ec..dca8d35 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,10 +1,10 @@ -Current release 8.1.0 ---------------------- +Current release +--------------- * Add support for azwikimedia, gucwiki, gurwiki (:phab:`T317121`, :phab:`T326238`, :phab:`T327844`) * Avoid error when replacement includes backslash (:phab:`T330021`) -* Copy snak IDs/hashes when using :meth:`WikibaseEntity.editEntity` (:phab:`T327607`) -* Add ``timezone_aware`` to :meth:`WbTime.toTimestamp` (:phab:`T325868`) +* Copy snak IDs/hashes when using :meth:`page.WikibaseEntity.editEntity` (:phab:`T327607`) +* Add ``timezone_aware`` to :meth:`pywikibot.WbTime.toTimestamp` (:phab:`T325868`) * L10N and i18n updates -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894144 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I184cd95542f118f62bcbdc3b0c9244f1c0540c55 Gerrit-Change-Number: 894144 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [doc] Update ROADMAP.rst and CHANGELOG.rst
by Xqt (Code Review) 04 Mar '23

04 Mar '23

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894138 ) Change subject: [doc] Update ROADMAP.rst and CHANGELOG.rst ...................................................................... [doc] Update ROADMAP.rst and CHANGELOG.rst Change-Id: I73dafea746c1d59679cd969695622aa7e6fac286 --- M ROADMAP.rst M scripts/CHANGELOG.rst 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/ROADMAP.rst b/ROADMAP.rst index ee98ef9..5a115ec 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,7 +1,11 @@ Current release 8.1.0 --------------------- -* *No changes yet* +* Add support for azwikimedia, gucwiki, gurwiki (:phab:`T317121`, :phab:`T326238`, :phab:`T327844`) +* Avoid error when replacement includes backslash (:phab:`T330021`) +* Copy snak IDs/hashes when using :meth:`WikibaseEntity.editEntity` (:phab:`T327607`) +* Add ``timezone_aware`` to :meth:`WbTime.toTimestamp` (:phab:`T325868`) +* L10N and i18n updates Deprecations diff --git a/scripts/CHANGELOG.rst b/scripts/CHANGELOG.rst index 01f2207..8f86a68 100644 --- a/scripts/CHANGELOG.rst +++ b/scripts/CHANGELOG.rst @@ -1,6 +1,20 @@ Scripts Changelog ================= +8.1.0 +----- + +clean_sandbox +~~~~~~~~~~~~~ + +* L10N for several wikis + +touch +~~~~~ + +* Login first when starting the script (:phab:`T328204`) + + 8.0.0 ----- -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894138 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I73dafea746c1d59679cd969695622aa7e6fac286 Gerrit-Change-Number: 894138 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: improve flush exception logging
by jenkins-bot (Code Review) 03 Mar '23

03 Mar '23

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894120 ) Change subject: improve flush exception logging ...................................................................... improve flush exception logging * log the traceback * show the exception value in the critical message Change-Id: I75e4aa4c36318f8904419e239b990ef0545b4549 --- M pywikibot/comms/http.py 1 file changed, 26 insertions(+), 1 deletion(-) Approvals: JJMC89: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/comms/http.py b/pywikibot/comms/http.py index 7828acf..2f345ce 100644 --- a/pywikibot/comms/http.py +++ b/pywikibot/comms/http.py @@ -34,6 +34,7 @@ import codecs import re import sys +import traceback from contextlib import suppress from http import HTTPStatus, cookiejar from string import Formatter @@ -115,7 +116,19 @@ session.close() if hasattr(sys, 'last_type'): - critical(f'Exiting due to uncaught exception {sys.last_type}') + log( + ''.join( + traceback.format_exception( + sys.last_type, + value=sys.last_value, + tb=sys.last_traceback + ) + ) + ) + critical( + f'Exiting due to uncaught exception {sys.last_type.__name__}: ' + f'{sys.last_value}' + ) log('Network session closed.') -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/894120 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I75e4aa4c36318f8904419e239b990ef0545b4549 Gerrit-Change-Number: 894120 Gerrit-PatchSet: 2 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits March 2023