jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/792993 )
Change subject: [dist] Show a deprecation warning when using PyMySQL < 0.7.11
......................................................................
[dist] Show a deprecation warning when using PyMySQL < 0.7.11
0.7.10 support was held due to the preinstalled package on toolforge.
With the migration from Stretch to Bastion Pywikibot 3.7.3 is present
and supported PyMySQL version is 0.9.3. The old code will be removed
with Pywikibot 8.
This reverts commit 5e3a5c392329eddb3661e19776493a10bbdbb7b3.
Bug: T216741
Change-Id: I5c601399c4c20939762b88de2538b0598a6a98d4
---
M pywikibot/data/mysql.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
DannyS712: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/data/mysql.py b/pywikibot/data/mysql.py
index 69fd036..f5ef7d9 100644
--- a/pywikibot/data/mysql.py
+++ b/pywikibot/data/mysql.py
@@ -12,6 +12,7 @@
import pywikibot
from pywikibot import config
from pywikibot.backports import removesuffix
+from pywikibot.tools import issue_deprecation_warning
try:
@@ -31,6 +32,8 @@
toolforge (:phab:`T216741`).
.. versionadded:: 7.0
+ .. deprecated:: 7.4
+ Update your pymysql package
"""
def close(self) -> None: # pragma: no cover
@@ -94,6 +97,9 @@
}
if pymysql_version < pkg_resources.parse_version('0.7.11'):
+ issue_deprecation_warning(
+ 'pymysql package release {}'.format(pymysql_version),
+ instead='pymysql >= 0.7.11', since='7.4.0')
connection = _OldConnection(**args, **credentials)
else:
connection = pymysql.connect(**args, **credentials)
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/792993
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I5c601399c4c20939762b88de2538b0598a6a98d4
Gerrit-Change-Number: 792993
Gerrit-PatchSet: 4
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: DannyS712 <dannys712.wiki(a)gmail.com>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/794778 )
Change subject: [doc] Update ROADMAP.rst; separate Pywikibot 8 removals
......................................................................
[doc] Update ROADMAP.rst; separate Pywikibot 8 removals
Change-Id: Icae9303dde8c7aeb127502b0d89c3570d6eab15f
---
M ROADMAP.rst
1 file changed, 13 insertions(+), 7 deletions(-)
Approvals:
DannyS712: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ROADMAP.rst b/ROADMAP.rst
index db50131..8aba0c0 100644
--- a/ROADMAP.rst
+++ b/ROADMAP.rst
@@ -6,16 +6,13 @@
Deprecations
^^^^^^^^^^^^
-* 7.3.0: Python 3.5 support will be dropped with Python 8 (:phab:`T301908`)
+* 7.2.0: ``tb`` parameter of ``exception()`` function was renamed to ``exc_info``
* 7.2.0: XMLDumpOldPageGenerator is deprecated in favour of a `content` parameter (:phab:`T306134`)
* 7.2.0: RedirectPageBot and NoRedirectPageBot bot classes are deprecated in favour of `use_redirects` attribute
* 7.2.0: `tools.formatter.color_format` is deprecated and will be removed
-* 7.1.0: win32_unicode.py will be removed with Pywikibot 8
* 7.1.0: Unused `get_redirect` parameter of Page.getOldVersion() will be removed
* 7.1.0: APISite._simple_request() will be removed in favour of APISite.simple_request()
-* 7.0.0: The i18n identifier 'cosmetic_changes-append' will be removed in favour of 'pywikibot-cosmetic-changes'
* 7.0.0: User.isBlocked() method is renamed to is_blocked for consistency
-* 7.0.0: Require mysql >= 0.7.11 (:phab:`T216741`)
* 7.0.0: Private BaseBot counters _treat_counter, _save_counter, _skip_counter will be removed in favour of collections.Counter counter attribute
* 7.0.0: A boolean watch parameter in Page.save() is deprecated and will be desupported
* 7.0.0: baserevid parameter of editSource(), editQualifier(), removeClaims(), removeSources(), remove_qualifiers() DataSite methods will be removed
@@ -31,6 +28,15 @@
* 6.2.0: Throttle.multiplydelay attribute is deprecated
* 6.2.0: SequenceOutputter.format_list() is deprecated in favour of 'out' property
* 6.0.0: config.register_family_file() is deprecated
-* 5.5.0: APISite.redirectRegex() is deprecated in favour of APISite.redirect_regex() and will be removed with Pywikibot 8
-* 4.0.0: Revision.parent_id is deprecated in favour of Revision.parentid and will be removed with Pywikibot 8
-* 4.0.0: Revision.content_model is deprecated in favour of Revision.contentmodel and will be removed with Pywikibot 8
+
+
+Will be removed in Pywikibot 8
+------------------------------
+
+* 7.3.0: Python 3.5 support will be dropped (:phab:`T301908`)
+* 7.1.0: win32_unicode.py will be removed
+* 7.0.0: The i18n identifier 'cosmetic_changes-append' will be removed in favour of 'pywikibot-cosmetic-changes'
+* 7.0.0: Require mysql >= 0.7.11 (:phab:`T216741`)
+* 5.5.0: APISite.redirectRegex() will be removed in favour of APISite.redirect_regex()
+* 4.0.0: Revision.parent_id will be removed in favour of Revision.parentid
+* 4.0.0: Revision.content_model will be removed in favour of Revision.contentmodel
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/794778
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Icae9303dde8c7aeb127502b0d89c3570d6eab15f
Gerrit-Change-Number: 794778
Gerrit-PatchSet: 4
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: DannyS712 <dannys712.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/795675 )
Change subject: [doc] Fix spelling mistakes
......................................................................
[doc] Fix spelling mistakes
Bug: T201491
Change-Id: I5f3dbd6f48268aa224141f8789d82235916e22e3
---
M docs/scripts/outdated.rst
M pywikibot/page/_links.py
M scripts/delinker.py
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
D3r1ck01: Looks good to me, approved
DannyS712: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/docs/scripts/outdated.rst b/docs/scripts/outdated.rst
index 7961562..49f00a0 100644
--- a/docs/scripts/outdated.rst
+++ b/docs/scripts/outdated.rst
@@ -136,7 +136,7 @@
splitwarning script
-------------------
-**Splits a interwiki.log file into chunks of warnings separated by language**
+**Splits an interwiki.log file into chunks of warnings separated by language**
standardize\_notes script
@@ -174,6 +174,6 @@
**Script creates backlinks from a log file**
-A robot to implement backlinks from a interwiki.log file without checking
+A robot to implement backlinks from an interwiki.log file without checking
them against the live wikipedia.
diff --git a/pywikibot/page/_links.py b/pywikibot/page/_links.py
index 8c1a59e..43e7800 100644
--- a/pywikibot/page/_links.py
+++ b/pywikibot/page/_links.py
@@ -1,7 +1,7 @@
"""Objects representing internal or interwiki link in wikitext.
..note::
- `Link` objects definded here represent a wiki-page's title, while
+ `Link` objects defined here represent a wiki-page's title, while
:class:`pywikibot.Page` objects represent the page itself, including
its contents.
"""
diff --git a/scripts/delinker.py b/scripts/delinker.py
index fe43cbe..bad4000 100644
--- a/scripts/delinker.py
+++ b/scripts/delinker.py
@@ -3,7 +3,7 @@
This script keeps track of image deletions and delinks removed files
from current wiki in namespace 0. This script is suitable to delink
-files from a image repository as well as for local images.
+files from an image repository as well as for local images.
The following parameters are supported:
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/795675
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I5f3dbd6f48268aa224141f8789d82235916e22e3
Gerrit-Change-Number: 795675
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: DannyS712 <dannys712.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged