Pywikibot-commits February 2022

pywikibot-commits@lists.wikimedia.org

1 participants
99 discussions

[Gerrit] ...core[master]: pywikibot: Add support for chunked uploading in imagetransfer.py

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762107 ) Change subject: pywikibot: Add support for chunked uploading in imagetransfer.py ...................................................................... pywikibot: Add support for chunked uploading in imagetransfer.py Support for -asynchronous and -chunk_size flags were added to upload.py in e68f619. This patch adds the same options to imagetransfer.py and just maps them to the corresponding UploadBot parameters. Bug: T300531 Change-Id: I46c1a2484475075921888d4782ec25715fa5271c --- M scripts/imagetransfer.py 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/imagetransfer.py b/scripts/imagetransfer.py index 98743a2..c25e8bc 100755 --- a/scripts/imagetransfer.py +++ b/scripts/imagetransfer.py @@ -22,6 +22,10 @@ -force_if_shared Upload the file to the target, even if it exists on that wiki's shared repo + -asynchronous Upload to stash. + + -chunk_size:n Upload in chunks of n bytes. + -file:z Upload many files from textfile: [[Image:x]] [[Image:y]] @@ -144,6 +148,8 @@ 'keepname': False, 'target': None, 'force_if_shared': False, + 'asynchronous': False, + 'chunk_size': 0, } def __init__(self, **kwargs): @@ -162,6 +168,10 @@ shared to the target site (e.g. when moving from Commons to another wiki) :type force_if_shared: boolean + :keyword asynchronous: Upload to stash. + :type asynchronous: boolean + :keyword chunk_size: Upload in chunks of this size bytes. + :type chunk_size: integer """ super().__init__(**kwargs) if self.opt.target is None: @@ -217,7 +227,9 @@ keep_filename=self.opt.keepname, verify_description=not self.opt.keepname, ignore_warning=self.opt.ignore_warning, - force_if_shared=self.opt.force_if_shared) + force_if_shared=self.opt.force_if_shared, + asynchronous=self.opt.asynchronous, + chunk_size=self.opt.chunk_size) # try to upload if bot.skip_run(): @@ -347,7 +359,7 @@ for arg in local_args: opt, _, value = arg.partition(':') if opt in ('-ignore_warning', '-interwiki', '-keepname', - '-force_if_shared'): + '-force_if_shared', '-asynchronous'): options[opt[1:]] = True elif opt == '-tolang': target_code = value @@ -355,6 +367,8 @@ target_family = value elif opt == '-tosite': options['target'] = value + elif opt == '-chunk_size': + options['chunk_size'] = value else: generator_factory.handle_arg(arg) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762107 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I46c1a2484475075921888d4782ec25715fa5271c Gerrit-Change-Number: 762107 Gerrit-PatchSet: 1 Gerrit-Owner: Xover <xover(a)pobox.com> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: pywikibot: Fix KeyError in create_warnings_list

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762101 ) Change subject: pywikibot: Fix KeyError in create_warnings_list ...................................................................... pywikibot: Fix KeyError in create_warnings_list create_warnings_list() was looking for an offset entry in the passed-in response dict which is (no longer?) being set for that code path. This patch uses the _offest argument to upload() instead. Bug: T301610 Change-Id: Ibe63befb6f80a0831adee446c66c4fb875ff0b1d --- M pywikibot/site/_apisite.py 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site/_apisite.py b/pywikibot/site/_apisite.py index 305dc01..faf8f03 100644 --- a/pywikibot/site/_apisite.py +++ b/pywikibot/site/_apisite.py @@ -2954,11 +2954,8 @@ _file_key = None if not report_success: - if source_filename: - offset = result.setdefault('offset', True) - else: - offset = False - + result.setdefault('offset', bool(source_filename)) + offset = result['offset'] if source_filename else False if ignore_warnings(create_warnings_list(result)): return self.upload( filepage, source_filename=source_filename, -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762101 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ibe63befb6f80a0831adee446c66c4fb875ff0b1d Gerrit-Change-Number: 762101 Gerrit-PatchSet: 2 Gerrit-Owner: Xover <xover(a)pobox.com> Gerrit-Reviewer: Inductiveload <inductiveload(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-CC: Welcome, new contributor! <ssethi(a)wikimedia.org> Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: [cleanup] remove deprecated http.get_fake_user_agent() function

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761342 ) Change subject: [cleanup] remove deprecated http.get_fake_user_agent() function ...................................................................... [cleanup] remove deprecated http.get_fake_user_agent() function - http.get_fake_user_agent() function is nowhere used in the framework and deprecated for over 5 years. - also config.fake_user_agent isn't used anywhere in the famework an is deprecated for years; it can be removed. - remove GetFakeUserAgentTestCase Change-Id: I30f5ffffd0a5c81c06ce68608bfb412f12238a09 --- M pywikibot/comms/http.py M pywikibot/config.py M tests/http_tests.py 3 files changed, 2 insertions(+), 60 deletions(-) Approvals: JJMC89: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/comms/http.py b/pywikibot/comms/http.py index 6a99a24..ad635a0 100644 --- a/pywikibot/comms/http.py +++ b/pywikibot/comms/http.py @@ -22,7 +22,7 @@ :py:obj:`flush()` can be called to close the session object. """ # -# (C) Pywikibot team, 2007-2021 +# (C) Pywikibot team, 2007-2022 # # Distributed under the terms of the MIT license. # @@ -48,10 +48,7 @@ Server504Error, ) from pywikibot.logging import critical, debug, error, log, warning -from pywikibot.tools import ( - deprecated, - file_mode_checker, -) +from pywikibot.tools import file_mode_checker try: @@ -194,22 +191,6 @@ return formatted -@deprecated('pywikibot.comms.http.fake_user_agent', since='20161205') -def get_fake_user_agent(): - """ - Return a fake user agent depending on `fake_user_agent` option in config. - - Deprecated, use fake_user_agent() instead. - - :rtype: str - """ - if isinstance(config.fake_user_agent, str): - return config.fake_user_agent - if config.fake_user_agent is False: - return user_agent() - return fake_user_agent() - - def fake_user_agent() -> str: """Return a fake user agent.""" try: diff --git a/pywikibot/config.py b/pywikibot/config.py index 09c185f..a60dad2 100644 --- a/pywikibot/config.py +++ b/pywikibot/config.py @@ -159,8 +159,6 @@ # Example: {'problematic.site.example': True, # 'prefers.specific.ua.example': 'snakeoil/4.2'} fake_user_agent_exceptions = {} # type: Dict[str, Union[bool, str]] -# This following option is deprecated in favour of finer control options above. -fake_user_agent = False # The default interface for communicating with the site # currently the only defined interface is 'APISite', so don't change this! diff --git a/tests/http_tests.py b/tests/http_tests.py index 62b066e..d52dd1a 100644 --- a/tests/http_tests.py +++ b/tests/http_tests.py @@ -303,43 +303,6 @@ self._test_fetch_use_fake_user_agent() -class GetFakeUserAgentTestCase(TestCase): - - """Test the deprecated get_fake_user_agent().""" - - net = False - - def setUp(self): - """Set up unit test.""" - self.orig_fake_user_agent = config.fake_user_agent - super().setUp() - - def tearDown(self): - """Tear down unit test.""" - config.fake_user_agent = self.orig_fake_user_agent - super().tearDown() - - def _test_config_settings(self): - """Test if method honours configuration toggle.""" - with suppress_warnings(r'.*?get_fake_user_agent is deprecated'): - # ON: True and None in config are considered turned on. - config.fake_user_agent = True - self.assertNotEqual(http.get_fake_user_agent(), http.user_agent()) - config.fake_user_agent = None - self.assertNotEqual(http.get_fake_user_agent(), http.user_agent()) - - # OFF: All other values won't make it return random UA. - config.fake_user_agent = False - self.assertEqual(http.get_fake_user_agent(), http.user_agent()) - config.fake_user_agent = 'ARBITRARY' - self.assertEqual(http.get_fake_user_agent(), 'ARBITRARY') - - @require_modules('fake_useragent') - def test_with_fake_useragent(self): - """Test method with fake_useragent module.""" - self._test_config_settings() - - class CharsetTestCase(TestCase): """Test that HttpRequest correct handles the charsets given.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761342 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I30f5ffffd0a5c81c06ce68608bfb412f12238a09 Gerrit-Change-Number: 761342 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: MtDu <justin.d128(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: [tests] replace type-specific assertEqual methods

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762058 ) Change subject: [tests] replace type-specific assertEqual methods ...................................................................... [tests] replace type-specific assertEqual methods type-specific assertEqual methods are already dispatched by the assertEqual method and unnecessary to call them explicitly. Change-Id: I3a2af8148c41cec3364f54b3711c4b6c9df55e95 --- M tests/flow_edit_tests.py M tests/http_tests.py M tests/site_tests.py M tests/sparql_tests.py 4 files changed, 15 insertions(+), 12 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/flow_edit_tests.py b/tests/flow_edit_tests.py index 74333f0..f09a40b 100644 --- a/tests/flow_edit_tests.py +++ b/tests/flow_edit_tests.py @@ -135,7 +135,7 @@ # Nested reply old_nested_replies = first_reply_post.replies(force=True)[:] - self.assertListEqual(old_nested_replies, []) + self.assertEqual(old_nested_replies, []) second_reply_post = first_reply_post.reply(second_content, 'wikitext') # Test nested reply's content @@ -151,7 +151,7 @@ # self.assertLength(new_nested_replies, len(old_nested_replies) + 1) # Current test for nested reply list - self.assertListEqual(old_nested_replies, []) + self.assertEqual(old_nested_replies, []) more_root_replies = topic_root.replies(force=True) self.assertLength(more_root_replies, len(new_root_replies) + 1) diff --git a/tests/http_tests.py b/tests/http_tests.py index 62b066e..62c2a37 100644 --- a/tests/http_tests.py +++ b/tests/http_tests.py @@ -558,7 +558,7 @@ self.assertEqual(r.status_code, HTTPStatus.OK) content = json.loads(r.text) - self.assertDictEqual(content['args'], {}) + self.assertEqual(content['args'], {}) def test_unencoded_params(self): """ @@ -577,7 +577,7 @@ self.assertEqual(r.status_code, HTTPStatus.OK) content = json.loads(r.text) - self.assertDictEqual(content['args'], {'fish&chips': 'delicious'}) + self.assertEqual(content['args'], {'fish&chips': 'delicious'}) def test_encoded_params(self): """ @@ -596,7 +596,7 @@ self.assertEqual(r.status_code, HTTPStatus.OK) content = json.loads(r.text) - self.assertDictEqual(content['args'], {'fish%26chips': 'delicious'}) + self.assertEqual(content['args'], {'fish%26chips': 'delicious'}) class DataBodyParameterTestCase(HttpbinTestCase): @@ -625,7 +625,7 @@ r_data['headers'].pop(tracker_id, None) r_body['headers'].pop(tracker_id, None) - self.assertDictEqual(r_data, r_body) + self.assertEqual(r_data, r_body) if __name__ == '__main__': # pragma: no cover diff --git a/tests/site_tests.py b/tests/site_tests.py index faf457c..2d3ce36 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -896,8 +896,9 @@ if not self.site.data_repository(): self.skipTest('Site is not using a Wikibase repository') upgen = self.site.unconnected_pages(total=3) - self.assertDictEqual( - upgen.request._params, { + self.assertEqual( + upgen.request._params, + { 'gqppage': ['UnconnectedPages'], 'prop': ['info', 'imageinfo', 'categoryinfo'], 'inprop': ['protection'], @@ -905,7 +906,9 @@ 'iiprop': ['timestamp', 'user', 'comment', 'url', 'size', 'sha1', 'metadata'], 'generator': ['querypage'], 'action': ['query'], - 'indexpageids': [True], 'continue': [True]}) + 'indexpageids': [True], 'continue': [True] + } + ) self.assertLessEqual(len(tuple(upgen)), 3) def test_assert_valid_iter_params(self): diff --git a/tests/sparql_tests.py b/tests/sparql_tests.py index 4f9b808..d909805 100644 --- a/tests/sparql_tests.py +++ b/tests/sparql_tests.py @@ -106,12 +106,12 @@ self.assertIsInstance(res, list, 'Result is not a list') self.assertLength(res, 2) - self.assertDictEqual( + self.assertEqual( res[0], {'cat': 'http://www.wikidata.org/entity/Q498787', 'catLabel': 'Muezza', 'd': '1955-01-01T00:00:00Z'}, 'Bad result') - self.assertDictEqual( + self.assertEqual( res[1], {'cat': 'http://www.wikidata.org/entity/Q677525', 'catLabel': 'Orangey', 'd': '2015-06-22T00:00:00Z'}, @@ -156,7 +156,7 @@ with skipping(pywikibot.exceptions.TimeoutError): q = sparql.SparqlQuery() res = q.get_items('SELECT * WHERE { ?x ?y ?z }', 'cat') - self.assertSetEqual(res, {'Q498787', 'Q677525'}) + self.assertEqual(res, {'Q498787', 'Q677525'}) res = q.get_items('SELECT * WHERE { ?x ?y ?z }', 'cat', result_type=list) self.assertEqual(res, ['Q498787', 'Q677525', 'Q677525']) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762058 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I3a2af8148c41cec3364f54b3711c4b6c9df55e95 Gerrit-Change-Number: 762058 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: [doc] Update documentation

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761754 ) Change subject: [doc] Update documentation ...................................................................... [doc] Update documentation * Update redirected URLs Change-Id: Ia5300b56c7bd2aac6e3c9a9d509d3c4002e69af7 --- M .github/workflows/login_tests-ci.yml M .github/workflows/pywikibot-ci.yml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/.github/workflows/login_tests-ci.yml b/.github/workflows/login_tests-ci.yml index 95fda73..0dd1eb6 100644 --- a/.github/workflows/login_tests-ci.yml +++ b/.github/workflows/login_tests-ci.yml @@ -1,6 +1,6 @@ # This workflow will install Python dependencies, run Pywikibot tests # with a variety of Python versions. For more information see: -# https://help.github.com/actions/language-and-framework-guides/using-python-… +# https://docs.github.com/en/actions/automating-builds-and-tests/building-and… name: Login CI diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index 62a757e..ca92152 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -1,6 +1,6 @@ # This workflow will install Python dependencies, run Pywikibot tests # with a variety of Python versions. For more information see: -# https://help.github.com/actions/language-and-framework-guides/using-python-… +# https://docs.github.com/en/actions/automating-builds-and-tests/building-and… name: Pywikibot CI -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761754 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ia5300b56c7bd2aac6e3c9a9d509d3c4002e69af7 Gerrit-Change-Number: 761754 Gerrit-PatchSet: 2 Gerrit-Owner: Meno25 <meno25mail(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: [tests] Fix resolving a site

by Xqt (Code Review)

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762059 ) Change subject: [tests] Fix resolving a site ...................................................................... [tests] Fix resolving a site Change-Id: Id205b06701efe058de98e40d8070172f0fb601b4 --- M .github/workflows/login_tests-ci.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/login_tests-ci.yml b/.github/workflows/login_tests-ci.yml index 61f96b4..95fda73 100644 --- a/.github/workflows/login_tests-ci.yml +++ b/.github/workflows/login_tests-ci.yml @@ -93,7 +93,7 @@ - name: Generate user files run: | - if [ ${{matrix.site}} != 'False' ]; then + if [ ${{matrix.site}} != false ]; then python -Werror::UserWarning -m pwb generate_user_files -site:${{matrix.site}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; else python -Werror::UserWarning -m pwb generate_user_files -family:${{matrix.family}} -lang:${{matrix.code}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762059 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Id205b06701efe058de98e40d8070172f0fb601b4 Gerrit-Change-Number: 762059 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: [tests] move TestClearCookies to site_login_logout_tests.py

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762057 ) Change subject: [tests] move TestClearCookies to site_login_logout_tests.py ...................................................................... [tests] move TestClearCookies to site_login_logout_tests.py TestClearCookies uses logout() method and should not run in parallel with other CI tests. Change-Id: I730845205a9f44a6c1dd6015d76e22bd1ca74a03 --- M tests/site_login_logout_tests.py M tests/site_tests.py 2 files changed, 32 insertions(+), 27 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_login_logout_tests.py b/tests/site_login_logout_tests.py index d53ff30..751b243 100644 --- a/tests/site_login_logout_tests.py +++ b/tests/site_login_logout_tests.py @@ -1,5 +1,10 @@ #!/usr/bin/python3 -"""Test for login and logout methods.""" +"""Test for login and logout methods. + +These tests are separated from others because they should not be runned +in paralled CI test tasks. Any logout could lead other parallel tests +to fail. +""" # # (C) Pywikibot team, 2022 # @@ -12,7 +17,7 @@ import pywikibot from pywikibot.exceptions import APIError -from tests.aspects import DefaultSiteTestCase +from tests.aspects import DefaultSiteTestCase, TestCase class TestLoginLogout(DefaultSiteTestCase): @@ -51,10 +56,34 @@ self.assertIsNone(site.user()) +class TestClearCookies(TestCase): + """Test cookies are cleared after logout.""" + + login = True + + family = 'wikisource' + code = 'zh' + + def test_clear_cookies(self): + """Test cookies are cleared (T224712).""" + site = self.get_site() + site.login() + site2 = pywikibot.Site('mul', 'wikisource', user=site.username()) + site2.login() + site.logout() + + raised = False + try: + site.login() + except Exception as e: + raised = e + self.assertFalse(raised) + + def setUpModule(): # noqa: N802 """Skip tests if PYWIKIBOT_LOGIN_LOGOUT variable is not set.""" if os.environ.get('PYWIKIBOT_LOGIN_LOGOUT', '0') != '1': - raise unittest.SkipTest('login/logout tests ar disabled') + raise unittest.SkipTest('login/logout tests are disabled') if __name__ == '__main__': # pragma: no cover diff --git a/tests/site_tests.py b/tests/site_tests.py index faf457c..de1bde2 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -3568,30 +3568,6 @@ self.assertIsNone(page) -class TestClearCookies(TestCase): - """Test cookies are cleared after logout.""" - - login = True - - family = 'wikisource' - code = 'zh' - - def test_clear_cookies(self): - """Test cookies are cleared (T224712).""" - site = self.get_site() - site.login() - site2 = pywikibot.Site('mul', 'wikisource', user=site.username()) - site2.login() - site.logout() - - raised = False - try: - site.login() - except Exception as e: - raised = e - self.assertFalse(raised) - - if __name__ == '__main__': # pragma: no cover with suppress(SystemExit): unittest.main() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/762057 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I730845205a9f44a6c1dd6015d76e22bd1ca74a03 Gerrit-Change-Number: 762057 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: [doc] Update documentation

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761752 ) Change subject: [doc] Update documentation ...................................................................... [doc] Update documentation * Update URL: ** Pywikibot no longer supports version 3.4 ** Use the most recent version instead Change-Id: If6f05c1970f9d6cb172e41e02b1ef2c2e28b3c19 --- M scripts/archivebot.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/archivebot.py b/scripts/archivebot.py index adf23c1..7e5a64e 100755 --- a/scripts/archivebot.py +++ b/scripts/archivebot.py @@ -74,7 +74,7 @@ See also: - https://webspace.science.uu.nl/~gent0113/calendar/isocalendar.htm - - https://docs.python.org/3.4/library/datetime.html#datetime.date.isocalendar + - https://docs.python.org/3/library/datetime.html#datetime.date.isocalendar Options (may be omitted): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761752 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If6f05c1970f9d6cb172e41e02b1ef2c2e28b3c19 Gerrit-Change-Number: 761752 Gerrit-PatchSet: 3 Gerrit-Owner: Meno25 <meno25mail(a)gmail.com> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: [tests] skip test_create_short_link if login fails.

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761968 ) Change subject: [tests] skip test_create_short_link if login fails. ...................................................................... [tests] skip test_create_short_link if login fails. Bug: T256540 Change-Id: Ib7bb706c5d92564f86aabf0c25e96d219624e44b --- M .github/workflows/pywikibot-ci.yml M tests/page_tests.py 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index 6631832..62a757e 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -21,7 +21,7 @@ strategy: fail-fast: false - max-parallel: 9 + max-parallel: 10 matrix: python-version: ["pypy3", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10"] diff --git a/tests/page_tests.py b/tests/page_tests.py index 006e603..fa81453 100644 --- a/tests/page_tests.py +++ b/tests/page_tests.py @@ -1234,6 +1234,9 @@ meta = pywikibot.Site('meta:meta') if not meta.logged_in(): meta.login() + if not meta.user(): + self.skipTest('{}: Not able to login to {}' + .format(type(self).__name__, meta)) site = self.get_site() p1 = pywikibot.Page(site, 'User:Framawiki/pwb_tests/shortlink') -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761968 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ib7bb706c5d92564f86aabf0c25e96d219624e44b Gerrit-Change-Number: 761968 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

2 years, 2 months

[Gerrit] ...core[master]: [tests] skip test_speedy_delete if no user is logged in

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761936 ) Change subject: [tests] skip test_speedy_delete if no user is logged in ...................................................................... [tests] skip test_speedy_delete if no user is logged in Bug: T301555 Change-Id: Ia478ee1a4f81f5481fcba74ed37e27d7480440c6 --- M tests/script_tests.py 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/script_tests.py b/tests/script_tests.py index fa02e3e..baa8aab 100644 --- a/tests/script_tests.py +++ b/tests/script_tests.py @@ -122,6 +122,11 @@ 'upload': 'ERROR: Upload error', } +# skip test if result is unexpected in this way +skip_on_results = { + 'speedy_delete': 'No user is logged in on site' # T301555 +} + enable_autorun_tests = ( os.environ.get('PYWIKIBOT_TEST_AUTORUN', '0') == '1') @@ -234,8 +239,12 @@ if result['exit_code'] == -9: unittest_print(' killed', end=' ') + skip_result = self._skip_results.get(script_name) + if skip_result and skip_result in err_result: + self.skipTest(skip_result) + if error: - self.assertIn(error, result['stderr']) + self.assertIn(error, err_result) exit_codes = [0, 1, 2, -9] elif not is_autorun: @@ -340,6 +349,7 @@ _arguments = '-help' _results = None + _skip_results = {} class TestScriptSimulate(DefaultSiteTestCase, PwbTestCase, @@ -368,6 +378,7 @@ _arguments = '-simulate' _results = no_args_expected_results + _skip_results = skip_on_results if __name__ == '__main__': # pragma: no cover -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/761936 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ia478ee1a4f81f5481fcba74ed37e27d7480440c6 Gerrit-Change-Number: 761936 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

2 years, 2 months

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits February 2022