Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/668078 )
Change subject: [IMPR] Use the new DisambiguationRobot interface and options
......................................................................
[IMPR] Use the new DisambiguationRobot interface and options
Change-Id: I13791107fa93bb0c1ca63b52abb1f1365cae2c52
---
M scripts/misspelling.py
1 file changed, 9 insertions(+), 20 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/scripts/misspelling.py b/scripts/misspelling.py
index cefb7f8..30d88bf 100755
--- a/scripts/misspelling.py
+++ b/scripts/misspelling.py
@@ -31,7 +31,6 @@
import pywikibot
from pywikibot import i18n, pagegenerators
-from pywikibot.bot import SingleSiteBot
from pywikibot.tools.formatter import color_format
from scripts.solve_disambiguation import DisambiguationRobot as BaseDisambigBot
@@ -50,29 +49,19 @@
"""Spelling bot."""
- available_options = {
- 'always': None,
- 'start': None,
- 'main': False,
- }
-
misspelling_templates = {
'wikipedia:de': ('Falschschreibung', 'Obsolete Schreibung'),
}
- # Optional: if there is a category, one can use the -start
- # parameter.
+ # Optional: if there is a category, one can use the -start parameter
misspelling_categories = ('Q8644265', 'Q9195708')
def __init__(self, **kwargs) -> None:
"""Initializer."""
- # handle options first;
- # they are needed for DisambiguationRobot positional arguments
- SingleSiteBot.__init__(self, **kwargs)
- super().__init__(always=self.opt.always, alternatives=[],
- getAlternatives=True, dnSkip=False, generator=None,
- primary=False, main_only=self.opt.main,
- **self.options) # save options
+ self.available_options.update({
+ 'start': None,
+ })
+ super().__init__(**kwargs)
@property
def generator(self) -> Generator[pywikibot.Page, None, None]:
@@ -124,7 +113,7 @@
@return: True if alternate link was appended
"""
if page.isRedirectPage():
- self.alternatives.append(page.getRedirectTarget().title())
+ self.opt.pos.append(page.getRedirectTarget().title())
return True
sitename = page.site.sitename
@@ -143,12 +132,12 @@
# misspelling is ambiguous, see for example:
# https://de.wikipedia.org/wiki/Buthan
for match in self.linkR.finditer(correct_spelling):
- self.alternatives.append(match.group('title'))
+ self.opt.pos.append(match.group('title'))
- if not self.alternatives:
+ if not self.opt.pos:
# There were no links in the parameter, so there is
# only one correct spelling.
- self.alternatives.append(correct_spelling)
+ self.opt.pos.append(correct_spelling)
return True
return False
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/668078
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I13791107fa93bb0c1ca63b52abb1f1365cae2c52
Gerrit-Change-Number: 668078
Gerrit-PatchSet: 4
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: DannyS712 <dannys712.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-CC: Bharatkhatri <bharatkhatri351(a)gmail.com>
Gerrit-MessageType: merged
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/676723 )
Change subject: [doc] fix docstring
......................................................................
[doc] fix docstring
Change-Id: Icd4ddc8853464e79f574075d59cdc7eccd2cc979
---
M scripts/maintenance/cache.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/maintenance/cache.py b/scripts/maintenance/cache.py
index f7f4212..08023cb 100755
--- a/scripts/maintenance/cache.py
+++ b/scripts/maintenance/cache.py
@@ -54,7 +54,7 @@
older_than_one_day(entry)
recent(entry)
- There are helper functions which can be part of a command:
+There are helper functions which can be part of a command:
older_than(entry, interval)
newer_than(entry, interval)
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/676723
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Icd4ddc8853464e79f574075d59cdc7eccd2cc979
Gerrit-Change-Number: 676723
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/676712 )
Change subject: [sphinx] ignore deprecated methods
......................................................................
[sphinx] ignore deprecated methods
Change-Id: Iddd7096bc382205a4b74fadc30d2515661d40cbe
---
M docs/conf.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/docs/conf.py b/docs/conf.py
index bbc1bb4..075f718 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -456,7 +456,7 @@
if name.startswith('__') and name.endswith('__'):
return True
if obj.__doc__ is not None \
- and obj.__doc__.startswith(('DEPRECATED', 'Deprecated')):
+ and ('DEPRECATED' in obj.__doc__ or 'Deprecated' in obj.__doc__):
return True
return skip or name in exclusions
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/676712
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Iddd7096bc382205a4b74fadc30d2515661d40cbe
Gerrit-Change-Number: 676712
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/676711 )
Change subject: [doc] Skip empty __init__
......................................................................
[doc] Skip empty __init__
Change-Id: If8cd57dda4b24ade071947f3bca1d0f7359450ab
---
M docs/conf.py
M pywikibot/site/_apisite.py
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/docs/conf.py b/docs/conf.py
index e4be68c..bbc1bb4 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -451,7 +451,7 @@
"""Skip certain members from documentation."""
inclusions = ('__init__', )
exclusions = ()
- if name in inclusions:
+ if name in inclusions and len(str.splitlines(obj.__doc__ or '')) >= 3:
return False
if name.startswith('__') and name.endswith('__'):
return True
diff --git a/pywikibot/site/_apisite.py b/pywikibot/site/_apisite.py
index f9233c9..951530e 100644
--- a/pywikibot/site/_apisite.py
+++ b/pywikibot/site/_apisite.py
@@ -102,10 +102,9 @@
WikibaseClientMixin,
):
- """
- API interface to MediaWiki site.
+ """API interface to MediaWiki site.
- Do not instantiate directly; use pywikibot.Site function.
+ Do not instantiate directly; use L{pywikibot.Site} function.
"""
@remove_last_args(['sysop'])
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/676711
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: If8cd57dda4b24ade071947f3bca1d0f7359450ab
Gerrit-Change-Number: 676711
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/676709 )
Change subject: Fix spelling mistake
......................................................................
Fix spelling mistake
Change-Id: I0091ee9a37b788e22b93de3c90a3ec3b1732fa9d
---
M scripts/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
JJMC89: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/__init__.py b/scripts/__init__.py
index 0b5b23a..9ec9e7c 100644
--- a/scripts/__init__.py
+++ b/scripts/__init__.py
@@ -8,7 +8,7 @@
Every script provides a ``-help`` option which shows all available
-options, their explanation and usage examples. Global optiond will be
+options, their explanation and usage examples. Global options will be
shown by ``-help:global`` or using::
python pwb.py -help
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/676709
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I0091ee9a37b788e22b93de3c90a3ec3b1732fa9d
Gerrit-Change-Number: 676709
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged