Pywikibot-commits July 2020

pywikibot-commits@lists.wikimedia.org

1 participants
180 discussions

[Gerrit] ...core[master]: Update listpages for py3
by jenkins-bot (Code Review) 12 Jul '20

12 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611826 ) Change subject: Update listpages for py3 ...................................................................... Update listpages for py3 Bug: T257399 Change-Id: I0441d7c90ab1151b9172c6cdebafdea81657becd --- M scripts/listpages.py 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/listpages.py b/scripts/listpages.py index 57614ea..bd79ffa 100755 --- a/scripts/listpages.py +++ b/scripts/listpages.py @@ -88,23 +88,22 @@ &params; """ # -# (C) Pywikibot team, 2008-2019 +# (C) Pywikibot team, 2008-2020 # # Distributed under the terms of the MIT license. # -from __future__ import absolute_import, division, unicode_literals - import os import re import pywikibot + from pywikibot import config2 as config, i18n from pywikibot.pagegenerators import GeneratorFactory, parameterHelp docuReplacements = {'&params;': parameterHelp} # noqa: N816 -class Formatter(object): +class Formatter: """Structure with Page attributes exposed for formatting from cmd line.""" @@ -121,7 +120,7 @@ # Identify which formats need outputlang fmt_need_lang = [k for k, v in fmt_options.items() if 'trs_title' in v] - def __init__(self, page, outputlang=None, default='******'): + def __init__(self, page, outputlang=None, default='******') -> None: """ Initializer. @@ -153,7 +152,7 @@ except pywikibot.Error: self.trs_title = '{0}:{1}'.format(default, page._link.title) - def output(self, num=None, fmt='1'): + def output(self, num=None, fmt='1') -> str: """Output formatted string.""" fmt = self.fmt_options.get(fmt, fmt) # If selected format requires trs_title, outputlang must be set. @@ -168,7 +167,7 @@ return fmt.format(num=num, page=self) -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. @@ -246,7 +245,7 @@ 'You can use the -overwrite argument to ' 'replace the content of this page.' .format(page_target.title(as_link=True))) - return False + return if re.match('[a-z_-]+$', summary): summary = i18n.twtranslate(site, summary) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611826 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I0441d7c90ab1151b9172c6cdebafdea81657becd Gerrit-Change-Number: 611826 Gerrit-PatchSet: 1 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Update illustrate_wikidata for py3
by jenkins-bot (Code Review) 12 Jul '20

12 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611811 ) Change subject: Update illustrate_wikidata for py3 ...................................................................... Update illustrate_wikidata for py3 Bug: T257399 Change-Id: I810cac4228a9c44675f1d01d81f8aecf4719be5b --- M scripts/illustrate_wikidata.py 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/illustrate_wikidata.py b/scripts/illustrate_wikidata.py index 1448177..117cff7 100755 --- a/scripts/illustrate_wikidata.py +++ b/scripts/illustrate_wikidata.py @@ -14,12 +14,10 @@ &params; """ # -# (C) Pywikibot team, 2013-2019 +# (C) Pywikibot team, 2013-2020 # # Distributed under the terms of MIT License. # -from __future__ import absolute_import, division, unicode_literals - import pywikibot from pywikibot import pagegenerators, WikidataBot @@ -31,7 +29,7 @@ """A bot to add Wikidata image claims.""" - def __init__(self, generator, wdproperty='P18'): + def __init__(self, generator, wdproperty='P18') -> None: """ Initializer. @@ -40,7 +38,7 @@ @param wdproperty: The property to add. Should be of type commonsMedia @type wdproperty: str """ - super(IllustrateRobot, self).__init__() + super().__init__() self.generator = generator self.wdproperty = wdproperty self.cacheSources() @@ -50,7 +48,7 @@ raise ValueError('{} is of type {}, should be commonsMedia' .format(self.wdproperty, claim.type)) - def treat_page_and_item(self, page, item): + def treat_page_and_item(self, page, item) -> None: """Treat a page / item.""" pywikibot.output('Found ' + item.title()) imagename = page.properties().get('page_image_free') @@ -82,7 +80,7 @@ self.user_add_claim(item, newclaim, page.site) -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611811 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I810cac4228a9c44675f1d01d81f8aecf4719be5b Gerrit-Change-Number: 611811 Gerrit-PatchSet: 2 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Update interwikidata for py3
by jenkins-bot (Code Review) 12 Jul '20

12 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611813 ) Change subject: Update interwikidata for py3 ...................................................................... Update interwikidata for py3 Bug: T257399 Change-Id: I982d2fef1937b34f974c2140228a7171a4a14cc7 --- M scripts/interwikidata.py 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/interwikidata.py b/scripts/interwikidata.py index d7897ba..51518cc 100644 --- a/scripts/interwikidata.py +++ b/scripts/interwikidata.py @@ -23,11 +23,11 @@ -summary: Use your own edit summary for cleaning the page. """ -# (C) Pywikibot team, 2015-2019 +# (C) Pywikibot team, 2015-2020 # # Distributed under the terms of the MIT license. # -from __future__ import unicode_literals, division, absolute_import +from typing import Set, Union import pywikibot @@ -39,7 +39,7 @@ docuReplacements = {'&params;': pagegenerators.parameterHelp} # noqa: N816 # Allowed namespaces. main, project, template, category -namespaces = [0, 4, 10, 14] +NAMESPACES = (0, 4, 10, 14) # TODO: Some templates on pages, like csd, inuse and afd templates, # should cause the bot to skip the page, see T134497 @@ -49,7 +49,7 @@ """The bot for interwiki.""" - def __init__(self, **kwargs): + def __init__(self, **kwargs) -> None: """Initialize the bot.""" self.availableOptions.update({ 'clean': False, @@ -58,7 +58,7 @@ 'summary': None, 'ignore_ns': False, # used by interwikidata_tests only }) - super(IWBot, self).__init__(**kwargs) + super().__init__(**kwargs) if not self.site.has_data_repository: raise ValueError('{site} does not have a data repository, ' 'use interwiki.py instead.'.format( @@ -68,20 +68,20 @@ self.options['summary'] = pywikibot.i18n.twtranslate( self.site, 'interwikidata-clean-summary') - def treat_page(self): + def treat_page(self) -> None: """Check page.""" - if (self.current_page.namespace() not in namespaces + if (self.current_page.namespace() not in NAMESPACES and not self.getOption('ignore_ns')): output('{page} is not in allowed namespaces, skipping' .format(page=self.current_page.title( as_link=True))) - return False + return self.iwlangs = pywikibot.textlib.getLanguageLinks( self.current_page.text, insite=self.current_page.site) if not self.iwlangs: output('No interlanguagelinks on {page}'.format( page=self.current_page.title(as_link=True))) - return False + return try: item = pywikibot.ItemPage.fromPage(self.current_page) except pywikibot.NoPage: @@ -99,7 +99,7 @@ self.current_item = item self.clean_page() - def create_item(self): + def create_item(self) -> pywikibot.ItemPage: """Create item in repo for current_page.""" data = {'sitelinks': {self.site.dbName(): @@ -127,7 +127,7 @@ output('Created item {item}'.format(item=item.getID())) return item - def handle_complicated(self): + def handle_complicated(self) -> bool: """ Handle pages when they have interwiki conflict. @@ -138,7 +138,7 @@ """ return False - def clean_page(self): + def clean_page(self) -> None: """Clean interwiki links from the page.""" if not self.iwlangs: return @@ -147,13 +147,13 @@ if not self.handle_complicated(): warning('Interwiki conflict in {}, skipping...' .format(self.current_page.title(as_link=True))) - return False + return output('Cleaning up the page') new_text = pywikibot.textlib.removeLanguageLinks( self.current_page.text, site=self.current_page.site) self.put_current(new_text, summary=self.getOption('summary')) - def get_items(self): + def get_items(self) -> Set[pywikibot.ItemPage]: """Return all items of pages linked through the interwiki.""" wd_data = set() for iw_page in self.iwlangs.values(): @@ -168,7 +168,7 @@ .format(iw_page.title(as_link=True))) return wd_data - def try_to_add(self): + def try_to_add(self) -> Union[pywikibot.ItemPage, bool, None]: """Add current page in repo.""" wd_data = self.get_items() if not wd_data: @@ -188,7 +188,7 @@ self.current_page.title(as_link=True, insite=item.site))) return item - def try_to_merge(self, item): + def try_to_merge(self, item) -> Union[pywikibot.ItemPage, bool, None]: """Merge two items.""" wd_data = self.get_items() if not wd_data: @@ -209,7 +209,7 @@ return target_item -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611813 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I982d2fef1937b34f974c2140228a7171a4a14cc7 Gerrit-Change-Number: 611813 Gerrit-PatchSet: 2 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Update harvest_template for py3
by jenkins-bot (Code Review) 12 Jul '20

12 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611810 ) Change subject: Update harvest_template for py3 ...................................................................... Update harvest_template for py3 Bug: T257399 Change-Id: If5948ecb6023d805a767c0daa8a7e64ffd5ea4d9 --- M scripts/harvest_template.py 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py index e8606de..9f0d587 100755 --- a/scripts/harvest_template.py +++ b/scripts/harvest_template.py @@ -92,11 +92,12 @@ # # Distributed under the terms of MIT License. # -from __future__ import absolute_import, division, unicode_literals - import signal +from typing import Any, List, Optional + import pywikibot + from pywikibot import pagegenerators as pg, textlib from pywikibot.bot import WikidataBot, OptionHandler @@ -104,7 +105,7 @@ willstop = False -def _signal_handler(signal, frame): +def _signal_handler(signal, frame) -> None: global willstop if not willstop: willstop = True @@ -134,7 +135,7 @@ """A bot to add Wikidata claims.""" - def __init__(self, generator, template_title, fields, **kwargs): + def __init__(self, generator, template_title, fields, **kwargs) -> None: """ Initializer. @@ -162,7 +163,7 @@ 'islink': False, 'multi': False, }) - super(HarvestRobot, self).__init__(**kwargs) + super().__init__(**kwargs) self.generator = generator # TODO: Make it a list including the redirects to the template self.fields = {} @@ -177,7 +178,7 @@ self.linkR = textlib.compileLinkR() self.create_missing_item = self.getOption('create') - def getTemplateSynonyms(self, title): + def getTemplateSynonyms(self, title) -> List[str]: """Fetch redirects of the title, so we can check against them.""" temp = pywikibot.Page(pywikibot.Site(), title, ns=10) if not temp.exists(): @@ -196,7 +197,8 @@ titles.append(temp.title(with_ns=False)) return titles - def _template_link_target(self, item, link_text): + def _template_link_target(self, item, link_text + ) -> Optional[pywikibot.ItemPage]: link = pywikibot.Link(link_text) linked_page = pywikibot.Page(link) try: @@ -231,7 +233,7 @@ return linked_item - def _get_option_with_fallback(self, handler, option): + def _get_option_with_fallback(self, handler, option) -> Any: """ Compare bot's (global) and provided (local) options. @@ -244,7 +246,7 @@ else: return local or default - def treat_page_and_item(self, page, item): + def treat_page_and_item(self, page, item) -> None: """Process a single page/item.""" if willstop: raise KeyboardInterrupt @@ -349,7 +351,7 @@ item, claim, exists_arg, page.site, pywikibot.output) -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. @@ -409,7 +411,7 @@ fields[current_args[0]] = (current_args[1], handler) elif len(current_args) == 1: pywikibot.error('Incomplete command line param-property pair.') - return False + return if not template_title: pywikibot.error( -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611810 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If5948ecb6023d805a767c0daa8a7e64ffd5ea4d9 Gerrit-Change-Number: 611810 Gerrit-PatchSet: 1 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Update clean_sandbox for py3
by jenkins-bot (Code Review) 12 Jul '20

12 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611673 ) Change subject: Update clean_sandbox for py3 ...................................................................... Update clean_sandbox for py3 Bug: T257399 Change-Id: I4a02589465ec4e57285198de8b5fba209556c60f --- M scripts/clean_sandbox.py 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/clean_sandbox.py b/scripts/clean_sandbox.py index 93c7f91..b7c7959 100755 --- a/scripts/clean_sandbox.py +++ b/scripts/clean_sandbox.py @@ -38,12 +38,10 @@ delay: 7 """ # -# (C) Pywikibot team, 2006-2019 +# (C) Pywikibot team, 2006-2020 # # Distributed under the terms of the MIT license. # -from __future__ import absolute_import, division, unicode_literals - import datetime import sys import time @@ -157,9 +155,9 @@ 'delay_td': None, # not a real option but __init__ sets it } - def __init__(self, **kwargs): + def __init__(self, **kwargs) -> None: """Initializer.""" - super(SandboxBot, self).__init__(**kwargs) + super().__init__(**kwargs) if self.getOption('delay') < 0: d = min(15, max(5, int(self.getOption('hours') * 60))) self.availableOptions['delay_td'] = datetime.timedelta(minutes=d) @@ -184,7 +182,7 @@ sys.exit() self.generator = pages - def run(self): + def run(self) -> None: """Run bot.""" self.site.login() while True: @@ -257,7 +255,7 @@ pywikibot.sleep(self.getOption('hours') * 60 * 60) -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611673 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I4a02589465ec4e57285198de8b5fba209556c60f Gerrit-Change-Number: 611673 Gerrit-PatchSet: 3 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Update coordinate_import for py3
by jenkins-bot (Code Review) 12 Jul '20

12 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611676 ) Change subject: Update coordinate_import for py3 ...................................................................... Update coordinate_import for py3 Bug: T257399 Change-Id: I4361127f3410dc7542404d204be2dbad32276e4b --- M scripts/coordinate_import.py 1 file changed, 9 insertions(+), 14 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/coordinate_import.py b/scripts/coordinate_import.py index 39868cd..b37e987 100755 --- a/scripts/coordinate_import.py +++ b/scripts/coordinate_import.py @@ -37,11 +37,11 @@ &params; """ # -# (C) Pywikibot team, 2013-2019 +# (C) Pywikibot team, 2013-2020 # # Distributed under the terms of MIT License. # -from __future__ import absolute_import, division, unicode_literals +from typing import Optional import pywikibot from pywikibot import pagegenerators, WikidataBot @@ -56,20 +56,20 @@ use_from_page = None - def __init__(self, generator, **kwargs): + def __init__(self, generator, **kwargs) -> None: """ Initializer. @param generator: A generator that yields Page objects. """ self.availableOptions['create'] = False - super(CoordImportRobot, self).__init__(**kwargs) + super().__init__(**kwargs) self.generator = generator self.cacheSources() self.prop = 'P625' self.create_missing_item = self.getOption('create') - def has_coord_qualifier(self, claims): + def has_coord_qualifier(self, claims) -> Optional[str]: """ Check if self.prop is used as property for a qualifier. @@ -77,7 +77,6 @@ @type claims: dict @return: the first property for which self.prop is used as qualifier, or None if any - @return: unicode or None """ for prop in claims: for claim in claims[prop]: @@ -85,12 +84,11 @@ return prop return None - def item_has_coordinates(self, item): + def item_has_coordinates(self, item) -> bool: """ Check if the item has coordinates. @return: whether the item has coordinates - @rtype: bool """ claims = item.get().get('claims') if self.prop in claims: @@ -106,7 +104,7 @@ return True return False - def treat_page_and_item(self, page, item): + def treat_page_and_item(self, page, item) -> None: """Treat page/item.""" if self.item_has_coordinates(item): return @@ -120,13 +118,12 @@ self.try_import_coordinates_from_page(page, item) - def try_import_coordinates_from_page(self, page, item): + def try_import_coordinates_from_page(self, page, item) -> bool: """ Try import coordinate from the given page to the given item. @return: whether any coordinates were found and the import was successful - @rtype: bool """ coordinate = page.coordinates(primary_only=True) if not coordinate: @@ -149,7 +146,7 @@ return True -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. @@ -176,10 +173,8 @@ if generator: coordbot = CoordImportRobot(generator, create=create_new) coordbot.run() - return True else: pywikibot.bot.suggest_help(missing_generator=True) - return False if __name__ == '__main__': -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611676 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I4361127f3410dc7542404d204be2dbad32276e4b Gerrit-Change-Number: 611676 Gerrit-PatchSet: 3 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Update cosmetic_changes for py3
by jenkins-bot (Code Review) 12 Jul '20

12 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611679 ) Change subject: Update cosmetic_changes for py3 ...................................................................... Update cosmetic_changes for py3 Bug: T257399 Change-Id: I675fe225ed4258cd3de5ac2392955498d73fc4b1 --- M scripts/cosmetic_changes.py 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/cosmetic_changes.py b/scripts/cosmetic_changes.py index 3069bcb..a826608 100644 --- a/scripts/cosmetic_changes.py +++ b/scripts/cosmetic_changes.py @@ -28,12 +28,10 @@ For further information see pywikibot/cosmetic_changes.py """ # -# (C) Pywikibot team, 2006-2019 +# (C) Pywikibot team, 2006-2020 # # Distributed under the terms of the MIT license. # -from __future__ import absolute_import, division, unicode_literals - import pywikibot from pywikibot import config, cosmetic_changes, i18n, pagegenerators @@ -56,18 +54,18 @@ """Cosmetic changes bot.""" - def __init__(self, generator, **kwargs): + def __init__(self, generator, **kwargs) -> None: """Initializer.""" self.availableOptions.update({ 'async': False, 'summary': 'Robot: Cosmetic changes', 'ignore': cosmetic_changes.CANCEL_ALL, }) - super(CosmeticChangesBot, self).__init__(**kwargs) + super().__init__(**kwargs) self.generator = generator - def treat_page(self): + def treat_page(self) -> None: """Treat page with the cosmetic toolkit.""" cc_toolkit = cosmetic_changes.CosmeticChangesToolkit.from_page( self.current_page, ignore=self.getOption('ignore')) @@ -78,7 +76,7 @@ asynchronous=self.getOption('async')) -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611679 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I675fe225ed4258cd3de5ac2392955498d73fc4b1 Gerrit-Change-Number: 611679 Gerrit-PatchSet: 3 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Update claimit for py3
by jenkins-bot (Code Review) 12 Jul '20

12 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611668 ) Change subject: Update claimit for py3 ...................................................................... Update claimit for py3 Bug: T257399 Change-Id: I8ee6d3d5e72cc523c56e8d3efc7b636cea4b83cb --- M scripts/claimit.py 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/claimit.py b/scripts/claimit.py index 254bf24..0cdfda0 100755 --- a/scripts/claimit.py +++ b/scripts/claimit.py @@ -47,12 +47,10 @@ """ # -# (C) Pywikibot team, 2013-2019 +# (C) Pywikibot team, 2013-2020 # # Distributed under the terms of the MIT license. # -from __future__ import absolute_import, division, unicode_literals - import pywikibot from pywikibot import pagegenerators, WikidataBot @@ -67,7 +65,7 @@ use_from_page = None - def __init__(self, generator, claims, exists_arg=''): + def __init__(self, generator, claims, exists_arg='') -> None: """ Initializer. @@ -79,7 +77,7 @@ @type exists_arg: str """ self.availableOptions['always'] = True - super(ClaimRobot, self).__init__() + super().__init__() self.generator = generator self.claims = claims self.exists_arg = ''.join(x for x in exists_arg.lower() if x in 'pqst') @@ -88,7 +86,7 @@ pywikibot.output("'exists' argument set to '{}'" .format(self.exists_arg)) - def treat_page_and_item(self, page, item): + def treat_page_and_item(self, page, item) -> None: """Treat each page.""" for claim in self.claims: # The generator might yield pages from multiple sites @@ -97,7 +95,7 @@ item, claim.copy(), self.exists_arg, site) -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. @@ -105,7 +103,6 @@ @param args: command line arguments @type args: str - @rtype: bool """ exists_arg = '' commandline_claims = [] @@ -125,7 +122,7 @@ commandline_claims.append(arg) if len(commandline_claims) % 2: pywikibot.error('Incomplete command line property-value pair.') - return False + return claims = [] repo = pywikibot.Site().data_repository() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611668 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I8ee6d3d5e72cc523c56e8d3efc7b636cea4b83cb Gerrit-Change-Number: 611668 Gerrit-PatchSet: 2 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Fix KeyError when extension has no name
by jenkins-bot (Code Review) 11 Jul '20

11 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611841 ) Change subject: Fix KeyError when extension has no name ...................................................................... Fix KeyError when extension has no name Change-Id: I620ed38d5a8ee2cae5b46cb26a5f133699885423 --- M pywikibot/site/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: JJMC89: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site/__init__.py b/pywikibot/site/__init__.py index bef6a1f..a96ce98 100644 --- a/pywikibot/site/__init__.py +++ b/pywikibot/site/__init__.py @@ -2670,7 +2670,7 @@ """ extensions = self.siteinfo['extensions'] for ext in extensions: - if ext['name'] == name: + if 'name' in ext and ext['name'] == name: return True return False -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611841 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I620ed38d5a8ee2cae5b46cb26a5f133699885423 Gerrit-Change-Number: 611841 Gerrit-PatchSet: 1 Gerrit-Owner: John Leen <jleen(a)saturnvalley.org> Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-CC: Welcome, new contributor! <ssethi(a)wikimedia.org> Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: Update basic for py3
by jenkins-bot (Code Review) 11 Jul '20

11 Jul '20

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611632 ) Change subject: Update basic for py3 ...................................................................... Update basic for py3 Bug: T257399 Change-Id: I4c4994ea561dbbf46ffd23c275f4dad8bb677abc --- M scripts/basic.py 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/basic.py b/scripts/basic.py index 6ef72ba..e5df728 100755 --- a/scripts/basic.py +++ b/scripts/basic.py @@ -29,12 +29,10 @@ &params; """ # -# (C) Pywikibot team, 2006-2019 +# (C) Pywikibot team, 2006-2020 # # Distributed under the terms of the MIT license. # -from __future__ import absolute_import, division, unicode_literals - import pywikibot from pywikibot import pagegenerators @@ -69,7 +67,7 @@ summary_key = 'basic-changing' - def __init__(self, generator, **kwargs): + def __init__(self, generator, **kwargs) -> None: """ Initializer. @@ -87,12 +85,12 @@ }) # call initializer of the super class - super(BasicBot, self).__init__(site=True, **kwargs) + super().__init__(site=True, **kwargs) # assign the generator to the bot self.generator = generator - def treat_page(self): + def treat_page(self) -> None: """Load the given page, do some changes, and save it.""" text = self.current_page.text @@ -124,7 +122,7 @@ self.put_current(text, summary=self.getOption('summary')) -def main(*args): +def main(*args) -> None: """ Process command line arguments and invoke bot. -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611632 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I4c4994ea561dbbf46ffd23c275f4dad8bb677abc Gerrit-Change-Number: 611632 Gerrit-PatchSet: 2 Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits July 2020