Pywikibot-commits March 2020

pywikibot-commits@lists.wikimedia.org

1 participants
124 discussions

[Gerrit] pywikibot/core[master]: [bugfix] Restore initialization of Claim.on_item
by jenkins-bot (Code Review) 28 Mar '20

28 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/584131 ) Change subject: [bugfix] Restore initialization of Claim.on_item ...................................................................... [bugfix] Restore initialization of Claim.on_item It was accidentally dropped in Icbcc728c7. This patch is just a duct tape. Eventually, this should be subject to another refactoring. Bug: T248746 Change-Id: I29ed37b23f3883f48ab0abd510faa47bb3e3cb91 --- M pywikibot/page/__init__.py 1 file changed, 30 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py index 4704b67..f2f6db8 100644 --- a/pywikibot/page/__init__.py +++ b/pywikibot/page/__init__.py @@ -3862,6 +3862,12 @@ return claims + def set_on_item(self, item): + """Set Claim.on_item attribute for all claims in this collection.""" + for claims in self.values(): + for claim in claims: + claim.on_item = item + class SiteLinkCollection(MutableMapping): """A structure holding SiteLinks for a Wikibase item.""" @@ -4439,6 +4445,10 @@ if 'pageid' in self._content: self._pageid = self._content['pageid'] + # xxx: this is ugly + if 'claims' in data: + self.claims.set_on_item(self) + return data @property @@ -5241,7 +5251,23 @@ self.qualifiers = OrderedDict() self.target = None self.snaktype = 'value' - self.on_item = None # The item it's on + self._on_item = None # The item it's on + + @property + def on_item(self): + """Return item this claim is attached to.""" + return self._on_item + + @on_item.setter + def on_item(self, item): + self._on_item = item + for values in self.qualifiers.values(): + for qualifier in values: + qualifier.on_item = item + for source in self.sources: + for values in source.values(): + for source in values: + source.on_item = item def __repr__(self): """Return the representation string.""" @@ -5577,6 +5603,7 @@ self.on_item.latest_revision_id = data['pageinfo']['lastrevid'] for claim in claims: claim.hash = data['reference']['hash'] + claim.on_item = self.on_item source = defaultdict(list) for claim in claims: claim.isReference = True @@ -5618,6 +5645,7 @@ if self.on_item is not None: data = self.repo.editQualifier(self, qualifier, **kwargs) self.on_item.latest_revision_id = data['pageinfo']['lastrevid'] + qualifier.on_item = self.on_item qualifier.isQualifier = True if qualifier.getID() in self.qualifiers: self.qualifiers[qualifier.getID()].append(qualifier) @@ -5644,6 +5672,7 @@ self.on_item.latest_revision_id = data['pageinfo']['lastrevid'] for qualifier in qualifiers: self.qualifiers[qualifier.getID()].remove(qualifier) + qualifier.on_item = None def target_equals(self, value): """ -- To view, visit https://gerrit.wikimedia.org/r/584131 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I29ed37b23f3883f48ab0abd510faa47bb3e3cb91 Gerrit-Change-Number: 584131 Gerrit-PatchSet: 2 Gerrit-Owner: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [bugfix] Fix scripts/login.py with clientlogin using "rememberMe"
by jenkins-bot (Code Review) 28 Mar '20

28 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/584116 ) Change subject: [bugfix] Fix scripts/login.py with clientlogin using "rememberMe" ...................................................................... [bugfix] Fix scripts/login.py with clientlogin using "rememberMe" scripts/login.py ends session after it finishes, which clears login credentials without rememberme cookie. With action=login, rememberme cookie was set automatically, but clientlogin needs to include "rememberMe" specifically in the API query. Change-Id: Ib1b84d8c6e8fea79feb4073265b4066f2d75222a --- M pywikibot/data/api.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index 207b3ab..917011a 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -3126,6 +3126,7 @@ if self.action == 'clientlogin': # clientlogin requires non-empty loginreturnurl parameters['loginreturnurl'] = 'https://example.com' + parameters['rememberMe'] = '1' # base login request login_request = self.site._request(use_get=False, -- To view, visit https://gerrit.wikimedia.org/r/584116 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib1b84d8c6e8fea79feb4073265b4066f2d75222a Gerrit-Change-Number: 584116 Gerrit-PatchSet: 6 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [doc] Update current release
by jenkins-bot (Code Review) 28 Mar '20

28 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/584108 ) Change subject: [doc] Update current release ...................................................................... [doc] Update current release Change-Id: I2fc20aaef2b7b79daba9c15bdaa4d376e82252e8 --- M docs/conf.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/docs/conf.py b/docs/conf.py index 96a494c..b54bfcd 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -71,7 +71,7 @@ # The short X.Y version. version = '3.0' # The full version, including alpha/beta/rc tags. -release = '3.0.20200306' +release = '3.0.20200326' # The language for content autogenerated by Sphinx. Refer to documentation # for a list of supported languages. -- To view, visit https://gerrit.wikimedia.org/r/584108 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2fc20aaef2b7b79daba9c15bdaa4d376e82252e8 Gerrit-Change-Number: 584108 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [bugfix] Fix errors produced by clientlogin
by jenkins-bot (Code Review) 28 Mar '20

28 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/584094 ) Change subject: [bugfix] Fix errors produced by clientlogin ...................................................................... [bugfix] Fix errors produced by clientlogin - clientlogin has different set of responses from login, which makes several assertions fail Change-Id: I41bdd6020cd32d22e15610e5973ec0a62683bc6a --- M pywikibot/login.py M tests/api_tests.py 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/login.py b/pywikibot/login.py index ef65e03..1b32a48 100644 --- a/pywikibot/login.py +++ b/pywikibot/login.py @@ -262,6 +262,7 @@ 'Illegal': 'is invalid', 'readapidenied': 'does not have read permissions', 'Failed': 'does not have read permissions', + 'FAIL': 'does not have read permissions', } def login(self, retry=False, autocreate=False): @@ -303,7 +304,7 @@ if error_code in self._api_error: error_msg = 'Username "{}" {} on {}'.format( self.login_name, self._api_error[error_code], self.site) - if error_code == 'Failed': + if error_code in ('Failed', 'FAIL'): error_msg += '\n.{}'.format(e.info) raise NoUsername(error_msg) diff --git a/tests/api_tests.py b/tests/api_tests.py index 11a2dc1..bd3b310 100644 --- a/tests/api_tests.py +++ b/tests/api_tests.py @@ -1026,7 +1026,10 @@ try: error.assert_called_with('Login failed (readapidenied).') except AssertionError: # MW version is older than 1.34.0-wmf.13 - error.assert_called_with('Login failed (Failed).') + try: + error.assert_called_with('Login failed (FAIL).') + except AssertionError: # MW version is older than 1.27 + error.assert_called_with('Login failed (Failed).') warning.assert_called_with( 'API error readapidenied: ' 'You need read permission to use this module.') -- To view, visit https://gerrit.wikimedia.org/r/584094 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I41bdd6020cd32d22e15610e5973ec0a62683bc6a Gerrit-Change-Number: 584094 Gerrit-PatchSet: 3 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [bugfix] Fix Python 2 bug in action=clientlogin
by jenkins-bot (Code Review) 28 Mar '20

28 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/584090 ) Change subject: [bugfix] Fix Python 2 bug in action=clientlogin ...................................................................... [bugfix] Fix Python 2 bug in action=clientlogin Change-Id: I2894680f25ec403800a1c48d9a5e61e5dcd57284 --- M pywikibot/data/api.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index 9d54333..207b3ab 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -3167,7 +3167,8 @@ or status == 'Failed' and 'wait' in fail_reason): match = re.search(r'(\d+) (seconds|minutes)', fail_reason) if match: - delta = datetime.timedelta(**{match[2]: int(match[1])}) + delta = datetime.timedelta( + **{match.group(2): int(match.group(1))}) wait = response.get('wait') if wait: delta = datetime.timedelta(seconds=int(wait)) -- To view, visit https://gerrit.wikimedia.org/r/584090 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2894680f25ec403800a1c48d9a5e61e5dcd57284 Gerrit-Change-Number: 584090 Gerrit-PatchSet: 3 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [bugfix] Fix bug in action=clientlogin
by jenkins-bot (Code Review) 27 Mar '20

27 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/584083 ) Change subject: [bugfix] Fix bug in action=clientlogin ...................................................................... [bugfix] Fix bug in action=clientlogin Change-Id: Ie844691acb35e8e923f6b4995f72c6b33b74e7ac --- M pywikibot/data/api.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index 3f85140..9d54333 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -3107,11 +3107,6 @@ below_mw_1_27 = self.site.mw_version < '1.27' - # prepare default login parameters - parameters = {'action': self.action, - self.keyword('user'): self.login_name, - self.keyword('password'): self.password} - if '@' in self.login_name or '@' in self.password or below_mw_1_27: # Since MW 1.27 only for bot passwords. # Bot passwords username contains @, @@ -3123,6 +3118,12 @@ # Standard login request since MW 1.27 self.action = 'clientlogin' + # prepare default login parameters + parameters = {'action': self.action, + self.keyword('user'): self.login_name, + self.keyword('password'): self.password} + + if self.action == 'clientlogin': # clientlogin requires non-empty loginreturnurl parameters['loginreturnurl'] = 'https://example.com' -- To view, visit https://gerrit.wikimedia.org/r/584083 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie844691acb35e8e923f6b4995f72c6b33b74e7ac Gerrit-Change-Number: 584083 Gerrit-PatchSet: 2 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [bugfix] Resolve action=login deprecation warning
by jenkins-bot (Code Review) 27 Mar '20

27 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/584017 ) Change subject: [bugfix] Resolve action=login deprecation warning ...................................................................... [bugfix] Resolve action=login deprecation warning - Use action=clientlogin if suitable - Map action=login parameters and responses keywords to action=clientlogin keywords - Handle new throttle responses Bug: T137805 Bug: T224712 Change-Id: I5004a1676e2309e90959e0b8d9a75f7a49392fb3 --- M pywikibot/data/api.py 1 file changed, 73 insertions(+), 21 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index 669c7c1..3f85140 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -3069,6 +3069,22 @@ """Supply getCookie() method to use API interface.""" + # API login parameters mapping + mapping = { + 'user': ('lgname', 'username'), + 'password': ('lgpassword', 'password'), + 'ldap': ('lgdomain', 'domain'), + 'token': ('lgtoken', 'logintoken'), + 'result': ('result', 'status'), + 'success': ('Success', 'PASS'), + 'reason': ('reason', 'message') + } + + def keyword(self, key): + """Get API keyword from mapping.""" + index = 0 if self.action == 'login' else 1 + return self.mapping[key][index] + @remove_last_args(arg_names=['remember, captchaId, captchaAnswer']) def getCookie(self): """Login to the site. @@ -3089,43 +3105,79 @@ .format(diff.seconds)) pywikibot.sleep(diff.seconds) + below_mw_1_27 = self.site.mw_version < '1.27' + + # prepare default login parameters + parameters = {'action': self.action, + self.keyword('user'): self.login_name, + self.keyword('password'): self.password} + + if '@' in self.login_name or '@' in self.password or below_mw_1_27: + # Since MW 1.27 only for bot passwords. + # Bot passwords username contains @, + # otherwise @ is not allowed in usernames. + # @ in bot password is deprecated, + # but we don't want to break bots using it. + self.action = 'login' + else: + # Standard login request since MW 1.27 + self.action = 'clientlogin' + + # clientlogin requires non-empty loginreturnurl + parameters['loginreturnurl'] = 'https://example.com' + # base login request - login_request = self.site._request( - use_get=False, - parameters={ - 'action': 'login', - 'lgname': self.login_name, - 'lgpassword': self.password, - }) + login_request = self.site._request(use_get=False, + parameters=parameters) if self.site.family.ldapDomain: - login_request['lgdomain'] = self.site.family.ldapDomain + login_request[self.keyword('ldap')] = self.site.family.ldapDomain # get token using meta=tokens if supported - if self.site.mw_version >= '1.27': - login_request['lgtoken'] = self.get_login_token() + if not below_mw_1_27: + login_request[self.keyword('token')] = self.get_login_token() self.site._loginstatus = -2 # IN_PROGRESS while True: + # try to login login_result = login_request.submit() - if 'login' not in login_result: - raise RuntimeError( - "API login response does not have 'login' key.") - if login_result['login']['result'] == 'Success': + + # clientlogin response can be clientlogin or error + if self.action in login_result: + response = login_result[self.action] + result_key = self.keyword('result') + elif 'error' in login_result: + response = login_result['error'] + result_key = 'code' + else: + raise RuntimeError('Unexpected API login response key.') + + status = response[result_key] + fail_reason = response.get(self.keyword('reason'), '') + if status == self.keyword('success'): return '' - elif login_result['login']['result'] == 'NeedToken': + elif status == 'NeedToken': # Kept for backwards compatibility - token = login_result['login']['token'] + token = response['token'] login_request['lgtoken'] = token continue - elif login_result['login']['result'] == 'Throttled': - self._waituntil = datetime.datetime.now() + datetime.timedelta( - seconds=int(login_result['login']['wait'])) + elif (status == 'Throttled' or status == 'FAIL' + and response['messagecode'] == 'login-throttled' + or status == 'Failed' and 'wait' in fail_reason): + match = re.search(r'(\d+) (seconds|minutes)', fail_reason) + if match: + delta = datetime.timedelta(**{match[2]: int(match[1])}) + wait = response.get('wait') + if wait: + delta = datetime.timedelta(seconds=int(wait)) + self._waituntil = datetime.datetime.now() + delta break else: break - info = login_result['login'].get('reason', '') - raise APIError(code=login_result['login']['result'], info=info) + if 'error' in login_result: + raise APIError(**response) + info = fail_reason + raise APIError(code=status, info=info) def storecookiedata(self, data): """Ignore data; cookies are set by threadedhttp module.""" -- To view, visit https://gerrit.wikimedia.org/r/584017 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5004a1676e2309e90959e0b8d9a75f7a49392fb3 Gerrit-Change-Number: 584017 Gerrit-PatchSet: 7 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [doc] Add a note about site and page move
by jenkins-bot (Code Review) 27 Mar '20

27 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/584014 ) Change subject: [doc] Add a note about site and page move ...................................................................... [doc] Add a note about site and page move Change-Id: I081478ba6b33021e4201e209b3e801ca9217f2d2 --- M HISTORY.rst 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/HISTORY.rst b/HISTORY.rst index d17e43b..c6f2898 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -4,6 +4,12 @@ Current release --------------- +* Bugfixes and improvements +* Localisation updates + +3.0.20200326 +------------ +* site.py and page.py files were moved to their own folders and will be split in the future * Refactor data attributes of Wikibase entities (T233406) * Functions dealing with stars list are desupported and may be removed * Use path's stem of script filename within pwb.py wrapper (T248372) -- To view, visit https://gerrit.wikimedia.org/r/584014 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I081478ba6b33021e4201e209b3e801ca9217f2d2 Gerrit-Change-Number: 584014 Gerrit-PatchSet: 2 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [IMPR] Add code aliases to langs
by jenkins-bot (Code Review) 26 Mar '20

26 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/583737 ) Change subject: [IMPR] Add code aliases to langs ...................................................................... [IMPR] Add code aliases to langs - fix generate_family_files for aliases + add wikimaniateam + use SubdomainFamily super for Wikimania family Bug: T248608 Change-Id: Ibddcbffde22bde48661a777a0d7a463acc98e51f --- M pywikibot/families/wikimania_family.py M pywikibot/family.py 2 files changed, 18 insertions(+), 9 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/families/wikimania_family.py b/pywikibot/families/wikimania_family.py index 881e57e..9651f77 100644 --- a/pywikibot/families/wikimania_family.py +++ b/pywikibot/families/wikimania_family.py @@ -23,7 +23,7 @@ '2014', '2015', '2016', '2017', '2018' ] - codes = ['wikimania'] + codes = ['wikimania', 'team'] code_aliases = {'2019': 'wikimania'} @@ -32,10 +32,8 @@ @classproperty def langs(cls): """Property listing family languages.""" - codes = cls.codes + cls.closed_wikis - - # shortcut this classproperty - cls.langs = {code: '{}{}.{}'.format(cls.name, code, cls.domain) - for code in codes if code != 'wikimania'} - cls.langs['wikimania'] = 'wikimania.{}'.format(cls.domain) + cls.langs = super(Family, cls).langs + for lang, url in cls.langs.items(): + if not url.startswith(cls.name): + cls.langs[lang] = cls.name + url return cls.langs diff --git a/pywikibot/family.py b/pywikibot/family.py index 43e5e65..bea8eaf 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -36,8 +36,9 @@ logger = logging.getLogger('pywiki.wiki.family') # Legal characters for Family.name and Family.langs keys +# nl_nds code alias requires "_" NAME_CHARACTERS = string.ascii_letters + string.digits -CODE_CHARACTERS = string.ascii_lowercase + string.digits + '-' +CODE_CHARACTERS = string.ascii_lowercase + string.digits + '-_' class Family(object): @@ -1568,6 +1569,11 @@ # shortcut this classproperty cls.langs = {code: '{0}.{1}'.format(code, cls.domain) for code in codes} + + if hasattr(cls, 'code_aliases'): + cls.langs.update({alias: '{0}.{1}'.format(code, cls.domain) + for alias, code in cls.code_aliases.items()}) + return cls.langs @classproperty @@ -1597,7 +1603,12 @@ @classproperty def langs(cls): """Property listing family languages.""" - return {code: cls.domain for code in cls.codes} + codes = cls.codes + + if hasattr(cls, 'code_aliases'): + codes += tuple(cls.code_aliases.keys()) + + return {code: cls.domain for code in codes} def protocol(self, code): """Return 'https' as the protocol.""" -- To view, visit https://gerrit.wikimedia.org/r/583737 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibddcbffde22bde48661a777a0d7a463acc98e51f Gerrit-Change-Number: 583737 Gerrit-PatchSet: 6 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [doc] Fix doc warnings introduced today
by jenkins-bot (Code Review) 26 Mar '20

26 Mar '20

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/583753 ) Change subject: [doc] Fix doc warnings introduced today ...................................................................... [doc] Fix doc warnings introduced today Change-Id: Ie0e430ff319dc07de272cd2e1d1af92d53e78e4f --- M pywikibot/page/__init__.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py index 928a2c1..4704b67 100644 --- a/pywikibot/page/__init__.py +++ b/pywikibot/page/__init__.py @@ -3897,7 +3897,7 @@ @param key: site key as Site instance or db key @type key: pywikibot.Site or str - @rtype: SiteLink + @rtype: pywikibot.page.SiteLink """ key = self.getdbName(key) return self._data[key] @@ -3910,7 +3910,7 @@ @type key: pywikibot.Site or str @param val: page name as a string or JSON containing SiteLink data @type val: dict or str - @rtype: SiteLink + @rtype: pywikibot.page.SiteLink """ if isinstance(val, UnicodeType): val = SiteLink(val, key) -- To view, visit https://gerrit.wikimedia.org/r/583753 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie0e430ff319dc07de272cd2e1d1af92d53e78e4f Gerrit-Change-Number: 583753 Gerrit-PatchSet: 3 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits March 2020