jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/487114 )
Change subject: [tests] Skip site_tests.TestUserContribsWithoutUser for wikia
......................................................................
[tests] Skip site_tests.TestUserContribsWithoutUser for wikia
Wikia does not support ucuserprefix for API:Usercontribs even though
Wikia has version 1.19.24 and userprefix was introduced with 1.13.
Skip this tests for Wikia until the underlying problem is solved
to focus on all other tests.
Bug: T214263
Change-Id: Id387363b6e091940cc93be1b401f951be15f66ad
---
M tests/site_tests.py
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Framawiki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index 6f6dc77..78a7aff 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1686,6 +1686,16 @@
"""Test site method site.usercontribs() without bot user."""
+ @classmethod
+ def setUpClass(cls):
+ """Skip tests for wikia (T214263)."""
+ super(TestUserContribsWithoutUser, cls).setUpClass()
+ mysite = cls.get_site()
+ if mysite.sitename == 'wikia:wikia':
+ raise unittest.SkipTest(
+ 'Skipping site_tests.TestUserContribsWithoutUser tests for '
+ 'Wikia due to T214263')
+
def test_user_prefix(self):
"""Test the site.usercontribs() method with userprefix."""
mysite = self.get_site()
--
To view, visit https://gerrit.wikimedia.org/r/487114
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id387363b6e091940cc93be1b401f951be15f66ad
Gerrit-Change-Number: 487114
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot (75)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/487648 )
Change subject: [cleanup] Move the initializer on top of the class
......................................................................
[cleanup] Move the initializer on top of the class
Change-Id: If60f27f06d3311e6830cfbb2a3b12d2631022c08
---
M scripts/unlink.py
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/unlink.py b/scripts/unlink.py
index 00fcaf6..4597d08 100755
--- a/scripts/unlink.py
+++ b/scripts/unlink.py
@@ -21,7 +21,7 @@
descriptions.
"""
#
-# (C) Pywikibot team, 2007-2018
+# (C) Pywikibot team, 2007-2019
#
# Distributed under the terms of the MIT license.
#
@@ -38,11 +38,6 @@
summary_key = 'unlink-unlinking'
- @property
- def summary_parameters(self):
- """Return the title parameter."""
- return {'title': self.pageToUnlink.title()}
-
def __init__(self, pageToUnlink, **kwargs):
"""Initialize a UnlinkBot instance with the given page to unlink."""
super(UnlinkBot, self).__init__(**kwargs)
@@ -50,6 +45,11 @@
self.generator = pageToUnlink.getReferences(
namespaces=self.getOption('namespaces'), content=True)
+ @property
+ def summary_parameters(self):
+ """Return the title parameter."""
+ return {'title': self.pageToUnlink.title()}
+
def treat_page(self):
"""Remove links pointing to the configured page from the given page."""
self.unlink(self.pageToUnlink)
--
To view, visit https://gerrit.wikimedia.org/r/487648
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If60f27f06d3311e6830cfbb2a3b12d2631022c08
Gerrit-Change-Number: 487648
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <alangiderick(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/487657 )
Change subject: [tests] Test for UnknownExtension if 'Linter' is not available
......................................................................
[tests] Test for UnknownExtension if 'Linter' is not available
test for UnknownExtension if 'Linter' extension is not available
for a given site inside TestFactoryGenerator.test_linter_generator_show()
test method.
Bug: T215124
Change-Id: I92d3c4b013639948df6af04da50f2beaa6d0fbcf
---
M tests/pagegenerators_tests.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 72f4673..a32debf 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1220,9 +1220,12 @@
def test_linter_generator_show(self):
"""Test generator of pages with lint errors."""
gf = pagegenerators.GeneratorFactory(site=self.site)
- with self.assertRaises(SystemExit) as cm:
- gf.handleArg('-linter:show')
- self.assertEqual(cm.exception.code, 0)
+ if self.site.has_extension('Linter'):
+ with self.assertRaises(SystemExit) as cm:
+ gf.handleArg('-linter:show')
+ self.assertEqual(cm.exception.code, 0)
+ else:
+ self.assertRaises(UnknownExtension, gf.handleArg, '-linter:show')
def test_querypage_generator_with_valid_page(self):
"""Test generator of pages with lint errors."""
--
To view, visit https://gerrit.wikimedia.org/r/487657
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I92d3c4b013639948df6af04da50f2beaa6d0fbcf
Gerrit-Change-Number: 487657
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/487630 )
Change subject: pagegenerators.py: fix tests in PY2 for -querypage
......................................................................
pagegenerators.py: fix tests in PY2 for -querypage
Bug: T214234
Change-Id: I0f09ff13c760e506081521e9dfacb20a5adeb9f3
---
M pywikibot/pagegenerators.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index d735c1f..f342683 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -59,6 +59,9 @@
if sys.version_info[0] > 2:
basestring = (str, )
+ from itertools import zip_longest
+else:
+ from itertools import izip_longest as zip_longest
_logger = 'pagegenerators'
@@ -754,8 +757,7 @@
max_w = max(len(p) for p in pages[::2]) + 4
txt = 'Available special pages:\n'
- for a, b in itertools.zip_longest(pages[::2], pages[1::2],
- fillvalue=''):
+ for a, b in zip_longest(pages[::2], pages[1::2], fillvalue=''):
txt += ' {a:<{max_w}}{b}\n'.format(a=a, b=b, max_w=max_w)
txt += ('\nMaximum number of pages to return is {max} '
'({highmax} for bots).\n'.format(**limit))
--
To view, visit https://gerrit.wikimedia.org/r/487630
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f09ff13c760e506081521e9dfacb20a5adeb9f3
Gerrit-Change-Number: 487630
Gerrit-PatchSet: 1
Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot (75)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/487582 )
Change subject: [IMPR] Minor improvements of lonelypages.py script
......................................................................
[IMPR] Minor improvements of lonelypages.py script
1. Fixed typos in code
2. Removed params xml, page, limit from documentation because they are
already included by pagegenerators
Bug: T201491
Bug: T215102
Change-Id: I43dae94fe6a84ee35daa957f536b735863f926f1
---
M scripts/lonelypages.py
1 file changed, 2 insertions(+), 12 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/lonelypages.py b/scripts/lonelypages.py
index e46b311..df30892 100755
--- a/scripts/lonelypages.py
+++ b/scripts/lonelypages.py
@@ -7,14 +7,6 @@
¶ms;
--xml Retrieve information from a local XML dump (pages-articles
- or pages-meta-current, see https://dumps.wikimedia.org).
- Argument can also be given as "-xml:filename".
-
--page Only edit a specific page.
- Argument can also be given as "-page:pagetitle". You can
- give this parameter multiple times to edit multiple pages.
-
Furthermore, the following command line parameters are supported:
-enable: Enable or disable the bot via a Wiki Page.
@@ -22,8 +14,6 @@
-disambig: Set a page where the bot saves the name of the disambig
pages found (default: skip the pages)
--limit: Set how many pages check.
-
-always Always say yes, won't ask
@@ -143,7 +133,7 @@
try:
self.disambigtext = self.disambigpage.get()
except pywikibot.NoPage:
- pywikibot.output("{0} doesn't esist, skip!"
+ pywikibot.output("{0} doesn't exist, skip!"
.format(self.disambigpage.title()))
self.disambigtext = ''
except pywikibot.IsRedirectPage:
@@ -164,7 +154,7 @@
getenable = enable.get()
except pywikibot.NoPage:
pywikibot.output(
- "{0} doesn't esist, I use the page as if it was blank!"
+ "{0} doesn't exist, I use the page as if it was blank!"
.format(enable.title()))
getenable = ''
except pywikibot.IsRedirectPage:
--
To view, visit https://gerrit.wikimedia.org/r/487582
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I43dae94fe6a84ee35daa957f536b735863f926f1
Gerrit-Change-Number: 487582
Gerrit-PatchSet: 5
Gerrit-Owner: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: D3r1ck01 <alangiderick(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)