jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/548715 )
Change subject: [IMPR] Use functools.wraps to fix wrapper name
......................................................................
[IMPR] Use functools.wraps to fix wrapper name
Change-Id: Iedca2ce8e12bd68f509973bc6f2e071b22eef95c
---
M tests/utils.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/utils.py b/tests/utils.py
index f11edd3..76b4091 100644
--- a/tests/utils.py
+++ b/tests/utils.py
@@ -7,6 +7,7 @@
#
from __future__ import absolute_import, division, unicode_literals
+from functools import wraps
import inspect
import json
import os
@@ -84,6 +85,7 @@
This decorator runs the test and, if it is a failure, reports the result
and considers it a skipped test.
"""
+ @wraps(func)
def wrapper(*args, **kwargs):
try:
func(*args, **kwargs)
@@ -98,7 +100,6 @@
except Exception:
pywikibot.exception(tb=True)
raise unittest.SkipTest('Test is allowed to fail.')
- wrapper.__name__ = func.__name__
if PY2:
return unittest.expectedFailure(func)
--
To view, visit https://gerrit.wikimedia.org/r/548715
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedca2ce8e12bd68f509973bc6f2e071b22eef95c
Gerrit-Change-Number: 548715
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot (75)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/538724 )
Change subject: Make sure the user is logged in before attempting a delete
......................................................................
Make sure the user is logged in before attempting a delete
When BotPasswords is used, even if you have already run the login.py
script, you will still end up logged out when you run the delete.py
script later. This patch provides a workaround so that delete.py remains
usable while we revamp the BotPasswords related processes to make the
login session info persistant.
Bug: T233608
Change-Id: Ib3bc9005ab58ff19ce14acf9df4127a7d32eb746
---
M scripts/delete.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/delete.py b/scripts/delete.py
index 18cbec7..b291e5a 100755
--- a/scripts/delete.py
+++ b/scripts/delete.py
@@ -214,6 +214,8 @@
self.current_page, ns_names))
return # Not an orphan, do not delete.
+ if self.site.user() is None:
+ self.site.login()
self.current_page.delete(self.summary,
not self.getOption('always'),
self.getOption('always'),
--
To view, visit https://gerrit.wikimedia.org/r/538724
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3bc9005ab58ff19ce14acf9df4127a7d32eb746
Gerrit-Change-Number: 538724
Gerrit-PatchSet: 5
Gerrit-Owner: Huji <huji.huji(a)gmail.com>
Gerrit-Reviewer: Huji <huji.huji(a)gmail.com>
Gerrit-Reviewer: Revi <wiki(a)ymhong.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot (75)