Pywikibot-commits January 2019

pywikibot-commits@lists.wikimedia.org

1 participants
45 discussions

[Gerrit] pywikibot/core[master]: [tests] Test default -chunked value in uploadscript_tests
by jenkins-bot (Code Review) 06 Jan '19

06 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482480 ) Change subject: [tests] Test default -chunked value in uploadscript_tests ...................................................................... [tests] Test default -chunked value in uploadscript_tests Change-Id: I81798ec0d84dcb9907cd135657340b090c1c0b78 --- M tests/uploadscript_tests.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Framawiki: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/uploadscript_tests.py b/tests/uploadscript_tests.py index e67b384..0804039 100644 --- a/tests/uploadscript_tests.py +++ b/tests/uploadscript_tests.py @@ -18,7 +18,7 @@ net = False - def match(self, value): + def match(self, value=''): """Create a match object and call get_chunk_site. @param value: a chunk size value @@ -26,12 +26,15 @@ @return: chunk size in bytes @rtype: int """ - option = '-chunked:' + value + option = '-chunked' + if value: + option += ':' + value match = CHUNK_SIZE_REGEX.match(option) return get_chunk_size(match) def test_regex(self): """Test CHUNK_SIZE_REGEX and get_chunk_size function.""" + self.assertEqual(self.match(), 1024 ** 2) self.assertEqual(self.match('12345'), 12345) self.assertEqual(self.match('4567k'), 4567 * 1000) self.assertEqual(self.match('7890m'), 7890 * 10 ** 6) -- To view, visit https://gerrit.wikimedia.org/r/482480 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I81798ec0d84dcb9907cd135657340b090c1c0b78 Gerrit-Change-Number: 482480 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [tests] Remove some code duplication for user_tests.py
by jenkins-bot (Code Review) 05 Jan '19

05 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482417 ) Change subject: [tests] Remove some code duplication for user_tests.py ...................................................................... [tests] Remove some code duplication for user_tests.py Change-Id: Id66eb7bc0820c73d5a214312fd4adc83a7e548f4 --- M tests/user_tests.py 1 file changed, 30 insertions(+), 42 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/user_tests.py b/tests/user_tests.py index b0732be..12246eb 100644 --- a/tests/user_tests.py +++ b/tests/user_tests.py @@ -24,6 +24,36 @@ family = 'wikipedia' code = 'de' + def _tests_unregistered_user(self, user, prop='invalid'): + """Proceed user tests.""" + with suppress_warnings('pywikibot.page.User.name', DeprecationWarning): + self.assertEqual(user.name(), user.username) + self.assertEqual(user.title(with_ns=False), user.username) + self.assertFalse(user.isRegistered()) + self.assertIsNone(user.registration()) + self.assertFalse(user.isEmailable()) + self.assertEqual(user.gender(), 'unknown') + self.assertFalse(user.is_thankable) + self.assertIn(prop, user.getprops()) + + def test_anonymous_user(self): + """Test registered user.""" + user = User(self.site, '123.45.67.89') + self._tests_unregistered_user(user) + self.assertTrue(user.isAnonymous()) + + def test_unregistered_user(self): + """Test unregistered user.""" + user = User(self.site, 'This user name is not registered yet') + self._tests_unregistered_user(user, prop='missing') + self.assertFalse(user.isAnonymous()) + + def test_invalid_user(self): + """Test invalid user.""" + user = User(self.site, 'Invalid char\x9f in Name') + self._tests_unregistered_user(user) + self.assertFalse(user.isAnonymous()) + def test_registered_user(self): """Test registered user.""" user = User(self.site, 'Xqt') @@ -82,48 +112,6 @@ self.assertIn('userid', user.getprops()) self.assertTrue(user.is_thankable) - def test_anonymous_user(self): - """Test registered user.""" - user = User(self.site, '123.45.67.89') - with suppress_warnings('pywikibot.page.User.name', DeprecationWarning): - self.assertEqual(user.name(), user.username) - self.assertEqual(user.title(with_ns=False), user.username) - self.assertFalse(user.isRegistered()) - self.assertTrue(user.isAnonymous()) - self.assertIsNone(user.registration()) - self.assertFalse(user.isEmailable()) - self.assertEqual(user.gender(), 'unknown') - self.assertIn('invalid', user.getprops()) - self.assertFalse(user.is_thankable) - - def test_unregistered_user(self): - """Test unregistered user.""" - user = User(self.site, 'This user name is not registered yet') - with suppress_warnings('pywikibot.page.User.name', DeprecationWarning): - self.assertEqual(user.name(), user.username) - self.assertEqual(user.title(with_ns=False), user.username) - self.assertFalse(user.isRegistered()) - self.assertFalse(user.isAnonymous()) - self.assertIsNone(user.registration()) - self.assertFalse(user.isEmailable()) - self.assertEqual(user.gender(), 'unknown') - self.assertIn('missing', user.getprops()) - self.assertFalse(user.is_thankable) - - def test_invalid_user(self): - """Test invalid user.""" - user = User(self.site, 'Invalid char\x9f in Name') - with suppress_warnings('pywikibot.page.User.name', DeprecationWarning): - self.assertEqual(user.name(), user.username) - self.assertEqual(user.title(with_ns=False), user.username) - self.assertFalse(user.isRegistered()) - self.assertFalse(user.isAnonymous()) - self.assertIsNone(user.registration()) - self.assertFalse(user.isEmailable()) - self.assertEqual(user.gender(), 'unknown') - self.assertIn('invalid', user.getprops()) - self.assertFalse(user.is_thankable) - def test_bot_user(self): """Test bot user.""" user = User(self.site, 'Xqbot') -- To view, visit https://gerrit.wikimedia.org/r/482417 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id66eb7bc0820c73d5a214312fd4adc83a7e548f4 Gerrit-Change-Number: 482417 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: Revert "[bugfix] import MWSite in generate_family_file.py for tests"
by jenkins-bot (Code Review) 05 Jan '19

05 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482419 ) Change subject: Revert "[bugfix] import MWSite in generate_family_file.py for tests" ...................................................................... Revert "[bugfix] import MWSite in generate_family_file.py for tests" pwb_tests and script_tests are failing. This reverts commit 4cd790567da33ebd29a21f24b8ce43b33e733acb. Bug: T212988 Change-Id: I0d8e50ed65f6c95e2a2801ff9fb3397b780b1913 --- M generate_family_file.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/generate_family_file.py b/generate_family_file.py index 4e6ff98..a73e3ec 100755 --- a/generate_family_file.py +++ b/generate_family_file.py @@ -3,7 +3,7 @@ """This script generates a family file from a given URL.""" # # (C) Merlijn van Deen, 2010-2013 -# (C) Pywikibot team, 2010-2019 +# (C) Pywikibot team, 2010-2018 # # Distributed under the terms of the MIT license # @@ -224,6 +224,3 @@ sep=os.sep)) FamilyFileGenerator(*sys.argv[1:]).run() -else: - # for testing purposes - from pywikibot.site_detect import MWSite as Wiki # noqa: E402 -- To view, visit https://gerrit.wikimedia.org/r/482419 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0d8e50ed65f6c95e2a2801ff9fb3397b780b1913 Gerrit-Change-Number: 482419 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [bugfix] import MWSite in generate_family_file.py for tests
by jenkins-bot (Code Review) 05 Jan '19

05 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482407 ) Change subject: [bugfix] import MWSite in generate_family_file.py for tests ...................................................................... [bugfix] import MWSite in generate_family_file.py for tests Bug: T212998 Change-Id: Ib5cac9f2fda20ace52cbdfef1488e386dab25873 --- M generate_family_file.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Framawiki: Looks good to me, approved jenkins-bot: Verified diff --git a/generate_family_file.py b/generate_family_file.py index a73e3ec..4e6ff98 100755 --- a/generate_family_file.py +++ b/generate_family_file.py @@ -3,7 +3,7 @@ """This script generates a family file from a given URL.""" # # (C) Merlijn van Deen, 2010-2013 -# (C) Pywikibot team, 2010-2018 +# (C) Pywikibot team, 2010-2019 # # Distributed under the terms of the MIT license # @@ -224,3 +224,6 @@ sep=os.sep)) FamilyFileGenerator(*sys.argv[1:]).run() +else: + # for testing purposes + from pywikibot.site_detect import MWSite as Wiki # noqa: E402 -- To view, visit https://gerrit.wikimedia.org/r/482407 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib5cac9f2fda20ace52cbdfef1488e386dab25873 Gerrit-Change-Number: 482407 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [tests] New uploadscript_tests
by jenkins-bot (Code Review) 05 Jan '19

05 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482404 ) Change subject: [tests] New uploadscript_tests ...................................................................... [tests] New uploadscript_tests - make chunk_size_regex a global const to be imported by the test - test the upload.get_chunk_size function and it's regex Change-Id: Id9438b641288fd69088415fa48822a6f52186178 --- M scripts/upload.py A tests/uploadscript_tests.py 2 files changed, 53 insertions(+), 4 deletions(-) Approvals: Framawiki: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/upload.py b/scripts/upload.py index 3750bb2..b5396b9 100755 --- a/scripts/upload.py +++ b/scripts/upload.py @@ -52,7 +52,7 @@ """ # # (C) Rob W.W. Hooft, Andre Engels 2003-2004 -# (C) Pywikibot team, 2003-2018 +# (C) Pywikibot team, 2003-2019 # # Distributed under the terms of the MIT license. # @@ -68,6 +68,10 @@ from pywikibot.specialbots import UploadRobot +CHUNK_SIZE_REGEX = re.compile( + r'^-chunked(?::(\d+(?:\.\d+)?)[ \t]*(k|ki|m|mi)?b?)?$', re.I) + + def get_chunk_size(match): """Get chunk size.""" if not match: @@ -113,8 +117,6 @@ aborts = set() ignorewarn = set() chunk_size = 0 - chunk_size_regex = re.compile( - r'^-chunked(?::(\d+(?:\.\d+)?)[ \t]*(k|ki|m|mi)?b?)?$', re.I) recursive = False description_file = None @@ -150,7 +152,7 @@ else: ignorewarn = True elif arg == '-chunked': - match = chunk_size_regex.match(option) + match = CHUNK_SIZE_REGEX.match(option) chunk_size = get_chunk_size(match) elif arg == '-descfile': description_file = value diff --git a/tests/uploadscript_tests.py b/tests/uploadscript_tests.py new file mode 100644 index 0000000..e67b384 --- /dev/null +++ b/tests/uploadscript_tests.py @@ -0,0 +1,47 @@ +# -*- coding: utf-8 -*- +"""upload.py script test.""" +# +# (C) Pywikibot team, 2019 +# +# Distributed under the terms of the MIT license. +# +from __future__ import absolute_import, division, unicode_literals + +from scripts.upload import CHUNK_SIZE_REGEX, get_chunk_size + +from tests.aspects import unittest, TestCase + + +class TestUploadScript(TestCase): + + """Test cases for upload.""" + + net = False + + def match(self, value): + """Create a match object and call get_chunk_site. + + @param value: a chunk size value + @type value: str + @return: chunk size in bytes + @rtype: int + """ + option = '-chunked:' + value + match = CHUNK_SIZE_REGEX.match(option) + return get_chunk_size(match) + + def test_regex(self): + """Test CHUNK_SIZE_REGEX and get_chunk_size function.""" + self.assertEqual(self.match('12345'), 12345) + self.assertEqual(self.match('4567k'), 4567 * 1000) + self.assertEqual(self.match('7890m'), 7890 * 10 ** 6) + self.assertEqual(self.match('987ki'), 987 * 1024) + self.assertEqual(self.match('654mi'), 654 * 1024 ** 2) + self.assertEqual(self.match('3mike'), 0) + + +if __name__ == '__main__': # pragma: no cover + try: + unittest.main() + except SystemExit: + pass -- To view, visit https://gerrit.wikimedia.org/r/482404 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id9438b641288fd69088415fa48822a6f52186178 Gerrit-Change-Number: 482404 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <alangiderick(a)gmail.com> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [doc] Update HISTORY.rst
by jenkins-bot (Code Review) 05 Jan '19

05 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482414 ) Change subject: [doc] Update HISTORY.rst ...................................................................... [doc] Update HISTORY.rst Change-Id: Ieb18d2c9d013015158ea5c314071702e492bd3e5 --- M HISTORY.rst 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Framawiki: Looks good to me, approved jenkins-bot: Verified diff --git a/HISTORY.rst b/HISTORY.rst index d4e587c..1aa881d 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -4,6 +4,7 @@ Current release --------------- +* Ensure "modules" parameter of ParamInfo._fetch is a set (T122763) * Support adding new claims with qualifiers and/or references (T112577, T170432) * Support LZMA and XZ compression formats * Update correct-ar Typo corrections in fixes.py (T211492) -- To view, visit https://gerrit.wikimedia.org/r/482414 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ieb18d2c9d013015158ea5c314071702e492bd3e5 Gerrit-Change-Number: 482414 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [test] test UploadRobot directly from library
by jenkins-bot (Code Review) 05 Jan '19

05 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482402 ) Change subject: [test] test UploadRobot directly from library ...................................................................... [test] test UploadRobot directly from library - Instead of loading the UploadRobot via script, import it from specialbots directly for tests purposed - use a params dict for creating the bot - remove default parameter keys Change-Id: Ie366dccabde17cd5e5be0aecf1ff65d42f9f6cd2 --- M tests/uploadbot_tests.py 1 file changed, 16 insertions(+), 20 deletions(-) Approvals: Framawiki: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/uploadbot_tests.py b/tests/uploadbot_tests.py index 37c96f8..f3e9861 100644 --- a/tests/uploadbot_tests.py +++ b/tests/uploadbot_tests.py @@ -5,7 +5,7 @@ These tests write to the wiki. """ # -# (C) Pywikibot team, 2014-2018 +# (C) Pywikibot team, 2014-2019 # # Distributed under the terms of the MIT license. # @@ -13,7 +13,7 @@ import os -from scripts import upload +from pywikibot.specialbots import UploadRobot from tests import join_images_path from tests.aspects import unittest, TestCase @@ -28,40 +28,36 @@ family = 'wikipedia' code = 'test' + params = dict( # noqa: C408 + description='pywikibot upload.py script test', + keepFilename=True, + aborts=set(), + ignoreWarning=True, + ) + def test_png_list(self): """Test uploading a list of pngs using upload.py.""" image_list = [] for directory_info in os.walk(join_images_path()): for dir_file in directory_info[2]: image_list.append(os.path.join(directory_info[0], dir_file)) - bot = upload.UploadRobot(url=image_list, - description='pywikibot upload.py script test', - useFilename=None, keepFilename=True, - verifyDescription=True, aborts=set(), - ignoreWarning=True, - targetSite=self.get_site()) + bot = UploadRobot(url=image_list, targetSite=self.get_site(), + **self.params) bot.run() def test_png(self): """Test uploading a png using upload.py.""" - bot = upload.UploadRobot(url=[join_images_path('MP_sounds.png')], - description='pywikibot upload.py script test', - useFilename=None, keepFilename=True, - verifyDescription=True, aborts=set(), - ignoreWarning=True, - targetSite=self.get_site()) + bot = UploadRobot( + url=[join_images_path('MP_sounds.png')], + targetSite=self.get_site(), **self.params) bot.run() def test_png_url(self): """Test uploading a png from url using upload.py.""" link = 'https://upload.wikimedia.org/' link += 'wikipedia/commons/f/fc/MP_sounds.png' - bot = upload.UploadRobot( - url=[link], - description='pywikibot upload.py script test', - useFilename=None, keepFilename=True, - verifyDescription=True, aborts=set(), - ignoreWarning=True, targetSite=self.get_site()) + bot = UploadRobot(url=[link], targetSite=self.get_site(), + **self.params) bot.run() -- To view, visit https://gerrit.wikimedia.org/r/482402 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie366dccabde17cd5e5be0aecf1ff65d42f9f6cd2 Gerrit-Change-Number: 482402 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [cleanup] Remove handling of old -dry parameter
by jenkins-bot (Code Review) 05 Jan '19

05 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/462144 ) Change subject: [cleanup] Remove handling of old -dry parameter ...................................................................... [cleanup] Remove handling of old -dry parameter Bug: T205190 Change-Id: If18b60a417059b654917b1bb774e952075916970 --- M scripts/basic.py 1 file changed, 0 insertions(+), 30 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/basic.py b/scripts/basic.py index e5cd63d..282c2e7 100755 --- a/scripts/basic.py +++ b/scripts/basic.py @@ -36,7 +36,6 @@ from pywikibot.bot import ( SingleSiteBot, ExistingPageBot, NoRedirectPageBot, AutomaticTWSummaryBot) -from pywikibot.tools import issue_deprecation_warning # This is required for the text that is shown when you run this script # with the parameter -help. @@ -88,38 +87,9 @@ # call initializer of the super class super(BasicBot, self).__init__(site=True, **kwargs) - # handle old -dry parameter - self._handle_dry_param(**kwargs) - # assign the generator to the bot self.generator = generator - def _handle_dry_param(self, **kwargs): - """ - Read the dry parameter and set the simulate variable instead. - - This is a private method. It prints a deprecation warning for old - -dry paramter and sets the global simulate variable and informs - the user about this setting. - - The constuctor of the super class ignores it because it is not - part of self.availableOptions. - - @note: You should ommit this method in your own application. - - @keyword dry: deprecated option to prevent changes on live wiki. - Use -simulate instead. - @type dry: bool - """ - if 'dry' in kwargs: - issue_deprecation_warning('dry argument', - 'pywikibot.config.simulate', 1, - warning_class=FutureWarning, - since='20160124') - # use simulate variable instead - pywikibot.config.simulate = True - pywikibot.output('config.simulate was set to True') - def treat_page(self): """Load the given page, do some changes, and save it.""" text = self.current_page.text -- To view, visit https://gerrit.wikimedia.org/r/462144 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If18b60a417059b654917b1bb774e952075916970 Gerrit-Change-Number: 462144 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [fix] Fix spelling mistake
by jenkins-bot (Code Review) 05 Jan '19

05 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482406 ) Change subject: [fix] Fix spelling mistake ...................................................................... [fix] Fix spelling mistake Change-Id: I995e7302bb1387cef9e954d2fd0c7f21b3928ee7 --- M tests/generate_family_files_tests.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/generate_family_files_tests.py b/tests/generate_family_files_tests.py index 2c9ba7c..84d3f20 100644 --- a/tests/generate_family_files_tests.py +++ b/tests/generate_family_files_tests.py @@ -1,7 +1,7 @@ # -*- coding: utf-8 -*- """Test generate_family_files script.""" # -# (C) Pywikibot team, 2018 +# (C) Pywikibot team, 2018-2019 # # Distributed under the terms of the MIT license. # @@ -43,7 +43,7 @@ self.generator_instance = FamilyTestGenerator( url=self.site.base_url(''), name='gff-test', dointerwiki='y') - def test_initial_attibutes(self): + def test_initial_attributes(self): """Test inital FamilyFileGenerator attributes.""" self.assertEqual(self.generator_instance.base_url, self.site.base_url('')) @@ -53,7 +53,7 @@ self.assertIsInstance(self.generator_instance.langs, list) @unittest.expectedFailure # T194138 - def test_attibutes_after_run(self): + def test_attributes_after_run(self): """Test FamilyFileGenerator attributes after run().""" self.generator_instance.run() langs = [self.site.lang] + self.generator_instance.prefixes -- To view, visit https://gerrit.wikimedia.org/r/482406 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I995e7302bb1387cef9e954d2fd0c7f21b3928ee7 Gerrit-Change-Number: 482406 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

[Gerrit] pywikibot/core[master]: [bugfix] Fix doc warnings introduced in a5c9ce93
by jenkins-bot (Code Review) 04 Jan '19

04 Jan '19

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/482313 ) Change subject: [bugfix] Fix doc warnings introduced in a5c9ce93 ...................................................................... [bugfix] Fix doc warnings introduced in a5c9ce93 Change-Id: Ic4c21cf033a04221103cc3645de2eeba3244fe77 --- M scripts/touch.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: JJMC89: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/touch.py b/scripts/touch.py index 24f5605..edd69f8 100755 --- a/scripts/touch.py +++ b/scripts/touch.py @@ -13,9 +13,11 @@ -purge Do not touch but purge the page Touch arguments: + -botflag Force botflag in case of edits with changes. Purge arguments: + -converttitles Convert titles to other variants if necessary -forcelinkupdate Update the links tables -forcerecursivelinkupdate Update the links table, and update the links tables -- To view, visit https://gerrit.wikimedia.org/r/482313 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic4c21cf033a04221103cc3645de2eeba3244fe77 Gerrit-Change-Number: 482313 Gerrit-PatchSet: 2 Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: D3r1ck01 <alangiderick(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits January 2019