jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/407423 )
Change subject: [IMPR] ident attribute has been dropped
......................................................................
[IMPR] ident attribute has been dropped
With removing __version__ strings the ident attribute has been dropped.
The related file could be deleted then.
Change-Id: I67a3f20612e66d4bc03d13bde42bf253f8bc9b1e
---
D .gitattributes
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Dalba: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.gitattributes b/.gitattributes
deleted file mode 100644
index 274c91d..0000000
--- a/.gitattributes
+++ /dev/null
@@ -1 +0,0 @@
-*.py ident
--
To view, visit https://gerrit.wikimedia.org/r/407423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67a3f20612e66d4bc03d13bde42bf253f8bc9b1e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/407388 )
Change subject: [test] Skip test if Linter extension is missing
......................................................................
[test] Skip test if Linter extension is missing
Bug: T186000
Change-Id: I09c732b23005a163a401ef25511aaf23b32bbeb1
---
M tests/pagegenerators_tests.py
M tests/site_tests.py
2 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Dalba: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 107a68d..43ca6ce 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1179,6 +1179,9 @@
def test_linter_generator_ns_valid_cat(self):
"""Test generator of pages with lint errors."""
+ if not self.site.has_extension('Linter'):
+ raise unittest.SkipTest(
+ 'The site {0} does not use Linter extension'.format(self.site))
gf = pagegenerators.GeneratorFactory(site=self.site)
gf.handleArg('-ns:1')
gf.handleArg('-limit:3')
@@ -1194,6 +1197,9 @@
def test_linter_generator_invalid_cat(self):
"""Test generator of pages with lint errors."""
+ if not self.site.has_extension('Linter'):
+ raise unittest.SkipTest(
+ 'The site {0} does not use Linter extension'.format(self.site))
gf = pagegenerators.GeneratorFactory(site=self.site)
self.assertRaises(ValueError, gf.handleArg, '-linter:dummy')
diff --git a/tests/site_tests.py b/tests/site_tests.py
index bd5ec92..e6d95f2 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
"""Tests for the site module."""
#
-# (C) Pywikibot team, 2008-2017
+# (C) Pywikibot team, 2008-2018
#
# Distributed under the terms of the MIT license.
#
@@ -1069,6 +1069,13 @@
"""Test linter_pages methods."""
+ def setUp(self):
+ """Skip tests if Linter extension is missing."""
+ super(TestLinterPages, self).setUpClass()
+ if not self.site.has_extension('Linter'):
+ raise unittest.SkipTest(
+ 'The site {0} does not use Linter extension'.format(self.site))
+
def test_linter_pages(self):
"""Test the deprecated site.logpages() method."""
le = list(self.site.linter_pages(
--
To view, visit https://gerrit.wikimedia.org/r/407388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09c732b23005a163a401ef25511aaf23b32bbeb1
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>