Pywikibot-commits September 2017

pywikibot-commits@lists.wikimedia.org

2 participants
109 discussions

[Gerrit] pywikibot/core[master]: Add test to ensure WbUnknown is used for unknown datatypes

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377733 ) Change subject: Add test to ensure WbUnknown is used for unknown datatypes ...................................................................... Add test to ensure WbUnknown is used for unknown datatypes Change-Id: I07ca798a78a91dfefb49a17b6f87c50f02800878 --- A tests/pages/Q60_unknown_datatype.wd M tests/wikibase_tests.py 2 files changed, 75 insertions(+), 0 deletions(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/pages/Q60_unknown_datatype.wd b/tests/pages/Q60_unknown_datatype.wd new file mode 100644 index 0000000..54e1489 --- /dev/null +++ b/tests/pages/Q60_unknown_datatype.wd @@ -0,0 +1,45 @@ +{ + "id": "Q60", + "type": "item", + "lastrevid": 122836617, + "pageid": 186, + "aliases": { + "en": [ + { + "language": "en", + "value": "foo bar" + } + ] + }, + "labels": { + "en": { + "language": "en", + "value": "Foobar" + } + }, + "descriptions": { + "en": { + "language": "en", + "value": "An item with an unknown foobar datatype" + } + }, + "claims": { + "P99999": [ + { + "id": "Q60$efebe507-4e9f-4254-dc47-fake", + "mainsnak": { + "snaktype": "value", + "property": "P99999", + "datatype": "foo-unknown-bar", + "datavalue": { + "value": "foobar", + "type": "bar-unknown-foo" + } + }, + "type": "statement", + "rank": "normal" + } + ] + }, + "sitelinks": {} +} diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index e5ae318..44bbe68 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -12,6 +12,11 @@ from decimal import Decimal +try: + from unittest import mock +except ImportError: + import mock + import pywikibot from pywikibot import pagegenerators @@ -829,6 +834,31 @@ {'text': 'Test this!', 'language': 'en'}) +class TestLoadUnknownType(WikidataTestCase): + + """Test unknown datatypes being loaded as WbUnknown.""" + + dry = True + + def setUp(self): + """Setup test.""" + super(TestLoadUnknownType, self).setUp() + wikidata = self.get_repo() + self.wdp = ItemPage(wikidata, 'Q60') + self.wdp.id = 'Q60' + with open(join_pages_path('Q60_unknown_datatype.wd')) as f: + self.wdp._content = json.load(f) + + def test_load_unknown(self): + """Ensure unknown value is loaded but raises a warning.""" + with mock.patch.object(pywikibot, 'warning', autospec=True) as warn: + self.wdp.get() + unknown_value = self.wdp.claims['P99999'][0].getTarget() + self.assertIsInstance(unknown_value, pywikibot.WbUnknown) + warn.assert_called_once_with( + 'foo-unknown-bar datatype is not supported yet.') + + class TestItemPageExtensibility(TestCase): """Test ItemPage extensibility.""" -- To view, visit https://gerrit.wikimedia.org/r/377733 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07ca798a78a91dfefb49a17b6f87c50f02800878 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Lokal Profil <lokal.profil(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Lokal Profil <lokal.profil(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 7 months

Passed: wikimedia/pywikibot-core#4313 (master - 22d19cf)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4313 Status: Passed Duration: 2 hours, 8 minutes, and 51 seconds Commit: 22d19cf (master) Author: dalba Message: dev-requirements.txt: Avoide double-requirement Mentioning the inverse python_version of line 11 in line 12 prevents double-requirement situation which may occure under Python 2.6 and Windows OS. Bug: T175669 Change-Id: Iadf7191b7794ea4a0863424a36d138d2fe2dbd16 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/e121eb8e6027...22d19cf4… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/274803957?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 7 months

[Gerrit] pywikibot/core[master]: dev-requirements.txt: Avoide double-requirement

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377415 ) Change subject: dev-requirements.txt: Avoide double-requirement ...................................................................... dev-requirements.txt: Avoide double-requirement Mentioning the inverse python_version of line 11 in line 12 prevents double-requirement situation which may occure under Python 2.6 and Windows OS. Bug: T175669 Change-Id: Iadf7191b7794ea4a0863424a36d138d2fe2dbd16 --- M dev-requirements.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/dev-requirements.txt b/dev-requirements.txt index d25f4a7..8bfa279 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -9,7 +9,7 @@ pytest-attrib pytest-httpbin httpbin<0.6.0 ; python_version < '2.7' -httpbin!=0.6.0,!=0.6.1 ; os_name != 'posix' +httpbin!=0.6.0,!=0.6.1 ; os_name != 'posix' and python_version >= '2.7' six -- To view, visit https://gerrit.wikimedia.org/r/377415 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadf7191b7794ea4a0863424a36d138d2fe2dbd16 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

6 years, 7 months

Fixed: wikimedia/pywikibot-core#4312 (master - e121eb8)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4312 Status: Fixed Duration: 1 hour, 6 minutes, and 53 seconds Commit: e121eb8 (master) Author: jenkins-bot Message: Merge "site_detect.py: Raise ServerError for 502 response status" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/7eeacccdcf0e...e121eb8e… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/274359094?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 7 months

[Gerrit] pywikibot/core[master]: site_detect.py: Raise ServerError for 502 response status

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377282 ) Change subject: site_detect.py: Raise ServerError for 502 response status ...................................................................... site_detect.py: Raise ServerError for 502 response status Bug: T175584 Change-Id: I1f2d5cb701f37c5e7e40db81b0849d9989485c2c --- M pywikibot/site_detect.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/site_detect.py b/pywikibot/site_detect.py index 347bd63..60048a6 100644 --- a/pywikibot/site_detect.py +++ b/pywikibot/site_detect.py @@ -305,6 +305,8 @@ """Raise ServerError if the response indicates a server error.""" if response.status == 503: raise ServerError('Service Unavailable') + elif response.status == 502: + raise ServerError('Bad Gateway') elif response.status == 500: raise ServerError('Internal Server Error') elif response.status == 200 and SERVER_DB_ERROR_MSG in response.content: -- To view, visit https://gerrit.wikimedia.org/r/377282 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f2d5cb701f37c5e7e40db81b0849d9989485c2c Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 7 months

Failed: wikimedia/pywikibot-core#4311 (3.0.20170911 - 7eeaccc)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4311 Status: Failed Duration: 2 hours, 24 minutes, and 5 seconds Commit: 7eeaccc (3.0.20170911) Author: jenkins-bot Message: Merge "[bugfix] Check KeyError for hidden logentry comment" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/3.0.20170911 View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/274237572?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 7 months

[Gerrit] pywikibot/core[master]: [bugfix] Check KeyError for hidden logentry comment

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377067 ) Change subject: [bugfix] Check KeyError for hidden logentry comment ...................................................................... [bugfix] Check KeyError for hidden logentry comment Bug: T175496 Change-Id: Ie51178dd457dcaa9c39345014d1d0f1e48e5c36b --- M tests/logentry_tests.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/logentry_tests.py b/tests/logentry_tests.py index cf96995..e32f3d3 100644 --- a/tests/logentry_tests.py +++ b/tests/logentry_tests.py @@ -75,7 +75,10 @@ else: self.assertNotIn(logentry.type(), logentry.data) self.assertIsInstance(logentry.action(), unicode) - self.assertIsInstance(logentry.comment(), unicode) + if hasattr(logentry, 'comment'): + self.assertIsInstance(logentry.comment(), unicode) + else: + self.assertRaises(KeyError, logentry.comment) self.assertIsInstance(logentry.logid(), int) self.assertIsInstance(logentry.ns(), int) self.assertIsInstance(logentry.pageid(), int) -- To view, visit https://gerrit.wikimedia.org/r/377067 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie51178dd457dcaa9c39345014d1d0f1e48e5c36b Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

6 years, 7 months

[Gerrit] pywikibot/core[master]: site_tests.py: Avoid race conditions in test_pagetemplates a...

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377047 ) Change subject: site_tests.py: Avoid race conditions in test_pagetemplates and test_pagelinks ...................................................................... site_tests.py: Avoid race conditions in test_pagetemplates and test_pagelinks Instead of comparing the results of two generator calls that might not match, either because of random functions used in the page or simultaneous user edits, just make sure that the correct parameters are assigned to the underlying Request. In addition, for namespace-restricted generators confirm that the results are all from the expected namespace. Bug: T92856 Bug: T153501 Bug: T169649 Change-Id: I775729eb7153168140dbc832e0ae15790dd66779 --- M tests/site_tests.py 1 file changed, 36 insertions(+), 22 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/site_tests.py b/tests/site_tests.py index 1a7f2b8..74d3b11 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -551,13 +551,23 @@ def test_pagetemplates(self): """Test Site.pagetemplates.""" - pagetemplates_all = set(self.site.pagetemplates(self.mainpage)) - pagetemplates_ns_10 = set(self.site.pagetemplates(self.mainpage, namespaces=[10])) + tl_gen = self.site.pagetemplates(self.mainpage) + expected_params = { + 'titles': [self.mainpage.title()], + 'prop': ['info', 'imageinfo', 'categoryinfo'], + 'inprop': ['protection'], + 'iiprop': ['timestamp', 'user', 'comment', 'url', 'size', + 'sha1', 'metadata'], + 'generator': ['templates'], 'action': ['query'], + 'indexpageids': [True], 'continue': [True]} + self.assertEqual(tl_gen.request._params, expected_params) - for te in pagetemplates_all: + tl_gen = self.site.pagetemplates(self.mainpage, namespaces=[10]) + expected_params['gtlnamespace'] = [10] + self.assertEqual(tl_gen.request._params, expected_params) + for te in tl_gen: self.assertIsInstance(te, pywikibot.Page) - - self.assertLessEqual(pagetemplates_ns_10, pagetemplates_all) + self.assertEqual(te.namespace(), 10) def test_pagelanglinks(self): """Test Site.pagelanglinks.""" @@ -571,23 +581,27 @@ def test_pagelinks(self): """Test Site.pagelinks.""" - links = set(self.site.pagelinks(self.mainpage)) - for pl in links: - self.assertIsInstance(pl, pywikibot.Page) - # test links arguments - # TODO: There have been build failures because the following assertion - # wasn't true. Bug: T92856 - # Example: https://travis-ci.org/wikimedia/pywikibot-core/jobs/54552081#L505 - namespace_links = set(self.site.pagelinks(self.mainpage, namespaces=[0, 1])) - if namespace_links - links: - unittest_print( - 'FAILURE wrt T92856:\nSym. difference: "{0}"'.format( - '", "'.join( - '{0}@{1}'.format(link.namespace(), - link.title(withNamespace=False)) - for link in namespace_links ^ links))) - self.assertCountEqual( - set(self.site.pagelinks(self.mainpage, namespaces=[0, 1])) - links, []) + links_gen = self.site.pagelinks(self.mainpage) + gen_params = links_gen.request._params.copy() + expected_params = { + 'redirects': [False], + 'prop': ['info', 'imageinfo', 'categoryinfo'], + 'inprop': ['protection'], + 'iiprop': ['timestamp', 'user', 'comment', 'url', 'size', + 'sha1', 'metadata'], 'generator': ['links'], + 'action': ['query'], 'indexpageids': [True], 'continue': [True]} + if 'pageids' in gen_params: + expected_params['pageids'] = [str(self.mainpage.pageid)] + else: + expected_params['titles'] = [self.mainpage.title()] + self.assertEqual(gen_params, expected_params) + + links_gen = self.site.pagelinks(self.mainpage, namespaces=[0, 1]) + gen_params = links_gen.request._params.copy() + expected_params['gplnamespace'] = [0, 1] + self.assertEqual(gen_params, expected_params) + self.assertPagesInNamespaces(links_gen, set([0, 1])) + for target in self.site.preloadpages( self.site.pagelinks(self.mainpage, follow_redirects=True, total=5)): self.assertIsInstance(target, pywikibot.Page) -- To view, visit https://gerrit.wikimedia.org/r/377047 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I775729eb7153168140dbc832e0ae15790dd66779 Gerrit-PatchSet: 11 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 7 months

[Gerrit] pywikibot/core[master]: dev-requirements.txt: Do not use httpbin 0.6.0 or 0.6.1 on n...

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377215 ) Change subject: dev-requirements.txt: Do not use httpbin 0.6.0 or 0.6.1 on non-posix OSs ...................................................................... dev-requirements.txt: Do not use httpbin 0.6.0 or 0.6.1 on non-posix OSs Bug: T174886 Change-Id: I8e16746a7d7f510bab8949d9851b9181a048cea4 --- M dev-requirements.txt 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/dev-requirements.txt b/dev-requirements.txt index 7265af2..d25f4a7 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -9,6 +9,7 @@ pytest-attrib pytest-httpbin httpbin<0.6.0 ; python_version < '2.7' +httpbin!=0.6.0,!=0.6.1 ; os_name != 'posix' six -- To view, visit https://gerrit.wikimedia.org/r/377215 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e16746a7d7f510bab8949d9851b9181a048cea4 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 7 months

[Gerrit] pywikibot/core[master]: Test caching in TestItemLoad

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377053 ) Change subject: Test caching in TestItemLoad ...................................................................... Test caching in TestItemLoad Bug: T175486 Change-Id: Ib3b706c0b36d63f56fd5308bc0bf6dec53afe05e --- M tests/wikibase_tests.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index c809d3d..15b0423 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -1064,6 +1064,8 @@ item.get() self.assertTrue(hasattr(item, '_content')) self.assertTrue(item.exists()) + item2 = ItemPage.fromPage(page) + self.assertTrue(item is item2) def test_fromPage_lazy(self): """Test item from page with lazy_load.""" -- To view, visit https://gerrit.wikimedia.org/r/377053 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3b706c0b36d63f56fd5308bc0bf6dec53afe05e Gerrit-PatchSet: 4 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 7 months

← Newer
1
2
3
4
5
6
7
8
...
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits September 2017