jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/364123 )
Change subject: [bugfix] format string must be concatenated first
......................................................................
[bugfix] format string must be concatenated first
Bug: T170087
Change-Id: Ie106f296258ddf3404a2ae30489395375e2eeb93
---
M scripts/checkimages.py
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Framawiki: Looks good to me, but someone else must approve
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/checkimages.py b/scripts/checkimages.py
index 7b22ade..2caf92b 100755
--- a/scripts/checkimages.py
+++ b/scripts/checkimages.py
@@ -872,8 +872,8 @@
# It's not only on commons but the image needs a check
# the second usually is a url or something like that.
# Compare the two in equal way, both url.
- repme = (self.list_entry +
- "is also on '''Commons''': [[commons:File:%s]]"
+ repme = ((self.list_entry +
+ "is also on '''Commons''': [[commons:File:%s]]")
% (self.imageName,
commons_image_with_this_hash.title(
withNamespace=False)))
@@ -1012,11 +1012,11 @@
if self.duplicatesReport or only_report:
if only_report:
- repme = (self.list_entry + 'has the following duplicates '
- "('''forced mode'''):"
+ repme = ((self.list_entry + 'has the following duplicates '
+ "('''forced mode'''):")
% self.image.title(asUrl=True))
else:
- repme = (self.list_entry + 'has the following duplicates:'
+ repme = ((self.list_entry + 'has the following duplicates:')
% self.image.title(asUrl=True))
for dup_page in duplicates:
@@ -1299,10 +1299,10 @@
self.some_problem = False
else:
if not self.seems_ok and self.license_found:
- rep_text_license_fake = (self.list_entry +
- "seems to have a ''fake license'', "
- 'license detected: '
- '<nowiki>%s</nowiki>' %
+ rep_text_license_fake = ((self.list_entry +
+ "seems to have a ''fake license'', "
+ 'license detected: '
+ '<nowiki>%s</nowiki>') %
(self.imageName, self.license_found))
printWithTimeZone(
u"%s seems to have a fake license: %s, reporting..."
--
To view, visit https://gerrit.wikimedia.org/r/364123
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie106f296258ddf3404a2ae30489395375e2eeb93
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/362829 )
Change subject: [bugfix] illustratewikidata: rename page_image key in page_image_free
......................................................................
[bugfix] illustratewikidata: rename page_image key in page_image_free
The name of the key is no longer page_image but is now page_image_free.
So illustrate_wikidata.py is actually entirely broken.
Note: I don't think that we need, with this script, to get non-free images too. So I'll just implement the rename, not the both elements key.
Bug: T169447
Change-Id: Ia28c472c88baaad68f0042057905a0dbcd433ec8
---
M scripts/illustrate_wikidata.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/scripts/illustrate_wikidata.py b/scripts/illustrate_wikidata.py
index 81bd6ba..329fb4d 100755
--- a/scripts/illustrate_wikidata.py
+++ b/scripts/illustrate_wikidata.py
@@ -59,7 +59,7 @@
self.current_page = page
pywikibot.output(u'Found %s' % item.title())
- imagename = page.properties().get('page_image')
+ imagename = page.properties().get('page_image_free')
if not imagename:
return
@@ -79,8 +79,8 @@
image = pywikibot.FilePage(image.getRedirectTarget())
if not image.exists():
- pywikibot.output('[[%s]] doesn\'t exist so I can\'t link to it'
- % (image.title(),))
+ pywikibot.output("%s doesn't exist so I can't link to it"
+ % image.title(asLink=True))
return
newclaim.setTarget(image)
--
To view, visit https://gerrit.wikimedia.org/r/362829
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia28c472c88baaad68f0042057905a0dbcd433ec8
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>