Pywikibot-commits May 2017

pywikibot-commits@lists.wikimedia.org

2 participants
99 discussions

[Gerrit] pywikibot/core[master]: FilePage: remove deprecated use of fileUrl

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/356086 ) Change subject: FilePage: remove deprecated use of fileUrl ...................................................................... FilePage: remove deprecated use of fileUrl Use get_file_url in favor of deprecated fileUrl. Change-Id: I06ab79183b13918b89abfb3b7e7f3a27becfe1cb --- M pywikibot/page.py M tests/file_tests.py 2 files changed, 21 insertions(+), 11 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/page.py b/pywikibot/page.py index 49f282e..3dbd1d8 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -2495,10 +2495,10 @@ if not self.site.has_image_repository: return False elif 'wikitravel_shared' in self.site.shared_image_repository(): - return self.fileUrl().startswith( + return self.latest_file_info.url.startswith( u'http://wikitravel.org/upload/shared/') else: - return self.fileUrl().startswith( + return self.latest_file_info.url.startswith( 'https://upload.wikimedia.org/wikipedia/commons/') @deprecated("FilePage.latest_file_info.sha1") diff --git a/tests/file_tests.py b/tests/file_tests.py index 483b484..324f2c1 100644 --- a/tests/file_tests.py +++ b/tests/file_tests.py @@ -20,7 +20,7 @@ class TestShareFiles(TestCase): - """Test methods fileIsShared, exists and fileUrl with shared files.""" + """Test fileIsShared, exists and fileUrl/get_file_url with shared files.""" sites = { 'enwiki': { @@ -43,6 +43,16 @@ cached = True + def test_fileUrl_versus_get_file_url(self): + """Test fileUrl() is equivalent to get_file_url().""" + title = 'File:Sepp Maier 1.JPG' + commons = self.get_site('commons') + commons_file = pywikibot.FilePage(commons, title) + self.assertEqual(commons_file.fileUrl(), commons_file.get_file_url()) + itwp = self.get_site('itwiki') + itwp_file = pywikibot.FilePage(itwp, title) + self.assertEqual(itwp_file.fileUrl(), itwp_file.get_file_url()) + def testSharedOnly(self): """Test fileIsShared() on file page with shared file only.""" title = 'File:Sepp Maier 1.JPG' @@ -60,9 +70,9 @@ self.assertTrue(itwp_file.fileIsShared()) self.assertTrue(commons_file.fileIsShared()) - self.assertTrue(commons_file.fileUrl()) + self.assertTrue(commons_file.get_file_url()) - self.assertIn('/wikipedia/commons/', itwp_file.fileUrl()) + self.assertIn('/wikipedia/commons/', itwp_file.get_file_url()) self.assertRaises(pywikibot.NoPage, itwp_file.get) def testLocalOnly(self): @@ -78,14 +88,14 @@ commons_file = pywikibot.FilePage(commons, title) - self.assertTrue(enwp_file.fileUrl()) + self.assertTrue(enwp_file.latest_file_info.url) self.assertTrue(enwp_file.exists()) self.assertFalse(commons_file.exists()) self.assertFalse(enwp_file.fileIsShared()) self.assertRaises(pywikibot.NoPage, commons_file.fileIsShared) - self.assertRaises(pywikibot.NoPage, commons_file.fileUrl) + self.assertRaises(pywikibot.NoPage, commons_file.get_file_url) self.assertRaises(pywikibot.NoPage, commons_file.get) def testOnBoth(self): @@ -100,7 +110,7 @@ commons_file = pywikibot.FilePage(commons, title) - self.assertTrue(itwp_file.fileUrl()) + self.assertTrue(itwp_file.get_file_url()) self.assertTrue(itwp_file.exists()) self.assertTrue(commons_file.exists()) @@ -115,13 +125,13 @@ testwp = self.get_site('testwiki') testwp_file = pywikibot.FilePage(testwp, title) - self.assertTrue(testwp_file.fileUrl()) + self.assertTrue(testwp_file.latest_file_info.url) self.assertTrue(testwp_file.exists()) self.assertTrue(testwp_file.fileIsShared()) commons_file = pywikibot.FilePage(commons, title) - self.assertEqual(testwp_file.fileUrl(), - commons_file.fileUrl()) + self.assertEqual(testwp_file.get_file_url(), + commons_file.get_file_url()) class TestFilePage(TestCase): -- To view, visit https://gerrit.wikimedia.org/r/356086 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06ab79183b13918b89abfb3b7e7f3a27becfe1cb Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 11 months

Fixed: wikimedia/pywikibot-core#4086 (master - f4410dc)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4086 Status: Fixed Duration: 2 hours, 18 minutes, and 48 seconds Commit: f4410dc (master) Author: xqt Message: [DOC] Setup keywords for pypi package Change-Id: I8a1beebba6651225839c24a5a328c1a8a4983265 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/b25b77888820...f4410dc4… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/237258544?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 11 months

[Gerrit] pywikibot/core[master]: [DOC] Setup keywords for pypi package

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/356028 ) Change subject: [DOC] Setup keywords for pypi package ...................................................................... [DOC] Setup keywords for pypi package Change-Id: I8a1beebba6651225839c24a5a328c1a8a4983265 --- M setup.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Merlijn van Deen: Looks good to me, approved jenkins-bot: Verified diff --git a/setup.py b/setup.py index fe99201..fb19347 100644 --- a/setup.py +++ b/setup.py @@ -208,6 +208,8 @@ version=version, description='Python MediaWiki Bot Framework', long_description=open('README.rst').read(), + keywords=('pywikibot python mediawiki bot wiki framework ' + 'wikimedia wikipedia pwb pywikipedia API'), maintainer='The Pywikibot team', maintainer_email='pywikibot(a)lists.wikimedia.org', license='MIT License', -- To view, visit https://gerrit.wikimedia.org/r/356028 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a1beebba6651225839c24a5a328c1a8a4983265 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

6 years, 11 months

[Gerrit] pywikibot/core[master]: Update ChangeLog for 3.0.20170521

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/355992 ) Change subject: Update ChangeLog for 3.0.20170521 ...................................................................... Update ChangeLog for 3.0.20170521 Change-Id: I419ccfebb301e19a4250d80b750894cba9687c37 --- M ChangeLog 1 file changed, 74 insertions(+), 0 deletions(-) Approvals: Merlijn van Deen: Looks good to me, approved jenkins-bot: Verified Objections: Xqt: There's a problem with this change, please improve diff --git a/ChangeLog b/ChangeLog index 1361e3a..63288f3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,77 @@ +Release 3.0.20170521 (21 Mai 2017) +==================================== + +Bugfixes (core) +--------------- +a79ce64 Increase the default socket_timeout to 75 seconds (T163635) +4c8acd8 use repr() of exceptions to prevent UnicodeDecodeErrors (T120222) +3727717 Handle offset mismatches during chunked upload (T156402) +f4cc5ee Correct _wbtypes equality comparison (T160282) +46dff29 Re-enable getFileVersionHistoryTable() method (T162528) +6f7ecb4 Replaced the word 'async' with 'asynchronous' due to py3.7 (T106230) +ac1d5ed Raise ImportError if no editor is available (T163632) +489741f templatesWithParams: cache and standardise params (T113892) +31eb055 getInternetArchiveURL: Retry http.fetch if there is a ConnectionError (T164208) +6d8c9e7 Remove wikidataquery from pywikibot (T162585) + +Improvements (core) +------------------- +345e677 Introduce user_add_claim and allow asynchronous ItemPage.addClaim (T87493) +eade449 Enable private edit summary in specialbots (T162527) +d74cb73 Make a decorator for asynchronous methods +4159a9c Provide options by a separate handler class +ccdb71a Show a warning when a LogEntry type is not known (T135505) +aa74f5c Add Wikibase Client extension requirement to APISite.unconnectedpages() +894d5b9 Update content after editing entity +ae0d3f9 Make WbTime from Timestamp and vice versa (T131624) +feaffb7 Add support for geo-shape Wikibase data type (T161726) +f8fe0a1 Add async parameter to ItemPage.editEntity (T86074) +a7c02e5 Make sparql use Site to access sparql endpoint and entity_url (T159956) +df7ab6d timestripper: search wikilinks to reduce false matches +e54e584 Set Coordinate globe via item +4e824eb use extract_templates_and_params_regex_simple for template validation +e26c9b4 Add _items for WbMonolingualText +c67e069 Allow date-versioned pypi releases from setup.py (T152907) +2b6509f Provide site to WbTime via WbTime.fromWikibase +165adc2 Provide preloading via GeneratorFactory.getCombinedGenerator() (T135331) +f4af75f Accept QuitKeyboardInterrupt in specialbots.Uploadbot (T163970) +a0c75d8 Remove unnecessary description change message when uploading a file (T163108) +b5b721b Add 'OptionHandler' to bot.__all__ tuple +6a56c23 Use FilePage.upload inside UploadRobot +b6962ab Add support for tabular-data Wikibase data type (T163981) +2d9e841 Get thumburl information in FilePage() (T137011) + +Updates (core) +-------------- +ec33c23 Update languages_by_size in family files +d9b9913 wikisource_family.py: Add "pa" to languages_by_size +6f159c5 Config2: limit the number of retries to 15 (T165898) + +Bugfixes (scripts) +------------------ +3c3bfb8 Remove comments when parsing template in harvest_template.py (T127691) +b6e5218 Assign object to Tkdialog if it cannot be imported from gui module (T164163) +a8aa142 weblinkchecker.py: Retry get_memento_info if there is a ConnectionError (T164365) +09142d7 newitem.py: Test if the page actually exists (T86491) + +Improvements (scripts) +---------------------- +d6dad3c use OptionHandler class for PageFromFileReader +b6567e4 Do not use the deprecated pywikibot.setAction() in makecat.py +88bbb2a Update newitem.py to use WikidataBot.user_edit_entity (T87493) +07a4344 Improve redirect.py (T153883) +da9021c use OptionHandler for redirect.RedirectGenerator +bc59339 Enable a new option sdtemplate for customized sd template (T140624) +cfaf7c0 Rewrite claimit.py (T69284) +2487c75 Replace private mylang variables with mycode in misspelling.py +37a4846 se input_yn in states_redirect.py +0809a60 Use bot classes for table2wiki.py + +Updates (scripts) +----------------- +f819ef4 Update cfr templates for cswiki + + Release 3.0.20170403 (03 April 2017) ==================================== This is a major release from master branch. -- To view, visit https://gerrit.wikimedia.org/r/355992 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I419ccfebb301e19a4250d80b750894cba9687c37 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 11 months

Broken: wikimedia/pywikibot-core#4085 (master - b25b778)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4085 Status: Broken Duration: 2 hours, 21 minutes, and 1 second Commit: b25b778 (master) Author: jenkins-bot Message: Merge "[IMPR] category.py/tidy: Show page title at the bottom of the output" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/061363e18f1d...b25b7788… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/237027617?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 11 months

Broken: wikimedia/pywikibot-core#4084 (master - 061363e)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4084 Status: Broken Duration: 2 hours, 18 minutes, and 12 seconds Commit: 061363e (master) Author: jenkins-bot Message: Merge "proofreadpage.py: raise TypeError, not ValueError" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/3834b6c929e3...061363e1… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/237026904?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 11 months

[Gerrit] pywikibot/core[master]: [IMPR] category.py/tidy: Show page title at the bottom of th...

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/355905 ) Change subject: [IMPR] category.py/tidy: Show page title at the bottom of the output ...................................................................... [IMPR] category.py/tidy: Show page title at the bottom of the output Bug: T166468 Change-Id: I7e03ff8da23f844ee8512e90bf4a7251ca947003 --- M scripts/category.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/category.py b/scripts/category.py index 1bef740..d7854da 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -906,9 +906,9 @@ # Show the title of the page where the link was found. # Highlight the title in purple. pywikibot.output(color_format( - 'Treating page {lightpurple}{0}{default}, ' + 'Treating page {0}, ' 'currently in {lightpurple}{1}{default}', - article.title(), current_cat.title())) + article.title(asLink=True), current_cat.title())) # Determine a reasonable amount of context to print try: @@ -951,7 +951,9 @@ StandardOption('remove this category tag', 'r'), context_option, StandardOption('save category as "{0}"'.format(current_cat.title()), 'c')) - choice = pywikibot.input_choice('Choice:', options, default='c') + choice = pywikibot.input_choice(color_format( + 'Choice for page {lightpurple}{0}{default}:\n', + article.title()), options, default='c') if choice == 'c': pywikibot.output(u'Saving category as %s' % current_cat.title()) -- To view, visit https://gerrit.wikimedia.org/r/355905 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e03ff8da23f844ee8512e90bf4a7251ca947003 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 11 months

[Gerrit] pywikibot/core[master]: proofreadpage.py: raise TypeError, not ValueError

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/355904 ) Change subject: proofreadpage.py: raise TypeError, not ValueError ...................................................................... proofreadpage.py: raise TypeError, not ValueError Raise correct Exception when assigning wrong object to ProofreadPage.index property. Tests added. Change-Id: I1217f272e77db414feb389253e8bfe17a54a94dc --- M pywikibot/proofreadpage.py M tests/proofreadpage_tests.py 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py index 47bf1ab..60546c4 100644 --- a/pywikibot/proofreadpage.py +++ b/pywikibot/proofreadpage.py @@ -173,8 +173,8 @@ @index.setter def index(self, value): if not isinstance(value, IndexPage): - raise ValueError('value %s must be a IndexPage object.' - % value) + raise TypeError('value %s must be a IndexPage object.' + % value) self._index = (value, None) @index.deleter diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py index 21e9762..49b6e75 100644 --- a/tests/proofreadpage_tests.py +++ b/tests/proofreadpage_tests.py @@ -268,13 +268,15 @@ page = ProofreadPage(self.site, self.valid['title']) index_page = IndexPage(self.site, self.valid['index']) - # Test propery. + # Test property. self.assertEqual(page.index, index_page) # Test deleter del page.index self.assertFalse(hasattr(page, '_index')) - # Test setter + # Test setter with wrong type. + self.assertRaises(TypeError, setattr, page, 'index', 'invalid index') + # Test setter with correct type. page.index = index_page self.assertEqual(page.index, index_page) -- To view, visit https://gerrit.wikimedia.org/r/355904 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1217f272e77db414feb389253e8bfe17a54a94dc Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

6 years, 11 months

Failed: wikimedia/pywikibot-core#4083 (3.0.20170521 - 6ccd35d)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4083 Status: Failed Duration: 2 hours, 14 minutes, and 46 seconds Commit: 6ccd35d (3.0.20170521) Author: jenkins-bot Message: Merge "Remove unnecessary TODO from pwb.py" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/3.0.20170521 View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/236964364?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 11 months

Errored: wikimedia/pywikibot-core#4082 (Branch_3.0.20170521 - 6ccd35d)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4082 Status: Errored Duration: 10 minutes and 48 seconds Commit: 6ccd35d (Branch_3.0.20170521) Author: jenkins-bot Message: Merge "Remove unnecessary TODO from pwb.py" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/Branch_3.0.20170521 View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/236964336?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 11 months

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits May 2017