Pywikibot-commits September 2016

pywikibot-commits@lists.wikimedia.org

2 participants
66 discussions

[Gerrit] pywikibot/compat[master]: Remove blockreview.py from framework
by jenkins-bot (Code Review) 13 Sep '16

13 Sep '16

jenkins-bot has submitted this change and it was merged. Change subject: Remove blockreview.py from framework ...................................................................... Remove blockreview.py from framework - This script is not finished and was never used. Put it out of the scope of the framework and delete it. Change-Id: Ic47c233e85bb33b5bc6e460e0b392418a8c058b3 --- D blockreview.py 1 file changed, 0 insertions(+), 330 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/blockreview.py b/blockreview.py deleted file mode 100644 index b59ed35..0000000 --- a/blockreview.py +++ /dev/null @@ -1,330 +0,0 @@ -#!/usr/bin/python -# -*- coding: utf-8 -*- -""" -This bot implements a blocking review process for de-wiki first. -For other sites this bot script must be changed. - -This script is run by [[de:User:xqt]]. It should -not be run by other users without prior contact. - -The following parameters are supported: - -- - -All other parameters will be regarded as part of the title of a single page, -and the bot will only work on that single page. -""" -# -# (C) xqt, 2010-2013 -# -# Distributed under the terms of the MIT license. -# -__version__ = '$Id$' -# - -import wikipedia as pywikibot -import userlib -import query - - -class BlockreviewBot: - # notes - note_admin = { - 'de': u""" - -== Sperrprüfungswunsch == -Hallo %(admin)s, - -[[%(user)s]] wünscht die Prüfung seiner/ihrer Sperre vom %(time)s über die Dauer von %(duration)s. Kommentar war ''%(comment)s''. Bitte äußere Dich dazu auf der [[%(usertalk)s#%(section)s|Diskussionsseite]]. -~~~~""" - } - - note_project = { - 'de': u""" - -== [[%(user)s]] == -* gesperrt am %(time)s durch {{Benutzer|%(admin)s}} für eine Dauer von %(duration)s. -* Kommentar war ''%(comment)s''. -* [[Benutzer:%(admin)s]] wurde [[Benutzer Diskussion:%(admin)s#Sperrprüfungswunsch|benachrichtigt]]. -* [[%(usertalk)s#%(section)s|Link zur Diskussion]] -:<small>-~~~~</small> -;Antrag entgegengenommen""" - } - - # edit summaries - msg_admin = { - 'de': u'Bot-Benachrichtigung: Sperrprüfungswunsch von [[%(user)s]]', - } - - msg_user = { - 'de': u'Bot: Administrator [[Benutzer:%(admin)s|%(admin)s]] für Sperrprüfung benachrichtigt', - } - - msg_done = { - 'de': u'Bot: Sperrprüfung abgeschlossen. Benutzer ist entsperrt.', - } - - unblock_tpl = { - 'de': u'Benutzer:TAXman/Sperrprüfungsverfahren', - 'pt': u'Predefinição:Discussão de bloqueio', - } - - review_cat = { - 'de': u'Wikipedia:Sperrprüfung', - } - - project_name = { - 'de': u'Benutzer:TAXman/Sperrprüfung Neu', - 'pt': u'Wikipedia:Pedidos a administradores/Discussão de bloqueio', - } - - def __init__(self, dry): - """ - Constructor. Parameters: - * generator - The page generator that determines on which pages - to work on. - * dry - If True, doesn't do any real changes, but only shows - what would have been changed. - """ - self.site = pywikibot.getSite() - self.dry = dry - self.info = None - self.parts = None - - def run(self): - # TODO: change the generator for template to the included category - try: - genPage = pywikibot.Page(self.site, - self.unblock_tpl[self.site.lang], - defaultNamespace=10) - except KeyError: - pywikibot.error(u'Language "%s" not supported by this bot.' - % self.site.lang) - else: - for page in genPage.getReferences(follow_redirects=False, - withTemplateInclusion=True, - onlyTemplateInclusion=True): - if page.namespace() == 3: - self.treat(page) - else: - pywikibot.output(u'Ignoring %s, user namespace required' - % page.title(asLink=True)) - - def treat(self, userPage): - """ - Loads the given page, does some changes, and saves it. - """ - talkText = self.load(userPage) - if not talkText: - # sanity check. No talk page found. - return - unblock_tpl = self.unblock_tpl[self.site.lang] - project_name = self.project_name[self.site.lang] - user = userlib.User(self.site, userPage.title(withNamespace=False)) - saveAdmin = saveProject = False - talkComment = None - for templates in userPage.templatesWithParams(): - if templates[0] == unblock_tpl: - self.getInfo(user) - # Step 1 - # a new template is set on blocked users talk page. - # Notify the blocking admin - if templates[1] == [] or templates[1][0] == u'1': - if self.info['action'] == 'block' or user.isBlocked(): - if self.site.sitename() == 'wikipedia:de': - admin = userlib.User(self.site, self.info['user']) - adminPage = admin.getUserTalkPage() - adminText = adminPage.get() - note = pywikibot.translate(self.site.lang, - self.note_admin, - self.parts) - comment = pywikibot.translate(self.site.lang, - self.msg_admin, - self.parts) - adminText += note - self.save(adminText, adminPage, comment, False) - ### test for pt-wiki - ### just print all sysops talk pages - elif self.site.sitename() == 'wikipedia:pt': - import pagegenerators as pg - gen = pg.PreloadingGenerator(self.SysopGenerator()) - for sysop in gen: - print sysop.title() - - talkText = talkText.replace(u'{{%s}}' % unblock_tpl, - u'{{%s|2}}' % unblock_tpl) - talkText = talkText.replace(u'{{%s|1}}' % unblock_tpl, - u'{{%s|2}}' % unblock_tpl) - talkComment = pywikibot.translate(self.site.lang, - self.msg_user - % self.parts) - - # some test stuff - if pywikibot.logger.isEnabledFor(pywikibot.DEBUG) \ - and self.site().loggedInAs() == u'Xqbot:': - testPage = pywikibot.Page(self.site, - 'Benutzer:Xqt/Test') - test = testPage.get() - test += note - self.save(test, testPage, - '[[WP:BA#SPP-Bot|SPPB-Test]]') - else: - # nicht blockiert. Fall auf DS abschließen - talkText = talkText.replace(u'{{%s}}' % unblock_tpl, - u'{{%s|4}}' % unblock_tpl) - talkText = talkText.replace(u'{{%s|1}}' % unblock_tpl, - u'{{%s|4}}' % unblock_tpl) - talkComment = pywikibot.translate(self.site.lang, - self.msg_done) - # Step 2 - # Admin has been notified. - # Wait for 2 hours, than put a message to the project page - elif templates[1][0] == u'2': - if self.info['action'] == 'block' or user.isBlocked(): - # TODO: check whether wait time is gone - # check whether this entry already esists - project = pywikibot.Page(self.site, project_name) - projText = project.get() - note = pywikibot.translate(self.site.lang, - self.note_project, - self.parts) - comment = pywikibot.translate(self.site.lang, - self.msg_admin, - self.parts) - projText += note - self.save(projText, project, comment, botflag=False) - talkText = talkText.replace(u'{{%s|2}}' % unblock_tpl, - u'{{%s|3}}' % unblock_tpl) - talkComment = u'Bot: [[%s|Wikipedia:Sperrprüfung]] eingetragen' \ - % project_name - else: - # User is unblocked. Review can be closed - talkText = talkText.replace(u'{{%s|2}}' % unblock_tpl, - u'{{%s|4}}' % unblock_tpl) - talkComment = pywikibot.translate(self.site.lang, - self.msg_done) - # Step 3 - # Admin is notified, central project page has a message - # Discussion is going on - # Check whether it can be closed - elif templates[1][0] == u'3': - if self.info['action'] == 'block' or user.isBlocked(): - pass - else: - # User is unblocked. Review can be closed - talkText = talkText.replace(u'{{%s|3}}' % unblock_tpl, - u'{{%s|4}}' % unblock_tpl) - talkComment = pywikibot.translate(self.site.lang, - self.msg_done) - # Step 4 - # Review is closed - elif templates[1][0] == u'4': - # nothing left to do - pass - else: - # wrong template found - pass - - # at last if there is a talk comment, users talk page must be changed - if talkComment: - self.save(talkText, userPage, talkComment) - - def getInfo(self, user): - if not self.info: - self.info = self.site.logpages(1, mode='block', - title=user.getUserPage().title(), - dump=True).next() - self.parts = { - 'admin': self.info['user'], - 'user': self.info['title'], - 'usertalk': user.getUserTalkPage().title(), - 'section': u'Sperrprüfung', - 'time': self.info['timestamp'], - 'duration': self.info['block']['duration'], - 'comment': self.info['comment'], - } - - def SysopGenerator(self): - params = param = { - 'action': 'query', - 'list': 'allusers', - 'augroup': 'sysop', - 'auprop': 'groups', - 'aulimit': 500, - } - data = query.GetData(params, self.site) - for user in data['query']['allusers']: - # exclude sysop bots - if 'bot' not in user['groups']: - # yield the sysop talkpage - yield pywikibot.Page(self.site, user['name'], - defaultNamespace=3) - - def load(self, page): - """ - Loads the given page, does some changes, and saves it. - """ - try: - # Load the page - text = page.get() - except pywikibot.NoPage: - pywikibot.output(u"Page %s does not exist; skipping." - % page.title(asLink=True)) - except pywikibot.IsRedirectPage: - pywikibot.output(u"Page %s is a redirect; skipping." - % page.title(asLink=True)) - else: - return text - return None - - def save(self, text, page, comment, minorEdit=True, botflag=True): - if text != page.get(): - # Show the title of the page we're working on. - # Highlight the title in purple. - pywikibot.output(u"\n\n>>> \03{lightpurple}%s\03{default} <<<" - % page.title()) - # show what was changed - pywikibot.showDiff(page.get(), text) - pywikibot.output(u'Comment: %s' % comment) - if not self.dry: - choice = pywikibot.inputChoice( - u'Do you want to accept these changes?', - ['Yes', 'No'], ['y', 'N'], 'N') - if choice == 'y': - try: - # Save the page - page.put(text, comment=comment, minorEdit=minorEdit, - botflag=botflag) - except pywikibot.LockedPage: - pywikibot.output(u"Page %s is locked; skipping." - % page.title(asLink=True)) - except pywikibot.EditConflict: - pywikibot.output( - u'Skipping %s because of edit conflict' - % (page.title())) - except pywikibot.SpamfilterError, error: - pywikibot.output( - u'Cannot change %s because of spam blacklist entry ' - u'%s' % (page.title(), error.url)) - else: - return True - return - - -def main(): - show = False - - # Parse command line arguments - for arg in pywikibot.handleArgs(): - show = True - - if not show: - bot = BlockreviewBot(pywikibot.simulate) - bot.run() - else: - pywikibot.showHelp() - -if __name__ == "__main__": - try: - main() - finally: - pywikibot.stopme() -- To view, visit https://gerrit.wikimedia.org/r/307326 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic47c233e85bb33b5bc6e460e0b392418a8c058b3 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

Errored: wikimedia/pywikibot-core#3623 (master - 44be554)
by Travis CI 13 Sep '16

13 Sep '16

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3623 Status: Errored Duration: 44 minutes and 37 seconds Commit: 44be554 (master) Author: Translation updater bot Message: Updated git submodules Project: pywikibot/i18n master 9e2988327bba4bc1374e6991e592e77d1f93420b Localisation updates from https://translatewiki.net. Change-Id: Ia58d58836095b1e47190c8dfd7f0965906d7208d View the changeset: https://github.com/wikimedia/pywikibot-core/compare/96848bd656c9...44be5545… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/159504567 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Gerrit] pywikibot/core[master]: Revert "[bugfix] fix tests for wikidata"
by jenkins-bot (Code Review) 13 Sep '16

13 Sep '16

jenkins-bot has submitted this change and it was merged. Change subject: Revert "[bugfix] fix tests for wikidata" ...................................................................... Revert "[bugfix] fix tests for wikidata" This reverts commit 8816913e4320dbac94c0d18926803ee8f5e8d44b. Bug: T134655 Change-Id: Ib435c5c64a3744f43aef639364dfbbd3b6712b08 --- M tests/wikibase_tests.py 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index 6cfceaf..7b747e3 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -1131,30 +1131,13 @@ }, } - def test_own_repository(self, key): - """Test that a data repository family is its own repository.""" - site = self.get_site(key) - self.assertEqual(site, site.data_repository()) - self.assertTrue(site.is_data_repository) - def test_own_client(self, key): """Test that a data repository family can be its own client.""" site = self.get_site(key) - self.assertTrue(site.has_data_repository) - def test_item_exists(self): - """Test that a ItemPage exists for wikidata:wikidata.""" - site = self.get_site('wikidata') page = pywikibot.Page(site, 'Wikidata:Main Page') item = pywikibot.ItemPage.fromPage(page) self.assertEqual(item.site, site) - - def test_item_not_exists(self): - """Test that a ItemPage does not exists for test:wikidata.""" - site = self.get_site('wikidatatest') - page = pywikibot.Page(site, 'Wikidata:Main Page') - with self.assertRaises(pywikibot.NoPage): - pywikibot.ItemPage.fromPage(page) class TestUnconnectedClient(TestCase): -- To view, visit https://gerrit.wikimedia.org/r/298452 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib435c5c64a3744f43aef639364dfbbd3b6712b08 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

Errored: wikimedia/pywikibot-core#3621 (master - 96848bd)
by Travis CI 11 Sep '16

11 Sep '16

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3621 Status: Errored Duration: 25 minutes and 2 seconds Commit: 96848bd (master) Author: jenkins-bot Message: Merge "Re-enable test_allpages_langlinks_enabled test" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/a19edfad0f75...96848bd6… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/159088998 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

Errored: wikimedia/pywikibot-core#3620 (master - a19edfa)
by Travis CI 11 Sep '16

11 Sep '16

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3620 Status: Errored Duration: 33 minutes and 21 seconds Commit: a19edfa (master) Author: jenkins-bot Message: Merge "Print additional warning when starting a thread fails" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/49f6c7ecdab1...a19edfad… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/159086691 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Gerrit] pywikibot/core[master]: Re-enable test_allpages_langlinks_enabled test
by jenkins-bot (Code Review) 11 Sep '16

11 Sep '16

jenkins-bot has submitted this change and it was merged. Change subject: Re-enable test_allpages_langlinks_enabled test ...................................................................... Re-enable test_allpages_langlinks_enabled test - re-enable this test without allowed_failure decorator since T78276 is fixed. Bug: T145319 Change-Id: I5dcb5a0cbe67d126c927e9b20629efc0dc95a538 --- M tests/site_tests.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_tests.py b/tests/site_tests.py index 840f9b5..2ddd451 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -588,7 +588,6 @@ self.assertEqual(page.namespace(), 0) self.assertFalse(page.isRedirectPage()) - @allowed_failure # T78276 def test_allpages_langlinks_enabled(self): """Test allpages with langlinks enabled.""" mysite = self.get_site() -- To view, visit https://gerrit.wikimedia.org/r/309817 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dcb5a0cbe67d126c927e9b20629efc0dc95a538 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: Print additional warning when starting a thread fails
by jenkins-bot (Code Review) 11 Sep '16

11 Sep '16

jenkins-bot has submitted this change and it was merged. Change subject: Print additional warning when starting a thread fails ...................................................................... Print additional warning when starting a thread fails - print a warning to decrease max_external_links - increase sleeping time before starting a new thread to config.retry_wait value to wait a longer time until a previous thread was finished. Bug: T145273 Change-Id: I1cebcfa6e49f0e68975d7e9062e1dd3825b9a7ac --- M scripts/weblinkchecker.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py index 9f5abb5..44e3296 100755 --- a/scripts/weblinkchecker.py +++ b/scripts/weblinkchecker.py @@ -862,13 +862,20 @@ # Limit the number of threads started at the same time. Each # thread will check one page, then die. while threading.activeCount() >= config.max_external_links: - # wait 100 ms - time.sleep(0.1) + time.sleep(config.retry_wait) thread = LinkCheckThread(page, url, self.history, self.HTTPignore, self.day) # thread dies when program terminates thread.setDaemon(True) - thread.start() + try: + thread.start() + except threading.ThreadError: + pywikibot.warning( + "Can't start a new thread.\nPlease decrease " + "max_external_links in your user-config.py or use\n" + "'-max_external_links:' option with a smaller value. " + "Default is 50.") + raise def RepeatPageGenerator(): -- To view, visit https://gerrit.wikimedia.org/r/309730 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cebcfa6e49f0e68975d7e9062e1dd3825b9a7ac Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

Errored: wikimedia/pywikibot-core#3619 (master - 49f6c7e)
by Travis CI 11 Sep '16

11 Sep '16

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3619 Status: Errored Duration: 34 minutes and 22 seconds Commit: 49f6c7e (master) Author: John Vandenberg Message: Use released flake8-mock 0.3 Change-Id: I10d134d8059236ea758065566a64edc390aeaab0 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/5ad518163b4a...49f6c7ec… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/159075334 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Gerrit] pywikibot/core[master]: Use released flake8-mock 0.3
by jenkins-bot (Code Review) 11 Sep '16

11 Sep '16

jenkins-bot has submitted this change and it was merged. Change subject: Use released flake8-mock 0.3 ...................................................................... Use released flake8-mock 0.3 Change-Id: I10d134d8059236ea758065566a64edc390aeaab0 --- M dev-requirements.txt M tox.ini 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/dev-requirements.txt b/dev-requirements.txt index e8bab19..edd5005 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -17,7 +17,7 @@ pyflakes>=0.9 flake8 flake8-docstrings>=0.2.6 -git+https://github.com/jayvdb/flake8-mock@use-ascii-readme +flake8-mock>=0.3 codecov coverage mock ; python_version < '3' diff --git a/tox.ini b/tox.ini index c436cf8..f053a96 100644 --- a/tox.ini +++ b/tox.ini @@ -62,7 +62,7 @@ flake8-import-order flake8-tuple>=0.2.8 flake8-print>=2.0.1 - git+https://github.com/jayvdb/flake8-mock@use-ascii-readme + flake8-mock>=0.3 pep8-naming [testenv:nose] -- To view, visit https://gerrit.wikimedia.org/r/309816 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10d134d8059236ea758065566a64edc390aeaab0 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

Errored: wikimedia/pywikibot-core#3618 (master - 5ad5181)
by Travis CI 10 Sep '16

10 Sep '16

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3618 Status: Errored Duration: 39 minutes and 1 second Commit: 5ad5181 (master) Author: Alex Monk Message: Default wikimedia rcstream to https on port 443 Instead of http on port 80 This commit itself is not tested (I'm not a pywikibot user), though I have checked my own little socketIO_client script and it should be okay. Bug: T145244 Change-Id: I4a01817ba7e525f3ebdf82cab939ac8bbcdf1835 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/6453e15141d4...5ad51816… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/158849183 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits September 2016