Build Update for wikimedia/pywikibot-core
-------------------------------------
Build: #3238
Status: Errored
Duration: 1 hour, 9 minutes, and 29 seconds
Commit: afcacf0 (master)
Author: John Vandenberg
Message: Positional args support for GeneratorFactory
Some scripts have positional parameters which are used to create
a page generator. A common example is page names, which could be
written as -page:"..." but the scripts allow to be simple "...".
In order to bring these parameters into the common infrastructure,
support has been added for positional parameters being detected as
belonging to a standard page generator selected by the script.
Change-Id: I93f9289aa93ea7a263cd8347aa78136065cf4e6b
View the changeset: https://github.com/wikimedia/pywikibot-core/compare/7eaf57f80d2d...afcacf03…
View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/108979976
--
You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications
jenkins-bot has submitted this change and it was merged.
Change subject: Fix edit conflicts after calls to save_claim()
......................................................................
Fix edit conflicts after calls to save_claim()
Unlike DataSite.addClaim(), DataSite.save_claim() was not updating
the latest revision ID of the item of the saved claim. As a result,
any submission to Wikidata after modifying a claim, such as
Claim.changeRank(), would result in an edit conflict.
Now DataSite.save_claim() updates the latest revision ID of the
item of the saved claim.
Change-Id: I2079228b50abca2e171bbc63e6bdd581532cd703
---
M pywikibot/site.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site.py b/pywikibot/site.py
index fb92abe..39ac5cb 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -7071,6 +7071,7 @@
req = self._simple_request(**params)
data = req.submit()
+ claim.on_item.latest_revision_id = data['pageinfo']['lastrevid']
return data
@must_be(group='user')
--
To view, visit https://gerrit.wikimedia.org/r/268877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2079228b50abca2e171bbc63e6bdd581532cd703
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Gallaecio <adriyetichaves(a)gmail.com>
Gerrit-Reviewer: Gallaecio <adriyetichaves(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>