Pywikibot-commits August 2015

pywikibot-commits@lists.wikimedia.org

2 participants
240 discussions

[Gerrit] Skip sites that timeout - change (pywikibot/core)
by jenkins-bot (Code Review) 31 Aug '15

31 Aug '15

jenkins-bot has submitted this change and it was merged. Change subject: Skip sites that timeout ...................................................................... Skip sites that timeout Change-Id: I2e7cc972f262b281e65f56cf48c4ecd8148d1f4f --- M tests/site_detect_tests.py 1 file changed, 31 insertions(+), 13 deletions(-) Approvals: XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_detect_tests.py b/tests/site_detect_tests.py index 7a0072c..f13105f 100644 --- a/tests/site_detect_tests.py +++ b/tests/site_detect_tests.py @@ -9,6 +9,8 @@ __version__ = '$Id$' +from requests.exceptions import Timeout + from pywikibot.site_detect import MWSite from pywikibot.tools import PY2 @@ -28,6 +30,7 @@ def setUp(self): """Set up test.""" + self.skips = {} self.failures = {} self.errors = {} self.passes = {} @@ -40,25 +43,25 @@ res = None typ = -1 for pos, result in enumerate([self.passes, self.errors, - self.failures]): + self.failures, self.skips]): if url in result: assert res is None res = result[url] typ = pos if res is None: - typ += 1 + typ = len(PREFIXES) - 1 res = 'Missing' assert 0 <= pos < len(PREFIXES) return typ, url, res super(TestWikiSiteDetection, self).tearDown() - print('Out of %d sites, %d tests passed, %d tests failed ' - 'and %d tests raised an error' + print('Out of %d sites, %d tests passed, %d tests failed, ' + '%d tests skiped and %d tests raised an error' % (len(self.all), len(self.passes), len(self.failures), - len(self.errors)) + len(self.skips), len(self.errors)) ) - PREFIXES = ['PASS', 'ERR ', 'FAIL', 'MISS'] + PREFIXES = ['PASS', 'ERR ', 'FAIL', 'SKIP', 'MISS'] sorted_all = sorted((norm(url) for url in self.all), key=lambda item: item[0]) @@ -72,8 +75,12 @@ self.all += [url] try: site = MWSite(url) + except Timeout as e: + self.skips[url] = e + return except Exception as e: - print('failed on ' + url) + print('failure {0} on {1}: {2}'.format( + url, type(e), e)) self.errors[url] = e return try: @@ -92,6 +99,18 @@ def assertNoSite(self, url): """Assert a url is not a MediaWiki site.""" self._wiki_detection(url, None) + + def assertAllPass(self): + """Assert that all urls were detected as a MediaWiki site.""" + self.assertEqual(len(self.passes), len(self.all) - len(self.skips)) + self.assertEqual(len(self.failures), 0) + self.assertEqual(len(self.errors), 0) + + def assertAllError(self): + """Assert that all urls were not detected as a MediaWiki site.""" + self.assertEqual(len(self.passes), 0) + self.assertEqual(len(self.failures), 0) + self.assertEqual(len(self.errors), len(self.all) - len(self.skips)) def test_IWM(self): """Test the load_site method for MW sites on the IWM list.""" @@ -125,6 +144,7 @@ """Test detection of MediaWiki sites.""" self.assertSite('http://botwiki.sno.cc/wiki/$1') self.assertSite('http://glossary.reuters.com/index.php?title=$1') + self.assertSite('http://www.livepedia.gr/index.php?title=$1') self.assertSite('http://guildwars.wikia.com/wiki/$1') self.assertSite('http://www.hrwiki.org/index.php/$1') self.assertSite('http://www.proofwiki.org/wiki/$1') @@ -136,9 +156,7 @@ self.assertSite('http://www.EcoReality.org/wiki/$1') self.assertSite('http://www.wikichristian.org/index.php?title=$1') self.assertSite('http://wikitree.org/index.php?title=$1') - self.assertEqual(len(self.passes), 11) - self.assertEqual(len(self.failures), 0) - self.assertEqual(len(self.errors), 0) + self.assertAllPass() def test_detect_failure(self): """Test detection failure for MediaWiki sites with an API.""" @@ -149,7 +167,7 @@ self.assertNoSite('http://wiki.linuxquestions.org/wiki/$1') # offline self.assertNoSite('http://seattlewiki.org/wiki/$1') - self.assertEqual(len(self.errors), 4) + self.assertAllError() def test_pre_api_sites(self): """Test detection of MediaWiki sites prior to the API.""" @@ -159,7 +177,7 @@ self.assertNoSite('http://www.werelate.org/wiki/$1') self.assertNoSite('http://www.otterstedt.de/wiki/index.php/$1') self.assertNoSite('http://kb.mozillazine.org/$1') - self.assertEqual(len(self.errors), 6) + self.assertAllError() def test_detect_nosite(self): """Test detection of non-wiki sites.""" @@ -176,7 +194,7 @@ self.assertNoSite('http://arxiv.org/abs/$1') self.assertNoSite('http://musicbrainz.org/doc/$1') self.assertNoSite('http://wiki.animutationportal.com/index.php/$1') - self.assertEqual(len(self.errors), 11) + self.assertAllError() if __name__ == '__main__': -- To view, visit https://gerrit.wikimedia.org/r/234845 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e7cc972f262b281e65f56cf48c4ecd8148d1f4f Gerrit-PatchSet: 5 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

1 0

Broken: wikimedia/pywikibot-core#2746 (master - b6a6c0f)
by Travis CI 31 Aug '15

31 Aug '15

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2746 Status: Broken Duration: 30 minutes and 47 seconds Commit: b6a6c0f (master) Author: Kunal Mehta Message: Updated pywikibot/core Project: pywikibot/i18n 7dd81cea84c4d977758002bee54c6bfb567b5f69 Don't hardcode every directory in Gruntfile.js See <http://gruntjs.com/configuring-tasks#globbing-patterns>. Bug: T85335 Change-Id: Iea4f25b16f87e865ccb4dde63ec90236b8246f08 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/486253defecd...b6a6c0fd… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/77988298 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

1 0

[Gerrit] Use Q7 for test_item_missing - change (pywikibot/core)
by jenkins-bot (Code Review) 31 Aug '15

31 Aug '15

jenkins-bot has submitted this change and it was merged. Change subject: Use Q7 for test_item_missing ...................................................................... Use Q7 for test_item_missing Q404 was restored, causing test_item_missing to fail. Use Q7 instead. Bug: T110819 Change-Id: I96909daec59160e03d2217c5e7ba97aa1d69ee4a (cherry picked from commit a43537b81deb3806ca1cad1d83aab3d868c390ab) --- M tests/wikibase_tests.py 1 file changed, 16 insertions(+), 14 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index 5a37136..929dbd1 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -265,26 +265,28 @@ def test_item_missing(self): wikidata = self.get_repo() - # this item is deleted - item = pywikibot.ItemPage(wikidata, 'Q404') - self.assertEqual(item._link._title, 'Q404') - self.assertEqual(item.title(), 'Q404') + # this item has never existed + item = pywikibot.ItemPage(wikidata, 'Q7') + self.assertEqual(item._link._title, 'Q7') + self.assertEqual(item.title(), 'Q7') self.assertFalse(hasattr(item, '_content')) - self.assertEqual(item.id, 'Q404') - self.assertEqual(item.getID(), 'Q404') - self.assertEqual(item.getID(numeric=True), 404) + self.assertEqual(item.id, 'Q7') + self.assertEqual(item.getID(), 'Q7') + numeric_id = item.getID(numeric=True) + self.assertIsInstance(numeric_id, int) + self.assertEqual(numeric_id, 7) self.assertFalse(hasattr(item, '_content')) self.assertRaises(pywikibot.NoPage, item.get) self.assertTrue(hasattr(item, '_content')) - self.assertEqual(item.id, 'Q404') - self.assertEqual(item.getID(), 'Q404') - self.assertEqual(item._link._title, 'Q404') - self.assertEqual(item.title(), 'Q404') + self.assertEqual(item.id, 'Q7') + self.assertEqual(item.getID(), 'Q7') + self.assertEqual(item._link._title, 'Q7') + self.assertEqual(item.title(), 'Q7') self.assertRaises(pywikibot.NoPage, item.get) self.assertTrue(hasattr(item, '_content')) - self.assertEqual(item._link._title, 'Q404') - self.assertEqual(item.getID(), 'Q404') - self.assertEqual(item.title(), 'Q404') + self.assertEqual(item._link._title, 'Q7') + self.assertEqual(item.getID(), 'Q7') + self.assertEqual(item.title(), 'Q7') def test_item_never_existed(self): wikidata = self.get_repo() -- To view, visit https://gerrit.wikimedia.org/r/234946 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96909daec59160e03d2217c5e7ba97aa1d69ee4a Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: 2.0 Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

Broken: wikimedia/pywikibot-core#2745 (master - 486253d)
by Travis CI 31 Aug '15

31 Aug '15

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2745 Status: Broken Duration: 6 minutes and 37 seconds Commit: 486253d (master) Author: Kunal Mehta Message: Updated pywikibot/core Project: pywikibot/i18n d03a9ab0a156a6237ca34660eed166f7be29adfd Upgrade to working version of grunt-banana-checker 0.2.0 is totally broken. See <https://github.com/wikimedia/grunt-banana-checker/pull/14>. Change-Id: I58ffe0ebb311f527c52baa2f92b3449b2c618f3b View the changeset: https://github.com/wikimedia/pywikibot-core/compare/af204e0decad...486253de… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/77988260 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

1 0

Passed: wikimedia/pywikibot-core#2743 (master - af204e0)
by Travis CI 31 Aug '15

31 Aug '15

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2743 Status: Passed Duration: 32 minutes and 35 seconds Commit: af204e0 (master) Author: John Vandenberg Message: Updated pywikibot/core Project: pywikibot/i18n cdd85e2f69db9ede944b2b7ae3025d2d4d992eaa Add missing qqq messages Change-Id: I2a2c090842f5a01a8f219ebe95e5cc64e2aba204 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/0ab9ec974e31...af204e0d… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/77988193 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

1 0

[Gerrit] Don't hardcode every directory in Gruntfile.js - change (pywikibot/i18n)
by jenkins-bot (Code Review) 31 Aug '15

31 Aug '15

jenkins-bot has submitted this change and it was merged. Change subject: Don't hardcode every directory in Gruntfile.js ...................................................................... Don't hardcode every directory in Gruntfile.js See <http://gruntjs.com/configuring-tasks#globbing-patterns>. Bug: T85335 Change-Id: Iea4f25b16f87e865ccb4dde63ec90236b8246f08 --- M Gruntfile.js 1 file changed, 2 insertions(+), 49 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/Gruntfile.js b/Gruntfile.js index 1849c7b..971ed9f 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -8,55 +8,7 @@ grunt.initConfig( { banana: { - pywikibot: 'pywikibot/', - thirdparty: 'thirdparty/', - add_text: 'add_text/', - archivebot: 'archivebot/', - basic: 'basic/', - blockpageschecker: 'blockpageschecker/', - capitalize_redirects: 'capitalize_redirects/', - casechecker: 'casechecker/', - catall: 'catall/', - category: 'category/', - category_redirect: 'category_redirect/', - clean_sandbox: 'clean_sandbox/', - commons_link: 'commons_link/', - commons: 'commons/', - cosmetic_changes: 'cosmetic_changes/', - delete: 'delete/', - djvutext: 'djvutext/', - editarticle: 'editarticle/', - featured: 'featured/', - fixing_redirects: 'fixing_redirects/', - followlive: 'followlive/', - interwiki: 'interwiki/', - interwikidata: 'interwikidata/', - isbn: 'isbn/', - lonelypages: 'lonelypages/', - makecat: 'makecat/', - misspelling: 'misspelling/', - movepages: 'movepages/', - ndashredir: 'ndashredir/', - noreferences: 'noreferences/', - pagefromfile: 'pagefromfile/', - piper: 'piper/', - protect: 'protect/', - redirect: 'redirect/', - reflinks: 'reflinks/', - remove_edp_images: 'remove_edp_images/', - replace: 'replace/', - revertbot: 'revertbot/', - selflink: 'selflink/', - solve_disambiguation: 'solve_disambiguation/', - spamremove: 'spamremove/', - spellcheck: 'spellcheck/', - table2wiki: 'table2wiki/', - template: 'template/', - undelete: 'undelete/', - unprotect: 'unprotect/', - unlink: 'unlink/', - // Missing messages: weblinkchecker: 'weblinkchecker/', - welcome: 'welcome/' + all: ['*/', '!node_modules/'] } } ); @@ -64,3 +16,4 @@ grunt.registerTask( 'test', ['lint'] ); grunt.registerTask( 'default', ['test'] ); }; + -- To view, visit https://gerrit.wikimedia.org/r/234939 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea4f25b16f87e865ccb4dde63ec90236b8246f08 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/i18n Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] Upgrade to working version of grunt-banana-checker - change (pywikibot/i18n)
by jenkins-bot (Code Review) 31 Aug '15

31 Aug '15

jenkins-bot has submitted this change and it was merged. Change subject: Upgrade to working version of grunt-banana-checker ...................................................................... Upgrade to working version of grunt-banana-checker 0.2.0 is totally broken. See <https://github.com/wikimedia/grunt-banana-checker/pull/14>. Change-Id: I58ffe0ebb311f527c52baa2f92b3449b2c618f3b --- M package.json 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/package.json b/package.json index 7fa8e36..5387cac 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "devDependencies": { "grunt": "0.4.2", "grunt-cli": "0.1.13", - "grunt-banana-checker": "0.2.0" + "grunt-banana-checker": "0.2.2" } } -- To view, visit https://gerrit.wikimedia.org/r/234940 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58ffe0ebb311f527c52baa2f92b3449b2c618f3b Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/i18n Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] Add missing qqq messages - change (pywikibot/i18n)
by jenkins-bot (Code Review) 31 Aug '15

31 Aug '15

jenkins-bot has submitted this change and it was merged. Change subject: Add missing qqq messages ...................................................................... Add missing qqq messages Change-Id: I2a2c090842f5a01a8f219ebe95e5cc64e2aba204 --- M category_redirect/qqq.json M featured/qqq.json 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/category_redirect/qqq.json b/category_redirect/qqq.json index b4f7fe4..56e2ffe 100644 --- a/category_redirect/qqq.json +++ b/category_redirect/qqq.json @@ -2,12 +2,14 @@ "@metadata": { "authors": [ "Csisc", + "John Vandenberg", "Shirayuki", "Xqt" ] }, "category_redirect-add-template": "Used as edit summary.", "category_redirect-change-category": "Used as comment. Parameters:\n* %(oldCatLink)s - old category name\n* %(oldCatTitle)s - old category name\n* %(newCatLink)s - new category name\n* %(newCatTitle)s - new category name", + "category_redirect-comment": "Edit summary for maintenance notice of new redirects created.", "category_redirect-edit-request": "Variables:\n* %(itemlists)s - list of edit requests (pages). Uses the message {{msg-pywikibot|Category redirect-edit-request-item}}.", "category_redirect-edit-request-item": "Used as <code>%(itemlist)s</code> in {{msg-pywikibot|Category_redirect-edit-request}}.\n\nVariables:\n* %(title)s - page title\n* %(oldcat)s - old category name\n* %(newcat)s - new category name", "category_redirect-fix-double": "Edit summary when the bot fixes double category redirects." diff --git a/featured/qqq.json b/featured/qqq.json index 0a2ed51..e1fb00f 100644 --- a/featured/qqq.json +++ b/featured/qqq.json @@ -1,8 +1,12 @@ { "@metadata": { "authors": [ + "John Vandenberg", "Shirayuki" ] }, - "featured-former": "Used as edit summary. Variables:\n* %(page)s - page title" + "featured-featured": "Used as edit summary. Variables:\n* %(page)s - page title", + "featured-former": "Used as edit summary. Variables:\n* %(page)s - page title", + "featured-good": "Used as edit summary. Variables:\n* %(page)s - page title", + "featured-list": "Used as edit summary. Variables:\n* %(page)s - page title" } -- To view, visit https://gerrit.wikimedia.org/r/234941 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a2c090842f5a01a8f219ebe95e5cc64e2aba204 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/i18n Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

Passed: wikimedia/pywikibot-core#2741 (master - 0ab9ec9)
by Travis CI 31 Aug '15

31 Aug '15

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2741 Status: Passed Duration: 30 minutes and 31 seconds Commit: 0ab9ec9 (master) Author: jenkins-bot Message: Merge "[IMPROV] version: Import at top and BytesIO" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/c28b316c8b46...0ab9ec97… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/77976573 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

1 0

[Gerrit] [IMPROV] version: Import at top and BytesIO - change (pywikibot/core)
by jenkins-bot (Code Review) 31 Aug '15

31 Aug '15

jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] version: Import at top and BytesIO ...................................................................... [IMPROV] version: Import at top and BytesIO This moves the imports at the top of the file as suggested by PEP8. It also uses BytesIO and not StringIO and delegates the decoding to the underlying XML parser who can interpret the the header to determine the encoding. Change-Id: Ib7779b8d26a62dd11f3fcf344ca400239dbbf3f5 --- M pywikibot/version.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/version.py b/pywikibot/version.py index 8de383e..6022dff 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -18,6 +18,9 @@ import datetime import subprocess import codecs +import xml.dom.minidom + +from io import BytesIO from warnings import warn @@ -182,8 +185,6 @@ @return: the git hash @rtype: str """ - from io import StringIO - import xml.dom.minidom from pywikibot.comms import http uri = 'https://github.com/wikimedia/%s/!svn/vcc/default' % tag @@ -192,9 +193,8 @@ "<propfind xmlns=\"DAV:\"><allprop/></propfind>", headers={'label': str(rev), 'user-agent': 'SVN/1.7.5 {pwb}'}) - data = request.content - dom = xml.dom.minidom.parse(StringIO(data)) + dom = xml.dom.minidom.parse(BytesIO(request.raw)) hsh = dom.getElementsByTagName("C:git-commit")[0].firstChild.nodeValue date = dom.getElementsByTagName("S:date")[0].firstChild.nodeValue date = time.strptime(date[:19], '%Y-%m-%dT%H:%M:%S') -- To view, visit https://gerrit.wikimedia.org/r/200256 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7779b8d26a62dd11f3fcf344ca400239dbbf3f5 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits August 2015