jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] tests: Don't do hostname check if net=False
......................................................................
[FIX] tests: Don't do hostname check if net=False
When using net=False it shouldn't do any hostname checks as the test is
intended to be run without any network activity. This only affects tests which
also have a site defined (e.g. using dry=True) as CheckHostnameMixin wouldn't
check if no hostname or sites are defined.
Also verifies that net is not False when only hostnames (and not sites) are
defined as hostnames is only there for hostname checks.
Change-Id: Ic60d6d24b489bf63284164411ad5cf1d4ba2ece6
---
M tests/aspects.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/aspects.py b/tests/aspects.py
index 4c09d1c..11890d8 100644
--- a/tests/aspects.py
+++ b/tests/aspects.py
@@ -786,7 +786,10 @@
if 'cached' in dct and dct['cached']:
bases = tuple([ForceCacheMixin] + list(bases))
- bases = tuple([CheckHostnameMixin] + list(bases))
+ if 'net' in dct and dct['net']:
+ bases = tuple([CheckHostnameMixin] + list(bases))
+ else:
+ assert not hostnames, 'net must be True with hostnames defined'
if 'write' in dct and dct['write']:
if 'user' not in dct:
--
To view, visit https://gerrit.wikimedia.org/r/232715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic60d6d24b489bf63284164411ad5cf1d4ba2ece6
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Italian Wikipedia is not supported
......................................................................
Italian Wikipedia is not supported
The user template in the 'it' configuration has never existed,
much like the English configuration removed in e07cc841.
Also note that the user template should be subst:'d.
'جا:' added in 2012 is Farsi for subst:
https://www.mediawiki.org/wiki/Special:Code/pywikipedia/10706
Change-Id: I06f4b2844f50e217a64f3d5bfd967c0e09b798e0
---
M scripts/unusedfiles.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/unusedfiles.py b/scripts/unusedfiles.py
index 472b81a..30140aa 100755
--- a/scripts/unusedfiles.py
+++ b/scripts/unusedfiles.py
@@ -37,9 +37,10 @@
'it': u'{{immagine orfana}}',
'fa': u'{{تصاویر بدون استفاده}}',
}
+
+# This template message should use subst:
template_to_the_user = {
'fa': u'\n\n{{جا:اخطار به کاربر برای تصاویر بدون استفاده|%(title)s}}--~~~~',
- 'it': u'\n\n{{Utente:Filbot/Immagine orfana}}',
}
--
To view, visit https://gerrit.wikimedia.org/r/232691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06f4b2844f50e217a64f3d5bfd967c0e09b798e0
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>