Pywikibot-commits July 2015

pywikibot-commits@lists.wikimedia.org

2 participants
224 discussions

[Gerrit] [FIX] l10n_tests: Do lazy network requests - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FIX] l10n_tests: Do lazy network requests ...................................................................... [FIX] l10n_tests: Do lazy network requests To get the site's language it needs to query the site's siteinfo. When this is done in a test meta class it will do that regardless before something can check the net flag of the class. To avoid this it's now requesting the language inside the test method so that a testing environment can check the net flag before. This is also fixing other minor issues in the module: - Removed senseless comment - Use 'code' and 'family' attributes in both test classes - Using super to call the actual super metaclass and not generic type metaclass Change-Id: Iee5f4ad957b55139a07f711c30e682846df098f3 --- M tests/l10n_tests.py 1 file changed, 19 insertions(+), 23 deletions(-) Approvals: John Vandenberg: Looks good to me, approved XZise: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/tests/l10n_tests.py b/tests/l10n_tests.py index f184ff7..294914a 100644 --- a/tests/l10n_tests.py +++ b/tests/l10n_tests.py @@ -29,12 +29,14 @@ def __new__(cls, name, bases, dct): """Create the new class.""" - # this comment is to avoid senseless flake8 warning - - def test_method(msg, site): + def test_method(site): def test_template(self): """Test validity of template.""" + lang = site.lang + if lang not in keys: + return + msg = i18n.twtranslate(lang, package, fallback=False) if msg: # check whether the message contains a template template = re.findall(u'.*?{{(.*?)[|}]', msg) @@ -46,32 +48,24 @@ "'simple' wiki has 'en' language code but " "missing template. Must be solved by the " "corresponding script.") - if template: - # check whether template exists - title = template[0] - page = pywikibot.Page(site, title, ns=10) - self.assertTrue(page.exists()) + # check whether template exists + title = template[0] + page = pywikibot.Page(site, title, ns=10) + self.assertTrue(page.exists()) return test_template # create test methods for package messages processed by unittest - site = pywikibot.Site('en', 'wikipedia') + site = pywikibot.Site(dct['code'], dct['family']) codes = site.family.languages_by_size del site for package in PACKAGES: keys = i18n.twget_keys(package) for code in codes: - current_site = pywikibot.Site(code, 'wikipedia') - lang = current_site.lang - if lang not in keys: - continue - template_msg = i18n.twtranslate(lang, package, fallback=False) - if template_msg is None: - continue - test_name = ("test_%s_%s_%s" - % (package, lang, code)).replace('-', '_') - dct[test_name] = test_method(template_msg, current_site) - return type.__new__(cls, name, bases, dct) + current_site = pywikibot.Site(code, dct['family']) + test_name = ("test_%s_%s" % (package, code)).replace('-', '_') + dct[test_name] = test_method(current_site) + return super(TestValidTemplateMeta, cls).__new__(cls, name, bases, dct) @add_metaclass @@ -81,19 +75,21 @@ __metaclass__ = TestValidTemplateMeta - net = True # magic flag tells jenkins to not run the test. + family = 'wikipedia' + code = 'en' class TestSites(TestCase): """Other test L10N cases processed by unittest.""" - site = pywikibot.Site('en', 'wikipedia') + family = 'wikipedia' + code = 'en' def test_valid_sites(self): """Test whether language key has a corresponding site.""" codes = self.site.family.languages_by_size - languages = [pywikibot.Site(code, 'wikipedia').lang for code in codes] + languages = [pywikibot.Site(code, self.family).lang for code in codes] for package in PACKAGES: keys = i18n.twget_keys(package) for key in keys: -- To view, visit https://gerrit.wikimedia.org/r/226329 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee5f4ad957b55139a07f711c30e682846df098f3 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 9 months

Broken: wikimedia/pywikibot-core#2574 (master - d708022)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2574 Status: Broken Duration: 30 minutes and 41 seconds Commit: d708022 (master) Author: Fabian Neundorf Message: [IMPROV] page/textlib: add remaining docstrings Only two docstrings were missing from the page module with PEP257 0.6.0 to comply with the mandatory tox job. And the textlib module was missing only one. Change-Id: Ied7846896301e2acb587e7414aebb4b26438a69c View the changeset: https://github.com/wikimedia/pywikibot-core/compare/6255530f833c...d708022e… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/72202118 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 9 months

[Gerrit] [IMPROV] page/textlib: add remaining docstrings - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] page/textlib: add remaining docstrings ...................................................................... [IMPROV] page/textlib: add remaining docstrings Only two docstrings were missing from the page module with PEP257 0.6.0 to comply with the mandatory tox job. And the textlib module was missing only one. Change-Id: Ied7846896301e2acb587e7414aebb4b26438a69c --- M pywikibot/page.py M pywikibot/textlib.py M tox.ini 3 files changed, 35 insertions(+), 3 deletions(-) Approvals: John Vandenberg: Looks good to me, approved XZise: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index 73c030f..1f94132 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -4138,6 +4138,11 @@ 'hash': data['hash']}) def toJSON(self): + """ + Create dict suitable for the MediaWiki API. + + @rtype: dict + """ data = { 'mainsnak': { 'snaktype': self.snaktype, @@ -4524,6 +4529,17 @@ @property def sha1(self): + """ + Return and cache SHA1 checksum of the text. + + @return: if the SHA1 checksum is cached it'll be returned which is the + case when it was requested from the API. Otherwise it'll use the + revision's text to calculate the checksum (encoding it using UTF8 + first). That calculated checksum will be cached too and returned on + future calls. If the text is None (not queried) it will just return + None and does not cache anything. + @rtype: str or None + """ if self._sha1 is None: if self.text is None: # No text? No sha1 then. diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py index 1612436..a0b4d99 100644 --- a/pywikibot/textlib.py +++ b/pywikibot/textlib.py @@ -429,9 +429,23 @@ def expandmarker(text, marker='', separator=''): - # set to remove any number of separator occurrences plus arbitrary - # whitespace before, after, and between them, - # by allowing to include them into marker. + """ + Return a marker expanded whitespace and the separator. + + It searches for the first occurrence of the marker and gets the combination + of the separator and whitespace directly before it. + + @param text: the text which will be searched. + @type text: str + @param marker: the marker to be searched. + @type marker: str + @param separator: the separator string allowed before the marker. If empty + it won't include whitespace too. + @type separator: str + @return: the marker with the separator and whitespace from the text in front + of it. It'll be just the marker if the separator is empty. + @rtype: str + """ if separator: firstinmarker = text.find(marker) firstinseparator = firstinmarker diff --git a/tox.ini b/tox.ini index ae7e9c2..d85d20b 100644 --- a/tox.ini +++ b/tox.ini @@ -56,8 +56,10 @@ pywikibot/fixes.py \ pywikibot/i18n.py \ pywikibot/login.py \ + pywikibot/page.py \ pywikibot/pagegenerators.py \ pywikibot/plural.py \ + pywikibot/textlib.py \ pywikibot/throttle.py \ pywikibot/tools/__init__.py \ pywikibot/tools/ip.py \ -- To view, visit https://gerrit.wikimedia.org/r/226306 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied7846896301e2acb587e7414aebb4b26438a69c Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 9 months

Passed: wikimedia/pywikibot-core#2573 (master - 6255530)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2573 Status: Passed Duration: 27 minutes and 12 seconds Commit: 6255530 (master) Author: Fabian Neundorf Message: [FIX] aspects: Imply user on write tests At the moment all writes require a user to be logged in but tests may not define user and in that case the write test might fail because it's not working on a logged in user. This sets user to True if it hasn't been set and is a write test. So in case someone writes a write test without requiring a logged in user it's necessary to explicitly set write to False now. Change-Id: I4ef37ed6d9b28b72c0a1aa6be447818408c7107f View the changeset: https://github.com/wikimedia/pywikibot-core/compare/9745542476f8...6255530f… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/72098968 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 9 months

[Gerrit] [FIX] aspects: Imply user on write tests - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FIX] aspects: Imply user on write tests ...................................................................... [FIX] aspects: Imply user on write tests At the moment all writes require a user to be logged in but tests may not define user and in that case the write test might fail because it's not working on a logged in user. This sets user to True if it hasn't been set and is a write test. So in case someone writes a write test without requiring a logged in user it's necessary to explicitly set write to False now. Change-Id: I4ef37ed6d9b28b72c0a1aa6be447818408c7107f --- M tests/aspects.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/aspects.py b/tests/aspects.py index 8af9ade..df0a07c 100644 --- a/tests/aspects.py +++ b/tests/aspects.py @@ -763,6 +763,8 @@ bases = tuple([CheckHostnameMixin] + list(bases)) if 'write' in dct and dct['write']: + if 'user' not in dct: + dct['user'] = True bases = tuple([SiteWriteMixin] + list(bases)) if ('user' in dct and dct['user']) or ('sysop' in dct and dct['sysop']): -- To view, visit https://gerrit.wikimedia.org/r/226282 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ef37ed6d9b28b72c0a1aa6be447818408c7107f Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

8 years, 9 months

Fixed: wikimedia/pywikibot-core#2572 (master - 9745542)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2572 Status: Fixed Duration: 30 minutes and 28 seconds Commit: 9745542 (master) Author: jenkins-bot Message: Merge "Disable a part of testRecentChanges on wikidata" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/51b3a4f0538c...97455424… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/72034505 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 9 months

[Gerrit] Disable a part of testRecentChanges on wikidata - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Disable a part of testRecentChanges on wikidata ...................................................................... Disable a part of testRecentChanges on wikidata Split the test method testRecentChanges and testSearch into separate classes, and disable test_ns_file on wikidata. Bug: T101502 Change-Id: I39c5dfb18258a1f98f5d2c93b32a5880975c8fc5 --- M tests/site_tests.py 1 file changed, 57 insertions(+), 5 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_tests.py b/tests/site_tests.py index 329be12..871ef3e 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -956,22 +956,37 @@ end=pywikibot.Timestamp.fromISOformat('2008-02-03T00:00:01Z'), reverse=True, total=5) - def testRecentchanges(self): - """Test the site.recentchanges() method.""" - mysite = self.get_site() - mainpage = self.get_mainpage() + +class TestRecentChanges(DefaultSiteTestCase): + + """Test recentchanges method.""" + + @classmethod + def setUpClass(cls): + """Test up test class.""" + super(TestRecentChanges, cls).setUpClass() + mysite = cls.get_site() try: # 1st image on main page imagepage = next(iter(mysite.allimages())) except StopIteration: print("No images on site {0!r}".format(mysite)) imagepage = None + cls.imagepage = imagepage + + def test_basic(self): + """Test the site.recentchanges() method.""" + mysite = self.site rc = list(mysite.recentchanges(total=10)) self.assertLessEqual(len(rc), 10) self.assertTrue(all(isinstance(change, dict) for change in rc)) + + def test_time_range(self): + """Test the site.recentchanges() method with start/end.""" + mysite = self.site for change in mysite.recentchanges( - start=pywikibot.Timestamp.fromISOformat('2008-10-01T01:02:03Z'), + start=pywikibot.Timestamp.fromISOformat("2008-10-01T01:02:03Z"), total=5): self.assertIsInstance(change, dict) self.assertLessEqual(change['timestamp'], "2008-10-01T01:02:03Z") @@ -1013,6 +1028,13 @@ start=pywikibot.Timestamp.fromISOformat("2008-02-03T23:59:59Z"), end=pywikibot.Timestamp.fromISOformat('2008-02-03T00:00:01Z'), reverse=True, total=5) + + def test_ns_file(self): + """Test the site.recentchanges() method with File: and File talk:.""" + if self.site.code == 'wikidata': + raise unittest.SkipTest( + 'MediaWiki bug frequently occurring on Wikidata. T101502') + mysite = self.site for change in mysite.recentchanges(namespaces=[6, 7], total=5): self.assertIsInstance(change, dict) self.assertIn('title', change) @@ -1022,6 +1044,12 @@ prefix = title[:title.index(":")] self.assertIn(self.site.namespaces.lookup_name(prefix).id, [6, 7]) self.assertIn(change["ns"], [6, 7]) + + def test_pagelist(self): + """Test the site.recentchanges() with pagelist deprecated MW 1.14.""" + mysite = self.site + mainpage = self.get_mainpage() + imagepage = self.imagepage if MediaWikiVersion(mysite.version()) <= MediaWikiVersion("1.14"): pagelist = [mainpage] if imagepage: @@ -1032,11 +1060,19 @@ self.assertIsInstance(change, dict) self.assertIn("title", change) self.assertIn(change["title"], titlelist) + + def test_changetype(self): + """Test the site.recentchanges() with changetype.""" + mysite = self.site for typ in ("edit", "new", "log"): for change in mysite.recentchanges(changetype=typ, total=5): self.assertIsInstance(change, dict) self.assertIn("type", change) self.assertEqual(change["type"], typ) + + def test_flags(self): + """Test the site.recentchanges() with boolean flags.""" + mysite = self.site for change in mysite.recentchanges(showMinor=True, total=5): self.assertIsInstance(change, dict) self.assertIn("minor", change) @@ -1059,6 +1095,17 @@ for change in mysite.recentchanges(showRedirects=False, total=5): self.assertIsInstance(change, dict) self.assertNotIn("redirect", change) + + +class TestUserRecentChanges(DefaultSiteTestCase): + + """Test recentchanges method requiring a user.""" + + user = True + + def test_patrolled(self): + """Test the site.recentchanges() with patrolled boolean flags.""" + mysite = self.site for change in mysite.recentchanges(showPatrolled=True, total=5): self.assertIsInstance(change, dict) if mysite.has_right('patrol'): @@ -1068,6 +1115,11 @@ if mysite.has_right('patrol'): self.assertNotIn("patrolled", change) + +class SearchTestCase(DefaultSiteTestCase): + + """Test search method.""" + def testSearch(self): """Test the site.search() method.""" mysite = self.get_site() -- To view, visit https://gerrit.wikimedia.org/r/226057 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39c5dfb18258a1f98f5d2c93b32a5880975c8fc5 Gerrit-PatchSet: 5 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 9 months

[Gerrit] Run SITE_ONLY tests on wiki.musicbrainz.org - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Run SITE_ONLY tests on wiki.musicbrainz.org ...................................................................... Run SITE_ONLY tests on wiki.musicbrainz.org Test HTTP Basic Auth support based on wiki.musicbrainz.org. '1movedto2' is removed because it may not available on some sites for test generic ApiSite methods. Bug: T103783 Change-Id: I662f9c4328d1ec291d03aac52b3210956d91e624 --- M .travis.yml M tests/site_tests.py 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: John Vandenberg: Looks good to me, approved Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/.travis.yml b/.travis.yml index 6e07c11..c8fb5c7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -46,6 +46,7 @@ - mkdir ~/.pywikibot - python pwb.py generate_family_file 'http://test.orain.org/' oraintest + - python pwb.py generate_family_file 'https://wiki.musicbrainz.org/' musicbrainz - python -W error::UserWarning -m generate_user_files -dir:~/.pywikibot/ -family:$FAMILY -lang:$LANGUAGE -v -user:"$PYWIKIBOT2_USERNAME" - if [[ -n "$USER_PASSWORD" && -n "$PYWIKIBOT2_USERNAME" ]]; then @@ -57,6 +58,8 @@ echo "import os" >> ~/.pywikibot/user-config.py ; echo "password_file = os.path.expanduser('~/.pywikibot/passwordfile')" >> ~/.pywikibot/user-config.py ; fi + + - echo "authenticate['wiki.musicbrainz.org'] = ('NOTSPAM', 'NOTSPAM')" >> ~/.pywikibot/user-config.py ; - echo "max_retries = 2" >> ~/.pywikibot/user-config.py - echo "maximum_GET_length = 5000" >> ~/.pywikibot/user-config.py @@ -95,6 +98,8 @@ env: LANGUAGE=wikia FAMILY=wikia PYWIKIBOT2_TEST_NO_RC=1 - python: '3.3' env: LANGUAGE=en FAMILY=oraintest SITE_ONLY=1 + - python: '3.3' + env: LANGUAGE=en FAMILY=musicbrainz SITE_ONLY=1 - python: '3.4' env: LANGUAGE=test FAMILY=wikidata SITE_ONLY=1 - python: '3.4' diff --git a/tests/site_tests.py b/tests/site_tests.py index 51dd11c..4ab5926 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -291,14 +291,13 @@ self.assertIsInstance(mysite.logged_in(True), bool) self.assertIsInstance(mysite.userinfo, dict) - for msg in ("1movedto2", "about", "aboutpage", "aboutsite", - "accesskey-n-portal"): + for msg in ('about', 'aboutpage', 'aboutsite', 'accesskey-n-portal'): self.assertTrue(mysite.has_mediawiki_message(msg)) self.assertIsInstance(mysite.mediawiki_message(msg), basestring) self.assertFalse(mysite.has_mediawiki_message("nosuchmessage")) self.assertRaises(KeyError, mysite.mediawiki_message, "nosuchmessage") - msg = ("1movedto2", "about", "aboutpage") + msg = ('about', 'aboutpage') self.assertIsInstance(mysite.mediawiki_messages(msg), dict) self.assertTrue(mysite.mediawiki_messages(msg)) -- To view, visit https://gerrit.wikimedia.org/r/225843 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I662f9c4328d1ec291d03aac52b3210956d91e624 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: VcamX <vcamx3(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: VcamX <vcamx3(a)gmail.com> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 9 months

[Gerrit] [FIX] Update pywikibot.__release__ to 2.0rc2 - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FIX] Update pywikibot.__release__ to 2.0rc2 ...................................................................... [FIX] Update pywikibot.__release__ to 2.0rc2 Change-Id: I9cad40a683bc41a20a9b48e17f90bc59e2ae099c --- M pywikibot/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: John Vandenberg: Looks good to me, approved Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/__init__.py b/pywikibot/__init__.py index ea8304a..0aaa184 100644 --- a/pywikibot/__init__.py +++ b/pywikibot/__init__.py @@ -7,7 +7,7 @@ # from __future__ import unicode_literals -__release__ = '2.0b3' +__release__ = '2.0rc2' __version__ = '$Id$' import datetime -- To view, visit https://gerrit.wikimedia.org/r/226143 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cad40a683bc41a20a9b48e17f90bc59e2ae099c Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: 2.0 Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

8 years, 9 months

[Gerrit] [IMPROV] Convert comment to docstring - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] Convert comment to docstring ...................................................................... [IMPROV] Convert comment to docstring The comment above CosmeticChangesToolkit.commonsfiledesc in pywikibot.cosmetic_changes is converted into a proper docstring. Change-Id: Ifc5aa5f30eaea8ef5f1937ffab9cdc6eddc26f9f --- M pywikibot/cosmetic_changes.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/cosmetic_changes.py b/pywikibot/cosmetic_changes.py index c85548c..1fa7e21 100755 --- a/pywikibot/cosmetic_changes.py +++ b/pywikibot/cosmetic_changes.py @@ -886,8 +886,15 @@ text = textlib.replaceExcept(text, str(i), new[i], exceptions) return text - # Retrieved from "https://commons.wikimedia.org/wiki/Commons:Tools/pywiki_file_description_cl…" def commonsfiledesc(self, text): + """ + Clean up file descriptions on the Wikimedia Commons. + + It is working according to [1] and works only on pages in the file + namespace on the Wikimedia Commons. + + [1]: https://commons.wikimedia.org/wiki/Commons:Tools/pywiki_file_description_cl… + """ if self.site.sitename() != u'commons:commons' or self.namespace == 6: return # section headers to {{int:}} versions -- To view, visit https://gerrit.wikimedia.org/r/225883 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc5aa5f30eaea8ef5f1937ffab9cdc6eddc26f9f Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 9 months

← Newer
1
2
3
4
5
6
7
8
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits July 2015