jenkins-bot has submitted this change and it was merged.
Change subject: [IMPR] Give more precise message for assert error
......................................................................
[IMPR] Give more precise message for assert error
Change-Id: Ibba56032fdd90c4d6991e74d75696f04815a1b0f
---
M tests/l10n_tests.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/l10n_tests.py b/tests/l10n_tests.py
index 287d602..f184ff7 100644
--- a/tests/l10n_tests.py
+++ b/tests/l10n_tests.py
@@ -98,7 +98,8 @@
keys = i18n.twget_keys(package)
for key in keys:
self.assertIn(key, languages,
- "%s not found in site codes" % key)
+ "'%s' - json key '%s' is not a site language"
+ % (package, key))
if __name__ == '__main__':
--
To view, visit https://gerrit.wikimedia.org/r/223810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibba56032fdd90c4d6991e74d75696f04815a1b0f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: jenkins-bot <>
Build Update for wikimedia/pywikibot-core
-------------------------------------
Build: #2515
Status: Passed
Duration: 28 minutes and 45 seconds
Commit: 170b9a9 (2.0)
Author: Fabian Neundorf
Message: [FIX] checkimages: Convert generator to iterator
With ff628236 the general handling of the script changed and with that it also
now used duplicates based on the hash differently. It tried to step through the
generator but that is not possible without turning them first into a iterator.
Bug: T105188
Change-Id: I02791b150b000beda86b7510663badaf842b41ba
View the changeset: https://github.com/wikimedia/pywikibot-core/compare/21d6a8dee427...170b9a9f…
View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/70281070
--
You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications
Build Update for wikimedia/pywikibot-core
-------------------------------------
Build: #2514
Status: Broken
Duration: 25 minutes and 23 seconds
Commit: 21d6a8d (2.0)
Author: John Vandenberg
Message: Remove broken wikis from battlestarwiki family
Moving these languages from langs to interwiki_removals will
cause anyone using Pywikibot to remove any interlanguage links
to these languages when they appear on English and German
Battlestarwiki. However as these sites have been down for a
while, and their User:Interwiki_Bot hasnt been active for many years,
and there are no bot edits in the last month on the English site.
Bug: T103470
Change-Id: Icd54ef6bda2544fb0134a0e7e8267c6ada45cc1c
View the changeset: https://github.com/wikimedia/pywikibot-core/compare/8d76870b5d4d...21d6a8de…
View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/70280909
--
You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications
Build Update for wikimedia/pywikibot-core
-------------------------------------
Build: #2512
Status: Broken
Duration: 23 minutes and 50 seconds
Commit: c7a12b5 (2.0)
Author: xqt
Message: [bugfix] Workaround UnicodeDecodeError on api error
When an API error happens it tries to log the parameters but it fails as they
are in a dict and the str and repr of a dict use the repr of each key and
value. If the value is then a Page instance it gets in Python 2 bytes returned
encoded with the console encoding. If then the str or repr of the dict is
inserted into a unicode it must decode the bytes and uses by default ASCII
which fails if the Page's title contains non-ASCII characters.
This patch works around that by manually decoding the bytes in Python 2 using
the console encoding whenever an API error happens but does not actually fix
Page's repr method so it might still fail at other places. It assumes that the
rest of the str is either also encoded using that or is encoded using ASCII and
that the console encoding is a superset of ASCII.
Conflicts:
pywikibot/data/api.py
tests/api_tests.py
Bug: T66958
Change-Id: I298b7594599dd189211a8c268c7e094d042f40e6
View the changeset: https://github.com/wikimedia/pywikibot-core/compare/d7212495a69d...c7a12b5e…
View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/70280077
--
You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications