Pywikibot-commits June 2015

pywikibot-commits@lists.wikimedia.org

2 participants
301 discussions

[Gerrit] "Amir Sarabadani" is already there, removing "Ladsgroup" - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: "Amir Sarabadani" is already there, removing "Ladsgroup" ...................................................................... "Amir Sarabadani" is already there, removing "Ladsgroup" Change-Id: I6f190bc7ca591b6384b666f1d4fea51bf093ca41 --- M CREDITS 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ladsgroup: Looks good to me, approved jenkins-bot: Verified diff --git a/CREDITS b/CREDITS index 714ca0f..86ca30b 100644 --- a/CREDITS +++ b/CREDITS @@ -41,7 +41,6 @@ Karl Eichwalder Kim Bruning Kunal Mehta -Ladsgroup Leonardo Gregianin Lewis Cawte Linedwell -- To view, visit https://gerrit.wikimedia.org/r/216536 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f190bc7ca591b6384b666f1d4fea51bf093ca41 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

Passed: wikimedia/pywikibot-core#2342 (master - bc70ee4)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2342 Status: Passed Duration: 21 minutes and 59 seconds Commit: bc70ee4 (master) Author: jenkins-bot Message: Merge "[doc] Add FileInfo to the list of included objects." View the changeset: https://github.com/wikimedia/pywikibot-core/compare/1bd376882f08...bc70ee45… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/65771930 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

[Gerrit] [doc] Add FileInfo to the list of included objects. - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [doc] Add FileInfo to the list of included objects. ...................................................................... [doc] Add FileInfo to the list of included objects. Also sort list by class occurence. Change-Id: I96ea48976c8c02d08b67f9d3383b5f811986dbb6 --- M pywikibot/page.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index 16a69d0..f89a1d9 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -3,10 +3,11 @@ Objects representing various types of MediaWiki, including Wikibase, pages. This module also includes objects: -* Link: an internal or interwiki link in wikitext. -* Revision: a single change to a wiki page. * Property: a type of semantic data. * Claim: an instance of a semantic assertion. +* Revision: a single change to a wiki page. +* FileInfo: a structure holding imageinfo of latest rev. of FilePage +* Link: an internal or interwiki link in wikitext. """ # -- To view, visit https://gerrit.wikimedia.org/r/216522 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96ea48976c8c02d08b67f9d3383b5f811986dbb6 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

Passed: wikimedia/pywikibot-core#2341 (master - 1bd3768)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2341 Status: Passed Duration: 22 minutes and 35 seconds Commit: 1bd3768 (master) Author: jenkins-bot Message: Merge "Test save flags nocreate, recreate and onlycreate" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/519dd943b485...1bd37688… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/65769571 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

[Gerrit] Test save flags nocreate, recreate and onlycreate - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Test save flags nocreate, recreate and onlycreate ...................................................................... Test save flags nocreate, recreate and onlycreate Change-Id: I1d1a65cceca31e8d97081839e2ec8cc8e49b3844 --- M tests/edit_failure_tests.py M tests/edit_tests.py 2 files changed, 24 insertions(+), 0 deletions(-) Approvals: XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/edit_failure_tests.py b/tests/edit_failure_tests.py index ba85bc5..112d98c 100644 --- a/tests/edit_failure_tests.py +++ b/tests/edit_failure_tests.py @@ -23,6 +23,8 @@ LockedPage, SpamfilterError, OtherPageSaveError, + NoCreateError, + PageCreatedConflict, ) from tests.aspects import unittest, TestCase, WikibaseTestCase @@ -64,6 +66,22 @@ new_text = page.get(force=True) self.assertEqual(old_text, new_text) + def test_createonly(self): + """Test that Page.save with createonly fails if page exists.""" + page = pywikibot.Page(self.site, 'User:Xqt/sandbox') + self.assertRaises(PageCreatedConflict, page.save, createonly=True) + + def test_nocreate(self): + """Test that Page.save with nocreate fails if page does not exist.""" + page = pywikibot.Page(self.site, 'User:John_Vandenberg/no_recreate') + self.assertRaises(NoCreateError, page.save, nocreate=True) + + def test_no_recreate(self): + """Test that Page.save with recreate disabled fails if page existed.""" + page = pywikibot.Page(self.site, 'User:John_Vandenberg/no_recreate') + self.assertRaisesRegex(OtherPageSaveError, 'Page .* doesn\'t exist', + page.save, recreate=False) + class TestActionFailure(TestCase): diff --git a/tests/edit_tests.py b/tests/edit_tests.py index 7a99297..7a4cf5d 100644 --- a/tests/edit_tests.py +++ b/tests/edit_tests.py @@ -31,6 +31,12 @@ user = True write = True + def test_createonly(self): + """Test save with createonly enforced.""" + ts = str(time.time()) + p = pywikibot.Page(self.site, 'User:John Vandenberg/createonly/' + ts) + p.save(createonly=True) + def test_async(self): """Test writing to a page.""" global called_back -- To view, visit https://gerrit.wikimedia.org/r/216525 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d1a65cceca31e8d97081839e2ec8cc8e49b3844 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

Passed: wikimedia/pywikibot-core#2340 (master - 519dd94)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2340 Status: Passed Duration: 17 minutes and 10 seconds Commit: 519dd94 (master) Author: jenkins-bot Message: Merge "[flake8] Remove obsolete site.pageinterwiki() method, add some docstrings" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/f0e0d8715152...519dd943… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/65766614 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

[Gerrit] [flake8] Remove obsolete site.pageinterwiki() method, add so... - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [flake8] Remove obsolete site.pageinterwiki() method, add some docstrings ...................................................................... [flake8] Remove obsolete site.pageinterwiki() method, add some docstrings - Remove explicit unicode literals in editarticle which are no longer needed due to "from __future__ import unicode_literals" - Add two files to the flake8-docstrings-mandatory section Change-Id: I51ce5eb9827af03e491a364f87de5a6744ce1c38 --- M pywikibot/cosmetic_changes.py M pywikibot/family.py M pywikibot/page.py M pywikibot/site.py M scripts/editarticle.py M scripts/noreferences.py M tox.ini 7 files changed, 20 insertions(+), 12 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/cosmetic_changes.py b/pywikibot/cosmetic_changes.py index bced95d..ac6c7cf 100755 --- a/pywikibot/cosmetic_changes.py +++ b/pywikibot/cosmetic_changes.py @@ -213,6 +213,7 @@ @deprecate_arg('debug', 'diff') def __init__(self, site, diff=False, redirect=False, namespace=None, pageTitle=None, ignore=CANCEL_ALL): + """Constructor.""" self.site = site self.diff = diff self.redirect = redirect @@ -624,6 +625,7 @@ return text def removeUselessSpaces(self, text): + """Cleanup multiple or trailing spaces.""" multipleSpacesR = re.compile(' +') spaceAtLineEndR = re.compile(' $') exceptions = ['comment', 'math', 'nowiki', 'pre', 'startspace', 'table', diff --git a/pywikibot/family.py b/pywikibot/family.py index c6566c9..1df55fe 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -46,6 +46,7 @@ """Parent class for all wiki families.""" def __init__(self): + """Constructor.""" if not hasattr(self, 'name'): self.name = None diff --git a/pywikibot/page.py b/pywikibot/page.py index 86290c7..ba3a58d 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -1858,6 +1858,7 @@ @deprecated('Page.is_flow_page()') def isFlowPage(self): + """DEPRECATED: use self.is_flow_page instead.""" return self.is_flow_page() def is_flow_page(self): diff --git a/pywikibot/site.py b/pywikibot/site.py index 2bd2c6b..f8e9c6d 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -3359,10 +3359,6 @@ raise NoPage(page) api.update_page(page, pagedata, rvgen.props) - def pageinterwiki(self, page): - # No such function in the API (this method isn't called anywhere) - raise NotImplementedError - def pagelanglinks(self, page, step=None, total=None, include_obsolete=False): """Iterate all interlanguage links on page, yielding Link objects. diff --git a/scripts/editarticle.py b/scripts/editarticle.py index db48b77..ad0b422 100755 --- a/scripts/editarticle.py +++ b/scripts/editarticle.py @@ -23,7 +23,7 @@ """ # # (C) Gerrit Holl, 2004 -# (C) Pywikibot team, 2004-2014 +# (C) Pywikibot team, 2004-2015 # # Distributed under the terms of the MIT license. # @@ -51,6 +51,7 @@ # joinchars = string.letters + '[]' + string.digits def __init__(self, *args): + """Constructor.""" self.set_options(*args) self.setpage() self.site = pywikibot.Site() @@ -70,28 +71,31 @@ self.options = parser.parse_args(my_args) if self.options.page and self.options.wikipage: - pywikibot.error(u"Multiple pages passed. Please specify a single page to edit.") + pywikibot.error("Multiple pages passed. Please specify a single " + "page to edit.") sys.exit(1) self.options.page = self.options.page or self.options.wikipage def setpage(self): """Set page and page title.""" site = pywikibot.Site() - pageTitle = self.options.page or pywikibot.input(u"Page to edit:") + pageTitle = self.options.page or pywikibot.input("Page to edit:") self.page = pywikibot.Page(pywikibot.Link(pageTitle, site)) if not self.options.edit_redirect and self.page.isRedirectPage(): self.page = self.page.getRedirectTarget() def handle_edit_conflict(self, new): + """When an edit conflict occures save the new text to a file.""" fn = os.path.join(tempfile.gettempdir(), self.page.title()) fp = open(fn, 'w') fp.write(new) fp.close() pywikibot.output( - u"An edit conflict has arisen. Your edit has been saved to %s. Please try again." - % fn) + "An edit conflict has arisen. Your edit has been saved to %s. " + "Please try again." % fn) def run(self): + """Run the bot.""" self.site.login() try: old = self.page.get(get_redirect=self.options.edit_redirect) @@ -101,7 +105,7 @@ new = textEditor.edit(old) if new and old != new: pywikibot.showDiff(old, new) - changes = pywikibot.input(u"What did you change?") + changes = pywikibot.input("What did you change?") comment = i18n.twtranslate(pywikibot.Site(), 'editarticle-edit', {'description': changes}) try: @@ -110,7 +114,7 @@ except pywikibot.EditConflict: self.handle_edit_conflict(new) else: - pywikibot.output(u"Nothing changed") + pywikibot.output("Nothing changed") def main(*args): diff --git a/scripts/noreferences.py b/scripts/noreferences.py index 1c22bbb..a8f12b6 100755 --- a/scripts/noreferences.py +++ b/scripts/noreferences.py @@ -463,6 +463,7 @@ self.referencesR = re.compile('<references.*?/>', re.IGNORECASE) def __iter__(self): + """XML iterator.""" from pywikibot import xmlreader dump = xmlreader.XmlDump(self.xmlFilename) for entry in dump.parse(): @@ -636,6 +637,7 @@ return self.createReferenceSection(oldText, index) def createReferenceSection(self, oldText, index, ident='=='): + """Create a reference section and insert it into the given text.""" if self.site.language() in noTitleRequired: newSection = u'\n%s\n' % (self.referencesText) else: @@ -647,7 +649,7 @@ return oldText[:index] + newSection + oldText[index:] def run(self): - + """Run the bot.""" for page in self.generator: self.current_page = page try: diff --git a/tox.ini b/tox.ini index e34218b..d78f8df 100644 --- a/tox.ini +++ b/tox.ini @@ -78,6 +78,7 @@ scripts/data_ingestion.py \ scripts/delete.py \ scripts/disambredir.py \ + scripts/editarticle.py \ scripts/fixing_redirects.py \ scripts/flickrripper.py \ scripts/harvest_template.py \ @@ -89,6 +90,7 @@ scripts/login.py \ scripts/maintenance/__init__.py \ scripts/newitem.py \ + scripts/noreferences.py \ scripts/pagefromfile.py \ scripts/piper.py \ scripts/protect.py \ -- To view, visit https://gerrit.wikimedia.org/r/210930 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51ce5eb9827af03e491a364f87de5a6744ce1c38 Gerrit-PatchSet: 5 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

Fixed: wikimedia/pywikibot-core#2339 (master - f0e0d87)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2339 Status: Fixed Duration: 17 minutes and 38 seconds Commit: f0e0d87 (master) Author: jenkins-bot Message: Merge "Skip RC entries without a title" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/73ba5a66abe4...f0e0d871… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/65686841 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

[Gerrit] Skip RC entries without a title - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Skip RC entries without a title ...................................................................... Skip RC entries without a title The title in a log entry may have been suppressed, and wont appear in the item data. Bug: T78152 Change-Id: I2b27813eb2b6861d606177f69d2eefa813c0cbd0 --- M pywikibot/pagegenerators.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py index 12e7523..dd96d21 100644 --- a/pywikibot/pagegenerators.py +++ b/pywikibot/pagegenerators.py @@ -994,6 +994,9 @@ showPatrolled=showPatrolled, topOnly=topOnly, step=step, total=total, user=user, excludeuser=excludeuser): + # The title in a log entry may have been suppressed + if 'title' not in item and item['type'] == 'log': + continue yield pywikibot.Page(pywikibot.Link(item["title"], site)) @@ -2047,6 +2050,9 @@ from pywikibot.comms.rcstream import site_rc_listener for entry in site_rc_listener(site, total=total): + # The title in a log entry may have been suppressed + if 'title' not in entry and entry['type'] == 'log': + continue page = pywikibot.Page(site, entry['title'], entry['namespace']) page._rcinfo = entry yield page -- To view, visit https://gerrit.wikimedia.org/r/216413 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b27813eb2b6861d606177f69d2eefa813c0cbd0 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

[Gerrit] Deadlock problem fixed by using requests - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Deadlock problem fixed by using requests ...................................................................... Deadlock problem fixed by using requests Bug: T71781 Change-Id: Iae9454cc0c7d4c815b2d9def7a8510d9d38f24e3 --- M scripts/makecat.py M tests/script_tests.py 2 files changed, 3 insertions(+), 16 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/makecat.py b/scripts/makecat.py index b2885f5..d1a80f9 100755 --- a/scripts/makecat.py +++ b/scripts/makecat.py @@ -194,7 +194,7 @@ main = True workingcatname = '' tocheck = DequeGenerator() - for arg in pywikibot.handleArgs(): + for arg in pywikibot.handle_args(): if arg.startswith('-nodate'): skipdates = True elif arg.startswith('-forward'): diff --git a/tests/script_tests.py b/tests/script_tests.py index bf11a8b..f93d126 100644 --- a/tests/script_tests.py +++ b/tests/script_tests.py @@ -66,10 +66,6 @@ 'script_wui', # depends on lua compiling ] -deadlock_script_list = [ - 'makecat', # bug 69781 -] - script_list = (['login'] + [name[0:-3] for name in os.listdir(scripts_path) # strip '.py' if name.endswith('.py') and @@ -173,10 +169,6 @@ # cause the loader to fallback to its own # discover() ordering of unit tests. - if deadlock_script_list: - print('Skipping deadlock scripts:\n %s' - % ', '.join(deadlock_script_list)) - if unrunnable_script_list: print('Skipping execution of unrunnable scripts:\n %r' % unrunnable_script_list) @@ -189,14 +181,12 @@ tests = (['test__login_help'] + ['test_' + name + '_help' for name in sorted(script_list) - if name != 'login' and - name not in deadlock_script_list] + + if name != 'login'] + ['test__login_simulate']) tests += ['test_' + name + '_simulate' for name in sorted(script_list) if name != 'login' and - name not in deadlock_script_list and name not in failed_dep_script_list and name not in unrunnable_script_list and (enable_autorun_tests or name not in auto_run_script_list)] @@ -343,9 +333,6 @@ # TODO: after bug 68611 and 68664 (and makecat), split -help # execution to a separate test class which uses site=False. - if script_name in deadlock_script_list: - dct[test_name].__test__ = False - if script_name == 'login': test_name = 'test__' + script_name + '_simulate' else: @@ -372,7 +359,7 @@ dct[test_name].__name__ = test_name # Disable test by default in nosetests - if script_name in unrunnable_script_list + deadlock_script_list: + if script_name in unrunnable_script_list: dct[test_name].__test__ = False # TODO: Ideally any script not on the auto_run_script_list -- To view, visit https://gerrit.wikimedia.org/r/216407 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae9454cc0c7d4c815b2d9def7a8510d9d38f24e3 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

← Newer
1
...
22
23
24
25
26
27
28
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits June 2015