Pywikibot-commits June 2015

pywikibot-commits@lists.wikimedia.org

2 participants
301 discussions

Fixed: wikimedia/pywikibot-core#2414 (master - d8828b5)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2414 Status: Fixed Duration: 20 minutes and 36 seconds Commit: d8828b5 (master) Author: Fabian Neundorf Message: [IMPROV] Tests: Do assertIn/assertNotIn if possible Change-Id: Iac2349170f6c883717beadf59dfe591d0f188406 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/8931dfdb1b67...d8828b51… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/67671083 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

[Gerrit] [IMPROV] Tests: Do assertIn/assertNotIn if possible - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] Tests: Do assertIn/assertNotIn if possible ...................................................................... [IMPROV] Tests: Do assertIn/assertNotIn if possible Change-Id: Iac2349170f6c883717beadf59dfe591d0f188406 --- M tests/l10n_tests.py M tests/site_tests.py M tests/wikibase_edit_tests.py 3 files changed, 13 insertions(+), 10 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/l10n_tests.py b/tests/l10n_tests.py index 46981a7..10e95b9 100644 --- a/tests/l10n_tests.py +++ b/tests/l10n_tests.py @@ -43,7 +43,7 @@ if template: # check whether site is valid site = pywikibot.Site('en', 'wikipedia') - self.assertTrue(code in site.languages()) + self.assertIn(code, site.languages()) # check whether template exists title = template[0] diff --git a/tests/site_tests.py b/tests/site_tests.py index 86af273..b022919 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -359,7 +359,7 @@ gen = site._generator(pywikibot.data.api.PageGenerator, type_arg='backlinks', namespaces=None) - self.assertTrue('gblnamespace' not in gen.request) + self.assertNotIn('gblnamespace', gen.request) gen = site._generator(pywikibot.data.api.PageGenerator, type_arg='backlinks', namespaces=1) @@ -400,7 +400,7 @@ self.assertIsInstance(ei, pywikibot.Page) self.assertIn(ei, refs) for ref in refs: - self.assertTrue(ref in backlinks or ref in embedded) + self.assertIn(ref, backlinks | embedded) # test embeddedin arguments self.assertTrue(embedded.issuperset( set(mysite.page_embeddedin(mainpage, filterRedirects=True, @@ -625,7 +625,8 @@ self.assertTrue(user["name"].startswith("D")) self.assertIn("editcount", user) self.assertIn("registration", user) - self.assertTrue("groups" in user and "sysop" in user["groups"]) + self.assertIn('groups' in user) + self.assertIn('sysop' in user['groups']) def testAllImages(self): """Test the site.allimages() method.""" @@ -980,7 +981,8 @@ end=pywikibot.Timestamp.fromISOformat("2008-02-03T00:00:01Z"), reverse=True, total=5) for change in mysite.recentchanges(namespaces=[6, 7], total=5): self.assertIsInstance(change, dict) - self.assertTrue("title" in change and "ns" in change) + self.assertIn('title', change) + self.assertIn('ns', change) title = change['title'] self.assertIn(":", title) prefix = title[:title.index(":")] @@ -1179,7 +1181,8 @@ end="2008-09-03T00:00:01Z", reverse=True, total=5) for rev in mysite.watchlist_revs(namespaces=[6, 7], total=5): self.assertIsInstance(rev, dict) - self.assertTrue("title" in rev and "ns" in rev) + self.assertIn('title', rev) + self.assertIn('ns', rev) title = rev['title'] self.assertIn(":", title) prefix = title[:title.index(":")] @@ -1676,7 +1679,7 @@ def test_async_request(self): self.assertTrue(page_put_queue.empty()) - self.assertTrue('statistics' not in self.site.siteinfo) + self.assertNotIn('statistics', self.site.siteinfo) async_request(self.site.siteinfo.get, 'statistics') page_put_queue.join() self.assertIn('statistics', self.site.siteinfo) diff --git a/tests/wikibase_edit_tests.py b/tests/wikibase_edit_tests.py index 84dc056..30d2582 100644 --- a/tests/wikibase_edit_tests.py +++ b/tests/wikibase_edit_tests.py @@ -42,8 +42,8 @@ item.editLabels({'en': 'Test123'}) item.editLabels({'fa': 'Test123'}) item.get(force=True) - self.assertTrue('en' in item.labels.keys()) - self.assertTrue('fa' in item.labels.keys()) + self.assertIn('en', item.labels.keys()) + self.assertIn('fa', item.labels.keys()) # This should remove the 'fa' label item.editLabels({'en': 'Test123', 'fa': ''}) @@ -51,7 +51,7 @@ # Check 'fa' label is removed item = pywikibot.ItemPage(testsite, 'Q68') item.get() - self.assertFalse('fa' in item.labels.keys()) + self.assertNotIn('fa', item.labels.keys()) def test_alias_set(self): testsite = self.get_repo() -- To view, visit https://gerrit.wikimedia.org/r/219587 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac2349170f6c883717beadf59dfe591d0f188406 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

Broken: wikimedia/pywikibot-core#2413 (master - 8931dfd)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2413 Status: Broken Duration: 22 minutes and 27 seconds Commit: 8931dfd (master) Author: jenkins-bot Message: Merge "Remove interwiki_putfirst_doubled" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/04c1391f7eef...8931dfdb… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/67667913 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

[Gerrit] Remove interwiki_putfirst_doubled - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Remove interwiki_putfirst_doubled ...................................................................... Remove interwiki_putfirst_doubled Bug: T103093 Change-Id: I24eafe79b9b38a2f4fd83c084293eafe2108a10b --- M pywikibot/family.py M pywikibot/site.py M pywikibot/textlib.py 3 files changed, 0 insertions(+), 28 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/family.py b/pywikibot/family.py index 467651a..7343d37 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -745,12 +745,6 @@ # order. self.interwiki_putfirst = {} - # Languages in interwiki_putfirst_doubled should have a number plus - # a list of languages. If there are at least the number of interwiki - # links, all languages in the list should be placed at the front as - # well as in the normal list. - self.interwiki_putfirst_doubled = {} # THIS APPEARS TO BE UNUSED! - # Some families, e. g. commons and meta, are not multilingual and # forward interlanguage links to another family (wikipedia). # These families can set this variable to the name of the target diff --git a/pywikibot/site.py b/pywikibot/site.py index 1e18a29..ca340a7 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -1005,25 +1005,6 @@ """Return list of language codes for ordering of interwiki links.""" return self.family.interwiki_putfirst.get(self.code, None) - def interwiki_putfirst_doubled(self, list_of_links): - # TODO: is this even needed? No family in the framework has this - # dictionary defined! - if self.lang in self.family.interwiki_putfirst_doubled: - if (len(list_of_links) >= - self.family.interwiki_putfirst_doubled[self.lang][0]): - links2 = [lang.language() for lang in list_of_links] - result = [] - for lang in self.family.interwiki_putfirst_doubled[self.lang][1]: - try: - result.append(list_of_links[links2.index(lang)]) - except ValueError: - pass - return result - else: - return False - else: - return False - def getSite(self, code): """Return Site object for language 'code' in this Family.""" return pywikibot.Site(code=code, fam=self.family, user=self.user()) diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py index 2fae512..9e3799b 100644 --- a/pywikibot/textlib.py +++ b/pywikibot/textlib.py @@ -936,9 +936,6 @@ del sites[sites.index(site)] firstsites = firstsites + [site] sites = firstsites + sites - if insite.interwiki_putfirst_doubled(sites): - # some (all?) implementations return False - sites = insite.interwiki_putfirst_doubled(sites) + sites return sites -- To view, visit https://gerrit.wikimedia.org/r/219365 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24eafe79b9b38a2f4fd83c084293eafe2108a10b Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

Fixed: wikimedia/pywikibot-core#2412 (master - 04c1391)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2412 Status: Fixed Duration: 27 minutes and 38 seconds Commit: 04c1391 (master) Author: jenkins-bot Message: Merge "User: check that the '_userprops' attribute exists before deleting it" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/6e0628969a33...04c1391f… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/67638010 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

[Gerrit] User: check that the '_userprops' attribute exists before de... - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: User: check that the '_userprops' attribute exists before deleting it ...................................................................... User: check that the '_userprops' attribute exists before deleting it Otherwise an AttributeError might be raised if it hasn't been loaded yet. Change-Id: I37428175177e4f1b4811b19465a5783ff565d995 --- M pywikibot/page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index 446bbe0..b01fce7 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -2733,7 +2733,7 @@ @return: dict """ - if force: + if force and hasattr(self, '_userprops'): del self._userprops if not hasattr(self, '_userprops'): self._userprops = list(self.site.users([self.username, ]))[0] -- To view, visit https://gerrit.wikimedia.org/r/219574 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37428175177e4f1b4811b19465a5783ff565d995 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

[Gerrit] Use mainpage from siteinfo - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Use mainpage from siteinfo ...................................................................... Use mainpage from siteinfo Porting a fix from compat to core. https://mediawiki.org/wiki/Special:Code/pywikipedia/7708 Bug: T103079 Change-Id: Ifd2e3e18860aabe9ecfbd58e3a2a6b33180e1f01 --- M scripts/interwiki.py 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/interwiki.py b/scripts/interwiki.py index 5f5ffb2..fa26860 100755 --- a/scripts/interwiki.py +++ b/scripts/interwiki.py @@ -2539,11 +2539,8 @@ site = pywikibot.Site() # ensure that we don't try to change main page - try: - mainpagename = site.mediawiki_message('mainpage') - globalvar.skip.add(pywikibot.Page(site, mainpagename)) - except pywikibot.Error: - pywikibot.output(u'Missing main page name') + mainpagename = site.siteinfo['mainpage'] + globalvar.skip.add(pywikibot.Page(site, mainpagename)) if newPages is not None: if len(namespaces) == 0: -- To view, visit https://gerrit.wikimedia.org/r/219341 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd2e3e18860aabe9ecfbd58e3a2a6b33180e1f01 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Alex S.H. Lin <alexsh(a)mail2000.com.tw> Gerrit-Reviewer: JAn Dudík <jan.dudik(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

Broken: wikimedia/pywikibot-core#2410 (master - 7cc2594)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2410 Status: Broken Duration: 40 minutes and 11 seconds Commit: 7cc2594 (master) Author: Ricordisamoa Message: Simplify ItemPage.get() Update the dict returned by WikibasePage.get() instead of creating a new one from scratch. Change-Id: Ib85b205858761386ed61b7460de2081bc591b365 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/ccaf67675482...7cc2594a… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/67627233 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

[Gerrit] Simplify ItemPage.get() - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Simplify ItemPage.get() ...................................................................... Simplify ItemPage.get() Update the dict returned by WikibasePage.get() instead of creating a new one from scratch. Change-Id: Ib85b205858761386ed61b7460de2081bc591b365 --- M pywikibot/page.py 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index 446bbe0..8abf390 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -3618,7 +3618,7 @@ @type force: bool @param args: values of props """ - super(ItemPage, self).get(force=force, *args, **kwargs) + data = super(ItemPage, self).get(force=force, *args, **kwargs) # claims self.claims = {} @@ -3637,12 +3637,9 @@ self.sitelinks[dbname] = self._content[ 'sitelinks'][dbname]['title'] - return {'aliases': self.aliases, - 'labels': self.labels, - 'descriptions': self.descriptions, - 'sitelinks': self.sitelinks, - 'claims': self.claims - } + data['claims'] = self.claims + data['sitelinks'] = self.sitelinks + return data def getRedirectTarget(self): """Return the redirect target for this page.""" -- To view, visit https://gerrit.wikimedia.org/r/219572 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib85b205858761386ed61b7460de2081bc591b365 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 11 months

Passed: wikimedia/pywikibot-core#2409 (master - ccaf676)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2409 Status: Passed Duration: 21 minutes and 3 seconds Commit: ccaf676 (master) Author: jenkins-bot Message: Merge "Don't ignore "DoNotArchiveUntil" timestamps" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/753856b92c4b...ccaf6767… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/67602965 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 11 months

← Newer
1
...
8
9
10
11
12
13
14
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits June 2015