jenkins-bot has submitted this change and it was merged.
Change subject: Disable cleanUpLinks in cosmetic_changes.py in Persian language wikis
......................................................................
Disable cleanUpLinks in cosmetic_changes.py in Persian language wikis
Community thinks this function has too many issues.
I do this upon request of User:Yamaha5
The discussion is here: http://bit.ly/1KMVZ7J
Also improving documentation of cleanUpLinks.
Reinvent of I4f40c7a89a6fd698009a6290e18948e3924f4f78
Change-Id: I1a342e0f0311764009d67d073fce74ee91a897f9
---
M cosmetic_changes.py
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/cosmetic_changes.py b/cosmetic_changes.py
index b15c226..a13be5d 100644
--- a/cosmetic_changes.py
+++ b/cosmetic_changes.py
@@ -375,9 +375,13 @@
return text
def cleanUpLinks(self, text):
- # helper function which works on one link and either returns it
- # unmodified, or returns a replacement.
+ """Cleanup wiki links."""
+
def handleOneLink(match):
+ """Helper function for one link.
+
+ Either returns it unmodified, or returns a replacement.
+ """
titleWithSection = match.group('titleWithSection')
label = match.group('label')
trailingChars = match.group('linktrail')
@@ -483,6 +487,10 @@
# don't change anything
return match.group()
+ if self.site.sitename() == u'wikipedia:fa':
+ # Per community discussion, this one is not allowed in fa.wp
+ return text # unmodified text
+
trailR = re.compile(self.site.linktrail())
# The regular expression which finds links. Results consist of four groups:
# group <newline> depends whether the links starts with a new line.
--
To view, visit https://gerrit.wikimedia.org/r/211139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a342e0f0311764009d67d073fce74ee91a897f9
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)openmailbox.org>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Disable cleanUpLinks in cosmetic_changes.py in Persian language wikis"
......................................................................
Revert "Disable cleanUpLinks in cosmetic_changes.py in Persian language wikis"
method always fails here. Must return the unchanged text for fa-wiki only.
This reverts commit 2adb3b87e0b4c5a2f116e611625f1434a74dd2b1.
Change-Id: Ibb729d138be423593f8cd8898f81d743031a2ba9
---
M cosmetic_changes.py
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/cosmetic_changes.py b/cosmetic_changes.py
index 4a9f528..b15c226 100644
--- a/cosmetic_changes.py
+++ b/cosmetic_changes.py
@@ -377,10 +377,6 @@
def cleanUpLinks(self, text):
# helper function which works on one link and either returns it
# unmodified, or returns a replacement.
- if self.site.sitename() != u'wikipedia:fa':
- # Per community discussion, this one is not allowed in fa.wp
- return
-
def handleOneLink(match):
titleWithSection = match.group('titleWithSection')
label = match.group('label')
--
To view, visit https://gerrit.wikimedia.org/r/211137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb729d138be423593f8cd8898f81d743031a2ba9
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>