Pywikibot-commits June 2014

pywikibot-commits@lists.wikimedia.org

1 participants
143 discussions

[Gerrit] test.wikipedia.org uses test.wikidata.org - change (pywikibot/core)
by jenkins-bot (Code Review) 09 Jun '14

09 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: test.wikipedia.org uses test.wikidata.org ...................................................................... test.wikipedia.org uses test.wikidata.org Change-Id: Ic53dee3eef3fae860b0e442545b4e933ce22164e --- M pywikibot/families/wikipedia_family.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/families/wikipedia_family.py b/pywikibot/families/wikipedia_family.py index 639878f..0006bc9 100644 --- a/pywikibot/families/wikipedia_family.py +++ b/pywikibot/families/wikipedia_family.py @@ -553,4 +553,7 @@ return self.code2encoding(code), def shared_data_repository(self, code, transcluded=False): - return ('wikidata', 'wikidata') + if code in ['test', 'test2']: + return ('test', 'wikidata') + else: + return ('wikidata', 'wikidata') -- To view, visit https://gerrit.wikimedia.org/r/138291 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic53dee3eef3fae860b0e442545b4e933ce22164e Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] Consistently use "MediaWiki" in CamelCase - change (pywikibot/core)
by jenkins-bot (Code Review) 09 Jun '14

09 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: Consistently use "MediaWiki" in CamelCase ...................................................................... Consistently use "MediaWiki" in CamelCase - replaced "mediawiki", only in docstring and comments Change-Id: I979f4c040af8979109f9246eaab8b4c2f7e368b6 --- M pywikibot/page.py M pywikibot/site.py M scripts/data_ingestion.py M scripts/flickrripper.py M scripts/reflinks.py 5 files changed, 14 insertions(+), 14 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index 33d3c6d..cd53b78 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -589,7 +589,7 @@ By default, loads a list of template names from the Family file; if the value in the Family file is None no entry was made, looks for the list on [[MediaWiki:Disambiguationspage]]. If this page does not - exist, take the mediawiki message. + exist, take the MediaWiki message. If get_Index is True then also load the templates for index articles which are given on en-wiki @@ -2164,7 +2164,7 @@ @deprecated('User.registration()') def registrationTime(self, force=False): """ Return registration date for this user, as a long in - Mediawiki's internal timestamp format, or 0 if the date is unknown. + MediaWiki's internal timestamp format, or 0 if the date is unknown. @param force: if True, forces reloading the data from API @type force: bool @@ -2206,7 +2206,7 @@ return 'blockedby' in self.getprops(force) def isEmailable(self, force=False): - """ Return True if emails can be send to this user through mediawiki, + """ Return True if emails can be send to this user through MediaWiki, False otherwise. @param force: if True, forces reloading the data from API @@ -2262,7 +2262,7 @@ self.site, defaultNamespace=3)) def sendMail(self, subject, text, ccme=False): - """ Send an email to this user via mediawiki's email interface. + """ Send an email to this user via MediaWiki's email interface. Return True on success, False otherwise. This method can raise an UserActionRefuse exception in case this user doesn't allow sending email to him or the currently logged in bot @@ -3123,7 +3123,7 @@ class Link(ComparableMixin): - """A Mediawiki link (local or interwiki) + """A MediaWiki link (local or interwiki) Has the following attributes: @@ -3187,7 +3187,7 @@ # Normalize unicode string to a NFC (composed) format to allow # proper string comparisons. According to # http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_6/phase3/includes/n… - # the mediawiki code normalizes everything to NFC, not NFKC + # the MediaWiki code normalizes everything to NFC, not NFKC # (which might result in information loss). t = unicodedata.normalize('NFC', t) diff --git a/pywikibot/site.py b/pywikibot/site.py index ea1cbad..971edc5 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -572,7 +572,7 @@ def need_version(version): - """ Decorator to require a certain mediawiki version number. + """ Decorator to require a certain MediaWiki version number. @param number: the mw version number required @return: a decorator to make sure the requirement is statisfied when @@ -583,7 +583,7 @@ if LV(self.version()) < LV(version): raise NotImplementedError( u'Method or function "%s"\n' - u"isn't implemented in mediawiki version < %s" + u"isn't implemented in MediaWiki version < %s" % (fn.__name__, version)) return fn(self, *args, **kwargs) callee.__name__ = fn.__name__ diff --git a/scripts/data_ingestion.py b/scripts/data_ingestion.py index 19d331b..4f11224 100755 --- a/scripts/data_ingestion.py +++ b/scripts/data_ingestion.py @@ -58,7 +58,7 @@ def findDuplicateImages(self, site=pywikibot.Site(u'commons', u'commons')): """ - Takes the photo, calculates the SHA1 hash and asks the mediawiki api + Takes the photo, calculates the SHA1 hash and asks the MediaWiki api for a list of duplicates. TODO: Add exception handling, fix site thing @@ -192,7 +192,7 @@ def findDuplicateImages(self, photo=None, site=pywikibot.Site(u'commons', u'commons')): """ - Takes the photo, calculates the SHA1 hash and asks the mediawiki api for a list of duplicates. + Takes the photo, calculates the SHA1 hash and asks the MediaWiki api for a list of duplicates. TODO: Add exception handling, fix site thing """ diff --git a/scripts/flickrripper.py b/scripts/flickrripper.py index a72d150..8cfdf7b 100644 --- a/scripts/flickrripper.py +++ b/scripts/flickrripper.py @@ -119,7 +119,7 @@ def findDuplicateImages(photo=None, site=pywikibot.Site(u'commons', u'commons')): - """ Take the photo, calculate the SHA1 hash and ask the mediawiki api + """ Take the photo, calculate the SHA1 hash and ask the MediaWiki api for a list of duplicates. TODO: Add exception handling, fix site thing @@ -195,7 +195,7 @@ def cleanUpTitle(title): - """ Clean up the title of a potential mediawiki page. Otherwise the title of + """ Clean up the title of a potential MediaWiki page. Otherwise the title of the page might not be allowed by the software. """ diff --git a/scripts/reflinks.py b/scripts/reflinks.py index e9fd399..fdb6ce2 100644 --- a/scripts/reflinks.py +++ b/scripts/reflinks.py @@ -63,10 +63,10 @@ '&params;': pagegenerators.parameterHelp } -localized_msg = ('fr', 'it', 'pl') # localized message at mediawiki +localized_msg = ('fr', 'it', 'pl') # localized message at MediaWiki # localized message at specific wikipedia site -# should be moved to mediawiki pywikibot manual +# should be moved to MediaWiki pywikibot manual stopPage = { -- To view, visit https://gerrit.wikimedia.org/r/138288 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979f4c040af8979109f9246eaab8b4c2f7e368b6 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: Audiodude <audiodude(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] code cleanups - change (pywikibot/core)
by jenkins-bot (Code Review) 09 Jun '14

09 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: code cleanups ...................................................................... code cleanups - rename a to source to indicate it's usage - use Page.text instead of Page.get() - use line separator from config Change-Id: Ibfd7d06a38d880b2ced1f72ef4f2bd9f7b0c5d0d --- M scripts/featured.py 1 file changed, 14 insertions(+), 13 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/featured.py b/scripts/featured.py index 692062d..39a6a2e 100644 --- a/scripts/featured.py +++ b/scripts/featured.py @@ -67,6 +67,7 @@ import pywikibot from pywikibot import i18n from pywikibot.pagegenerators import PreloadingGenerator +from pywikibot.config2 import LS # line separator def CAT(site, name, hide): @@ -525,20 +526,20 @@ re_Link_add = compile_link(fromsite, add_tl) re_Link_remove = compile_link(fromsite, remove_tl) interactive = self.getOption('interactive') - for a in gen: - if a.isRedirectPage(): - a = a.getRedirectTarget() + for source in gen: + if source.isRedirectPage(): + source = source.getRedirectTarget() - if not a.exists(): + if not source.exists(): pywikibot.output(u"source page doesn't exist: %s" - % a.title()) + % source.title()) continue - atrans = self.findTranslated(a, tosite) + atrans = self.findTranslated(source, tosite) if not atrans: continue - text = atrans.get() + text = atrans.text m1 = add_tl and re_Link_add.search(text) m2 = remove_tl and re_Link_remove.search(text) changed = False @@ -550,7 +551,7 @@ if (not interactive or pywikibot.input( u'Connecting %s -> %s. Proceed? [Y/N]' - % (a.title(), atrans.title())) in ['Y', 'y']): + % (source.title(), atrans.title())) in ['Y', 'y']): if self.getOption('side'): # Placing {{Link FA|xx}} right next to # corresponding interwiki @@ -561,8 +562,8 @@ # Moving {{Link FA|xx}} to top of interwikis iw = pywikibot.getLanguageLinks(text, self.site) text = pywikibot.removeLanguageLinks(text, self.site) - text += u"\r\n{{%s|%s}}\r\n" % (add_tl[0], - fromsite.code) + text += u"%s{{%s|%s}}%s" % (LS, add_tl[0], + fromsite.code, LS) text = pywikibot.replaceLanguageLinks(text, iw, self.site) changed = True @@ -572,15 +573,15 @@ not interactive or pywikibot.input( u'Connecting %s -> %s. Proceed? [Y/N]' - % (a.title(), atrans.title())) in ['Y', 'y']): + % (source.title(), atrans.title())) in ['Y', 'y']): text = re.sub(re_Link_remove, '', text) changed = True elif task == 'former': pywikibot.output(u"(already removed)") - cc[a.title()] = atrans.title() + cc[source.title()] = atrans.title() if changed: comment = i18n.twtranslate(self.site, 'featured-' + task, - {'page': unicode(a)}) + {'page': unicode(source)}) try: atrans.put(text, comment) except pywikibot.LockedPage: -- To view, visit https://gerrit.wikimedia.org/r/138162 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfd7d06a38d880b2ced1f72ef4f2bd9f7b0c5d0d Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] Update usage help string - change (pywikibot/core)
by jenkins-bot (Code Review) 09 Jun '14

09 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: Update usage help string ...................................................................... Update usage help string The usage help message looked wrong to me. Change-Id: I0773dc7a76686058d2a20efd1f074496cd50fc43 --- M scripts/illustrate_wikidata.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/illustrate_wikidata.py b/scripts/illustrate_wikidata.py index 5a845ff..a906943 100644 --- a/scripts/illustrate_wikidata.py +++ b/scripts/illustrate_wikidata.py @@ -2,13 +2,12 @@ # -*- coding: utf-8 -*- """ Bot to add images to Wikidata items. The image is extracted from the page_props. -For this to be available the PageImages extension (https://www.mediawiki.org/wiki/Extension:PageImages) needs to be installed +For this to be available the PageImages extension +(https://www.mediawiki.org/wiki/Extension:PageImages) needs to be installed Usage: python illustrate_wikidata.py <some generator> - -python harvest_template.py -lang:en -catr:Category:Railway_stations_in_New_York &params; """ -- To view, visit https://gerrit.wikimedia.org/r/138230 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0773dc7a76686058d2a20efd1f074496cd50fc43 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] Use new Property.type getter - change (pywikibot/core)
by jenkins-bot (Code Review) 08 Jun '14

08 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: Use new Property.type getter ...................................................................... Use new Property.type getter - claimit.py: type getter returns 'globe-coordinate' instead of 'globecoordinate' returned by now deprecated .getType() Change-Id: Ie0add58d3a5d795a0258b2d1a06ea6216d50b8e1 --- M pywikibot/data/wikidataquery.py M pywikibot/site.py M scripts/claimit.py M scripts/harvest_template.py M scripts/illustrate_wikidata.py 5 files changed, 18 insertions(+), 17 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/wikidataquery.py b/pywikibot/data/wikidataquery.py index c606a18..239dbbb 100644 --- a/pywikibot/data/wikidataquery.py +++ b/pywikibot/data/wikidataquery.py @@ -385,13 +385,13 @@ if not isinstance(claim, Claim): raise(TypeError, "claim must be a page.Claim") - if claim.getType() == 'wikibase-item': + if claim.type == 'wikibase-item': return HasClaim(claim.getID(numeric=True), claim.getTarget().getID(numeric=True)) - if claim.getType() == 'string': + if claim.type == 'string': return StringClaim(claim.getID(numeric=True), claim.getTarget()) else: raise(TypeError, "Cannot construct a query from a claim of type %s" - % claim.getType()) + % claim.type) class WikidataQuery(): diff --git a/pywikibot/site.py b/pywikibot/site.py index ef57dc1..34f7124 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -3835,21 +3835,21 @@ snak = {} for sourceclaim in sources: - if sourceclaim.getType() == 'wikibase-item': + if sourceclaim.type == 'wikibase-item': datavalue = {'type': 'wikibase-entityid', 'value': sourceclaim._formatDataValue(), } - elif sourceclaim.getType() in ['string', 'url']: + elif sourceclaim.type in ['string', 'url']: datavalue = {'type': 'string', 'value': sourceclaim._formatDataValue(), } - elif sourceclaim.getType() == 'time': + elif sourceclaim.type == 'time': datavalue = {'type': 'time', 'value': sourceclaim._formatDataValue(), } else: raise NotImplementedError('%s datatype is not supported yet.' - % sourceclaim.getType()) + % sourceclaim.type) valuesnaks = [] if sourceclaim.getID() in snak: valuesnaks = snak[sourceclaim.getID()] diff --git a/scripts/claimit.py b/scripts/claimit.py index bf01b55..af74030 100755 --- a/scripts/claimit.py +++ b/scripts/claimit.py @@ -170,11 +170,11 @@ repo = pywikibot.Site().data_repository() for i in range(0, len(commandline_claims), 2): claim = pywikibot.Claim(repo, commandline_claims[i]) - if claim.getType() == 'wikibase-item': + if claim.type == 'wikibase-item': target = pywikibot.ItemPage(repo, commandline_claims[i + 1]) - elif claim.getType() == 'string': + elif claim.type == 'string': target = commandline_claims[i + 1] - elif claim.getType() == 'globecoordinate': + elif claim.type == 'globe-coordinate': coord_args = map(float, commandline_claims[i + 1].split(',')) if len(coord_args) >= 3: precision = coord_args[2] @@ -184,7 +184,7 @@ else: raise NotImplementedError( "%s datatype is not yet supported by claimit.py" - % claim.getType()) + % claim.type) claim.setTarget(target) claims.append(claim) diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py index c70c9f2..263b838 100755 --- a/scripts/harvest_template.py +++ b/scripts/harvest_template.py @@ -153,7 +153,7 @@ # harvested values with existing claims esp. # without overwriting humans unintentionally. else: - if claim.getType() == 'wikibase-item': + if claim.type == 'wikibase-item': # Try to extract a valid page match = re.search(pywikibot.link_regex, value) if not match: @@ -166,9 +166,9 @@ continue claim.setTarget(linked_item) - elif claim.getType() == 'string': + elif claim.type == 'string': claim.setTarget(value.strip()) - elif claim.getType() == 'commonsMedia': + elif claim.type == 'commonsMedia': commonssite = pywikibot.Site("commons", "commons") imagelink = pywikibot.Link(value, source=commonssite, defaultNamespace=6) image = pywikibot.ImagePage(imagelink) @@ -179,7 +179,7 @@ continue claim.setTarget(image) else: - pywikibot.output("%s is not a supported datatype." % claim.getType()) + pywikibot.output("%s is not a supported datatype." % claim.type) continue pywikibot.output('Adding %s --> %s' % (claim.getID(), claim.getTarget())) diff --git a/scripts/illustrate_wikidata.py b/scripts/illustrate_wikidata.py index 7fde432..5a845ff 100644 --- a/scripts/illustrate_wikidata.py +++ b/scripts/illustrate_wikidata.py @@ -44,8 +44,9 @@ self.cacheSources() claim = pywikibot.Claim(self.repo, self.wdproperty) - if not claim.getType() == 'commonsMedia': - raise ValueError(u'%s is of type %s, should be commonsMedia' % (self.wdproperty, claim.getType())) + if claim.type != 'commonsMedia': + raise ValueError(u'%s is of type %s, should be commonsMedia' + % (self.wdproperty, claim.type)) def run(self): """ -- To view, visit https://gerrit.wikimedia.org/r/135405 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0add58d3a5d795a0258b2d1a06ea6216d50b8e1 Gerrit-PatchSet: 7 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: Daniel Kinzler <daniel.kinzler(a)wikimedia.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: Underlying lk <a375070(a)drdrb.net> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] Remove bot list of defunct 'gentoo' wiki. - change (pywikibot/core)
by jenkins-bot (Code Review) 08 Jun '14

08 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: Remove bot list of defunct 'gentoo' wiki. ...................................................................... Remove bot list of defunct 'gentoo' wiki. Change-Id: I8369d515602fc00059f43136e26cdf86e3dac702 --- M pywikibot/login.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/login.py b/pywikibot/login.py index 8f167ac..9035b8a 100644 --- a/pywikibot/login.py +++ b/pywikibot/login.py @@ -28,9 +28,6 @@ 'en': [u'Wikipedia:Bots/Status/active bots', 'BotS'], 'simple': [u'Wikipedia:Bots', '/links'] }, - 'gentoo': { - 'en': [u'Help:Bots', None], - } } -- To view, visit https://gerrit.wikimedia.org/r/138224 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8369d515602fc00059f43136e26cdf86e3dac702 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Nemo bis <federicoleva(a)tiscali.it> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] (breakage) Property#getID has numeric argument - change (pywikibot/core)
by jenkins-bot (Code Review) 08 Jun '14

08 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: (breakage) Property#getID has numeric argument ...................................................................... (breakage) Property#getID has numeric argument Change-Id: I84a07ac586b9795afdb8b01d3cebcb1f1c8a9241 --- M pywikibot/page.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Merlijn van Deen: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index b03edaa..33d3c6d 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -2801,8 +2801,11 @@ else: return self._type - def getID(self): - return self.id + def getID(self, numeric=False): + if numeric: + return int(self.id[1:]) + else: + return self.id class PropertyPage(WikibasePage, Property): -- To view, visit https://gerrit.wikimedia.org/r/138223 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84a07ac586b9795afdb8b01d3cebcb1f1c8a9241 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] Remove bot list of defunct 'gentoo' wiki. - change (pywikibot/compat)
by jenkins-bot (Code Review) 08 Jun '14

08 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: Remove bot list of defunct 'gentoo' wiki. ...................................................................... Remove bot list of defunct 'gentoo' wiki. Change-Id: Id31c4961ea24dc204985c1c6a86111ddc5b864a5 --- M login.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/login.py b/login.py index ebeccc7..ec12933 100644 --- a/login.py +++ b/login.py @@ -68,9 +68,6 @@ 'wikipedia': { 'en': [u'Wikipedia:Bots/Status/active bots', 'BotS'], 'simple': [u'Wikipedia:Bots', '/links'] - }, - 'gentoo': { - 'en': [u'Help:Bots', None], } } -- To view, visit https://gerrit.wikimedia.org/r/138221 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id31c4961ea24dc204985c1c6a86111ddc5b864a5 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] improvements to APISite#rollbackpage() - change (pywikibot/core)
by jenkins-bot (Code Review) 08 Jun '14

08 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: improvements to APISite#rollbackpage() ...................................................................... improvements to APISite#rollbackpage() - removed unused variable 'summary' - used **kwargs to support custom arguments Change-Id: Ic1a56f1742df6c55bb4c498f2670585d65c8ed41 --- M pywikibot/site.py 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site.py b/pywikibot/site.py index 2d2d243..cc27276 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -2989,15 +2989,16 @@ "alreadyrolled": "Page [[%(title)s]] already rolled back; action aborted.", } # other errors shouldn't arise because we check for those errors - def rollbackpage(self, page, summary=u''): + def rollbackpage(self, page, **kwargs): """Roll back page to version before last user's edits. + + The keyword arguments are those supported by the rollback API. As a precaution against errors, this method will fail unless the page history contains at least two revisions, and at least one that is not by the same user who made the last edit. @param page: the Page to be rolled back (must exist) - @param summary: edit summary (defaults to a standardized message) """ if len(page._revisions) < 2: @@ -3015,16 +3016,13 @@ raise pywikibot.Error( u"Rollback of %s aborted; only one user in revision history." % page.title(asLink=True)) - summary = summary or ( - u"Reverted edits by [[Special:Contributions/%(last_user)s|%(last_user)s]] " - u"([[User talk:%(last_user)s|Talk]]) to last version by %(prev_user)s" - % locals()) token = self.token(page, "rollback") self.lock_page(page) req = api.Request(site=self, action="rollback", title=page.title(withSection=False), user=last_user, - token=token) + token=token, + **kwargs) try: result = req.submit() except api.APIError as err: -- To view, visit https://gerrit.wikimedia.org/r/135421 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1a56f1742df6c55bb4c498f2670585d65c8ed41 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] port capitalize_redirects.py to core - done by compat2core s... - change (pywikibot/core)
by jenkins-bot (Code Review) 08 Jun '14

08 Jun '14

jenkins-bot has submitted this change and it was merged. Change subject: port capitalize_redirects.py to core - done by compat2core script ...................................................................... port capitalize_redirects.py to core - done by compat2core script with some improvements: - CapitalizeBot extends pywikibot.Bot with built-in 'always' option - use core-like page.save - remove obsolete script name from showHelp - bugfix: call handleArgs before GeneratorFactory as in I134529f3a914225d3473b95ca771cf7e7be01a36 - bugfix: show documentation correctly if no generator is provided - make localized strings depend on the actual working site bug: 64837 Change-Id: I3f1472808774cb345c617d006ef77d8228680857 --- A scripts/capitalize_redirects.py 1 file changed, 122 insertions(+), 0 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/capitalize_redirects.py b/scripts/capitalize_redirects.py new file mode 100644 index 0000000..814d771 --- /dev/null +++ b/scripts/capitalize_redirects.py @@ -0,0 +1,122 @@ +#!/usr/bin/python +# -*- coding: utf-8 -*- + +""" +Bot to create capitalized redirects where the first character of the first +word is uppercase and the remaining characters and words are lowercase. + +Command-line arguments: + +&params; + +-always Don't prompt to make changes, just do them. + +-titlecase creates a titlecased redirect version of a given page + where all words of the title start with an uppercase + character and the remaining characters are lowercase. + +Example: "python capitalize_redirects.py -start:B -always" +""" +# +# (C) Yrithinnd +# (C) Pywikibot team, 2007-2014 +# +# Distributed under the terms of the MIT license. +# +# Automatically converted from compat branch by compat2core.py script +# +__version__ = '$Id$' +# + +import pywikibot +from pywikibot import i18n, pagegenerators, Bot + +docuReplacements = { + '&params;': pagegenerators.parameterHelp +} + + +class CapitalizeBot(Bot): + def __init__(self, generator, **kwargs): + self.availableOptions.update({ + 'titlecase': False, + }) + + super(CapitalizeBot, self).__init__(**kwargs) + self.generator = generator + self.done = False + + def run(self): + for page in self.generator: + if self.done: + break + if page.exists(): + self.treat(page) + + def treat(self, page): + if page.isRedirectPage(): + page = page.getRedirectTarget() + page_t = page.title() + # Show the title of the page we're working on. + # Highlight the title in purple. + pywikibot.output(u"\n>>> \03{lightpurple}%s\03{default} <<<" + % page_t) + if self.getOption('titlecase'): + page_cap = pywikibot.Page(page.site, page_t.title()) + else: + page_cap = pywikibot.Page(page.site, page_t.capitalize()) + if page_cap.exists(): + pywikibot.output(u'%s already exists, skipping...\n' + % page_cap.title(asLink=True)) + else: + pywikibot.output(u'%s doesn\'t exist' + % page_cap.title(asLink=True)) + if not self.getOption('always'): + choice = pywikibot.inputChoice( + u'Do you want to create a redirect?', + ['Yes', 'No', 'All', 'Quit'], ['y', 'N', 'a', 'q'], 'N') + if choice == 'a': + self.options['always'] = True + elif choice == 'q': + self.done = True + if self.getOption('always') or choice == 'y': + comment = i18n.twtranslate( + page.site, + 'capitalize_redirects-create-redirect', + {'to': page_t}) + page_cap.text = u"#%s %s" % (page.site.redirect(), + page.title(asLink=True, + textlink=True)) + try: + page_cap.save(comment) + except: + pywikibot.output(u"An error occurred, skipping...") + + +def main(): + options = {} + + local_args = pywikibot.handleArgs() + genFactory = pagegenerators.GeneratorFactory() + + for arg in local_args: + if arg == '-always': + options['always'] = True + elif arg == '-titlecase': + options['titlecase'] = True + else: + genFactory.handleArg(arg) + + gen = genFactory.getCombinedGenerator() + if gen: + preloadingGen = pagegenerators.PreloadingGenerator(gen) + bot = CapitalizeBot(preloadingGen, **options) + try: + bot.run() + except KeyboardInterrupt: + pywikibot.output('\nQuitting program...') + else: + pywikibot.showHelp() + +if __name__ == "__main__": + main() -- To view, visit https://gerrit.wikimedia.org/r/135204 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f1472808774cb345c617d006ef77d8228680857 Gerrit-PatchSet: 4 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Alex S.H. Lin <alexsh(a)mail2000.com.tw> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: Russell Blau <russblau(a)imapmail.org> Gerrit-Reviewer: Siebrand <siebrand(a)kitano.nl> Gerrit-Reviewer: jenkins-bot <>

1 0

← Newer
1
...
7
8
9
10
11
12
13
14
15
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits June 2014