Ladsgroup has submitted this change and it was merged.
Change subject: Wikibase now uses uppercase ids.
......................................................................
Wikibase now uses uppercase ids.
We now force IDs to be uppercase rather than lowercase.
Change-Id: I19a33f60ea72e447f8a971279f149947d4e46bfd
Announcement: http://lists.wikimedia.org/pipermail/wikidata-tech/2013-September/000296.ht…
---
M pywikibot/page.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Ladsgroup: Verified; Looks good to me, approved
diff --git a/pywikibot/page.py b/pywikibot/page.py
index a20d7ce..3b250c0 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -2506,7 +2506,7 @@
@param title: id number of item, "Q###"
"""
super(ItemPage, self).__init__(site, title, ns=0)
- self.id = title.lower()
+ self.id = title.upper() # This might cause issues if not ns0?
@classmethod
def fromPage(cls, page):
@@ -2672,7 +2672,7 @@
@param title: page name of property, like "Property:P##"
"""
WikibasePage.__init__(self, source, title, ns=120)
- self.id = self.title(withNamespace=False).lower()
+ self.id = self.title(withNamespace=False).upper()
if not self.id.startswith(u'p'):
raise ValueError(u"'%s' is not a property page!" % self.title())
@@ -2697,7 +2697,7 @@
"""
def __init__(self, site, title):
WikibasePage.__init__(self, site, title, ns=122)
- self.id = self.title(withNamespace=False).lower()
+ self.id = self.title(withNamespace=False).upper()
if not self.id.startswith(u'u'):
raise ValueError(u"'%s' is not a query page!" % self.title())
--
To view, visit https://gerrit.wikimedia.org/r/83643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19a33f60ea72e447f8a971279f149947d4e46bfd
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
jenkins-bot has submitted this change and it was merged.
Change subject: login.py: use site.code instead of site.lang
......................................................................
login.py: use site.code instead of site.lang
The code used for the site is not necessary the same as the language -
this is clear for instance for commons (site.code = 'commons',
site.lang = 'en') and wikidata.
Changing this means logging in works for people using
mysite = 'wikidata'; family = 'wikidata'
where before this resulted in a cryptic
en.wikidata is not a valid site, please remove it from your config
error message.
Change-Id: I978437feb4862a7f1fc688fcd9ba4dee6d315c67
---
M scripts/login.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/login.py b/scripts/login.py
index afdc9a4..53638e6 100755
--- a/scripts/login.py
+++ b/scripts/login.py
@@ -81,7 +81,7 @@
namedict = config.usernames
else:
site = pywikibot.getSite()
- namedict = {site.family.name: {site.lang: None}}
+ namedict = {site.family.name: {site.code: None}}
for familyName in namedict:
for lang in namedict[familyName]:
try:
--
To view, visit https://gerrit.wikimedia.org/r/82883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I978437feb4862a7f1fc688fcd9ba4dee6d315c67
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
jenkins-bot has submitted this change and it was merged.
Change subject: Suggest git.wikimedia.org as httplib2 download site
......................................................................
Suggest git.wikimedia.org as httplib2 download site
See Wieland Hoffmanns mail [1] for more details; this should prevent
setup.py install from installing an non-functional httplib2 (that
is: one with outdated SSL certificated)
[1] http://article.gmane.org/gmane.comp.python.pywikipediabot.general/13432
Change-Id: Ia0f91237dde1565a6dd71206c2e0477690cf3855
---
M setup.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/setup.py b/setup.py
index a73bc36..db0ea02 100644
--- a/setup.py
+++ b/setup.py
@@ -30,6 +30,9 @@
install_requires=[
'httplib2>=0.6.0'
],
+ dependency_links=[
+ 'https://git.wikimedia.org/zip/?r=pywikibot/externals/httplib2.git&format=gz…'
+ ],
test_suite="tests",
classifiers=[
'License :: OSI Approved :: MIT License',
--
To view, visit https://gerrit.wikimedia.org/r/83370
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0f91237dde1565a6dd71206c2e0477690cf3855
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: jenkins-bot