I know we just pushed it to stable but on hindsight I wish I fought more against it and we didn't.
The code was supposed to remove the 300ms delay on certain devices for clicking to make the device feel more responsive.
I would now like to propose we kill it. It has rendered IE8 unusable as well as any device which supports both touch events and mouse events (e.g. BlackBerry Bold 9900)
Modern browsers are abandoning this sort of code however.
ios8 [1] has no need for it, neither does Chrome mobile [2]
I've drafted a patch to remove this [3] but first I need your okay about that.
At very least we should punt it back to beta and make this code better.
Thoughts?
[1] https://github.com/ftlabs/fastclick/issues/262#issuecomment-56023175 [2] http://updates.html5rocks.com/2013/12/300ms-tap-delay-gone-away [3] https://gerrit.wikimedia.org/r/169582
Yeah, let's just revert it (sorry, Juju!)..
On Oct 28, 2014, at 2:23 PM, Jon Robson jrobson@wikimedia.org wrote:
I know we just pushed it to stable but on hindsight I wish I fought more against it and we didn't.
The code was supposed to remove the 300ms delay on certain devices for clicking to make the device feel more responsive.
I would now like to propose we kill it. It has rendered IE8 unusable as well as any device which supports both touch events and mouse events (e.g. BlackBerry Bold 9900)
Modern browsers are abandoning this sort of code however.
ios8 [1] has no need for it, neither does Chrome mobile [2]
I've drafted a patch to remove this [3] but first I need your okay about that.
At very least we should punt it back to beta and make this code better.
Thoughts?
[1] https://github.com/ftlabs/fastclick/issues/262#issuecomment-56023175 [2] http://updates.html5rocks.com/2013/12/300ms-tap-delay-gone-away [3] https://gerrit.wikimedia.org/r/169582
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l