In the beta mode of mobile, due to the features having no tests we broke nearby pages.
There is a bug for this and the fix provides some browser tests https://bugzilla.wikimedia.org/62294
1) Can someone help with review for this 2) Do we want to lightning deploy a fix, or are we happy to have nearby broken on production wikis for a week?
Thanks for catching and fixing Jon. Since this is in beta and not critical functionality, I suggest we NOT lightning deploy the fix. However, final call is up to Kenan.
On Mon, Mar 10, 2014 at 4:38 PM, Jon Robson jrobson@wikimedia.org wrote:
In the beta mode of mobile, due to the features having no tests we broke nearby pages.
There is a bug for this and the fix provides some browser tests https://bugzilla.wikimedia.org/62294
- Can someone help with review for this
- Do we want to lightning deploy a fix, or are we happy to have
nearby broken on production wikis for a week?
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
It's still not fixed as it's still not been merged or even looked at. Kenan what are your thoughts on the lightning deploy? Note it also completely breaks the desktop BetaFeature which is really sucky.
Regardless of this discussion we should definitely look at getting this merged asap. Although there is JS changes, they are simply referencing a different ResourceLoader module and adding some tests. It really shouldn't be a tricky one to review...
https://gerrit.wikimedia.org/r/#/c/117126/
On Mon, Mar 10, 2014 at 6:05 PM, Arthur Richards arichards@wikimedia.org wrote:
Thanks for catching and fixing Jon. Since this is in beta and not critical functionality, I suggest we NOT lightning deploy the fix. However, final call is up to Kenan.
On Mon, Mar 10, 2014 at 4:38 PM, Jon Robson jrobson@wikimedia.org wrote:
In the beta mode of mobile, due to the features having no tests we broke nearby pages.
There is a bug for this and the fix provides some browser tests https://bugzilla.wikimedia.org/62294
- Can someone help with review for this
- Do we want to lightning deploy a fix, or are we happy to have
nearby broken on production wikis for a week?
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
-- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687
Looks like Kaldari merged the patch; thank you :)
On Tue, Mar 11, 2014 at 2:56 PM, Jon Robson jrobson@wikimedia.org wrote:
It's still not fixed as it's still not been merged or even looked at. Kenan what are your thoughts on the lightning deploy? Note it also completely breaks the desktop BetaFeature which is really sucky.
Regardless of this discussion we should definitely look at getting this merged asap. Although there is JS changes, they are simply referencing a different ResourceLoader module and adding some tests. It really shouldn't be a tricky one to review...
https://gerrit.wikimedia.org/r/#/c/117126/
On Mon, Mar 10, 2014 at 6:05 PM, Arthur Richards arichards@wikimedia.org wrote:
Thanks for catching and fixing Jon. Since this is in beta and not
critical
functionality, I suggest we NOT lightning deploy the fix. However, final call is up to Kenan.
On Mon, Mar 10, 2014 at 4:38 PM, Jon Robson jrobson@wikimedia.org
wrote:
In the beta mode of mobile, due to the features having no tests we broke nearby pages.
There is a bug for this and the fix provides some browser tests https://bugzilla.wikimedia.org/62294
- Can someone help with review for this
- Do we want to lightning deploy a fix, or are we happy to have
nearby broken on production wikis for a week?
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
-- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687