Just an FYI, a recent change in the selenium gem is causing the bot Barry to report false positives for MobileFrontend patches. If you see a -1 from him on your MobileFrontend patch, please read the log in the mean time - if only 2 tests are failing it's highly likely your patch is fine.
+2ers please consult the log prior to merging and overriding Barry's -1 whilst the upstream bug [1] remains unfixed.
QAers the problem seems to be related to a recent change to the selenium gem that requires a new user for new page creations. Would be great to fix this...
I've managed to find a workaround for time being so Barry should be +1ing / -1ing correctly again. Let's continue this conversation on the phabricator task from now on :)
On Mon, Jul 20, 2015 at 11:58 AM, Jon Robson jrobson@wikimedia.org wrote:
Just an FYI, a recent change in the selenium gem is causing the bot Barry to report false positives for MobileFrontend patches. If you see a -1 from him on your MobileFrontend patch, please read the log in the mean time - if only 2 tests are failing it's highly likely your patch is fine.
+2ers please consult the log prior to merging and overriding Barry's -1 whilst the upstream bug [1] remains unfixed.
QAers the problem seems to be related to a recent change to the selenium gem that requires a new user for new page creations. Would be great to fix this...
Correction: I didn't find a workaround :)
On Mon, Jul 20, 2015 at 3:50 PM, Jon Robson jrobson@wikimedia.org wrote:
I've managed to find a workaround for time being so Barry should be +1ing / -1ing correctly again. Let's continue this conversation on the phabricator task from now on :)
On Mon, Jul 20, 2015 at 11:58 AM, Jon Robson jrobson@wikimedia.org wrote:
Just an FYI, a recent change in the selenium gem is causing the bot Barry to report false positives for MobileFrontend patches. If you see a -1 from him on your MobileFrontend patch, please read the log in the mean time - if only 2 tests are failing it's highly likely your patch is fine.
+2ers please consult the log prior to merging and overriding Barry's -1 whilst the upstream bug [1] remains unfixed.
QAers the problem seems to be related to a recent change to the selenium gem that requires a new user for new page creations. Would be great to fix this...