Chris, this test has been failing for some time and I can't quite work out why. In Chrome, it looks like uploaded_image_link always points to the upload link at the top of the page when it is loaded.
I suspect Chrome driver matches the selector at the start and then doesn't refresh it to point to the latest element after the upload has completed.
Either that or something funky is going on with the random string in Chrome.
Chris or someone who knows this stuff could you take a look? I've spent the last hour trying to work it out to no avail...
On Tue, May 13, 2014 at 7:12 AM, jenkins-no-reply@cloudbees.com wrote:
- FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome
Build #441 https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/441/ (Tue, 13 May 2014 04:36:29 +0000)* *Test Result*https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/441/testReport/ 1 failed, 0 skipped Failed Tests *Test Name**Duration**Age* Special:Uploads uploads.Upload image filehttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/441/testReport/junit/(root)/Special_Uploads%20uploads/Upload_image_file31 sec13https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/428/ All Tests *Package**Duration**Fail**Skip**Total* (root)https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/441/testReport/junit/(root)27 min1081
On Tue, May 13, 2014 at 9:25 AM, Jon Robson jrobson@wikimedia.org wrote:
Chris, this test has been failing for some time and I can't quite work out why. In Chrome, it looks like uploaded_image_link always points to the upload link at the top of the page when it is loaded.
I suspect Chrome driver matches the selector at the start and then doesn't refresh it to point to the latest element after the upload has completed. Either that or something funky is going on with the random string in Chrome.
I was looking at this myself yesterday. The test fails for Chrome because the image is never actually uploaded. This behavior started only on May 7. I'll look into it further today.
Thanks Chris keep us posted - should I open a bug?
On Tue, May 13, 2014 at 6:39 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
On Tue, May 13, 2014 at 9:25 AM, Jon Robson jrobson@wikimedia.org wrote:
Chris, this test has been failing for some time and I can't quite work out why. In Chrome, it looks like uploaded_image_link always points to the upload link at the top of the page when it is loaded.
I suspect Chrome driver matches the selector at the start and then doesn't refresh it to point to the latest element after the upload has completed. Either that or something funky is going on with the random string in Chrome.
I was looking at this myself yesterday. The test fails for Chrome because the image is never actually uploaded. This behavior started only on May 7. I'll look into it further today.
For the sake of completeness, here's why this test is failing:
The regular UploadWizard checks for duplicate images on the target wiki and prevents users from uploading if it finds a duplicate image. (This btw is why the regular UploadWizard test uses the ChunkyPNG utility to create near-unique images for each run of the UploadWizard test.)
But the Mobile upload page will allow users to believe that they have uploaded a duplicate image. When the Mobile upload page presents the image thumbnail of the duplicate image on the success page, the alt text containing the image description is correct, but the actual href link itself is empty. Refresh the uploads page and the duplicate image thumb is no longer visible.
So this test as written would pass once and only once on a static target wiki like beta labs. -Chris
On Tue, May 13, 2014 at 9:49 AM, Jon Robson jrobson@wikimedia.org wrote:
Thanks Chris keep us posted - should I open a bug?
Thanks for documenting this Chris!
I'm not sure if this should be a bug - maybe uploads to Special:Uploads of this form should show an error message saying "We already have this photo." ?
That aside how can we ensure each of the images uploaded is unique? This test should be testing the case where an upload is unique...
On Tue, May 13, 2014 at 8:16 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
For the sake of completeness, here's why this test is failing:
The regular UploadWizard checks for duplicate images on the target wiki and prevents users from uploading if it finds a duplicate image. (This btw is why the regular UploadWizard test uses the ChunkyPNG utility to create near-unique images for each run of the UploadWizard test.)
But the Mobile upload page will allow users to believe that they have uploaded a duplicate image. When the Mobile upload page presents the image thumbnail of the duplicate image on the success page, the alt text containing the image description is correct, but the actual href link itself is empty. Refresh the uploads page and the duplicate image thumb is no longer visible.
So this test as written would pass once and only once on a static target wiki like beta labs. -Chris
On Tue, May 13, 2014 at 9:49 AM, Jon Robson jrobson@wikimedia.org wrote:
Thanks Chris keep us posted - should I open a bug?