Hey y'all,
Yesterday (Monday, 7th) Alex Monk submitted and subsequently back-ported and deployed a fix for an annoying bug in the code that registers the EventLogging schemas in the MobileFrontend extension [0]. The bug resulted in browse and diff click events failing to log as associated schemas weren't registered.
The patch that introduced the bug was merged on Tuesday, 25th August, which, I think, means that it'd have been deployed on Thursday, 3rd September – that's a long weekend's worth of data that we won't see again.
Thanks to Alex for squashing the bug so diligently.
–Sam
Thanks Alex! And thanks for the update Sam. We've talked many times with analytics about how useful it would be to do anomaly detection on our graphs (there's a bug somewhere out there for this) but I'm glad this took us a week to notice.
On Tue, Sep 8, 2015 at 1:50 PM, Sam Smith samsmith@wikimedia.org wrote:
Hey y'all,
Yesterday (Monday, 7th) Alex Monk submitted and subsequently back-ported and deployed a fix for an annoying bug in the code that registers the EventLogging schemas in the MobileFrontend extension [0]. The bug resulted in browse and diff click events failing to log as associated schemas weren't registered.
The patch that introduced the bug was merged on Tuesday, 25th August, which, I think, means that it'd have been deployed on Thursday, 3rd September – that's a long weekend's worth of data that we won't see again.
Thanks to Alex for squashing the bug so diligently.
–Sam
[0] https://gerrit.wikimedia.org/r/#/c/236239/
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
On 8 September 2015 at 20:50, Sam Smith samsmith@wikimedia.org wrote:
The patch that introduced the bug was merged on Tuesday, 25th August, which, I think, means that it'd have been deployed on Thursday, 3rd September – that's a long weekend's worth of data that we won't see again.
The deployment schedule is not quite that simple. If you open the 'Included in' section of the breaking commit, you can see it was included in wmf/1.26wmf21. According to https://www.mediawiki.org/wiki/MediaWiki_1.26/Roadmap that was deployed to mediawiki.org, zero.wikimedia.org and some test wikis on the 1st, most wikis on the 2nd, and then only Wikipedias on the 3rd.
The deployment schedule is not quite that simple. If you open the 'Included in' section of the breaking commit, you can see it was included in wmf/1.26wmf21. According to https://www.mediawiki.org/wiki/MediaWiki_1.26/Roadmap that was deployed to mediawiki.org, zero.wikimedia.org and some test wikis on the 1st, most wikis on the 2nd, and then only Wikipedias on the 3rd.
Indeed. I could've been more precise here.
Thanks again Alex,
–Sam